194259 2019-02-04 17:09:52 -0800 rotationDidEndCallback not triggered on iPad during testing 2024-03-22 02:32:34 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=193767 P2 Normal --- 1 jbedard webkit-unassigned a_protyasha ap lforschler wenson_hsieh oldest_to_newest 1502132 0 jbedard 2019-02-04 17:09:52 -0800 This causes the following tests to fail: fast/events/ios/rotation/basic-rotation.html [ Skip ] fast/events/ios/rotation/layout-viewport-during-rotation.html [ Skip ] fast/events/ios/rotation/layout-viewport-during-safari-type-rotation.html [ Skip ] fast/events/ios/rotation/resize-iframe-after-orientation-change.html [ Skip ] fast/events/ios/rotation/safari-like-rotation.html [ Skip ] In particular, the callback in this function never gets triggered during iPad testing: void UIScriptController::simulateRotation(DeviceOrientation* orientation, JSValueRef callback) { TestRunnerWKWebView *webView = TestController::singleton().mainWebView()->platformView(); webView.usesSafariLikeRotation = NO; unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent); webView.rotationDidEndCallback = ^{ if (!m_context) return; m_context->asyncTaskComplete(callbackID); }; [[UIDevice currentDevice] setOrientation:toUIDeviceOrientation(orientation) animated:YES]; } 2023068 1 a_protyasha 2024-03-22 02:32:34 -0700 This seems to no longer be the case. We should add iPad-specific baselines and unskip the tests now.