19424 2008-06-06 20:06:27 -0700 Add support for logging opcode pair counts 2008-06-06 22:14:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich webkit-unassigned ggaren mjs oliver oldest_to_newest 82504 0 zwarich 2008-06-06 20:06:27 -0700 I will post a patch for review. 82505 1 21542 zwarich 2008-06-06 20:15:59 -0700 Created attachment 21542 Proposed patch 82509 2 21542 oliver 2008-06-06 21:44:50 -0700 Comment on attachment 21542 Proposed patch Cool, r=me 82510 3 zwarich 2008-06-06 22:14:27 -0700 Landed in r34411. 21542 2008-06-06 20:15:59 -0700 2008-06-06 21:44:50 -0700 Proposed patch opcodecounts3.diff text/plain 6978 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM0NDEw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDgtMDYt MDYgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDE5NDI0OiBBZGQgc3Vw cG9ydCBmb3IgbG9nZ2luZyBvcGNvZGUgcGFpciBjb3VudHMKKyAgICAgICAgPGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQyND4KKworICAgICAgICAqIFZNL01hY2hp bmUuY3BwOgorICAgICAgICAoS0pTOjpNYWNoaW5lOjpwcml2YXRlRXhlY3V0ZSk6CisgICAgICAg ICogVk0vT3Bjb2RlLmNwcDoKKyAgICAgICAgKEtKUzo6T3Bjb2RlU3RhdHM6Ok9wY29kZVN0YXRz KToKKyAgICAgICAgKEtKUzo6Y29tcGFyZU9wY29kZUluZGljZXMpOgorICAgICAgICAoS0pTOjpj b21wYXJlT3Bjb2RlUGFpckluZGljZXMpOgorICAgICAgICAoS0pTOjpPcGNvZGVTdGF0czo6fk9w Y29kZVN0YXRzKToKKyAgICAgICAgKEtKUzo6T3Bjb2RlU3RhdHM6OnJlY29yZEluc3RydWN0aW9u KToKKyAgICAgICAgKEtKUzo6T3Bjb2RlU3RhdHM6OnJlc2V0TGFzdEluc3RydWN0aW9uKToKKyAg ICAgICAgKiBWTS9PcGNvZGUuaDoKKwogMjAwOC0wNi0wNiAgS2V2aW4gTWNDdWxsb3VnaCAgPGtt Y2N1bGxvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtLgpJbmRleDog Vk0vTWFjaGluZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVk0vTWFjaGluZS5jcHAJKHJldmlzaW9uIDM0 NDA5KQorKysgVk0vTWFjaGluZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg5OSw2ICs4OTksMTAg QEAgSlNWYWx1ZSogTWFjaGluZTo6cHJpdmF0ZUV4ZWN1dGUoRXhlY3V0aQogICAgICAgICB9IFwK ICAgICB9IHdoaWxlICgwKQogCisjaWYgRFVNUF9PUENPREVfU1RBVFMKKyAgICBPcGNvZGVTdGF0 czo6cmVzZXRMYXN0SW5zdHJ1Y3Rpb24oKTsKKyNlbmRpZgorCiAjaWYgSEFWRShDT01QVVRFRF9H T1RPKQogICAgICNkZWZpbmUgTkVYVF9PUENPREUgZ290byAqdlBDLT51Lm9wY29kZQogI2lmIERV TVBfT1BDT0RFX1NUQVRTCkBAIC0xODY5LDYgKzE4NzMsOSBAQCBKU1ZhbHVlKiBNYWNoaW5lOjpw cml2YXRlRXhlY3V0ZShFeGVjdXRpCiAgICAgICAgICAgIEp1bXBzIHVuY29uZGl0aW9uYWxseSB0 byBvZmZzZXQgdGFyZ2V0IGZyb20gdGhlIGN1cnJlbnQKICAgICAgICAgICAgaW5zdHJ1Y3Rpb24u CiAgICAgICAgICovCisjaWYgRFVNUF9PUENPREVfU1RBVFMKKyAgICAgICAgT3Bjb2RlU3RhdHM6 OnJlc2V0TGFzdEluc3RydWN0aW9uKCk7CisjZW5kaWYKICAgICAgICAgaW50IHRhcmdldCA9ICgr K3ZQQyktPnUub3BlcmFuZDsKIAogICAgICAgICB2UEMgKz0gdGFyZ2V0OwpAQCAtMjA2Niw2ICsy MDczLDEwIEBAIEpTVmFsdWUqIE1hY2hpbmU6OnByaXZhdGVFeGVjdXRlKEV4ZWN1dGkKICAgICAg ICAgICAgIGsgPSBjb2RlQmxvY2stPmpzVmFsdWVzLmRhdGEoKTsKICAgICAgICAgICAgIHZQQyA9 IGNvZGVCbG9jay0+aW5zdHJ1Y3Rpb25zLmJlZ2luKCk7CiAKKyNpZiBEVU1QX09QQ09ERV9TVEFU UworICAgICAgICAgICAgT3Bjb2RlU3RhdHM6OnJlc2V0TGFzdEluc3RydWN0aW9uKCk7CisjZW5k aWYKKyAgICAgICAgICAgIAogICAgICAgICAgICAgTkVYVF9PUENPREU7CiAgICAgICAgIH0KIApJ bmRleDogVk0vT3Bjb2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBWTS9PcGNvZGUuY3BwCShyZXZpc2lv biAzNDQwOSkKKysrIFZNL09wY29kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3LDEzICsyNywy MCBAQAogICogVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElU WSBPRiBTVUNIIERBTUFHRS4KICAqLwogCisjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAi T3Bjb2RlLmgiCiAKKyNpbmNsdWRlIDxzdGRsaWIuaD4KKwordXNpbmcgbmFtZXNwYWNlIHN0ZDsK KwogbmFtZXNwYWNlIEtKUyB7CiAKICNpZiBEVU1QX09QQ09ERV9TVEFUUwogCi11bnNpZ25lZCBP cGNvZGVTdGF0czo6b3Bjb2RlQ291bnRzW251bU9wY29kZUlEc107Citsb25nIGxvbmcgT3Bjb2Rl U3RhdHM6Om9wY29kZUNvdW50c1tudW1PcGNvZGVJRHNdOworbG9uZyBsb25nIE9wY29kZVN0YXRz OjpvcGNvZGVQYWlyQ291bnRzW251bU9wY29kZUlEc11bbnVtT3Bjb2RlSURzXTsKK2ludCBPcGNv ZGVTdGF0czo6bGFzdE9wY29kZSA9IC0xOwogCiBzdGF0aWMgT3Bjb2RlU3RhdHMgbG9nZ2VyOwog CkBAIC0xMjgsNDYgKzEzNSwxMDAgQEAgT3Bjb2RlU3RhdHM6Ok9wY29kZVN0YXRzKCkKIHsKICAg ICBmb3IgKGludCBpID0gMDsgaSA8IG51bU9wY29kZUlEczsgKytpKQogICAgICAgICBvcGNvZGVD b3VudHNbaV0gPSAwOworICAgIAorICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbnVtT3Bjb2RlSURz OyArK2kpCisgICAgICAgIGZvciAoaW50IGogPSAwOyBqIDwgbnVtT3Bjb2RlSURzOyArK2opCisg ICAgICAgICAgICBvcGNvZGVQYWlyQ291bnRzW2ldW2pdID0gMDsKIH0KIAotT3Bjb2RlU3RhdHM6 On5PcGNvZGVTdGF0cygpCitzdGF0aWMgaW50IGNvbXBhcmVPcGNvZGVJbmRpY2VzKGNvbnN0IHZv aWQqIGxlZnQsIGNvbnN0IHZvaWQqIHJpZ2h0KQogewotICAgIGludCB0b3RhbEluc3RydWN0aW9u cyA9IDA7Ci0gICAgaW50IHNvcnRlZEluZGljZXNbbnVtT3Bjb2RlSURzXTsKKyAgICBsb25nIGxv bmcgbGVmdFZhbHVlID0gT3Bjb2RlU3RhdHM6Om9wY29kZUNvdW50c1sqKGludCopIGxlZnRdOwor ICAgIGxvbmcgbG9uZyByaWdodFZhbHVlID0gT3Bjb2RlU3RhdHM6Om9wY29kZUNvdW50c1sqKGlu dCopIHJpZ2h0XTsKICAgICAKLSAgICBmb3IgKGludCBpID0gMDsgaSA8IG51bU9wY29kZUlEczsg KytpKSB7CisgICAgaWYgKGxlZnRWYWx1ZSA8IHJpZ2h0VmFsdWUpCisgICAgICAgIHJldHVybiAx OworICAgIGVsc2UgaWYgKGxlZnRWYWx1ZSA+IHJpZ2h0VmFsdWUpCisgICAgICAgIHJldHVybiAt MTsKKyAgICBlbHNlCisgICAgICAgIHJldHVybiAwOworfQorCitzdGF0aWMgaW50IGNvbXBhcmVP cGNvZGVQYWlySW5kaWNlcyhjb25zdCB2b2lkKiBsZWZ0LCBjb25zdCB2b2lkKiByaWdodCkKK3sK KyAgICBwYWlyPGludCwgaW50PiBsZWZ0UGFpciA9ICoocGFpcjxpbnQsIGludD4qKSBsZWZ0Owor ICAgIGxvbmcgbG9uZyBsZWZ0VmFsdWUgPSBPcGNvZGVTdGF0czo6b3Bjb2RlUGFpckNvdW50c1ts ZWZ0UGFpci5maXJzdF1bbGVmdFBhaXIuc2Vjb25kXTsKKyAgICBwYWlyPGludCwgaW50PiByaWdo dFBhaXIgPSAqKHBhaXI8aW50LCBpbnQ+KikgcmlnaHQ7CisgICAgbG9uZyBsb25nIHJpZ2h0VmFs dWUgPSBPcGNvZGVTdGF0czo6b3Bjb2RlUGFpckNvdW50c1tyaWdodFBhaXIuZmlyc3RdW3JpZ2h0 UGFpci5zZWNvbmRdOworICAgIAorICAgIGlmIChsZWZ0VmFsdWUgPCByaWdodFZhbHVlKQorICAg ICAgICByZXR1cm4gMTsKKyAgICBlbHNlIGlmIChsZWZ0VmFsdWUgPiByaWdodFZhbHVlKQorICAg ICAgICByZXR1cm4gLTE7CisgICAgZWxzZQorICAgICAgICByZXR1cm4gMDsKK30KKworT3Bjb2Rl U3RhdHM6On5PcGNvZGVTdGF0cygpCit7CisgICAgbG9uZyBsb25nIHRvdGFsSW5zdHJ1Y3Rpb25z ID0gMDsKKyAgICBmb3IgKGludCBpID0gMDsgaSA8IG51bU9wY29kZUlEczsgKytpKQogICAgICAg ICB0b3RhbEluc3RydWN0aW9ucyArPSBvcGNvZGVDb3VudHNbaV07CisgICAgCisgICAgbG9uZyBs b25nIHRvdGFsSW5zdHJ1Y3Rpb25QYWlycyA9IDA7CisgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBu dW1PcGNvZGVJRHM7ICsraSkKKyAgICAgICAgZm9yIChpbnQgaiA9IDA7IGogPCBudW1PcGNvZGVJ RHM7ICsraikKKyAgICAgICAgICAgIHRvdGFsSW5zdHJ1Y3Rpb25QYWlycyArPSBvcGNvZGVQYWly Q291bnRzW2ldW2pdOworCisgICAgaW50IHNvcnRlZEluZGljZXNbbnVtT3Bjb2RlSURzXTsgICAg CisgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBudW1PcGNvZGVJRHM7ICsraSkKICAgICAgICAgc29y dGVkSW5kaWNlc1tpXSA9IGk7Ci0gICAgfQotICAgICAgICAKLSAgICBmb3IgKGludCBpID0gMDsg aSA8IG51bU9wY29kZUlEcyAtIDE7ICsraSkgewotICAgICAgICBpbnQgbWF4ID0gaTsKLSAgICAg ICAgCi0gICAgICAgIGZvciAoaW50IGogPSBpICsgMTsgaiA8IG51bU9wY29kZUlEczsgKytqKSB7 Ci0gICAgICAgICAgICBpZiAob3Bjb2RlQ291bnRzW3NvcnRlZEluZGljZXNbal1dID4gb3Bjb2Rl Q291bnRzW3NvcnRlZEluZGljZXNbbWF4XV0pCi0gICAgICAgICAgICAgICAgbWF4ID0gajsKLSAg ICAgICAgfQotICAgICAgICAKLSAgICAgICAgaW50IHRlbXAgPSBzb3J0ZWRJbmRpY2VzW2ldOwot ICAgICAgICBzb3J0ZWRJbmRpY2VzW2ldID0gc29ydGVkSW5kaWNlc1ttYXhdOwotICAgICAgICBz b3J0ZWRJbmRpY2VzW21heF0gPSB0ZW1wOwotICAgIH0KLSAKKyAgICBtZXJnZXNvcnQoc29ydGVk SW5kaWNlcywgbnVtT3Bjb2RlSURzLCBzaXplb2YoaW50KSwgY29tcGFyZU9wY29kZUluZGljZXMp OworICAgIAorICAgIHBhaXI8aW50LCBpbnQ+IHNvcnRlZFBhaXJJbmRpY2VzW251bU9wY29kZUlE cyAqIG51bU9wY29kZUlEc107CisgICAgcGFpcjxpbnQsIGludD4qIGN1cnJlbnRQYWlySW5kZXgg PSBzb3J0ZWRQYWlySW5kaWNlczsKKyAgICBmb3IgKGludCBpID0gMDsgaSA8IG51bU9wY29kZUlE czsgKytpKQorICAgICAgICBmb3IgKGludCBqID0gMDsgaiA8IG51bU9wY29kZUlEczsgKytqKQor ICAgICAgICAgICAgKihjdXJyZW50UGFpckluZGV4KyspID0gbWFrZV9wYWlyKGksIGopOworICAg IG1lcmdlc29ydChzb3J0ZWRQYWlySW5kaWNlcywgbnVtT3Bjb2RlSURzICogbnVtT3Bjb2RlSURz LCBzaXplb2YocGFpcjxpbnQsIGludD4pLCBjb21wYXJlT3Bjb2RlUGFpckluZGljZXMpOworICAg IAogICAgIHByaW50ZigiXG5FeGVjdXRlZCBvcGNvZGUgc3RhdGlzdGljczpcblxuIik7IAogICAg IAotICAgIHByaW50ZigiVG90YWwgaW5zdHJ1Y3Rpb25zIGV4ZWN1dGVkOiAlZFxuXG4iLCB0b3Rh bEluc3RydWN0aW9ucyk7Ci0KKyAgICBwcmludGYoIlRvdGFsIGluc3RydWN0aW9ucyBleGVjdXRl ZDogJWxsZFxuXG4iLCB0b3RhbEluc3RydWN0aW9ucyk7CisgICAgCiAgICAgZm9yIChpbnQgaSA9 IDA7IGkgPCBudW1PcGNvZGVJRHM7ICsraSkgewogICAgICAgICBpbnQgaW5kZXggPSBzb3J0ZWRJ bmRpY2VzW2ldOwogICAgICAgICBwcmludGYoIiVzOiAlLjJmJSVcbiIsIG9wY29kZU5hbWVzW2lu ZGV4XSwgKChkb3VibGUpIG9wY29kZUNvdW50c1tpbmRleF0pIC8gKChkb3VibGUpIHRvdGFsSW5z dHJ1Y3Rpb25zKSAqIDEwMC4wKTsgICAgCiAgICAgfQogICAgIAogICAgIHByaW50ZigiXG4iKTsK KyAgICAKKyAgICBmb3IgKGludCBpID0gMDsgaSA8IG51bU9wY29kZUlEcyAqIG51bU9wY29kZUlE czsgKytpKSB7CisgICAgICAgIHBhaXI8aW50LCBpbnQ+IGluZGV4UGFpciA9IHNvcnRlZFBhaXJJ bmRpY2VzW2ldOworICAgICAgICBsb25nIGxvbmcgY291bnQgPSBvcGNvZGVQYWlyQ291bnRzW2lu ZGV4UGFpci5maXJzdF1baW5kZXhQYWlyLnNlY29uZF07CisgICAgICAgIAorICAgICAgICBpZiAo IWNvdW50KQorICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIAorICAgICAgICBwcmludGYoIigl cywgJXMpOiAlLjJmJSVcbiIsIG9wY29kZU5hbWVzW2luZGV4UGFpci5maXJzdF0sIG9wY29kZU5h bWVzW2luZGV4UGFpci5zZWNvbmRdLCAoKGRvdWJsZSkgY291bnQpIC8gKChkb3VibGUpIHRvdGFs SW5zdHJ1Y3Rpb25QYWlycykgKiAxMDAuMCk7CisgICAgfQorICAgIAorICAgIHByaW50ZigiXG4i KTsKIH0KIAogdm9pZCBPcGNvZGVTdGF0czo6cmVjb3JkSW5zdHJ1Y3Rpb24oaW50IG9wY29kZSkK IHsKICAgICBvcGNvZGVDb3VudHNbb3Bjb2RlXSsrOworICAgIAorICAgIGlmIChsYXN0T3Bjb2Rl ICE9IC0xKQorICAgICAgICBvcGNvZGVQYWlyQ291bnRzW2xhc3RPcGNvZGVdW29wY29kZV0rKzsK KyAgICAKKyAgICBsYXN0T3Bjb2RlID0gb3Bjb2RlOworfQorCit2b2lkIE9wY29kZVN0YXRzOjpy ZXNldExhc3RJbnN0cnVjdGlvbigpCit7CisgICAgbGFzdE9wY29kZSA9IC0xOwogfQogCiAjZW5k aWYKSW5kZXg6IFZNL09wY29kZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFZNL09wY29kZS5oCShyZXZpc2lv biAzNDQwOSkKKysrIFZNL09wY29kZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDMsOCArMTQzLDEy IEBAIG5hbWVzcGFjZSBLSlMgewogICAgIHN0cnVjdCBPcGNvZGVTdGF0cyB7CiAgICAgICAgIE9w Y29kZVN0YXRzKCk7CiAgICAgICAgIH5PcGNvZGVTdGF0cygpOwotICAgICAgICBzdGF0aWMgdW5z aWduZWQgb3Bjb2RlQ291bnRzW251bU9wY29kZUlEc107CisgICAgICAgIHN0YXRpYyBsb25nIGxv bmcgb3Bjb2RlQ291bnRzW251bU9wY29kZUlEc107CisgICAgICAgIHN0YXRpYyBsb25nIGxvbmcg b3Bjb2RlUGFpckNvdW50c1tudW1PcGNvZGVJRHNdW251bU9wY29kZUlEc107CisgICAgICAgIHN0 YXRpYyBpbnQgbGFzdE9wY29kZTsKKwogICAgICAgICBzdGF0aWMgdm9pZCByZWNvcmRJbnN0cnVj dGlvbihpbnQgb3Bjb2RlKTsKKyAgICAgICAgc3RhdGljIHZvaWQgcmVzZXRMYXN0SW5zdHJ1Y3Rp b24oKTsKICAgICB9OwogCiAjZW5kaWYK