194166 2019-02-01 10:59:10 -0800 Force settings.acceleratedCompositingEnabled() to true for WebKit 2019-06-03 01:17:29 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198478 InRadar P2 Normal --- 1 simon.fraser simon.fraser bugs-noreply cgarcia commit-queue magomez mcatanzaro simon.fraser thorton webkit-bug-importer zan oldest_to_newest 1501164 0 simon.fraser 2019-02-01 10:59:10 -0800 Force settings.acceleratedCompositingEnabled() to true for WebKit 1501171 1 360873 simon.fraser 2019-02-01 11:03:43 -0800 Created attachment 360873 Patch 1501172 2 simon.fraser 2019-02-01 11:03:45 -0800 <rdar://problem/47694328> 1501213 3 360873 commit-queue 2019-02-01 12:20:32 -0800 Comment on attachment 360873 Patch Clearing flags on attachment: 360873 Committed r240862: <https://trac.webkit.org/changeset/240862> 1501214 4 commit-queue 2019-02-01 12:20:33 -0800 All reviewed patches have been landed. Closing bug. 1501502 5 mcatanzaro 2019-02-02 09:00:20 -0800 Can this be moved to platform-specific code, e.g. WebPageCocoa.mm? GTK requires the ability to turn it off. References: https://gitlab.gnome.org/GNOME/epiphany/commit/1618a34e7b66947a4cbcda39870a6fa525dc3a92 https://gitlab.gnome.org/GNOME/epiphany/commit/f0ccff59b66f411a2183a5d716549d14f7f71c81 1501510 6 simon.fraser 2019-02-02 11:34:57 -0800 Is that the same thing? The "Accelerated compositing" setting is about whether RenderLayerCompositor makes RenderLayerBackings for things. Those may still be backed by non-GPU-rendered buffers. How does Epiphany do rendering with WebKit2? 1501523 7 mcatanzaro 2019-02-02 13:32:48 -0800 (In reply to Simon Fraser (smfr) from comment #6) > Is that the same thing? Yes, you can verify that our public API webkit_settings_get_hardware_acceleration_policy/webkit_settings_set_hardware_acceleration_policy is implemented by toggling this acceleratedCompositingEnabled setting (as well as the forceCompositingMode setting). > The "Accelerated compositing" setting is about > whether RenderLayerCompositor makes RenderLayerBackings for things. Those > may still be backed by non-GPU-rendered buffers. > > How does Epiphany do rendering with WebKit2? I don't know anything about this. 1501738 8 simon.fraser 2019-02-03 21:33:17 -0800 (In reply to Michael Catanzaro from comment #7) > I don't know anything about this. Who does? 1501803 9 mcatanzaro 2019-02-04 06:54:05 -0800 Zan or Miguel, both are CCed. Anyway, I'll just add #if PLATFORM(COCOA) guards for now. 1501815 10 mcatanzaro 2019-02-04 07:36:18 -0800 Committed r240920: <https://trac.webkit.org/changeset/240920> 1501851 11 zan 2019-02-04 09:12:33 -0800 (In reply to Michael Catanzaro from comment #9) > Zan or Miguel, both are CCed. > DrawingAreaImpl::display(), it draws through FrameView::paint() into a shareable bitmap that's then used in the UIProcess to draw content. > Anyway, I'll just add #if PLATFORM(COCOA) guards for now. Since all this is only the case for the GTK+ port, #if !PLATFORM(GTK) guards would be more fitting. 1501952 12 mcatanzaro 2019-02-04 12:49:41 -0800 Committed r240937: <https://trac.webkit.org/changeset/240937> 1501960 13 simon.fraser 2019-02-04 12:57:17 -0800 Thanks for fixing. 360873 2019-02-01 11:03:43 -0800 2019-02-01 12:20:32 -0800 Patch bug-194166-20190201110342.patch text/plain 2201 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwODI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE5YmI2NmU1MDczNDliY2Mw MDg4OTEzNjI5ZGUxNjA3YTFkZmU5MGYuLjQ1ODM1OTgxZWVmYTRlYmZkN2Y4YmVmOTc2ZTBjOWU3 Y2U2MjMyNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDItMDEgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgRm9yY2Ugc2V0dGluZ3Mu YWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQoKSB0byB0cnVlIGZvciBXZWJLaXQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDE2NgorICAgICAg ICByZGFyOi8vcHJvYmxlbS80NzY5NDMyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYktpdCByZWxpZXMgb24gYWNjZWxlcmF0ZWQgY29tcG9zaXRp bmcgZm9yIGl0cyBkcmF3aW5nIGFyZWFzIHRvIGZ1bmN0aW9uIGNvcnJlY3RseSwKKyAgICAgICAg YW5kIHNvbWV0aW1lcyBjbGllbnRzICgqY291Z2gqIFNhZmFyaSAqY291Z2gqKSBoYXZlIGJ1Z3Mg d2hlcmUgdGhleSBjbG9iYmVyIHRoZSBzZXR0aW5ncywKKyAgICAgICAgc28gZm9yY2UgdGhpcyBz ZXR0aW5nIHRvIGJlIGFsd2F5cyBvbiAoYW5kIHJlbGVhc2UgbG9nIGlmIHRoaXMgaGFwcGVucyku CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYlBhZ2U6OnVwZGF0ZVByZWZlcmVuY2VzKToKKwogMjAxOS0wMS0zMSAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFBhZ2Ugem9vbSBsZXZlbCBpcyBs b3N0IGFmdGVyIGEgcHJvY2VzcyBzd2FwIG9yIGEgY3Jhc2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggZDkxMTRhZjc4NGI1MjdkOWNiYTZiMTVj M2NmODU1YmRjNWYzNzg5NC4uMzYwZDRhZDk2ZTdhY2Y0YTAyOTA4OGJjMTkzYWYyZTMzMWJkMjM2 NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAg LTMzNjUsNiArMzM2NSwxMSBAQCB2b2lkIFdlYlBhZ2U6OnVwZGF0ZVByZWZlcmVuY2VzKGNvbnN0 IFdlYlByZWZlcmVuY2VzU3RvcmUmIHN0b3JlKQogCiAgICAgU2V0dGluZ3MmIHNldHRpbmdzID0g bV9wYWdlLT5zZXR0aW5ncygpOwogCisgICAgaWYgKCFzZXR0aW5ncy5hY2NlbGVyYXRlZENvbXBv c2l0aW5nRW5hYmxlZCgpKSB7CisgICAgICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoIiVwIC0g V2ViUGFnZSAtIGFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkIHNldHRpbmcgd2FzIGZhbHNl LiBXZWJLaXQgY2Fubm90IGZ1bmN0aW9uIGluIHRoaXMgbW9kZTsgY2hhbmdpbmcgc2V0dGluZyB0 byB0cnVlIiwgdGhpcyk7CisgICAgICAgIHNldHRpbmdzLnNldEFjY2VsZXJhdGVkQ29tcG9zaXRp bmdFbmFibGVkKHRydWUpOworICAgIH0KKwogICAgIGJvb2wgcmVxdWlyZXNVc2VyR2VzdHVyZUZv ck1lZGlhID0gc3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5OjpyZXF1 aXJlc1VzZXJHZXN0dXJlRm9yTWVkaWFQbGF5YmFja0tleSgpKTsKICAgICBzZXR0aW5ncy5zZXRW aWRlb1BsYXliYWNrUmVxdWlyZXNVc2VyR2VzdHVyZShyZXF1aXJlc1VzZXJHZXN0dXJlRm9yTWVk aWEgfHwgc3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5OjpyZXF1aXJl c1VzZXJHZXN0dXJlRm9yVmlkZW9QbGF5YmFja0tleSgpKSk7CiAgICAgc2V0dGluZ3Muc2V0QXVk aW9QbGF5YmFja1JlcXVpcmVzVXNlckdlc3R1cmUocmVxdWlyZXNVc2VyR2VzdHVyZUZvck1lZGlh IHx8IHN0b3JlLmdldEJvb2xWYWx1ZUZvcktleShXZWJQcmVmZXJlbmNlc0tleTo6cmVxdWlyZXNV c2VyR2VzdHVyZUZvckF1ZGlvUGxheWJhY2tLZXkoKSkpOwo=