194146 2019-02-01 01:38:55 -0800 [WPE] MiniBrowser: use g_file_new_for_commandline_arg 2019-03-01 10:18:53 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply calvaris mcatanzaro webkit-bug-importer oldest_to_newest 1501056 0 cgarcia 2019-02-01 01:38:55 -0800 That way we can open relative paths. 1501057 1 360850 cgarcia 2019-02-01 01:40:07 -0800 Created attachment 360850 Patch 1501059 2 360850 aperez 2019-02-01 01:58:07 -0800 Comment on attachment 360850 Patch Informal R+ \o/ 1501061 3 360850 calvaris 2019-02-01 01:59:41 -0800 Comment on attachment 360850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360850&action=review > Tools/MiniBrowser/wpe/main.cpp:206 > + GFile* file = g_file_new_for_commandline_arg(uriArguments[0]); > + char* url = g_file_get_uri(file); I'd recommend using smart pointers for this 1501063 4 cgarcia 2019-02-01 02:02:25 -0800 (In reply to Xabier Rodríguez Calvar from comment #3) > Comment on attachment 360850 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360850&action=review > > > Tools/MiniBrowser/wpe/main.cpp:206 > > + GFile* file = g_file_new_for_commandline_arg(uriArguments[0]); > > + char* url = g_file_get_uri(file); > > I'd recommend using smart pointers for this We can't. MiniBrowser uses only the public API. 1501064 5 cgarcia 2019-02-01 02:03:41 -0800 Committed r240840: <https://trac.webkit.org/changeset/240840> 1501109 6 mcatanzaro 2019-02-01 08:25:13 -0800 You should use g_autoptr though; then we'd have noticed that the WPE API doesn't define any autoptrs at all. That's still broken. :( 1501122 7 aperez 2019-02-01 08:55:16 -0800 (In reply to Michael Catanzaro from comment #6) > You should use g_autoptr though; then we'd have noticed that the WPE API > doesn't define any autoptrs at all. That's still broken. :( Somehow it does, I'm sure of it because I have been using g_auto* (of which I am a fan) in a couple of applications which use WPE WebKit. It has happened that some autoptr definitions have not been there at different moments in time and we have been adding them whenever we notice. 1501137 8 mcatanzaro 2019-02-01 09:45:03 -0800 There's no WebKitAutocleanups.h for WPE... where are the autocleanups defined? Quick 'git grep' indicates G_DEFINE_AUTOPTR_CLEANUP_FUNC is only used in three GTK-specific headers. 1511448 9 aperez 2019-03-01 10:18:53 -0800 (In reply to Michael Catanzaro from comment #8) > There's no WebKitAutocleanups.h for WPE... where are the autocleanups > defined? > > Quick 'git grep' indicates G_DEFINE_AUTOPTR_CLEANUP_FUNC is only used in > three GTK-specific headers. Finally I got back to this — you are right and I just happened to be only using g_autoptr() for types in GLib and libsoup in the program I mentioned that uses WPE. Let's handle adding the missing autocleanups in bug #195211 :) 360850 2019-02-01 01:40:07 -0800 2019-02-01 01:59:41 -0800 Patch wpe-mb-relative-paths.diff text/plain 1441 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4NjY2 YjRjNzUzMC4uNDJhZjg4MDQ1OGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wMi0wMSAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gTWluaUJyb3dz ZXI6IHVzZSBnX2ZpbGVfbmV3X2Zvcl9jb21tYW5kbGluZV9hcmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDE0NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGFsbG93cyB0byBvcGVuIHJlbGF0aXZl IHBhdGhzLgorCisgICAgICAgICogTWluaUJyb3dzZXIvd3BlL21haW4uY3BwOgorICAgICAgICAo bWFpbik6CisKIDIwMTktMDEtMTggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtXUEVdIEFkZCBBUEkgZm9yIHdlYnZpZXcgYmFja2dyb3VuZCBjb2xv ciBjb25maWd1cmF0aW9uCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci93cGUvbWFpbi5j cHAgYi9Ub29scy9NaW5pQnJvd3Nlci93cGUvbWFpbi5jcHAKaW5kZXggMzQwM2U2MDkzMTAuLjgw NzAwODBjODNiIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci93cGUvbWFpbi5jcHAKKysr IGIvVG9vbHMvTWluaUJyb3dzZXIvd3BlL21haW4uY3BwCkBAIC0yMDEsOSArMjAxLDEzIEBAIGlu dCBtYWluKGludCBhcmdjLCBjaGFyICphcmd2W10pCiAgICAgaWYgKGJnQ29sb3IgJiYgd2Via2l0 X2NvbG9yX3BhcnNlKCZjb2xvciwgYmdDb2xvcikpCiAgICAgICAgIHdlYmtpdF93ZWJfdmlld19z ZXRfYmFja2dyb3VuZF9jb2xvcih3ZWJWaWV3LCAmY29sb3IpOwogCi0gICAgaWYgKHVyaUFyZ3Vt ZW50cykKLSAgICAgICAgd2Via2l0X3dlYl92aWV3X2xvYWRfdXJpKHdlYlZpZXcsIHVyaUFyZ3Vt ZW50c1swXSk7Ci0gICAgZWxzZSBpZiAoIWF1dG9tYXRpb25Nb2RlKQorICAgIGlmICh1cmlBcmd1 bWVudHMpIHsKKyAgICAgICAgR0ZpbGUqIGZpbGUgPSBnX2ZpbGVfbmV3X2Zvcl9jb21tYW5kbGlu ZV9hcmcodXJpQXJndW1lbnRzWzBdKTsKKyAgICAgICAgY2hhciogdXJsID0gZ19maWxlX2dldF91 cmkoZmlsZSk7CisgICAgICAgIGdfb2JqZWN0X3VucmVmKGZpbGUpOworICAgICAgICB3ZWJraXRf d2ViX3ZpZXdfbG9hZF91cmkod2ViVmlldywgdXJsKTsKKyAgICAgICAgZ19mcmVlKHVybCk7Cisg ICAgfSBlbHNlIGlmICghYXV0b21hdGlvbk1vZGUpCiAgICAgICAgIHdlYmtpdF93ZWJfdmlld19s b2FkX3VyaSh3ZWJWaWV3LCAiaHR0cHM6Ly93cGV3ZWJraXQub3JnIik7CiAKICAgICBnX21haW5f bG9vcF9ydW4obG9vcCk7Cg==