194133 2019-01-31 18:30:57 -0800 run-webkit-tests emits message "...running None" when running tests 2019-02-05 10:33:48 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193857 InRadar P2 Normal --- 1 dbates jbedard aakash_jain commit-queue ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1500951 0 dbates 2019-01-31 18:30:57 -0800 Noticed from the output in bug 193857, comment 0, paraphrasing: [[ [[ $ Tools/Scripts/run-webkit-tests --no-build --debug --ios-simulator LayoutTests/fast/events/ios/keypress-keys-in-non-editable-element.html Using port 'ios-simulator' Test configuration: <, x86_64, debug> Placing test results in /Volumes/.../Debug-iphonesimulator/layout-test-results Using Debug build Pixel tests disabled Regular timeout: 30000, slow test timeout: 150000 Command line: /Volumes/.../Debug-iphonesimulator/WebKitTestRunnerApp.app - --lint-test-files warnings: LayoutTests/platform/ios/TestExpectations:12 Path does not exist. media/controls/ipad --lint-test-files warnings: LayoutTests/platform/ios/TestExpectations:12 Path does not exist. media/controls/ipad Found 1 test; running 1, skipping 0. Verbose baseline search path: platform/ipad-(6th generation)-...-wk2 -> platform/ipad-(6th generation)-... -> platform/ipad-(6th generation)-simulator-wk2 -> platform/ipad-(6th generation)-simulator -> platform/ipad-...-wk2 -> platform/ipad-... -> platform/ipad-simulator-wk2 -> platform/ipad-simulator -> platform/ios-...-wk2 -> platform/ios-... -> platform/ios-simulator-wk2 -> platform/ios-simulator -> platform/ipad-(6th generation)-...-wk2 -> platform/ipad-(6th generation)-... -> platform/ipad-(6th generation)-wk2 -> platform/ipad-(6th generation) -> platform/ipad-...-wk2 -> platform/ipad-... -> platform/ipad-wk2 -> platform/ipad -> platform/ios-...-wk2 -> platform/ios-... -> platform/ios-wk2 -> platform/ios -> platform/wk2 -> generic Baseline search path: platform/ios-simulator-wk2 -> platform/ios-simulator -> platform/ipad -> platform/ios-wk2 -> platform/ios -> platform/wk2 -> generic Running 1 test for iPad (6th generation) running None Running 1 WebKitTestRunnerApp.app. [1/1] fast/events/ios/keypress-keys-in-non-editable-element.html failed unexpectedly (text diff) Retrying 1 unexpected failure ... Running 1 WebKitTestRunnerApp.app. ]] Notice the "Running 1 test for iPad (6th generation) running None" line. Specifically, the "... running None" part of the line. What does this mean? Doesn't read right. 1500953 1 webkit-bug-importer 2019-01-31 18:31:44 -0800 <rdar://problem/47724738> 1500954 2 webkit-bug-importer 2019-01-31 18:31:46 -0800 <rdar://problem/47724739> 1501115 3 jbedard 2019-02-01 08:40:01 -0800 I agree that the 'running None' is silly (it should be running iOS <version>). I've seen this effect on-device testing as well. It's most likely a failure to define the OS when picking up booted devices. 1502379 4 jbedard 2019-02-05 09:03:56 -0800 Actually, looks like this is really about problems with future versions. It's a pretty simple fix. 1502383 5 361195 jbedard 2019-02-05 09:12:18 -0800 Created attachment 361195 Patch 1502415 6 361195 commit-queue 2019-02-05 10:33:46 -0800 Comment on attachment 361195 Patch Clearing flags on attachment: 361195 Committed r240982: <https://trac.webkit.org/changeset/240982> 1502416 7 commit-queue 2019-02-05 10:33:48 -0800 All reviewed patches have been landed. Closing bug. 361195 2019-02-05 09:12:18 -0800 2019-02-05 10:33:46 -0800 Patch bug-194133-20190205091217.patch text/plain 3495 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MDk3NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE5LTAyLTA1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4td2Via2l0LXRlc3RzIGVtaXRzIG1lc3NhZ2UgIi4uLnJ1bm5pbmcg Tm9uZSIgd2hlbiBydW5uaW5nIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTQxMzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3NzI0NzM4 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS94Y29kZS9kZXZpY2VfdHlwZS5weToKKyAgICAgICAgKERldmljZVR5cGUu X19zdHJfXyk6IFVzZSBib3RoIHZlcnNpb24gbWFwcGluZyB0YWJsZXMgYW5kIHVzZSBqdXN0IHRo ZSB2YXJpYW50CisgICAgICAgIG5hbWUgaWYgbm8gdmVyc2lvbiBuYW1lIGlzIGF2YWlsYWJsZS4K KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3hjb2RlL2RldmljZV90eXBlX3VuaXR0ZXN0LnB5 OgorICAgICAgICAoRGV2aWNlVHlwZVRlc3QpOgorICAgICAgICAoRGV2aWNlVHlwZVRlc3QudGVz dF91bm1hcHBlZF92ZXJzaW9uKTogVGVzdCBjYXNlIHdoZXJlIHRoZSB2ZXJzaW9uIGRvZXMgbm90 IGhhdmUKKyAgICAgICAgYW4gYXNzb2NpYXRlZCBuYW1lZC4KKwogMjAxOS0wMi0wNCAgTXMyZ2Vy ICA8TXMyZ2VyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBOZWVkIGEgZnVuY3Rp b24gdG8gY29udmVydCBpbnRlcm5hbCBVUkkgdG8gZGlzcGxheSAoInByZXR0eSIpIFVSSQpJbmRl eDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9kZXZpY2VfdHlwZS5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL2RldmljZV90eXBlLnB5CShyZXZpc2lv biAyNDA5NjMpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL2RldmljZV90eXBlLnB5 CSh3b3JraW5nIGNvcHkpCkBAIC0yMCw3ICsyMCw4IEBACiAjIE9SIFRPUlQgKElOQ0xVRElORyBO RUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNF CiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkg T0YgU1VDSCBEQU1BR0UuCiAKLWZyb20gd2Via2l0cHkuY29tbW9uLnZlcnNpb25fbmFtZV9tYXAg aW1wb3J0IFZlcnNpb25OYW1lTWFwCitmcm9tIHdlYmtpdHB5LmNvbW1vbi52ZXJzaW9uX25hbWVf bWFwIGltcG9ydCBWZXJzaW9uTmFtZU1hcCwgSU5URVJOQUxfVEFCTEUKK2Zyb20gd2Via2l0cHku cG9ydC5jb25maWcgaW1wb3J0IGFwcGxlX2FkZGl0aW9ucwogCiAKICMgVGhpcyBjbGFzcyBpcyBk ZXNpZ25lZCB0byBtYXRjaCBkZXZpY2UgdHlwZXMuIEJlY2F1c2UgaXQgaXMgdXNlZCBmb3IgbWF0 Y2hpbmcsICdOb25lJyBpcyB0cmVhdGVkIGFzIGEgd2lsZC1jYXJkLgpAQCAtMTA4LDEwICsxMDks MTYgQEAgY2xhc3MgRGV2aWNlVHlwZShvYmplY3QpOgogICAgICAgICBzZWxmLmNoZWNrX2NvbnNp c3RlbmN5KCkKIAogICAgIGRlZiBfX3N0cl9fKHNlbGYpOgorICAgICAgICB2ZXJzaW9uID0gTm9u ZQorICAgICAgICBpZiBzZWxmLnNvZnR3YXJlX3ZlcnNpb24gYW5kIGFwcGxlX2FkZGl0aW9ucygp OgorICAgICAgICAgICAgdmVyc2lvbiA9IFZlcnNpb25OYW1lTWFwLm1hcCgpLnRvX25hbWUoc2Vs Zi5zb2Z0d2FyZV92ZXJzaW9uLCBwbGF0Zm9ybT1zZWxmLnNvZnR3YXJlX3ZhcmlhbnQubG93ZXIo KSwgdGFibGU9SU5URVJOQUxfVEFCTEUpCisgICAgICAgIGVsaWYgc2VsZi5zb2Z0d2FyZV92ZXJz aW9uOgorICAgICAgICAgICAgdmVyc2lvbiA9IFZlcnNpb25OYW1lTWFwLm1hcCgpLnRvX25hbWUo c2VsZi5zb2Z0d2FyZV92ZXJzaW9uLCBwbGF0Zm9ybT1zZWxmLnNvZnR3YXJlX3ZhcmlhbnQubG93 ZXIoKSkKKwogICAgICAgICByZXR1cm4gJ3toYXJkd2FyZV9mYW1pbHl9e2hhcmR3YXJlX3R5cGV9 IHJ1bm5pbmcge3ZlcnNpb259Jy5mb3JtYXQoCiAgICAgICAgICAgICBoYXJkd2FyZV9mYW1pbHk9 c2VsZi5oYXJkd2FyZV9mYW1pbHkgaWYgc2VsZi5oYXJkd2FyZV9mYW1pbHkgZWxzZSAnRGV2aWNl JywKICAgICAgICAgICAgIGhhcmR3YXJlX3R5cGU9JyB7fScuZm9ybWF0KHNlbGYuaGFyZHdhcmVf dHlwZSkgaWYgc2VsZi5oYXJkd2FyZV90eXBlIGVsc2UgJycsCi0gICAgICAgICAgICB2ZXJzaW9u PVZlcnNpb25OYW1lTWFwLm1hcCgpLnRvX25hbWUoc2VsZi5zb2Z0d2FyZV92ZXJzaW9uLCBwbGF0 Zm9ybT1zZWxmLnNvZnR3YXJlX3ZhcmlhbnQubG93ZXIoKSkgaWYgc2VsZi5zb2Z0d2FyZV92ZXJz aW9uIGVsc2Ugc2VsZi5zb2Z0d2FyZV92YXJpYW50LAorICAgICAgICAgICAgdmVyc2lvbj12ZXJz aW9uIG9yIHNlbGYuc29mdHdhcmVfdmFyaWFudCwKICAgICAgICAgKQogCiAgICAgIyBUaGlzIHRl Y2huaXF1ZSBvZiBtYXRjaGluZyB0cmVhdHMgJ05vbmUnIGEgd2lsZC1jYXJkLgpJbmRleDogVG9v bHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9kZXZpY2VfdHlwZV91bml0dGVzdC5weQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL2RldmljZV90eXBlX3VuaXR0ZXN0 LnB5CShyZXZpc2lvbiAyNDA5NjMpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL2Rl dmljZV90eXBlX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNTUsMyArMTU1LDYgQEAg Y2xhc3MgRGV2aWNlVHlwZVRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBzZWxmLmFz c2VydFRydWUoRGV2aWNlVHlwZS5mcm9tX3N0cmluZygnaXBob25lIDZzJykgaW4gRGV2aWNlVHlw ZS5mcm9tX3N0cmluZygnaVBob25lJykpCiAgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShEZXZpY2VU eXBlLmZyb21fc3RyaW5nKCdpUGhvbmUgNnMnKSBpbiBEZXZpY2VUeXBlLmZyb21fc3RyaW5nKCdp cGhvbmUnKSkKICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKERldmljZVR5cGUuZnJvbV9zdHJpbmco J2lwaG9uZSA2cycpIGluIERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lwaG9uZScpKQorCisgICAg ZGVmIHRlc3RfdW5tYXBwZWRfdmVyc2lvbihzZWxmKToKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVh bCgnaVBob25lIHJ1bm5pbmcgaU9TJywgc3RyKERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lQaG9u ZScsIFZlcnNpb24oOSkpKSkK