194119 2019-01-31 15:36:44 -0800 Web Inspector: Make WI.StackedLineChart a WI.View subclass 2019-02-01 13:27:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1500852 0 joepeck 2019-01-31 15:36:44 -0800 Make WI.StackedLineChart a WI.View subclass It can eliminate its own needsLayout/updateLayout logic and participate in normal view drawing. Note: - LineChart just moved as well. 1500854 1 360796 joepeck 2019-01-31 15:37:48 -0800 Created attachment 360796 [PATCH] Proposed Fix 1500942 2 360796 hi 2019-01-31 17:51:34 -0800 Comment on attachment 360796 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=360796&action=review rs=me, not sure why this won't apply 🤔, but it looks good to me > Source/WebInspectorUI/UserInterface/Views/LineChart.js:91 > + super.layout(); Oops. Forgot that :P > Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.js:43 > + this._chart.size = new WI.Size(0, this.height); I don't think this is necessary, given that you're making the width `0`. Not setting a `size` means we don't draw, so it should have the same effect as setting the width to `0`. 1501247 3 joepeck 2019-02-01 13:27:02 -0800 https://trac.webkit.org/changeset/240871/webkit 1501250 4 webkit-bug-importer 2019-02-01 13:27:28 -0800 <rdar://problem/47747265> 360796 2019-01-31 15:37:48 -0800 2019-02-01 13:26:58 -0800 [PATCH] Proposed Fix stacked-line-chart-1.patch text/plain 5882 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGZjZGE0MmY3OGQwLi41ZjQzZDliMTkwYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMDEtMzEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBNYWtlIFdJLlN0YWNrZWRMaW5lQ2hhcnQgYSBXSS5WaWV3IHN1YmNsYXNzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQxMTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmll d3MvTGluZUNoYXJ0LmpzOgorICAgICAgICAoV0kuTGluZUNoYXJ0LnByb3RvdHlwZS5sYXlvdXQp OgorICAgICAgICAoV0kuTGluZUNoYXJ0KToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdz L01lbW9yeVRpbWVsaW5lT3ZlcnZpZXdHcmFwaC5qczoKKyAgICAgICAgKFdJLk1lbW9yeVRpbWVs aW5lT3ZlcnZpZXdHcmFwaCk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TdGFja2Vk TGluZUNoYXJ0LmpzOgorICAgICAgICAoV0kuU3RhY2tlZExpbmVDaGFydCk6CisgICAgICAgIChX SS5TdGFja2VkTGluZUNoYXJ0LnByb3RvdHlwZS5zZXQgc2l6ZSk6CisgICAgICAgIChXSS5TdGFj a2VkTGluZUNoYXJ0LnByb3RvdHlwZS5sYXlvdXQpOgorICAgICAgICAoV0kuU3RhY2tlZExpbmVD aGFydC5wcm90b3R5cGUuZ2V0IGVsZW1lbnQpOiBEZWxldGVkLgorICAgICAgICAoV0kuU3RhY2tl ZExpbmVDaGFydC5wcm90b3R5cGUuZ2V0IHBvaW50cyk6IERlbGV0ZWQuCisgICAgICAgIChXSS5T dGFja2VkTGluZUNoYXJ0LnByb3RvdHlwZS5uZWVkc0xheW91dCk6IERlbGV0ZWQuCisgICAgICAg IChXSS5TdGFja2VkTGluZUNoYXJ0LnByb3RvdHlwZS51cGRhdGVMYXlvdXQpOiBEZWxldGVkLgor CiAyMDE5LTAxLTMxICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBXSS5DaXJjbGVDaGFydCBhIFdJLlZpZXcgc3ViY2xh c3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0xpbmVDaGFydC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0xpbmVDaGFydC5qcwppbmRleCAyMWY0MTYwOTY3OC4uMTllZDBhNWRlMGQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xpbmVDaGFydC5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9MaW5lQ2hhcnQu anMKQEAgLTMzLDcgKzMzLDcgQEAKIC8vIC0gVGhlcmUgaXMgYSBzaW5nbGUgcGF0aCBmb3IgbGlu ZS4KIC8vCiAvLyAgPGRpdiBjbGFzcz0ibGluZS1jaGFydCI+Ci0vLyAgICAgIDxzdmcgd2lkdGg9 IjgwMCIgaGVpZ2h0PSI3NSIgdmlld0JveD0iMCAwIDgwMCA3NSI+CisvLyAgICAgIDxzdmcgdmll d0JveD0iMCAwIDgwMCA3NSI+CiAvLyAgICAgICAgICA8cGF0aCBkPSIuLi4iLz4KIC8vICAgICAg PC9zdmc+CiAvLyAgPC9kaXY+CkBAIC04OCw2ICs4OCw4IEBAIFdJLkxpbmVDaGFydCA9IGNsYXNz IExpbmVDaGFydCBleHRlbmRzIFdJLlZpZXcKIAogICAgIGxheW91dCgpCiAgICAgeworICAgICAg ICBzdXBlci5sYXlvdXQoKTsKKwogICAgICAgICBpZiAodGhpcy5sYXlvdXRSZWFzb24gPT09IFdJ LlZpZXcuTGF5b3V0UmVhc29uLlJlc2l6ZSkKICAgICAgICAgICAgIHJldHVybjsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTWVtb3J5VGlt ZWxpbmVPdmVydmlld0dyYXBoLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvTWVtb3J5VGltZWxpbmVPdmVydmlld0dyYXBoLmpzCmluZGV4IDM1NDUyNDk2NTMy Li4xN2U3NDMxOGZjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvTWVtb3J5VGltZWxpbmVPdmVydmlld0dyYXBoLmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL01lbW9yeVRpbWVsaW5lT3ZlcnZpZXdH cmFwaC5qcwpAQCAtMzksOCArMzksOSBAQCBXSS5NZW1vcnlUaW1lbGluZU92ZXJ2aWV3R3JhcGgg PSBjbGFzcyBNZW1vcnlUaW1lbGluZU92ZXJ2aWV3R3JhcGggZXh0ZW5kcyBXSS5UaQogCiAgICAg ICAgIHRoaXMuX2RpZEluaXRpYWxpemVDYXRlZ29yaWVzID0gZmFsc2U7CiAKLSAgICAgICAgbGV0 IHNpemUgPSBuZXcgV0kuU2l6ZSgwLCB0aGlzLmhlaWdodCk7Ci0gICAgICAgIHRoaXMuX2NoYXJ0 ID0gbmV3IFdJLlN0YWNrZWRMaW5lQ2hhcnQoc2l6ZSk7CisgICAgICAgIHRoaXMuX2NoYXJ0ID0g bmV3IFdJLlN0YWNrZWRMaW5lQ2hhcnQ7CisgICAgICAgIHRoaXMuX2NoYXJ0LnNpemUgPSBuZXcg V0kuU2l6ZSgwLCB0aGlzLmhlaWdodCk7CisgICAgICAgIHRoaXMuYWRkU3Vidmlldyh0aGlzLl9j aGFydCk7CiAgICAgICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9jaGFydC5lbGVt ZW50KTsKIAogICAgICAgICB0aGlzLl9sZWdlbmRFbGVtZW50ID0gdGhpcy5lbGVtZW50LmFwcGVu ZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1N0YWNrZWRMaW5lQ2hhcnQuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TdGFja2VkTGluZUNo YXJ0LmpzCmluZGV4IDhkYmQ2MWIxYWQxLi5lYTBhMDBmMDA3ZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3RhY2tlZExpbmVDaGFydC5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TdGFja2VkTGlu ZUNoYXJ0LmpzCkBAIC0zOCwzMSArMzgsMzEgQEAKIC8vICAgdGhhdCB0aGUgcGF0aHMgZm9yIGxv d2VyIHNlY3Rpb25zIG92ZXJsYXAgdGhlIHBhdGhzIGZvciB1cHBlciBzZWN0aW9ucy4KIC8vCiAv LyAgPGRpdiBjbGFzcz0ic3RhY2tlZC1saW5lLWNoYXJ0Ij4KLS8vICAgICAgPHN2ZyB3aWR0aD0i MTAwMCIgaGVpZ2h0PSIxMDAiIHZpZXdib3g9IjAgMCAxMDAwIDEwMCI+Ci0vLyAgICAgICAgICA8 cGF0aCBjbGFzcz0ic2VjdGlvbi1jbGFzcy1uYW1lLTEiIGQ9Ii4uLiIvPgorLy8gICAgICA8c3Zn IHZpZXdCb3g9IjAgMCAxMDAwIDEwMCI+CiAvLyAgICAgICAgICA8cGF0aCBjbGFzcz0ic2VjdGlv bi1jbGFzcy1uYW1lLTIiIGQ9Ii4uLiIvPgorLy8gICAgICAgICAgPHBhdGggY2xhc3M9InNlY3Rp b24tY2xhc3MtbmFtZS0xIiBkPSIuLi4iLz4KIC8vICAgICAgPC9zdmc+CiAvLyAgPC9kaXY+CiAK LVdJLlN0YWNrZWRMaW5lQ2hhcnQgPSBjbGFzcyBTdGFja2VkTGluZUNoYXJ0CitXSS5TdGFja2Vk TGluZUNoYXJ0ID0gY2xhc3MgU3RhY2tlZExpbmVDaGFydCBleHRlbmRzIFdJLlZpZXcKIHsKLSAg ICBjb25zdHJ1Y3RvcihzaXplKQorICAgIGNvbnN0cnVjdG9yKCkKICAgICB7Ci0gICAgICAgIHRo aXMuX2VsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKLSAgICAgICAgdGhp cy5fZWxlbWVudC5jbGFzc0xpc3QuYWRkKCJzdGFja2VkLWxpbmUtY2hhcnQiKTsKKyAgICAgICAg c3VwZXIoKTsKKworICAgICAgICB0aGlzLmVsZW1lbnQuY2xhc3NMaXN0LmFkZCgic3RhY2tlZC1s aW5lLWNoYXJ0Iik7CisKKyAgICAgICAgdGhpcy5fY2hhcnRFbGVtZW50ID0gdGhpcy5lbGVtZW50 LmFwcGVuZENoaWxkKGNyZWF0ZVNWR0VsZW1lbnQoInN2ZyIpKTsKKyAgICAgICAgdGhpcy5fY2hh cnRFbGVtZW50LnNldEF0dHJpYnV0ZSgicHJlc2VydmVBc3BlY3RSYXRpbyIsICJub25lIik7CiAK LSAgICAgICAgdGhpcy5fY2hhcnRFbGVtZW50ID0gdGhpcy5fZWxlbWVudC5hcHBlbmRDaGlsZChj cmVhdGVTVkdFbGVtZW50KCJzdmciKSk7CiAgICAgICAgIHRoaXMuX3BhdGhFbGVtZW50cyA9IFtd OwogCiAgICAgICAgIHRoaXMuX3BvaW50cyA9IFtdOwotICAgICAgICB0aGlzLnNpemUgPSBzaXpl OworICAgICAgICB0aGlzLl9zaXplID0gbnVsbDsKICAgICB9CiAKICAgICAvLyBQdWJsaWMKIAot ICAgIGdldCBlbGVtZW50KCkgeyByZXR1cm4gdGhpcy5fZWxlbWVudDsgfQotICAgIGdldCBwb2lu dHMoKSB7IHJldHVybiB0aGlzLl9wb2ludHM7IH0KLQogICAgIGdldCBzaXplKCkKICAgICB7CiAg ICAgICAgIHJldHVybiB0aGlzLl9zaXplOwpAQCAtNzAsMTEgKzcwLDE0IEBAIFdJLlN0YWNrZWRM aW5lQ2hhcnQgPSBjbGFzcyBTdGFja2VkTGluZUNoYXJ0CiAKICAgICBzZXQgc2l6ZShzaXplKQog ICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX3NpemUgJiYgdGhpcy5fc2l6ZS5lcXVhbHMoc2l6ZSkp CisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgdGhpcy5fc2l6ZSA9IHNpemU7CiAKLSAg ICAgICAgdGhpcy5fY2hhcnRFbGVtZW50LnNldEF0dHJpYnV0ZSgid2lkdGgiLCBzaXplLndpZHRo KTsKLSAgICAgICAgdGhpcy5fY2hhcnRFbGVtZW50LnNldEF0dHJpYnV0ZSgiaGVpZ2h0Iiwgc2l6 ZS5oZWlnaHQpOwotICAgICAgICB0aGlzLl9jaGFydEVsZW1lbnQuc2V0QXR0cmlidXRlKCJ2aWV3 Ym94IiwgYDAgMCAke3NpemUud2lkdGh9ICR7c2l6ZS5oZWlnaHR9YCk7CisgICAgICAgIHRoaXMu X2NoYXJ0RWxlbWVudC5zZXRBdHRyaWJ1dGUoInZpZXdCb3giLCBgMCAwICR7c2l6ZS53aWR0aH0g JHtzaXplLmhlaWdodH1gKTsKKworICAgICAgICB0aGlzLm5lZWRzTGF5b3V0KCk7CiAgICAgfQog CiAgICAgaW5pdGlhbGl6ZVNlY3Rpb25zKHNlY3Rpb25DbGFzc05hbWVzKQpAQCAtMTAzLDIwICsx MDYsMTcgQEAgV0kuU3RhY2tlZExpbmVDaGFydCA9IGNsYXNzIFN0YWNrZWRMaW5lQ2hhcnQKICAg ICAgICAgdGhpcy5fcG9pbnRzID0gW107CiAgICAgfQogCi0gICAgbmVlZHNMYXlvdXQoKQorICAg IC8vIFByb3RlY3RlZAorCisgICAgbGF5b3V0KCkKICAgICB7Ci0gICAgICAgIGlmICh0aGlzLl9z Y2hlZHVsZWRMYXlvdXRVcGRhdGVJZGVudGlmaWVyKQotICAgICAgICAgICAgcmV0dXJuOworICAg ICAgICBzdXBlci5sYXlvdXQoKTsKIAotICAgICAgICB0aGlzLl9zY2hlZHVsZWRMYXlvdXRVcGRh dGVJZGVudGlmaWVyID0gcmVxdWVzdEFuaW1hdGlvbkZyYW1lKHRoaXMudXBkYXRlTGF5b3V0LmJp bmQodGhpcykpOwotICAgIH0KKyAgICAgICAgaWYgKHRoaXMubGF5b3V0UmVhc29uID09PSBXSS5W aWV3LkxheW91dFJlYXNvbi5SZXNpemUpCisgICAgICAgICAgICByZXR1cm47CiAKLSAgICB1cGRh dGVMYXlvdXQoKQotICAgIHsKLSAgICAgICAgaWYgKHRoaXMuX3NjaGVkdWxlZExheW91dFVwZGF0 ZUlkZW50aWZpZXIpIHsKLSAgICAgICAgICAgIGNhbmNlbEFuaW1hdGlvbkZyYW1lKHRoaXMuX3Nj aGVkdWxlZExheW91dFVwZGF0ZUlkZW50aWZpZXIpOwotICAgICAgICAgICAgdGhpcy5fc2NoZWR1 bGVkTGF5b3V0VXBkYXRlSWRlbnRpZmllciA9IHVuZGVmaW5lZDsKLSAgICAgICAgfQorICAgICAg ICBpZiAoIXRoaXMuX3NpemUpCisgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgbGV0IHBh dGhDb21wb25lbnRzID0gW107CiAgICAgICAgIGxldCBsZW5ndGggPSB0aGlzLl9wYXRoRWxlbWVu dHMubGVuZ3RoOwo=