194050 2019-01-30 14:34:58 -0800 Object.keys can now lead to a PhantomNewArrayBuffer, OSR exit from the FTL should know how to materialize a NewArrayBuffer in that case 2019-01-30 16:49:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=190047 InRadar P2 Normal --- 1 rmorisset rmorisset commit-queue ews-watchlist keith_miller mark.lam msaboff saam ysuzuki oldest_to_newest 1500196 0 rmorisset 2019-01-30 14:34:58 -0800 <rdar://problem/47595592> 1500219 1 360630 rmorisset 2019-01-30 15:05:23 -0800 Created attachment 360630 Patch 1500220 2 360630 ysuzuki 2019-01-30 15:10:14 -0800 Comment on attachment 360630 Patch r=me 1500283 3 360630 commit-queue 2019-01-30 16:49:32 -0800 Comment on attachment 360630 Patch Clearing flags on attachment: 360630 Committed r240740: <https://trac.webkit.org/changeset/240740> 1500284 4 commit-queue 2019-01-30 16:49:34 -0800 All reviewed patches have been landed. Closing bug. 360630 2019-01-30 15:05:23 -0800 2019-01-30 16:49:32 -0800 Patch bug-194050-20190130150522.patch text/plain 3908 rmorisset SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDA3MzIpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE5LTAxLTMwICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBh cHBsZS5jb20+CisKKyAgICAgICAgT2JqZWN0LmtleXMgY2FuIG5vdyBsZWFkIHRvIGEgUGhhbnRv bU5ld0FycmF5QnVmZmVyLCBPU1IgZXhpdCBmcm9tIHRoZSBGVEwgc2hvdWxkIGtub3cgaG93IHRv IG1hdGVyaWFsaXplIGEgTmV3QXJyYXlCdWZmZXIgaW4gdGhhdCBjYXNlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTQwNTAKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzQ3NTk1NTkyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogc3RyZXNzL29iamVjdC1rZXlzLW9zci1leGl0LmpzOiBBZGRlZC4KKyAg ICAgICAgKGZvbyk6CisgICAgICAgIChjYXRjaCk6CisKIDIwMTktMDEtMjkgIE1hcmsgTGFtICA8 bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFZhbHVlUmVjb3Zlcnk6OnJlY292ZXIoKSBz aG91bGQgcHVyaWZ5IE5hTiB2YWx1ZXMgaXQgcmVjb3ZlcnMuCkluZGV4OiBKU1Rlc3RzL3N0cmVz cy9vYmplY3Qta2V5cy1vc3ItZXhpdC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9v YmplY3Qta2V5cy1vc3ItZXhpdC5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9v YmplY3Qta2V5cy1vc3ItZXhpdC5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDIyIEBACisv L0AgcnVuRGVmYXVsdCgiLS1mb3JjZUVhZ2VyQ29tcGlsYXRpb249MSIsICItLXVzZUNvbmN1cnJl bnRKSVQ9MCIpCisKK2Z1bmN0aW9uIGZvbyh4KSB7CisgIGlmICh4KSB7CisgICAgcmV0dXJuOwor ICB9CisgIGxldCBvYmogPSB7CisgICAgYTogMCwKKyAgICBiOiAwCisgIH07CisgIGZvbygxKTsK KyAgbGV0IGtleXMgPSBPYmplY3Qua2V5cyhvYmopOworICBmb28oKTsKKyAga2V5cy5sZW5ndGgK K30KKwordHJ5IHsKKyAgZm9vKCk7Cit9IGNhdGNoKGUpIHsKKyAgaWYgKGUgIT0gIlJhbmdlRXJy b3I6IE1heGltdW0gY2FsbCBzdGFjayBzaXplIGV4Y2VlZGVkLiIpCisgIHRocm93ICJGQUlMRUQi OworfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDA3MjYpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTcgQEAKKzIwMTktMDEtMzAgIFJvYmluIE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4K KworICAgICAgICBPYmplY3Qua2V5cyBjYW4gbm93IGxlYWQgdG8gYSBQaGFudG9tTmV3QXJyYXlC dWZmZXIsIE9TUiBleGl0IGZyb20gdGhlIEZUTCBzaG91bGQga25vdyBob3cgdG8gbWF0ZXJpYWxp emUgYSBOZXdBcnJheUJ1ZmZlciBpbiB0aGF0IGNhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDA1MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NDc1OTU1OTI+CisKKyAgICAgICAgRm9sbG93aW5nIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTAwNDcsIFBoYW50b21OZXdBcnJheUJ1ZmZlciBpcyBubyBsb25nZXIg Z3VhcmFudGVlZCB0byBvcmlnaW5hdGUgZnJvbSBhIE5ld0FycmF5QnVmZmVyIGluIHRoZSBiYXNl bGluZSBqaXQuCisgICAgICAgIEl0IGNhbiBub3cgY29tZSBmcm9tIE9iamVjdC5rZXlzLCB3aGlj aCBpcyBhIGZ1bmN0aW9uIGNhbGwuIFdlIG11c3QgdGVhY2ggdGhlIEZUTCBob3cgdG8gT1NSIGV4 aXQgaW4gdGhhdCBjYXNlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZnRsL0ZUTE9wZXJhdGlvbnMuY3BwOgorICAgICAgICAoSlNDOjpGVEw6Om9w ZXJhdGlvbk1hdGVyaWFsaXplT2JqZWN0SW5PU1IpOgorCiAyMDE5LTAxLTMwICBZdXN1a2UgU3V6 dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdXBkYXRlIHRo ZSBidWlsdGluIHRlc3QgcmVzdWx0cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9G VExPcGVyYXRpb25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRs L0ZUTE9wZXJhdGlvbnMuY3BwCShyZXZpc2lvbiAyNDA3MjYpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZnRsL0ZUTE9wZXJhdGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzUsNyArNDc1 LDEzIEBAIGV4dGVybiAiQyIgSlNDZWxsKiBKSVRfT1BFUkFUSU9OIG9wZXJhdGkKICAgICAgICAg Ly8gYW5kIFBoYW50b21OZXdBcnJheUJ1ZmZlciBhcmUgYWx3YXlzIGJvdW5kIHRvIGEgc3BlY2lm aWMgb3BfbmV3X2FycmF5X2J1ZmZlci4KICAgICAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2sgPSBi YXNlbGluZUNvZGVCbG9ja0Zvck9yaWdpbkFuZEJhc2VsaW5lQ29kZUJsb2NrKG1hdGVyaWFsaXph dGlvbi0+b3JpZ2luKCksIGV4ZWMtPmNvZGVCbG9jaygpLT5iYXNlbGluZUFsdGVybmF0aXZlKCkp OwogICAgICAgICBjb25zdCBJbnN0cnVjdGlvbiogY3VycmVudEluc3RydWN0aW9uID0gY29kZUJs b2NrLT5pbnN0cnVjdGlvbnMoKS5hdChtYXRlcmlhbGl6YXRpb24tPm9yaWdpbigpLmJ5dGVjb2Rl SW5kZXgpLnB0cigpOwotICAgICAgICBSRUxFQVNFX0FTU0VSVChjdXJyZW50SW5zdHJ1Y3Rpb24t PmlzPE9wTmV3QXJyYXlCdWZmZXI+KCkpOworICAgICAgICBpZiAoIWN1cnJlbnRJbnN0cnVjdGlv bi0+aXM8T3BOZXdBcnJheUJ1ZmZlcj4oKSkgeworICAgICAgICAgICAgLy8gVGhpcyBjYXNlIGNh biBoYXBwZW4gaWYgT2JqZWN0LmtleXMsIGFuIE9wQ2FsbCBpcyBmaXJzdCBjb252ZXJ0ZWQgaW50 byBhIE5ld0FycmF5QnVmZmVyIHdoaWNoIGlzIHRoZW4gY29udmVydGVkIGludG8gYSBQaGFudG9t TmV3QXJyYXlCdWZmZXIuCisgICAgICAgICAgICAvLyBUaGVyZSBpcyBubyBuZWVkIHRvIHVwZGF0 ZSB0aGUgYXJyYXkgYWxsb2NhdGlvbiBwcm9maWxlIGluIHRoYXQgY2FzZS4KKyAgICAgICAgICAg IFJFTEVBU0VfQVNTRVJUKGN1cnJlbnRJbnN0cnVjdGlvbi0+aXM8T3BDYWxsPigpKTsKKyAgICAg ICAgICAgIFN0cnVjdHVyZSogc3RydWN0dXJlID0gZXhlYy0+bGV4aWNhbEdsb2JhbE9iamVjdCgp LT5hcnJheVN0cnVjdHVyZUZvckluZGV4aW5nVHlwZUR1cmluZ0FsbG9jYXRpb24oaW1tdXRhYmxl QnV0dGVyZmx5LT5pbmRleGluZ01vZGUoKSk7CisgICAgICAgICAgICByZXR1cm4gQ29tbW9uU2xv d1BhdGhzOjphbGxvY2F0ZU5ld0FycmF5QnVmZmVyKHZtLCBzdHJ1Y3R1cmUsIGltbXV0YWJsZUJ1 dHRlcmZseSk7CisgICAgICAgIH0KICAgICAgICAgYXV0byBuZXdBcnJheUJ1ZmZlciA9IGN1cnJl bnRJbnN0cnVjdGlvbi0+YXM8T3BOZXdBcnJheUJ1ZmZlcj4oKTsKICAgICAgICAgQXJyYXlBbGxv Y2F0aW9uUHJvZmlsZSogcHJvZmlsZSA9ICZuZXdBcnJheUJ1ZmZlci5tZXRhZGF0YShjb2RlQmxv Y2spLm1fYXJyYXlBbGxvY2F0aW9uUHJvZmlsZTsKIAo=