19403 2008-06-05 17:29:50 -0700 ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call 2008-06-05 21:46:04 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 justin.garcia webkit-unassigned eric oldest_to_newest 82372 0 justin.garcia 2008-06-05 17:29:50 -0700 Run the attached test case in a debug build. ASSERT(!text.isEmpty()) inside InsertIntoTextNodeCommand::InsertIntoTextNodeCommand fires because RemoveFormat calls input with an empty String. plainText() is returning an empty string for a Range selection for some reason... 82373 1 21516 justin.garcia 2008-06-05 17:30:27 -0700 Created attachment 21516 test case 82380 2 21519 justin.garcia 2008-06-05 20:56:04 -0700 Created attachment 21519 patch 82383 3 21519 eric 2008-06-05 21:32:18 -0700 Comment on attachment 21519 patch Looks good. The if (string.isEmpty()) should have a comment before it explaning "why", since I'm not sure it will be clear to either of us why it's there in 9 months. :) If you strongly disagree I'm fine w/ you to landing w/o comment. I don't need to see your final patch again either way. :) 82384 4 justin.garcia 2008-06-05 21:46:04 -0700 (In reply to comment #3) > (From update of attachment 21519 [edit]) > Looks good. The if (string.isEmpty()) should have a comment before it > explaning "why", since I'm not sure it will be clear to either of us why it's > there in 9 months. :) You're right. Fixed that. http://trac.webkit.org/changeset/34399 21516 2008-06-05 17:30:27 -0700 2008-06-05 17:30:27 -0700 test case test.html text/html 239 justin.garcia PEJPRFk+PFNDUklQVD4KZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ3NlbGVjdGFsbCcpOwpkb2N1bWVu dC5kZXNpZ25Nb2RlID0gJ29uJzsKZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ2luc2VydGltYWdlJywg ZmFsc2UsICc8c2NyaXB0IHNyYz1odHRwczovL3dlYmtpdC5vcmc+Jyk7CmRvY3VtZW50LmV4ZWND b21tYW5kKCdzZWxlY3RhbGwnKTsKZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ3JlbW92ZWZvcm1hdCcp Owo8L1NDUklQVD4= 21519 2008-06-05 20:56:04 -0700 2008-06-05 21:32:18 -0700 patch 19403.txt text/plain 2770 justin.garcia SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNDM5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMDYtMDUgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lh QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NDAzPgorICAg ICAgICBBU1NFUlQgaW4gSW5zZXJ0SW50b1RleHROb2RlQ29tbWFuZDo6SW5zZXJ0SW50b1RleHRO b2RlQ29tbWFuZCBkdXJpbmcgUmVtb3ZlRm9ybWF0IGNhbGwKKworICAgICAgICAqIGVkaXRpbmcv UmVtb3ZlRm9ybWF0Q29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW1vdmVGb3JtYXRD b21tYW5kOjpkb0FwcGx5KTogSWYgdGhlIHNlbGVjdGlvbiB3YXMgYWxsCisgICAgICAgIGZvcm1h dHRpbmcgKGxpa2UgYW4gZW1wdHkgbGlzdCkgdGhlIGZvcm1hdC1sZXNzIHRleHQgd2lsbCBiZSBl bXB0eS4KKyAgICAgICAgRWFybHkgcmV0dXJuIHRvIGF2b2lkIHRoZSBBU1NFUlQgdGhhdCBmaXJl cyBpZiBpbnB1dCguLi4pIGlzIGNhbGxlZAorICAgICAgICB3aXRoIGFuIGVtcHR5IFN0cmluZy4K KwogMjAwOC0wNi0wNSAgQWxwIFRva2VyICA8YWxwQG51YW50aS5jb20+CiAKICAgICAgICAgQnVp bGQgZml4IGZvciByMzQzODcuCkluZGV4OiBXZWJDb3JlL2VkaXRpbmcvUmVtb3ZlRm9ybWF0Q29t bWFuZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9lZGl0aW5nL1JlbW92ZUZvcm1hdENvbW1h bmQuY3BwCShyZXZpc2lvbiAzNDM4OSkKKysrIFdlYkNvcmUvZWRpdGluZy9SZW1vdmVGb3JtYXRD b21tYW5kLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjUsNiArNjUsOSBAQAogICAgIC8vIERlbGV0 ZSBkb2Vzbid0IHJlbW92ZSBmdWxseSBzZWxlY3RlZCBsaXN0cy4KICAgICB3aGlsZSAoYnJlYWtP dXRPZkVtcHR5TGlzdEl0ZW0oKSkKICAgICAgICAgOworICAgICAgICAKKyAgICBpZiAoc3RyaW5n LmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuOwogICAgIAogICAgIC8vIE5vcm1hbGx5LCBkZWxl dGluZyBhIGZ1bGx5IHNlbGVjdGVkIGFuY2hvciBhbmQgdGhlbiBpbnNlcnRpbmcgdGV4dCB3aWxs IHJlLWNyZWF0ZQogICAgIC8vIHRoZSByZW1vdmVkIGFuY2hvciwgYnV0IHdlIGRvbid0IHdhbnQg dGhhdCBiZWhhdmlvciBoZXJlLiAKSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1h bmQvMTk0MDMuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21t YW5kLzE5NDAzLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWND b21tYW5kLzE5NDAzLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzxkaXYgaWQ9 ImRlc2NyaXB0aW9uIj5UaGlzIHRlc3RzIGZvciBhbiBBU1NFUlQgZHVyaW5nIGEgUmVtb3ZlRm9y bWF0IGNhbGwgd2hlbiBpdCdzIGNhbGxlZCBvbiBhIHNlbGVjdGlvbiBjb250YWluaW5nIG9ubHkg YSBob3Jpem9udGFsIHJ1bGUuICBJdCBzaG91bGQgbm90IEFTU0VSVC4gIEJ1ZzogSXQgc2hvdWxk IGFsc28gbm90IHJlbW92ZSB0aGUgaG9yaXpvbnRhbCBydWxlLjwvZGl2PgorPGRpdiBpZD0iZWRp dCIgY29udGVudEVkaXRhYmxlPSJ0cnVlIj48aHI+PC9kaXY+CisKKzxzY3JpcHQ+CitpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wQXNUZXh0KCk7CitlZGl0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImVkaXQiKTsK K2VkaXQuZm9jdXMoKTsKK2RvY3VtZW50LmV4ZWNDb21tYW5kKCJTZWxlY3RBbGwiKTsKK2RvY3Vt ZW50LmV4ZWNDb21tYW5kKCJSZW1vdmVGb3JtYXQiKTsKK2lmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpCisgICAgZG9jdW1lbnQuYm9keS5pbm5lclRleHQgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgiZGVzY3JpcHRpb24iKS5pbm5lclRleHQgKyAiXG4iICsgZWRpdC5pbm5lckhUTUw7 Cis8L3NjcmlwdD4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvMTk0MDMt ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1h bmQvMTk0MDMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGlu Zy9leGVjQ29tbWFuZC8xOTQwMy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs MiBAQAorVGhpcyB0ZXN0cyBmb3IgYW4gQVNTRVJUIGR1cmluZyBhIFJlbW92ZUZvcm1hdCBjYWxs IHdoZW4gaXQncyBjYWxsZWQgb24gYSBzZWxlY3Rpb24gY29udGFpbmluZyBvbmx5IGEgaG9yaXpv bnRhbCBydWxlLiBJdCBzaG91bGQgbm90IEFTU0VSVC4gQnVnOiBJdCBzaG91bGQgYWxzbyBub3Qg cmVtb3ZlIHRoZSBob3Jpem9udGFsIHJ1bGUuCis8YnI+Cg==