193931 2019-01-28 15:31:20 -0800 Standardize the <meta name="color-scheme"> separator. 2019-04-19 14:20:04 -0700 1 1 1 Unclassified WebKit CSS Safari Technology Preview Unspecified Unspecified RESOLVED FIXED BrowserCompat, InRadar P2 Normal --- 197016 1 rune.lillesveen timothy cdumez commit-queue darin dbates esprehn+autocc ews-watchlist kangil.han simon.fraser timothy webkit-bug-importer oldest_to_newest 1499234 0 rune.lillesveen 2019-01-28 15:31:20 -0800 <meta name="supported-color-schemes"> accepts both spaces and commas as separators. Shouldn't we standardize on either space[1] or comma[2] separation? [1] https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#space-separated-tokens [2] https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#comma-separated-tokens 1499577 1 timothy 2019-01-29 10:13:00 -0800 This was to match parsing of <meta name="viewport">, <meta name="format-detection">, and window.open() features string, which allows comma and whitespace [1]. But I'm open to changing it to just whitespace since this is a simple list and no key-value pairs. [1] https://html.spec.whatwg.org/#concept-window-open-features-tokenize 1528308 2 webkit-bug-importer 2019-04-17 15:50:43 -0700 <rdar://problem/49995929> 1528322 3 367695 timothy 2019-04-17 16:19:42 -0700 Created attachment 367695 Patch 1528341 4 367695 commit-queue 2019-04-17 16:55:53 -0700 Comment on attachment 367695 Patch Clearing flags on attachment: 367695 Committed r244413: <https://trac.webkit.org/changeset/244413> 1528342 5 commit-queue 2019-04-17 16:55:54 -0700 All reviewed patches have been landed. Closing bug. 1528462 6 367695 darin 2019-04-18 09:17:24 -0700 Comment on attachment 367695 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367695&action=review > Source/WebCore/dom/Document.cpp:3619 > +static inline bool isColorSchemeSeparator(UChar character) A few super-small thoughts: 1) Pretty sure this should be isHTMLSpace instead of isASCIISpace. The difference is in the handling of U+000B, which returns true from isASCIISpace, but false from isHTMLSpace. I don’t think the tests cover this but they should. 2) We’ve learned that with today’s C++ compilers there is no need to put the inline keyword on a function like this one. The compiler will inline it without a keyword. Roughly speaking, we only need to use "inline" when we want to include the function in multiple translation units (functions in headers), but the function is not a template and is not using "constexpr". 3) This function could be constexpr. 4) We don’t need a named function; the extra documentation that "these are the valid color scheme separators" was valuable when the rule was at all unclear, but now that it’s literally isHTMLSpace, I don’t think it’s helpful to have a named function. 1528833 7 timothy 2019-04-19 13:15:53 -0700 Reopening to attach new patch. 1528834 8 367817 timothy 2019-04-19 13:15:54 -0700 Created attachment 367817 Followup Patch 1528835 9 367695 timothy 2019-04-19 13:16:37 -0700 Comment on attachment 367695 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367695&action=review >> Source/WebCore/dom/Document.cpp:3619 >> +static inline bool isColorSchemeSeparator(UChar character) > > A few super-small thoughts: > > 1) Pretty sure this should be isHTMLSpace instead of isASCIISpace. The difference is in the handling of U+000B, which returns true from isASCIISpace, but false from isHTMLSpace. I don’t think the tests cover this but they should. > > 2) We’ve learned that with today’s C++ compilers there is no need to put the inline keyword on a function like this one. The compiler will inline it without a keyword. Roughly speaking, we only need to use "inline" when we want to include the function in multiple translation units (functions in headers), but the function is not a template and is not using "constexpr". > > 3) This function could be constexpr. > > 4) We don’t need a named function; the extra documentation that "these are the valid color scheme separators" was valuable when the rule was at all unclear, but now that it’s literally isHTMLSpace, I don’t think it’s helpful to have a named function. Good points. I attached a followup patch to address these. 1528866 10 367817 commit-queue 2019-04-19 14:20:02 -0700 Comment on attachment 367817 Followup Patch Clearing flags on attachment: 367817 Committed r244467: <https://trac.webkit.org/changeset/244467> 1528867 11 commit-queue 2019-04-19 14:20:04 -0700 All reviewed patches have been landed. Closing bug. 367695 2019-04-17 16:19:42 -0700 2019-04-19 13:16:01 -0700 Patch bug-193931-20190417161942.patch text/plain 7764 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzQ4OWJkYzcxNjRiM2Qz NzY2ZWI1ZDhjMDhlOTNhYTI2NDc5ZjcyYS4uYmJkZDNjYmU0ZDY1NzBlOWExMGJhYjY0YzAyZGMz NTFiNTg2MmY3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA0LTE3ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBTdGFuZGFyZGl6ZSB0 aGUgYDxtZXRhIG5hbWU9ImNvbG9yLXNjaGVtZSI+YCBzZXBhcmF0b3IuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM5MzEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcm9wIHN1cHBvcnQgZm9yIGNvbW1h IGFzIGEgdmFsaWQgc2VwZXJhdG9yIGluIDxtZXRhIG5hbWU9ImNvbG9yLXNjaGVtZSI+IHRvCisg ICAgICAgIG1hdGNoIHRoZSBwcm9wb3NhbCBiZWluZyB0cmFja2VkIGJ5OiBodHRwczovL2dpdGh1 Yi5jb20vd2hhdHdnL2h0bWwvaXNzdWVzLzQ1MDQKKworICAgICAgICBUZXN0czogY3NzLWRhcmst bW9kZS9jb2xvci1zY2hlbWUtbWV0YS5odG1sCisgICAgICAgICAgICAgICBjc3MtZGFyay1tb2Rl L29sZGVyLXN5bnRheC9zdXBwb3J0ZWQtY29sb3Itc2NoZW1lcy1tZXRhLmh0bWwKKworICAgICAg ICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc0NvbG9yU2NoZW1lU2Vw YXJhdG9yKTogRHJvcCBzdXBwb3J0IGZvciBjb21tYS4KKwogMjAxOS0wNC0xNyAgVGltb3RoeSBI YXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIGBzdXBwb3J0ZWQt Y29sb3Itc2NoZW1lc2AgdG8gYGNvbG9yLXNjaGVtZWAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApp bmRleCBjZGZkYWEyODI1NDU0ZDY2MDM1NzY0Y2ZiMmJmYTVkMDIxZDc1OTdmLi40YzMxYmJkMThk YjhlNThmZjA1NzcwNDNjMjlhMjMzNWZlZTU4MWZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAK QEAgLTM2MTYsOSArMzYxNiw5IEBAIHZvaWQgRG9jdW1lbnQ6OnVwZGF0ZVZpZXdwb3J0QXJndW1l bnRzKCkKIH0KIAogI2lmIEVOQUJMRShEQVJLX01PREVfQ1NTKQotc3RhdGljIGJvb2wgaXNDb2xv clNjaGVtZVNlcGFyYXRvcihVQ2hhciBjaGFyYWN0ZXIpCitzdGF0aWMgaW5saW5lIGJvb2wgaXND b2xvclNjaGVtZVNlcGFyYXRvcihVQ2hhciBjaGFyYWN0ZXIpCiB7Ci0gICAgcmV0dXJuIGlzQVND SUlTcGFjZShjaGFyYWN0ZXIpIHx8IGNoYXJhY3RlciA9PSAnLCc7CisgICAgcmV0dXJuIGlzQVND SUlTcGFjZShjaGFyYWN0ZXIpOwogfQogCiBzdGF0aWMgdm9pZCBwcm9jZXNzQ29sb3JTY2hlbWVT dHJpbmcoU3RyaW5nVmlldyBjb2xvclNjaGVtZSwgY29uc3QgV1RGOjpGdW5jdGlvbjx2b2lkKFN0 cmluZ1ZpZXcga2V5KT4mIGNhbGxiYWNrKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGY5N2M1NGZhMjcxNDEzNjc4NWUzZTdh OGI0MTk2ZWUyOTRhNWRhMTAuLjRlZWE5ZDRiMmY2MGQ0Mzk2YjQzYjBjOGM3NzE5OGQzMTY4ZWJj MmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wNC0xNyAgVGltb3RoeSBIYXRjaGVyICA8 dGltb3RoeUBhcHBsZS5jb20+CisKKyAgICAgICAgU3RhbmRhcmRpemUgdGhlIGA8bWV0YSBuYW1l PSJjb2xvci1zY2hlbWUiPmAgc2VwYXJhdG9yLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzOTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBjc3MtZGFyay1tb2RlL2NvbG9yLXNjaGVtZS1tZXRhLWV4 cGVjdGVkLnR4dDoKKyAgICAgICAgKiBjc3MtZGFyay1tb2RlL2NvbG9yLXNjaGVtZS1tZXRhLmh0 bWw6CisgICAgICAgICogY3NzLWRhcmstbW9kZS9vbGRlci1zeW50YXgvc3VwcG9ydGVkLWNvbG9y LXNjaGVtZS1tZXRhLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBjc3MtZGFyay1tb2RlL29sZGVy LXN5bnRheC9zdXBwb3J0ZWQtY29sb3Itc2NoZW1lcy1tZXRhLmh0bWw6CisKIDIwMTktMDQtMTcg IFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBg c3VwcG9ydGVkLWNvbG9yLXNjaGVtZXNgIHRvIGBjb2xvci1zY2hlbWVgLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvY3NzLWRhcmstbW9kZS9jb2xvci1zY2hlbWUtbWV0YS1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL2NvbG9yLXNjaGVtZS1tZXRhLWV4cGVjdGVkLnR4 dAppbmRleCBhZmM5MTRkMDIwN2YzZmU5ZjA4YWY4OWM4YmIxOGM0YWQzMjlkMjRmLi4wNDkxYzgw MWFjOTU0NDcyNTY3NWYwYzczMjBlNzJmYzk2ZjVkMzZiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9jc3MtZGFyay1tb2RlL2NvbG9yLXNjaGVtZS1tZXRhLWV4cGVjdGVkLnR4dAorKysgYi9MYXlv dXRUZXN0cy9jc3MtZGFyay1tb2RlL2NvbG9yLXNjaGVtZS1tZXRhLWV4cGVjdGVkLnR4dApAQCAt MTYsOCArMTYsOCBAQCBQQVNTIENvbG9yIHNjaGVtZXMgY2hhbmdlZCB0byBsaWdodCBhbmQgYSBi b2d1cyB2YWx1ZQogUEFTUyBFbGVtZW50IGNvbG9ycyBhcmUgY29ycmVjdCBpbiBkYXJrIGNvbG9y IHNjaGVtZSB3aXRoIG9ubHkgbGlnaHQgY29sb3Igc2NoZW1lIAogUEFTUyBDb2xvciBzY2hlbWVz IGNoYW5nZWQgdG8gZW1wdHkgdmFsdWUgCiBQQVNTIEVsZW1lbnQgY29sb3JzIGFyZSBjb3JyZWN0 IGluIGRhcmsgY29sb3Igc2NoZW1lIHdpdGggaW1wbGljaXQgbGlnaHQgY29sb3Igc2NoZW1lIAot UEFTUyBDb2xvciBzY2hlbWVzIGNoYW5nZWQgdG8gbGlnaHQgYW5kIGRhcmsgCi1QQVNTIEVsZW1l bnQgY29sb3JzIGFyZSBjb3JyZWN0IGluIGRhcmsgY29sb3Igc2NoZW1lIHdpdGggbGlnaHQgYW5k IGRhcmsgY29sb3Igc2NoZW1lIAorUEFTUyBDb2xvciBzY2hlbWVzIGNoYW5nZWQgdG8gbGlnaHQs ZGFyayAKK1BBU1MgRWxlbWVudCBjb2xvcnMgYXJlIGluIGxpZ2h0IGNvbG9yIHNjaGVtZSBzaW5j ZSBjb21tYSBpcyBub3QgYW4gYWxsb3dlZCBzZXBlcmF0b3IgCiBQQVNTIENvbG9yIHNjaGVtZXMg Y2hhbmdlZCB0byBhIGJvZ3VzIHZhbHVlIGFuZCBkYXJrIAogUEFTUyBFbGVtZW50IGNvbG9ycyBh cmUgY29ycmVjdCBpbiBkYXJrIGNvbG9yIHNjaGVtZSB3aXRoIGRhcmsgY29sb3Igc2NoZW1lIAog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL2NvbG9yLXNjaGVtZS1tZXRh Lmh0bWwgYi9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL2NvbG9yLXNjaGVtZS1tZXRhLmh0bWwK aW5kZXggZjUyYjc1ZWIzNDAzNjJkZDhjOTViMmI4YWE0MjEyMjNmNjNmMzlkNi4uY2U3YWFmZThi YjY5MzJjNTkyNTRjZGJkNThkZjM0MWFjMDE0MDk0YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Y3NzLWRhcmstbW9kZS9jb2xvci1zY2hlbWUtbWV0YS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Nz cy1kYXJrLW1vZGUvY29sb3Itc2NoZW1lLW1ldGEuaHRtbApAQCAtOTIsNyArOTIsNyBAQCB0ZXN0 KGZ1bmN0aW9uKCkgewogfSwgIkVsZW1lbnQgY29sb3JzIGFyZSBjb3JyZWN0IGluIGRhcmsgY29s b3Igc2NoZW1lIHdpdGggb25seSBkYXJrIGNvbG9yIHNjaGVtZSIpOwogCiB0ZXN0KGZ1bmN0aW9u KCkgewotICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJtZXRhIikuY29udGVudCA9ICJsaWdo dCAsZm9vICI7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1ldGEiKS5jb250ZW50ID0g ImxpZ2h0ICBmb28gIjsKIH0sICJDb2xvciBzY2hlbWVzIGNoYW5nZWQgdG8gbGlnaHQgYW5kIGEg Ym9ndXMgdmFsdWUiKTsKIAogdGVzdChmdW5jdGlvbigpIHsKQEAgLTExMCwxNiArMTEwLDE2IEBA IHRlc3QoZnVuY3Rpb24oKSB7CiB9LCAiRWxlbWVudCBjb2xvcnMgYXJlIGNvcnJlY3QgaW4gZGFy ayBjb2xvciBzY2hlbWUgd2l0aCBpbXBsaWNpdCBsaWdodCBjb2xvciBzY2hlbWUiKTsKIAogdGVz dChmdW5jdGlvbigpIHsKLSAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibWV0YSIpLmNvbnRl bnQgPSAiICAgbGlnaHQsIGRhcmsgIjsKLX0sICJDb2xvciBzY2hlbWVzIGNoYW5nZWQgdG8gbGln aHQgYW5kIGRhcmsiKTsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibWV0YSIpLmNvbnRl bnQgPSAiICAgbGlnaHQsZGFyayAiOworfSwgIkNvbG9yIHNjaGVtZXMgY2hhbmdlZCB0byBsaWdo dCxkYXJrIik7CiAKIHRlc3QoZnVuY3Rpb24oKSB7Ci0gICAgLy8gVGhlIHNlbWFudGljIHRleHQg Y29sb3Igc2hvdWxkIGJlIHdoaXRlIG5vdy4KLSAgICB0ZXN0X2NvbG9yX2lzX3doaXRlKCJ0ZXN0 MSIpOwotfSwgIkVsZW1lbnQgY29sb3JzIGFyZSBjb3JyZWN0IGluIGRhcmsgY29sb3Igc2NoZW1l IHdpdGggbGlnaHQgYW5kIGRhcmsgY29sb3Igc2NoZW1lIik7CisgICAgLy8gVGhlIHNlbWFudGlj IHRleHQgY29sb3Igc2hvdWxkIGJlIGJsYWNrIG5vdy4KKyAgICB0ZXN0X2NvbG9yX2lzX2JsYWNr KCJ0ZXN0MSIpOworfSwgIkVsZW1lbnQgY29sb3JzIGFyZSBpbiBsaWdodCBjb2xvciBzY2hlbWUg c2luY2UgY29tbWEgaXMgbm90IGFuIGFsbG93ZWQgc2VwZXJhdG9yIik7CiAKIHRlc3QoZnVuY3Rp b24oKSB7Ci0gICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1ldGEiKS5jb250ZW50ID0gIiwg Zm9vIGRhcmsiOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJtZXRhIikuY29udGVudCA9 ICIgIGZvbyBkYXJrIjsKIH0sICJDb2xvciBzY2hlbWVzIGNoYW5nZWQgdG8gYSBib2d1cyB2YWx1 ZSBhbmQgZGFyayIpOwogCiB0ZXN0KGZ1bmN0aW9uKCkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvY3NzLWRhcmstbW9kZS9vbGRlci1zeW50YXgvc3VwcG9ydGVkLWNvbG9yLXNjaGVtZXMtbWV0 YS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL29sZGVyLXN5bnRheC9z dXBwb3J0ZWQtY29sb3Itc2NoZW1lcy1tZXRhLWV4cGVjdGVkLnR4dAppbmRleCAyYTZlNjNjMDJl ZDFjYWE4NGU2ZDEzODM1MjNjZmQyZmUyYjZhNDJjLi5kM2M3ZTY4YTgxNzI4YmEwMGRkNmE5OGZj NTJjODgxOTNiZDM4MmU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL29s ZGVyLXN5bnRheC9zdXBwb3J0ZWQtY29sb3Itc2NoZW1lcy1tZXRhLWV4cGVjdGVkLnR4dAorKysg Yi9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL29sZGVyLXN5bnRheC9zdXBwb3J0ZWQtY29sb3It c2NoZW1lcy1tZXRhLWV4cGVjdGVkLnR4dApAQCAtMTYsOCArMTYsOCBAQCBQQVNTIFN1cHBvcnRl ZCBjb2xvciBzY2hlbWVzIGNoYW5nZWQgdG8gbGlnaHQgYW5kIGEgYm9ndXMgdmFsdWUKIFBBU1Mg RWxlbWVudCBjb2xvcnMgYXJlIGNvcnJlY3QgaW4gZGFyayBjb2xvciBzY2hlbWUgd2l0aCBvbmx5 IGxpZ2h0IGNvbG9yIHNjaGVtZSAKIFBBU1MgU3VwcG9ydGVkIGNvbG9yIHNjaGVtZXMgY2hhbmdl ZCB0byBlbXB0eSB2YWx1ZSAKIFBBU1MgRWxlbWVudCBjb2xvcnMgYXJlIGNvcnJlY3QgaW4gZGFy ayBjb2xvciBzY2hlbWUgd2l0aCBpbXBsaWNpdCBsaWdodCBjb2xvciBzY2hlbWUgCi1QQVNTIFN1 cHBvcnRlZCBjb2xvciBzY2hlbWVzIGNoYW5nZWQgdG8gbGlnaHQgYW5kIGRhcmsgCi1QQVNTIEVs ZW1lbnQgY29sb3JzIGFyZSBjb3JyZWN0IGluIGRhcmsgY29sb3Igc2NoZW1lIHdpdGggbGlnaHQg YW5kIGRhcmsgY29sb3Igc2NoZW1lIAorUEFTUyBTdXBwb3J0ZWQgY29sb3Igc2NoZW1lcyBjaGFu Z2VkIHRvIGxpZ2h0LGRhcmsgCitQQVNTIEVsZW1lbnQgY29sb3JzIGFyZSBpbiBsaWdodCBjb2xv ciBzY2hlbWUgc2luY2UgY29tbWEgaXMgbm90IGFuIGFsbG93ZWQgc2VwZXJhdG9yIAogUEFTUyBT dXBwb3J0ZWQgY29sb3Igc2NoZW1lcyBjaGFuZ2VkIHRvIGEgYm9ndXMgdmFsdWUgYW5kIGRhcmsg CiBQQVNTIEVsZW1lbnQgY29sb3JzIGFyZSBjb3JyZWN0IGluIGRhcmsgY29sb3Igc2NoZW1lIHdp dGggZGFyayBjb2xvciBzY2hlbWUgCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Nzcy1kYXJr LW1vZGUvb2xkZXItc3ludGF4L3N1cHBvcnRlZC1jb2xvci1zY2hlbWVzLW1ldGEuaHRtbCBiL0xh eW91dFRlc3RzL2Nzcy1kYXJrLW1vZGUvb2xkZXItc3ludGF4L3N1cHBvcnRlZC1jb2xvci1zY2hl bWVzLW1ldGEuaHRtbAppbmRleCBlYTFmNTYyNTUwZmRiYzA4MTYxMDY4MDM3NTc5YTZhMGRlMjUx MDNhLi4zMjg0YWVhMjNhYTVkN2VkN2MxMjU5YTg2ZDg2ODFiYTIzMmU2YjJjIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL29sZGVyLXN5bnRheC9zdXBwb3J0ZWQtY29sb3It c2NoZW1lcy1tZXRhLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvY3NzLWRhcmstbW9kZS9vbGRlci1z eW50YXgvc3VwcG9ydGVkLWNvbG9yLXNjaGVtZXMtbWV0YS5odG1sCkBAIC0xMTAsMTYgKzExMCwx NiBAQCB0ZXN0KGZ1bmN0aW9uKCkgewogfSwgIkVsZW1lbnQgY29sb3JzIGFyZSBjb3JyZWN0IGlu IGRhcmsgY29sb3Igc2NoZW1lIHdpdGggaW1wbGljaXQgbGlnaHQgY29sb3Igc2NoZW1lIik7CiAK IHRlc3QoZnVuY3Rpb24oKSB7Ci0gICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1ldGEiKS5j b250ZW50ID0gIiAgIGxpZ2h0LCBkYXJrICI7Ci19LCAiU3VwcG9ydGVkIGNvbG9yIHNjaGVtZXMg Y2hhbmdlZCB0byBsaWdodCBhbmQgZGFyayIpOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJtZXRhIikuY29udGVudCA9ICIgICBsaWdodCxkYXJrICI7Cit9LCAiU3VwcG9ydGVkIGNvbG9y IHNjaGVtZXMgY2hhbmdlZCB0byBsaWdodCxkYXJrIik7CiAKIHRlc3QoZnVuY3Rpb24oKSB7Ci0g ICAgLy8gVGhlIHNlbWFudGljIHRleHQgY29sb3Igc2hvdWxkIGJlIHdoaXRlIG5vdy4KLSAgICB0 ZXN0X2NvbG9yX2lzX3doaXRlKCJ0ZXN0MSIpOwotfSwgIkVsZW1lbnQgY29sb3JzIGFyZSBjb3Jy ZWN0IGluIGRhcmsgY29sb3Igc2NoZW1lIHdpdGggbGlnaHQgYW5kIGRhcmsgY29sb3Igc2NoZW1l Iik7CisgICAgLy8gVGhlIHNlbWFudGljIHRleHQgY29sb3Igc2hvdWxkIGJlIGJsYWNrIG5vdy4K KyAgICB0ZXN0X2NvbG9yX2lzX2JsYWNrKCJ0ZXN0MSIpOworfSwgIkVsZW1lbnQgY29sb3JzIGFy ZSBpbiBsaWdodCBjb2xvciBzY2hlbWUgc2luY2UgY29tbWEgaXMgbm90IGFuIGFsbG93ZWQgc2Vw ZXJhdG9yIik7CiAKIHRlc3QoZnVuY3Rpb24oKSB7Ci0gICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoIm1ldGEiKS5jb250ZW50ID0gIiwgZm9vIGRhcmsiOworICAgIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJtZXRhIikuY29udGVudCA9ICIgIGZvbyBkYXJrIjsKIH0sICJTdXBwb3J0ZWQgY29s b3Igc2NoZW1lcyBjaGFuZ2VkIHRvIGEgYm9ndXMgdmFsdWUgYW5kIGRhcmsiKTsKIAogdGVzdChm dW5jdGlvbigpIHsK 367817 2019-04-19 13:15:54 -0700 2019-04-19 14:20:02 -0700 Followup Patch bug-193931-20190419131553.patch text/plain 5054 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0NDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY2ZmM3MzhlMjI2OTNh NDg3M2QzN2M4NzJhNzI0OWQxNzMwNjEyMy4uZGI2Nzc0YTViYWJjMzYzYzRlMDY2NzFlOTYwOTMx OTU1YmMxMmU1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA0LTE5ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBTdGFuZGFyZGl6ZSB0 aGUgPG1ldGEgbmFtZT0iY29sb3Itc2NoZW1lIj4gc2VwYXJhdG9yLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzOTMxCisgICAgICAgIHJkYXI6Ly9w cm9ibGVtLzQ5OTk1OTI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGVzdHM6IGNzcy1kYXJrLW1vZGUvY29sb3Itc2NoZW1lLW1ldGEuaHRtbAorCisg ICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnByb2Nlc3NDb2xv clNjaGVtZVN0cmluZyk6IFVzZSBpc0hUTUxTcGFjZSBpbnNlYWQgb2YgaXNDb2xvclNjaGVtZVNl cGFyYXRvciBhbmQgaXNBU0NJSVNwYWNlLgorICAgICAgICAoV2ViQ29yZTo6aXNDb2xvclNjaGVt ZVNlcGFyYXRvcik6IERlbGV0ZWQuCisKIDIwMTktMDQtMTkgIFdlbnNvbiBIc2llaCAgPHdlbnNv bl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gQWRkIHF1aXJrcyB0byBkaXNhYmxl IGF1dG9jb3JyZWN0aW9uIGFuZCBhdXRvY2FwaXRhbGl6YXRpb24gaW4gaGlkZGVuIGVkaXRhYmxl IGFyZWFzIG9uIHNvbWUgd2Vic2l0ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDkyMTBk NjY4NTA0ZmU4OWFlZDMwNDZlZWMxYjgzOGY0NDA1NWU5MjYuLjQ0MWE2MDIzODkyMWJjNWIzODJl MjE1ZDBhMTgzOTJiNjFkY2YxOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtMzYwMywy MiArMzYwMywxNyBAQCB2b2lkIERvY3VtZW50Ojp1cGRhdGVWaWV3cG9ydEFyZ3VtZW50cygpCiB9 CiAKICNpZiBFTkFCTEUoREFSS19NT0RFX0NTUykKLXN0YXRpYyBpbmxpbmUgYm9vbCBpc0NvbG9y U2NoZW1lU2VwYXJhdG9yKFVDaGFyIGNoYXJhY3RlcikKLXsKLSAgICByZXR1cm4gaXNBU0NJSVNw YWNlKGNoYXJhY3Rlcik7Ci19Ci0KIHN0YXRpYyB2b2lkIHByb2Nlc3NDb2xvclNjaGVtZVN0cmlu ZyhTdHJpbmdWaWV3IGNvbG9yU2NoZW1lLCBjb25zdCBXVEY6OkZ1bmN0aW9uPHZvaWQoU3RyaW5n VmlldyBrZXkpPiYgY2FsbGJhY2spCiB7CiAgICAgdW5zaWduZWQgbGVuZ3RoID0gY29sb3JTY2hl bWUubGVuZ3RoKCk7CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGxlbmd0aDsgKSB7CiAg ICAgICAgIC8vIFNraXAgdG8gZmlyc3Qgbm9uLXNlcGFyYXRvci4KLSAgICAgICAgd2hpbGUgKGkg PCBsZW5ndGggJiYgaXNDb2xvclNjaGVtZVNlcGFyYXRvcihjb2xvclNjaGVtZVtpXSkpCisgICAg ICAgIHdoaWxlIChpIDwgbGVuZ3RoICYmIGlzSFRNTFNwYWNlKGNvbG9yU2NoZW1lW2ldKSkKICAg ICAgICAgICAgICsraTsKICAgICAgICAgdW5zaWduZWQga2V5QmVnaW4gPSBpOwogCiAgICAgICAg IC8vIFNraXAgdG8gZmlyc3Qgc2VwYXJhdG9yLgotICAgICAgICB3aGlsZSAoaSA8IGxlbmd0aCAm JiAhaXNDb2xvclNjaGVtZVNlcGFyYXRvcihjb2xvclNjaGVtZVtpXSkpCisgICAgICAgIHdoaWxl IChpIDwgbGVuZ3RoICYmICFpc0hUTUxTcGFjZShjb2xvclNjaGVtZVtpXSkpCiAgICAgICAgICAg ICArK2k7CiAgICAgICAgIHVuc2lnbmVkIGtleUVuZCA9IGk7CiAKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4ZWIwMWEyMDJh N2JmNzZkNjBjMTA3OGQwNTFlMWNkNDY0MzU3MzgwLi4zNGJiMGEzNTkxZTY0ODcxYTkyZjBhYzkz NzkyMTg2YTY3NWI1MDhjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDQtMTkgIFRpbW90 aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFN0YW5kYXJkaXplIHRo ZSBgPG1ldGEgbmFtZT0iY29sb3Itc2NoZW1lIj5gIHNlcGFyYXRvci4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzkzMQorICAgICAgICByZGFyOi8v cHJvYmxlbS80OTk5NTkyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogY3NzLWRhcmstbW9kZS9jb2xvci1zY2hlbWUtbWV0YS1leHBlY3RlZC50eHQ6 CisgICAgICAgICogY3NzLWRhcmstbW9kZS9jb2xvci1zY2hlbWUtbWV0YS5odG1sOiBUZXN0IG90 aGVyIHR5cGVzIG9mIHNwYWNlcyBsaWtlIHRhYiwgbmV3bGluZSBhbmQgdmVydGljYWwgdGFiLgor CiAyMDE5LTA0LTE4ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAK ICAgICAgICAgVXBkYXRlIGF1dG9zY3JvbGwgdGVzdCB0byBsaWZ0IGF0IHRoZSBlbmQgYW5kIGJl IGxlc3MgZmxha2V5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jc3MtZGFyay1tb2RlL2NvbG9y LXNjaGVtZS1tZXRhLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Nzcy1kYXJrLW1vZGUvY29s b3Itc2NoZW1lLW1ldGEtZXhwZWN0ZWQudHh0CmluZGV4IDA0OTFjODAxYWM5NTQ0NzI1Njc1ZjBj NzMyMGU3MmZjOTZmNWQzNmIuLjUzMzNmMzNmNjFiY2ZkYmQzZjVkOTY3OGNkZTUxMmUwYjkwNTc3 NmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Nzcy1kYXJrLW1vZGUvY29sb3Itc2NoZW1lLW1l dGEtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Nzcy1kYXJrLW1vZGUvY29sb3Itc2No ZW1lLW1ldGEtZXhwZWN0ZWQudHh0CkBAIC0xOCw2ICsxOCw4IEBAIFBBU1MgQ29sb3Igc2NoZW1l cyBjaGFuZ2VkIHRvIGVtcHR5IHZhbHVlCiBQQVNTIEVsZW1lbnQgY29sb3JzIGFyZSBjb3JyZWN0 IGluIGRhcmsgY29sb3Igc2NoZW1lIHdpdGggaW1wbGljaXQgbGlnaHQgY29sb3Igc2NoZW1lIAog UEFTUyBDb2xvciBzY2hlbWVzIGNoYW5nZWQgdG8gbGlnaHQsZGFyayAKIFBBU1MgRWxlbWVudCBj b2xvcnMgYXJlIGluIGxpZ2h0IGNvbG9yIHNjaGVtZSBzaW5jZSBjb21tYSBpcyBub3QgYW4gYWxs b3dlZCBzZXBlcmF0b3IgCitQQVNTIENvbG9yIHNjaGVtZXMgY2hhbmdlZCB0byBmb29cdmRhcmsg CitQQVNTIEVsZW1lbnQgY29sb3JzIGFyZSBpbiBsaWdodCBjb2xvciBzY2hlbWUgc2luY2UgdmVy dGljYWwgdGFiIGlzIG5vdCBhbiBhbGxvd2VkIHNlcGVyYXRvciAKIFBBU1MgQ29sb3Igc2NoZW1l cyBjaGFuZ2VkIHRvIGEgYm9ndXMgdmFsdWUgYW5kIGRhcmsgCiBQQVNTIEVsZW1lbnQgY29sb3Jz IGFyZSBjb3JyZWN0IGluIGRhcmsgY29sb3Igc2NoZW1lIHdpdGggZGFyayBjb2xvciBzY2hlbWUg CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Nzcy1kYXJrLW1vZGUvY29sb3Itc2NoZW1lLW1l dGEuaHRtbCBiL0xheW91dFRlc3RzL2Nzcy1kYXJrLW1vZGUvY29sb3Itc2NoZW1lLW1ldGEuaHRt bAppbmRleCBjZTdhYWZlOGJiNjkzMmM1OTI1NGNkYmQ1OGRmMzQxYWMwMTQwOTRiLi44ODdkYzRh ZDM2ODgwYWQwNTZkNTY2Y2Q0N2Y1Njk1YzdkMDJmMDY5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9jc3MtZGFyay1tb2RlL2NvbG9yLXNjaGVtZS1tZXRhLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv Y3NzLWRhcmstbW9kZS9jb2xvci1zY2hlbWUtbWV0YS5odG1sCkBAIC05Miw3ICs5Miw3IEBAIHRl c3QoZnVuY3Rpb24oKSB7CiB9LCAiRWxlbWVudCBjb2xvcnMgYXJlIGNvcnJlY3QgaW4gZGFyayBj b2xvciBzY2hlbWUgd2l0aCBvbmx5IGRhcmsgY29sb3Igc2NoZW1lIik7CiAKIHRlc3QoZnVuY3Rp b24oKSB7Ci0gICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1ldGEiKS5jb250ZW50ID0gImxp Z2h0ICBmb28gIjsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibWV0YSIpLmNvbnRlbnQg PSAiXHRsaWdodCAgZm9vICI7CiB9LCAiQ29sb3Igc2NoZW1lcyBjaGFuZ2VkIHRvIGxpZ2h0IGFu ZCBhIGJvZ3VzIHZhbHVlIik7CiAKIHRlc3QoZnVuY3Rpb24oKSB7CkBAIC0xMTksNyArMTE5LDE2 IEBAIHRlc3QoZnVuY3Rpb24oKSB7CiB9LCAiRWxlbWVudCBjb2xvcnMgYXJlIGluIGxpZ2h0IGNv bG9yIHNjaGVtZSBzaW5jZSBjb21tYSBpcyBub3QgYW4gYWxsb3dlZCBzZXBlcmF0b3IiKTsKIAog dGVzdChmdW5jdGlvbigpIHsKLSAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibWV0YSIpLmNv bnRlbnQgPSAiICBmb28gZGFyayI7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1ldGEi KS5jb250ZW50ID0gImZvb1x2ZGFyayAiOworfSwgIkNvbG9yIHNjaGVtZXMgY2hhbmdlZCB0byBm b29cXHZkYXJrIik7CisKK3Rlc3QoZnVuY3Rpb24oKSB7CisgICAgLy8gVGhlIHNlbWFudGljIHRl eHQgY29sb3Igc2hvdWxkIGJlIGJsYWNrIHN0aWxsLgorICAgIHRlc3RfY29sb3JfaXNfYmxhY2so InRlc3QxIik7Cit9LCAiRWxlbWVudCBjb2xvcnMgYXJlIGluIGxpZ2h0IGNvbG9yIHNjaGVtZSBz aW5jZSB2ZXJ0aWNhbCB0YWIgaXMgbm90IGFuIGFsbG93ZWQgc2VwZXJhdG9yIik7CisKK3Rlc3Qo ZnVuY3Rpb24oKSB7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1ldGEiKS5jb250ZW50 ID0gIiAgZm9vXG5kYXJrIjsKIH0sICJDb2xvciBzY2hlbWVzIGNoYW5nZWQgdG8gYSBib2d1cyB2 YWx1ZSBhbmQgZGFyayIpOwogCiB0ZXN0KGZ1bmN0aW9uKCkgewo=