193928 2019-01-28 15:16:46 -0800 [ews-app] Make the results url generic 2019-01-29 12:54:27 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193968 https://bugs.webkit.org/show_bug.cgi?id=193973 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1499220 0 aakash_jain 2019-01-28 15:16:46 -0800 Currently ews-app url to submit results contains patch_id in it. This works for 'build' event result, but not for 'step' event results, since step events results do not contain patch_id. We should make the url to accept result generic, so that it can accept any kind of data. Data verification can be done after receiving and parsing the data. 1499224 1 360385 aakash_jain 2019-01-28 15:20:26 -0800 Created attachment 360385 Proposed patch 1499227 2 360385 lforschler 2019-01-28 15:24:10 -0800 Comment on attachment 360385 Proposed patch Do we have existing code currently using the /patch api path? lgtm, as long as this doesn't break anything in place. 1499238 3 aakash_jain 2019-01-28 15:33:19 -0800 > Do we have existing code currently using the /patch api path? lgtm, as long as this doesn't break anything in place. Nothing in production. Next patch coming soon to process the data which comes through /results/ path. 1499642 4 aakash_jain 2019-01-29 12:12:45 -0800 > Next patch coming soon to process the data which comes through /results/ path. https://bugs.webkit.org/show_bug.cgi?id=193973 has patch to handle the results data. https://bugs.webkit.org/show_bug.cgi?id=193968 has patch which starts sending data to this results url. 1499661 5 360385 commit-queue 2019-01-29 12:53:23 -0800 Comment on attachment 360385 Proposed patch Clearing flags on attachment: 360385 Committed r240673: <https://trac.webkit.org/changeset/240673> 1499662 6 commit-queue 2019-01-29 12:53:25 -0800 All reviewed patches have been landed. Closing bug. 1499663 7 webkit-bug-importer 2019-01-29 12:54:27 -0800 <rdar://problem/47642499> 360385 2019-01-28 15:20:26 -0800 2019-01-29 12:53:23 -0800 Proposed patch ews-app-results-url.patch text/plain 1290 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MDYwNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTAxLTI4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gTWFrZSB0aGUgcmVzdWx0cyB1cmwgZ2VuZXJpYworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzOTI4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZl U3VwcG9ydC9ld3MtYXBwL2V3cy91cmxzLnB5OgorCiAyMDE5LTAxLTI4ICBBYWthc2ggSmFpbiAg PGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzLWFwcF0gQWRkIG1ldGhvZCB0 byBzYXZlIFN0ZXAgZGF0YSB0byBkYXRhYmFzZQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWFwcC9ld3MvdXJscy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYXBwL2V3cy91cmxzLnB5CShyZXZpc2lvbiAyNDA2MDYpCisrKyBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy91cmxzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMyw4 ICszMyw4IEBAIHVybHBhdHRlcm5zID0gWwogICAgIHVybChyJ14kJywgSW5kZXguYXNfdmlldygp LCBuYW1lPSdpbmRleCcpLAogICAgICMgZXg6IC9wYXRjaC81CiAgICAgdXJsKHInXnBhdGNoLyg/ UDxwYXRjaF9pZD5bMC05XSspLyQnLCBQYXRjaC5hc192aWV3KCksIG5hbWU9J3BhdGNoJyksCi0g ICAgIyBleDogL3BhdGNoLzUvcmVzdWx0cwotICAgIHVybChyJ15wYXRjaC8oP1A8cGF0Y2hfaWQ+ WzAtOV0rKS9yZXN1bHRzJCcsIFJlc3VsdHMuYXNfdmlldygpLCBuYW1lPSdyZXN1bHRzJyksCisg ICAgIyBleDogL3Jlc3VsdHMvCisgICAgdXJsKHInXnJlc3VsdHMvJCcsIFJlc3VsdHMuYXNfdmll dygpLCBuYW1lPSdyZXN1bHRzJyksCiAgICAgIyBleDogL3N0YXR1cy1idWJibGUvNQogICAgIHVy bChyJ15zdGF0dXMtYnViYmxlLyg/UDxwYXRjaF9pZD5bMC05XSspLyQnLCBTdGF0dXNCdWJibGUu YXNfdmlldygpLCBuYW1lPSdzdGF0dXNidWJibGUnKSwKIF0K