193890 2019-01-27 19:44:38 -0800 [ews-app] Add method to save Step data to database 2019-01-29 13:02:38 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193735 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1498922 0 aakash_jain 2019-01-27 19:44:38 -0800 We should add method to save Step data to database for ews-app. 1498985 1 360333 aakash_jain 2019-01-28 04:47:45 -0800 Created attachment 360333 Proposed patch Tested on a local instance. 1499104 2 aakash_jain 2019-01-28 11:28:35 -0800 This patch should apply to ToT after https://bugs.webkit.org/show_bug.cgi?id=193883 1499108 3 360333 lforschler 2019-01-28 11:31:38 -0800 Comment on attachment 360333 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=360333&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/step.py:55 > + # If the stepd data is already present in database, update it, e.g.: step complete event. possible typo: stepd? 1499669 4 aakash_jain 2019-01-29 13:01:29 -0800 Committed r240605: <https://trac.webkit.org/changeset/240605> 1499670 5 webkit-bug-importer 2019-01-29 13:02:38 -0800 <rdar://problem/47642762> 360333 2019-01-28 04:47:45 -0800 2019-01-28 11:31:38 -0800 Proposed patch 0004-ews-app-Add-method-to-save-Step-data-to-database.patch text/plain 4293 aakash_jain RnJvbSAwMGMwZTFhYmEwMjE3YzRmM2NjNGY2ODVmNzA3NzAwYmRhMTdjOTZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYWthc2ggSmFpbiA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgpE YXRlOiBNb24sIDI4IEphbiAyMDE5IDA3OjM4OjQ3IC0wNTAwClN1YmplY3Q6IFtQQVRDSCA0LzRd IFtld3MtYXBwXSBBZGQgbWV0aG9kIHRvIHNhdmUgU3RlcCBkYXRhIHRvIGRhdGFiYXNlCiBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzODkwCgpSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KCiogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0 ZXAucHk6CihTdGVwLnNhdmVfc3RlcCk6IE1ldGhvZCB0byBzYXZlIHN0ZXAgZGF0YS4KKFN0ZXAu dXBkYXRlX3N0ZXApOiBNZXRob2QgdG8gdXBkYXRlIHN0ZXAgZGF0YS4KKFN0ZXAuZ2V0X2V4aXN0 aW5nX3N0ZXApOiBNZXRob2QgdG8gZmV0Y2ggZXhpc3Rpbmcgc3RlcCBmcm9tIGRhdGFiYXNlLgoo U3RlcC5pc192YWxpZF9yZXN1bHQpOiBNZXRob2QgdG8gdmFsaWRhdGUgdmFsaWQgc3RlcCByZXN1 bHQuCi0tLQogLi4uL2V3cy1hcHAvZXdzL21vZGVscy9zdGVwLnB5ICAgICAgICAgICAgICAgIHwg NTEgKysrKysrKysrKysrKysrKysrKwogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgMTMgKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgNjQgaW5zZXJ0aW9ucygr KQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVs cy9zdGVwLnB5IGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0 ZXAucHkKaW5kZXggMzdhMzhiOTQ2NTkuLmU1ZDZiYjM0NDExIDEwMDY0NAotLS0gYS9Ub29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvc3RlcC5weQorKysgYi9Ub29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvc3RlcC5weQpAQCAtMjIsOCArMjIs MTQgQEAKIAogZnJvbSBfX2Z1dHVyZV9fIGltcG9ydCB1bmljb2RlX2xpdGVyYWxzCiAKK2ltcG9y dCBsb2dnaW5nCisKIGZyb20gZGphbmdvLmRiIGltcG9ydCBtb2RlbHMKK2Zyb20gZXdzLmNvbmZp ZyBpbXBvcnQgRVJSX1VORVhQRUNURUQsIFNVQ0NFU1MKIGZyb20gZXdzLm1vZGVscy5idWlsZCBp bXBvcnQgQnVpbGQKK2ltcG9ydCBld3MuY29tbW9uLnV0aWwgYXMgdXRpbAorCitfbG9nID0gbG9n Z2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiAKIAogY2xhc3MgU3RlcChtb2RlbHMuTW9kZWwpOgpA QCAtMzgsMyArNDQsNDggQEAgY2xhc3MgU3RlcChtb2RlbHMuTW9kZWwpOgogCiAgICAgZGVmIF9f c3RyX18oc2VsZik6CiAgICAgICAgIHJldHVybiBzdHIoc2VsZi5zdGVwX2lkKQorCisgICAgQGNs YXNzbWV0aG9kCisgICAgZGVmIHNhdmVfc3RlcChjbHMsIHN0ZXBfaWQsIGJ1aWxkX2lkLCByZXN1 bHQsIHN0YXRlX3N0cmluZywgc3RhcnRlZF9hdCwgY29tcGxldGVfYXQ9Tm9uZSk6CisgICAgICAg IGlmIG5vdCBTdGVwLmlzX3ZhbGlkX3Jlc3VsdChzdGVwX2lkLCBidWlsZF9pZCwgcmVzdWx0LCBz dGF0ZV9zdHJpbmcsIHN0YXJ0ZWRfYXQsIGNvbXBsZXRlX2F0KToKKyAgICAgICAgICAgIHJldHVy biBFUlJfVU5FWFBFQ1RFRAorCisgICAgICAgIHN0ZXAgPSBTdGVwLmdldF9leGlzdGluZ19zdGVw KHN0ZXBfaWQpCisgICAgICAgIGlmIHN0ZXA6CisgICAgICAgICAgICAjIElmIHRoZSBzdGVwZCBk YXRhIGlzIGFscmVhZHkgcHJlc2VudCBpbiBkYXRhYmFzZSwgdXBkYXRlIGl0LCBlLmcuOiBzdGVw IGNvbXBsZXRlIGV2ZW50LgorICAgICAgICAgICAgcmV0dXJuIFN0ZXAudXBkYXRlX3N0ZXAoc3Rl cCwgc3RlcF9pZCwgYnVpbGRfaWQsIHJlc3VsdCwgc3RhdGVfc3RyaW5nLCBzdGFydGVkX2F0LCBj b21wbGV0ZV9hdCkKKworICAgICAgICAjIFNhdmUgdGhlIG5ldyBzdGVwIGRhdGEsIGUuZy46IHN0 ZXAgc3RhcnQgZXZlbnQuCisgICAgICAgIFN0ZXAoc3RlcF9pZCwgYnVpbGRfaWQsIHJlc3VsdCwg c3RhdGVfc3RyaW5nLCBzdGFydGVkX2F0LCBjb21wbGV0ZV9hdCkuc2F2ZSgpCisgICAgICAgIF9s b2cuZGVidWcoJ1NhdmVkIHN0ZXAge30gaW4gZGF0YWJhc2UgZm9yIGJ1aWxkOiB7fScuZm9ybWF0 KHN0ZXBfaWQsIGJ1aWxkX2lkKSkKKyAgICAgICAgcmV0dXJuIFNVQ0NFU1MKKworICAgIEBjbGFz c21ldGhvZAorICAgIGRlZiB1cGRhdGVfc3RlcChjbHMsIHN0ZXAsIHN0ZXBfaWQsIGJ1aWxkX2lk LCByZXN1bHQsIHN0YXRlX3N0cmluZywgc3RhcnRlZF9hdCwgY29tcGxldGVfYXQpOgorICAgICAg ICBpZiBzdGVwLnN0ZXBfaWQgIT0gc3RlcF9pZDoKKyAgICAgICAgICAgIF9sb2cuZXJyb3IoJ3N0 ZXBfaWQge30gZG9lcyBub3QgbWF0Y2ggd2l0aCBzdGVwX2lkIHt9LiBJZ25vcmluZyBuZXcgZGF0 YS4nLmZvcm1hdChzdGVwLnN0ZXBfaWQsIHN0ZXBfaWQpKQorICAgICAgICAgICAgcmV0dXJuIEVS Ul9VTkVYUEVDVEVECisgICAgICAgIGlmIHN0ZXAuYnVpbGRfaWQgIT0gYnVpbGRfaWQ6CisgICAg ICAgICAgICBfbG9nLmVycm9yKCdidWlsZF9pZCB7fSBkb2VzIG5vdCBtYXRjaCB3aXRoIGJ1aWxk X2lkIHt9LiBJZ25vcmluZyBuZXcgZGF0YS4nLmZvcm1hdChzdGVwLmJ1aWxkX2lkLCBidWlsZF9p ZCkpCisgICAgICAgICAgICByZXR1cm4gRVJSX1VORVhQRUNURUQKKyAgICAgICAgc3RlcC5yZXN1 bHQgPSByZXN1bHQKKyAgICAgICAgc3RlcC5zdGF0ZV9zdHJpbmcgPSBzdGF0ZV9zdHJpbmcKKyAg ICAgICAgc3RlcC5zdGFydGVkX2F0ID0gc3RhcnRlZF9hdAorICAgICAgICBzdGVwLmNvbXBsZXRl X2F0ID0gY29tcGxldGVfYXQKKyAgICAgICAgc3RlcC5zYXZlKHVwZGF0ZV9maWVsZHM9WydyZXN1 bHQnLCAnc3RhdGVfc3RyaW5nJywgJ3N0YXJ0ZWRfYXQnLCAnY29tcGxldGVfYXQnXSkKKyAgICAg ICAgX2xvZy5pbmZvKCdVcGRhdGVkIHN0ZXAge30gaW4gZGF0YWJhc2UgZm9yIGJ1aWxkOiB7fScu Zm9ybWF0KHN0ZXBfaWQsIGJ1aWxkX2lkKSkKKyAgICAgICAgcmV0dXJuIFNVQ0NFU1MKKworICAg IEBjbGFzc21ldGhvZAorICAgIGRlZiBnZXRfZXhpc3Rpbmdfc3RlcChjbHMsIHN0ZXBfaWQpOgor ICAgICAgICB0cnk6CisgICAgICAgICAgICByZXR1cm4gU3RlcC5vYmplY3RzLmdldChzdGVwX2lk PXN0ZXBfaWQpCisgICAgICAgIGV4Y2VwdDoKKyAgICAgICAgICAgIHJldHVybiBOb25lCisKKyAg ICBAY2xhc3NtZXRob2QKKyAgICBkZWYgaXNfdmFsaWRfcmVzdWx0KGNscywgc3RlcF9pZCwgYnVp bGRfaWQsIHJlc3VsdCwgc3RhdGVfc3RyaW5nLCBzdGFydGVkX2F0LCBjb21wbGV0ZV9hdCk6Cisg ICAgICAgIGlmIG5vdCAodXRpbC5pc192YWxpZF9pZChzdGVwX2lkKSBhbmQgdXRpbC5pc192YWxp ZF9pZChidWlsZF9pZCkpOgorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisKKyAgICAgICAgcmV0 dXJuIFRydWUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwpp bmRleCBlMDVjMGI2NjJhMS4uNjE2MTllZmU0MzQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxOS0wMS0yOCAgQWFr YXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CisKKyAgICAgICAgW2V3cy1hcHBdIEFk ZCBtZXRob2QgdG8gc2F2ZSBTdGVwIGRhdGEgdG8gZGF0YWJhc2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Mzg5MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFw cC9ld3MvbW9kZWxzL3N0ZXAucHk6CisgICAgICAgIChTdGVwLnNhdmVfc3RlcCk6IE1ldGhvZCB0 byBzYXZlIHN0ZXAgZGF0YS4KKyAgICAgICAgKFN0ZXAudXBkYXRlX3N0ZXApOiBNZXRob2QgdG8g dXBkYXRlIHN0ZXAgZGF0YS4KKyAgICAgICAgKFN0ZXAuZ2V0X2V4aXN0aW5nX3N0ZXApOiBNZXRo b2QgdG8gZmV0Y2ggZXhpc3Rpbmcgc3RlcCBmcm9tIGRhdGFiYXNlLgorICAgICAgICAoU3RlcC5p c192YWxpZF9yZXN1bHQpOiBNZXRob2QgdG8gdmFsaWRhdGUgdmFsaWQgc3RlcCByZXN1bHQuCisK IDIwMTktMDEtMjggIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFtld3MtYXBwXSBBbGxvdyBjZXJ0YWluIGZpZWxkcyB0byBiZSBlbXB0eQotLSAKMi4xNy4y IChBcHBsZSBHaXQtMTEzKQoK