193872 2019-01-26 12:20:54 -0800 [LFC][BFC] Remove redundant vertical positioning in BlockFormattingContext::computeFloatingPosition 2019-01-28 07:44:27 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1498744 0 zalan 2019-01-26 12:20:54 -0800 This is already taken care of at BlockFormattingContext::computeHeightAndMargin. 1498745 1 360245 zalan 2019-01-26 12:23:36 -0800 Created attachment 360245 Patch 1499022 2 360245 commit-queue 2019-01-28 07:43:06 -0800 Comment on attachment 360245 Patch Clearing flags on attachment: 360245 Committed r240582: <https://trac.webkit.org/changeset/240582> 1499023 3 commit-queue 2019-01-28 07:43:07 -0800 All reviewed patches have been landed. Closing bug. 1499024 4 webkit-bug-importer 2019-01-28 07:44:27 -0800 <rdar://problem/47596797> 360245 2019-01-26 12:23:36 -0800 2019-01-28 07:43:06 -0800 Patch bug-193872-20190126122327.patch text/plain 2600 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjgwOTk1ODRhYjhmNjlh NGJmNDU0ZTg1OTc3ZTUzMmZiNjU1NmNmYy4uMWY3NDdkMDY1OGY2NjBiNDE3YmIzOGJkZjM4ZDRk MTk3MTE2YTgwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAxLTI2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXSBSZW1vdmUg cmVkdW5kYW50IHZlcnRpY2FsIHBvc2l0aW9uaW5nIGluIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6 OmNvbXB1dGVGbG9hdGluZ1Bvc2l0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTM4NzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIGlzIHRha2VuIGNhcmUgb2YgYnkgdmVydGljYWxQb3NpdGlv bldpdGhNYXJnaW4oKSBpbiBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0Ojpjb21wdXRlSGVpZ2h0QW5k TWFyZ2luKCkuIAorCisgICAgICAgICogbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1h dHRpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6QmxvY2tGb3JtYXR0 aW5nQ29udGV4dDo6Y29tcHV0ZUZsb2F0aW5nUG9zaXRpb24gY29uc3QpOgorCiAyMDE5LTAxLTI2 ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ10gVGhlIGlu aXRpYWwgdmFsdWVzIGZvciB0b3AvYm90dG9tIGluIGNvbnRlbnRIZWlnaHRGb3JGb3JtYXR0aW5n Q29udGV4dFJvb3Qgc2hvdWxkIG5vdCBiZSAwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5j cHAKaW5kZXggMGY5YzFiNzQ2YWRlZDVkOTQ0YzNjZmQ5ZTk5MTY2OGNiNzUxNjkzMy4uYjFhOTY4 NWFmOGQzNmMzMGZjOWFiZDg0N2FlZjg0MjMyZGFlYjhiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGlu Z0NvbnRleHQuY3BwCkBAIC0yNzMsMTkgKzI3Myw5IEBAIGJvb2wgQmxvY2tGb3JtYXR0aW5nQ29u dGV4dDo6aGFzUHJlY29tcHV0ZWRNYXJnaW5CZWZvcmUoY29uc3QgQm94JiBsYXlvdXRCb3gpIGNv CiAKIHZvaWQgQmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZUZsb2F0aW5nUG9zaXRpb24o Y29uc3QgRmxvYXRpbmdDb250ZXh0JiBmbG9hdGluZ0NvbnRleHQsIGNvbnN0IEJveCYgbGF5b3V0 Qm94KSBjb25zdAogewotICAgIGF1dG8mIGxheW91dFN0YXRlID0gdGhpcy0+bGF5b3V0U3RhdGUo KTsKICAgICBBU1NFUlQobGF5b3V0Qm94LmlzRmxvYXRpbmdQb3NpdGlvbmVkKCkpOwogICAgIEFT U0VSVChoYXNQcmVjb21wdXRlZE1hcmdpbkJlZm9yZShsYXlvdXRCb3gpKTsKLQotICAgIGF1dG8m IGRpc3BsYXlCb3ggPSBsYXlvdXRTdGF0ZS5kaXNwbGF5Qm94Rm9yTGF5b3V0Qm94KGxheW91dEJv eCk7Ci0gICAgLy8gOC4zLjEgQ29sbGFwc2luZyBtYXJnaW5zCi0gICAgLy8gSW4gYmxvY2sgZm9y bWF0dGluZyBjb250ZXh0IG1hcmdpbnMgYmV0d2VlbiBhIGZsb2F0ZWQgYm94IGFuZCBhbnkgb3Ro ZXIgYm94IGRvIG5vdCBjb2xsYXBzZS4KLSAgICAvLyBBZGp1c3QgdGhlIHN0YXRpYyBwb3NpdGlv biBieSB1c2luZyB0aGUgcHJldmlvdXMgaW5mbG93IGJveCdzIG5vbi1jb2xsYXBzZWQgbWFyZ2lu LgotICAgIGlmIChhdXRvKiBwcmV2aW91c0luRmxvd0JveCA9IGxheW91dEJveC5wcmV2aW91c0lu Rmxvd1NpYmxpbmcoKSkgewotICAgICAgICBhdXRvJiBwcmV2aW91c0Rpc3BsYXlCb3ggPSBsYXlv dXRTdGF0ZS5kaXNwbGF5Qm94Rm9yTGF5b3V0Qm94KCpwcmV2aW91c0luRmxvd0JveCk7Ci0gICAg ICAgIGRpc3BsYXlCb3gubW92ZVZlcnRpY2FsbHkocHJldmlvdXNEaXNwbGF5Qm94Lm5vbkNvbGxh cHNlZE1hcmdpbkFmdGVyKCkgLSBwcmV2aW91c0Rpc3BsYXlCb3gubWFyZ2luQWZ0ZXIoKSk7Ci0g ICAgfQotICAgIGRpc3BsYXlCb3guc2V0VG9wTGVmdChmbG9hdGluZ0NvbnRleHQucG9zaXRpb25G b3JGbG9hdChsYXlvdXRCb3gpKTsKKyAgICBsYXlvdXRTdGF0ZSgpLmRpc3BsYXlCb3hGb3JMYXlv dXRCb3gobGF5b3V0Qm94KS5zZXRUb3BMZWZ0KGZsb2F0aW5nQ29udGV4dC5wb3NpdGlvbkZvckZs b2F0KGxheW91dEJveCkpOwogfQogCiB2b2lkIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1 dGVQb3NpdGlvblRvQXZvaWRGbG9hdHMoY29uc3QgRmxvYXRpbmdDb250ZXh0JiBmbG9hdGluZ0Nv bnRleHQsIGNvbnN0IEJveCYgbGF5b3V0Qm94KSBjb25zdAo=