193855 2019-01-25 16:10:28 -0800 [LFC] Box::nextInFlowOrFloatingSibling() should always return sibling floats as well. 2019-01-26 04:45:27 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1498547 0 zalan 2019-01-25 16:10:28 -0800 right now it does not. 1498556 1 360185 zalan 2019-01-25 16:24:05 -0800 Created attachment 360185 Patch 1498708 2 zalan 2019-01-26 04:44:23 -0800 Committed r240544: <https://trac.webkit.org/changeset/240544> 1498709 3 webkit-bug-importer 2019-01-26 04:45:27 -0800 <rdar://problem/47573935> 360185 2019-01-25 16:24:05 -0800 2019-01-25 23:18:50 -0800 Patch bug-193855-20190125162356.patch text/plain 3258 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzBjYjFiMjY2MDc5NDZj YWZlODNjZWM3ZWZjNTU3YzhiZWM1ZDgwZC4uZjQwMGUzYjI0ZDhhMjk4MGFhNWJkM2E1ZjA5NzM5 MTMyMDhhZDBmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTAxLTI1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gQm94OjpuZXh0SW5G bG93T3JGbG9hdGluZ1NpYmxpbmcoKSBzaG91bGQgYWx3YXlzIHJldHVybiBzaWJsaW5nIGZsb2F0 cyBhcyB3ZWxsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkzODU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVXNlIGl0ZXJhdGl2ZSBhbGdvcml0aG0gdG8gZmluZCBuZXh0L3ByZXZpb3VzIHNpYmxpbmdz LgorCisgICAgICAgICogbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0Qm94LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkxheW91dDo6Qm94OjpuZXh0SW5GbG93T3JGbG9hdGluZ1NpYmxpbmcgY29uc3Qp OgorCiAyMDE5LTAxLTI1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAg ICAgW0xGQ11bQkZDXVtNYXJnaW5Db2xsYXBzaW5nXSBBZGQgImNsZWFyIiB0byBzdGF0aWMgcG9z aXRpb24gY29tcHV0YXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5 b3V0dHJlZS9MYXlvdXRCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2xheW91dHRyZWUv TGF5b3V0Qm94LmNwcAppbmRleCA1MGY5NzdkYTdiMjlhZDM0MjAwOTY1MjYwZDRhNTBkZGNhZWQy ODk4Li42ZDA1OTAzZDQxNmFiZmZjNzUzMzgwYjEyNTgyMTVhNzQ1Y2VjMTczIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRCb3guY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEJveC5jcHAKQEAgLTIyMiw0MiAr MjIyLDM0IEBAIGJvb2wgQm94Ojppc0luaXRpYWxDb250YWluaW5nQmxvY2soKSBjb25zdAogCiBj b25zdCBCb3gqIEJveDo6bmV4dEluRmxvd1NpYmxpbmcoKSBjb25zdAogewotICAgIGlmIChhdXRv KiBuZXh0U2libGluZyA9IHRoaXMtPm5leHRTaWJsaW5nKCkpIHsKLSAgICAgICAgaWYgKG5leHRT aWJsaW5nLT5pc0luRmxvdygpKQotICAgICAgICAgICAgcmV0dXJuIG5leHRTaWJsaW5nOwotICAg ICAgICByZXR1cm4gbmV4dFNpYmxpbmctPm5leHRJbkZsb3dTaWJsaW5nKCk7Ci0gICAgfQotICAg IHJldHVybiBudWxscHRyOworICAgIGF1dG8qIG5leHRTaWJsaW5nID0gdGhpcy0+bmV4dFNpYmxp bmcoKTsKKyAgICB3aGlsZSAobmV4dFNpYmxpbmcgJiYgIW5leHRTaWJsaW5nLT5pc0luRmxvdygp KQorICAgICAgICBuZXh0U2libGluZyA9IG5leHRTaWJsaW5nLT5uZXh0U2libGluZygpOworICAg IHJldHVybiBuZXh0U2libGluZzsKIH0KIAogY29uc3QgQm94KiBCb3g6Om5leHRJbkZsb3dPckZs b2F0aW5nU2libGluZygpIGNvbnN0CiB7Ci0gICAgaWYgKGF1dG8qIG5leHRTaWJsaW5nID0gdGhp cy0+bmV4dFNpYmxpbmcoKSkgewotICAgICAgICBpZiAobmV4dFNpYmxpbmctPmlzSW5GbG93KCkg fHwgbmV4dFNpYmxpbmctPmlzRmxvYXRpbmdQb3NpdGlvbmVkKCkpCi0gICAgICAgICAgICByZXR1 cm4gbmV4dFNpYmxpbmc7Ci0gICAgICAgIHJldHVybiBuZXh0U2libGluZy0+bmV4dEluRmxvd1Np YmxpbmcoKTsKLSAgICB9Ci0gICAgcmV0dXJuIG51bGxwdHI7CisgICAgYXV0byogbmV4dFNpYmxp bmcgPSB0aGlzLT5uZXh0U2libGluZygpOworICAgIHdoaWxlIChuZXh0U2libGluZyAmJiAhKG5l eHRTaWJsaW5nLT5pc0luRmxvdygpIHx8IG5leHRTaWJsaW5nLT5pc0Zsb2F0aW5nUG9zaXRpb25l ZCgpKSkKKyAgICAgICAgbmV4dFNpYmxpbmcgPSBuZXh0U2libGluZy0+bmV4dFNpYmxpbmcoKTsK KyAgICByZXR1cm4gbmV4dFNpYmxpbmc7CiB9CiAKIGNvbnN0IEJveCogQm94OjpwcmV2aW91c0lu Rmxvd1NpYmxpbmcoKSBjb25zdAogewotICAgIGlmIChhdXRvKiBwcmV2aW91c1NpYmxpbmcgPSB0 aGlzLT5wcmV2aW91c1NpYmxpbmcoKSkgewotICAgICAgICBpZiAocHJldmlvdXNTaWJsaW5nLT5p c0luRmxvdygpKQotICAgICAgICAgICAgcmV0dXJuIHByZXZpb3VzU2libGluZzsKLSAgICAgICAg cmV0dXJuIHByZXZpb3VzU2libGluZy0+cHJldmlvdXNJbkZsb3dTaWJsaW5nKCk7Ci0gICAgfQot ICAgIHJldHVybiBudWxscHRyOworICAgIGF1dG8qIHByZXZpb3VzU2libGluZyA9IHRoaXMtPnBy ZXZpb3VzU2libGluZygpOworICAgIHdoaWxlIChwcmV2aW91c1NpYmxpbmcgJiYgIXByZXZpb3Vz U2libGluZy0+aXNJbkZsb3coKSkKKyAgICAgICAgcHJldmlvdXNTaWJsaW5nID0gcHJldmlvdXNT aWJsaW5nLT5wcmV2aW91c1NpYmxpbmcoKTsKKyAgICByZXR1cm4gcHJldmlvdXNTaWJsaW5nOwog fQogCiBjb25zdCBCb3gqIEJveDo6cHJldmlvdXNJbkZsb3dPckZsb2F0aW5nU2libGluZygpIGNv bnN0CiB7Ci0gICAgaWYgKGF1dG8qIHByZXZpb3VzU2libGluZyA9IHRoaXMtPnByZXZpb3VzU2li bGluZygpKSB7Ci0gICAgICAgIGlmIChwcmV2aW91c1NpYmxpbmctPmlzSW5GbG93KCkgfHwgcHJl dmlvdXNTaWJsaW5nLT5pc0Zsb2F0aW5nUG9zaXRpb25lZCgpKQotICAgICAgICAgICAgcmV0dXJu IHByZXZpb3VzU2libGluZzsKLSAgICAgICAgcmV0dXJuIHByZXZpb3VzU2libGluZy0+cHJldmlv dXNJbkZsb3dPckZsb2F0aW5nU2libGluZygpOwotICAgIH0KLSAgICByZXR1cm4gbnVsbHB0cjsK KyAgICBhdXRvKiBwcmV2aW91c1NpYmxpbmcgPSB0aGlzLT5wcmV2aW91c1NpYmxpbmcoKTsKKyAg ICB3aGlsZSAocHJldmlvdXNTaWJsaW5nICYmICEocHJldmlvdXNTaWJsaW5nLT5pc0luRmxvdygp IHx8IHByZXZpb3VzU2libGluZy0+aXNGbG9hdGluZ1Bvc2l0aW9uZWQoKSkpCisgICAgICAgIHBy ZXZpb3VzU2libGluZyA9IHByZXZpb3VzU2libGluZy0+cHJldmlvdXNTaWJsaW5nKCk7CisgICAg cmV0dXJuIHByZXZpb3VzU2libGluZzsKIH0KIAogYm9vbCBCb3g6OmlzT3ZlcmZsb3dWaXNpYmxl KCkgY29uc3QK