19385 2008-06-03 20:04:25 -0700 [Qt] Dragging and dropping an image in edit mode does not work 2011-04-08 13:36:44 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 jonathon webkit-unassigned ap benjamin commit-queue oldest_to_newest 82266 0 jonathon 2008-06-03 20:04:25 -0700 Steps to reproduce: - make page editable - click on and drag an image - drop the image in a different spot on the page (e.g. in the middle of a paragraph somewhere) results: - the image is deleted from its original position, but it is not inserted into the document at the new position expected behavior: - the image should be moved from the old position to the new drop position 82267 1 21489 jonathon 2008-06-03 20:06:41 -0700 Created attachment 21489 Possible fix to insert the image into the editable document at the drop location Basically, when dragging an image it was saving the image data to the clipboard, but to move it within an editable html document, we want to save the html fragment in the clipboard and paste that into the new location. This patch just adds the html fragment as an additional format in the drag clipboard. 82270 2 mrowe 2008-06-03 20:34:18 -0700 This already behaves correctly on the Mac, which suggests to me that the fix should not be in core cross-platform code but in GTK-specific client classes. 86884 3 21489 eric 2008-07-24 11:43:52 -0700 Comment on attachment 21489 Possible fix to insert the image into the editable document at the drop location I just tested: 1. open "about:blank" 2. type "javascript:document.designMode="on"" 3. Drag the google.com logo from google.com onto the now-editable about:blank document. it worked for me on the Mac. Suggesting that this is a gtk-only issue? Please provide a test case so we can verify if your fix affects other platforms. 87149 4 22520 jonathon 2008-07-28 07:12:51 -0700 Created attachment 22520 A simple test case Thanks for looking at this Eric. I think your test case might be a slightly different situation than the bug I am seeing, so I'm attaching a simple test case to illustrate the problem I'm seeing (sorry for not attaching this initially). By the way, I'm seeing this issue in Qt, and it's possible that it only affects the Qt port, but from my reading of the source code, this seems unlikely to me. 331076 5 ap 2011-01-07 15:49:15 -0800 If I understand what this bug is about, the attached test case also works fine in Safari 5 on Mac OS X. The image is successfully moved, and all attributes (like ALT) are preserved. 380387 6 88427 benjamin 2011-04-06 08:17:36 -0700 Created attachment 88427 Patch 382400 7 88427 kling 2011-04-08 11:23:50 -0700 Comment on attachment 88427 Patch r=me 382513 8 88427 commit-queue 2011-04-08 13:36:39 -0700 Comment on attachment 88427 Patch Clearing flags on attachment: 88427 Committed r83338: <http://trac.webkit.org/changeset/83338> 382514 9 commit-queue 2011-04-08 13:36:44 -0700 All reviewed patches have been landed. Closing bug. 21489 2008-06-03 20:06:41 -0700 2010-06-10 15:49:38 -0700 Possible fix to insert the image into the editable document at the drop location 0001-Write-the-range-to-the-clipboard-when-dragging-an-im.patch text/plain 2079 jonathon RnJvbSBhODk0MTU0YTMzMWFmYmFmMmRiZTQwZDYxNTZiMDM1MTJmZjcwNjI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb25hdGhvbiBKb25nc21hIDxqam9uZ3NtYUBnbm9tZS5vcmc+ CkRhdGU6IFR1ZSwgMyBKdW4gMjAwOCAxNDo1OToyNSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIFdy aXRlIHRoZSByYW5nZSB0byB0aGUgY2xpcGJvYXJkIHdoZW4gZHJhZ2dpbmcgYW4gaW1nCgogICAg ICAgICogcGFnZS9EcmFnQ29udHJvbGxlci5jcHA6CiAgICAgICAgKFdlYkNvcmU6OnByZXBhcmVD bGlwYm9hcmRGb3JJbWFnZURyYWcpOiBXaGVuIGRyYWdnaW5nIGFuIGltYWdlLCBhbHNvCiAgICAg ICAgd3JpdGUgdGhlIGltZyBlbGVtZW50IHRvIHRoZSBjbGlwYm9hcmQuICBUaGlzIG1ha2VzIGl0 IHNvIHRoYXQgaWYgd2UKICAgICAgICBkcm9wIHRoZSBpbWFnZSBpbnRvIGFuIGVkaXRhYmxlIGh0 bWwgZG9jdW1lbnQsIGl0IHdpbGwgaW5zZXJ0IHRoZSA8aW1nPgogICAgICAgIHRhZyBwcm9wZXJs eQotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysr KwogV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcCB8ICAgIDEgKwogMiBmaWxlcyBjaGFu Z2VkLCAxMyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNv cmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGVmZjQ3NS4uNGNjMWE1YSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAwOC0wNi0wMyAgSm9uYXRob24gSm9uZ3NtYSAgPGpqb25nc21hQGdu b21lLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAgICAqIHBh Z2UvRHJhZ0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cHJlcGFyZUNsaXBib2Fy ZEZvckltYWdlRHJhZyk6IFdoZW4gZHJhZ2dpbmcgYW4gaW1hZ2UsIGFsc28KKyAgICAgICAgd3Jp dGUgdGhlIGltZyBlbGVtZW50IHRvIHRoZSBjbGlwYm9hcmQuICBUaGlzIG1ha2VzIGl0IHNvIHRo YXQgaWYgd2UKKyAgICAgICAgZHJvcCB0aGUgaW1hZ2UgaW50byBhbiBlZGl0YWJsZSBodG1sIGRv Y3VtZW50LCBpdCB3aWxsIGluc2VydCB0aGUgPGltZz4KKyAgICAgICAgdGFnIHByb3Blcmx5CisK IDIwMDgtMDUtMzAgIEpvbmF0aG9uIEpvbmdzbWEgIDxqb25hdGhvbi5qb25nc21hQGNvbGxhYm9y YS5jby51az4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAgYi9XZWJDb3JlL3BhZ2UvRHJhZ0Nv bnRyb2xsZXIuY3BwCmluZGV4IGUwNmJmNWUuLmM2Zjk3MzkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGFnZS9EcmFnQ29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVy LmNwcApAQCAtNTY2LDYgKzU2Niw3IEBAIHN0YXRpYyB2b2lkIHByZXBhcmVDbGlwYm9hcmRGb3JJ bWFnZURyYWcoRnJhbWUqIHNyYywgQ2xpcGJvYXJkKiBjbGlwYm9hcmQsIEVsZW1lCiAgICAgQVNT RVJUKGVjID09IDApOwogICAgIHNyYy0+c2VsZWN0aW9uQ29udHJvbGxlcigpLT5zZXRTZWxlY3Rp b24oU2VsZWN0aW9uKHJhbmdlLmdldCgpLCBET1dOU1RSRUFNKSk7ICAgICAgICAgICAKICAgICBj bGlwYm9hcmQtPmRlY2xhcmVBbmRXcml0ZURyYWdJbWFnZShub2RlLCAhbGlua1VSTC5pc0VtcHR5 KCkgPyBsaW5rVVJMIDogaW1hZ2VVUkwsIGxhYmVsLCBzcmMpOworICAgIGNsaXBib2FyZC0+d3Jp dGVSYW5nZShyYW5nZS5nZXQoKSwgc3JjKTsKIH0KICAgICAKIHN0YXRpYyBJbnRQb2ludCBkcmFn TG9jRm9yREhUTUxEcmFnKGNvbnN0IEludFBvaW50JiBtb3VzZURyYWdnZWRQb2ludCwgY29uc3Qg SW50UG9pbnQmIGRyYWdPcmlnaW4sIGNvbnN0IEludFBvaW50JiBkcmFnSW1hZ2VPZmZzZXQsIGJv b2wgaXNMaW5rSW1hZ2UpCi0tIAoxLjUuNQoK 22520 2008-07-28 07:12:51 -0700 2008-07-28 07:12:51 -0700 A simple test case image-drag.html text/html 925 jonathon PGh0bWw+CiAgICA8aGVhZD4KICAgICAgICA8dGl0bGU+QnVnIDE5Mzg1PC90aXRsZT4KICAgIDwv aGVhZD4KICAgIDxib2R5PgogICAgICAgIDxwPiBUaGlzIGlzIGEgdGVzdCBvZiBpbWFnZSBkcmFn Z2luZy4gVGhpcyBwYXJhZ3JhcGggaGFzIGFtIGVtYmVkZGVkIGltYWdlIDxpbWcgc3JjPSJodHRw Oi8vd2Via2l0Lm9yZy9pbWFnZXMvaWNvbi1nb2xkLnBuZyIgYWx0PSJ3ZWJraXQgbG9nbyBpbWFn ZSIgc3R5bGU9ImJvcmRlcjogMXB4IHNvbGlkIHJlZDsiLz4gd2l0aCBzb21lIGFsdCB0ZXh0IGFu ZCB2YXJpb3VzIG90aGVyIGF0dHJpYnV0ZXMuPC9wPgogICAgICAgIDxwPlRoaXMgZG9jdW1lbnQg aGFzIGRlc2lnbk1vZGU9Im9uIi4gIFRyeSB0byBkcmFnIHRoZSBpbWFnZSBmcm9tIHRoZSBmaXJz dCBwYXJhZ3JhcGggYW5kIGRyb3AgaXQgYXQgYSBkaWZmZXJlbnQgcGxhY2UgaW4gdGhlIGRvY3Vt ZW50LiAgVGhlIGltYWdlIHNob3VsZCBiZSBpbnNlcnRlZCBpbnRvIHRoZSBuZXcgbG9jYXRpb24g YW5kIGhhdmUgZXhhY3RseSB0aGUgc2FtZSBhdHRyaWJ1dGVzIGFzIGl0IGRpZCBpbiB0aGUgb3Jp Z2luYWwgbG9jYXRpb24uPC9wPgogICAgICAgIDxwPkluIHRoZSBRdCBwb3J0LCB0aGUgaW1hZ2Ug aXMgcmVtb3ZlZCBmcm9tIGl0cyBvcmlnaW5hbCBsb2NhdGlvbiBidXQgSSBlbmQgdXAgd2l0aCB0 aGUgZm9sbG93aW5nIGZyYWdtZW50IGF0IHRoZSBwb2ludCB3aGVyZSBJIGRyb3AgdGhlIGltYWdl OjwvcD4KICAgICAgICA8cHJlPiZsdDthIGhyZWY9Imh0dHA6Ly93ZWJraXQub3JnL2ltYWdlcy9p Y29uLWdvbGQucG5nIiZndDsmbHQ7L2EmZ3Q7PC9wcmU+CiAgICAgICAgPHNjcmlwdD4KICAgICAg ICAgICAgZG9jdW1lbnQuZGVzaWduTW9kZT0ib24iOwogICAgICAgIDwvc2NyaXB0PgogICAgPC9i b2R5Pgo8L2h0bWw+Cg== 88427 2011-04-06 08:17:36 -0700 2011-04-08 13:36:39 -0700 Patch 19385.diff text/plain 1521 benjamin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlMTQ2Y2QxLi4yMDcwNDY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDQtMDYgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lh LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb UXRdIERyYWdnaW5nIGFuZCBkcm9wcGluZyBhbiBpbWFnZSBpbiBlZGl0IG1vZGUgZG9lcyBub3Qg d29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkz ODUKKworICAgICAgICBXaGVuIGFkZGluZyBhbiBpbWFnZSB0byB0aGUgY2xpcGJvYXJkLCB3ZSBz aG91bGQgYWxzbyBpbmNsdWRlIHRoZSBIVE1MIGNvZGUgb2YgdGhhdCBpbWFnZSBzbworICAgICAg ICBpdCBjYW4gYmUgdXNlZCBmb3IgaW50ZXJuYWwgZHJhZyBhbmQgZHJvcC4KKworICAgICAgICBU aGlzIEhUTUwgaXMgZXhwZWN0ZWQgYnkgYWxsIGNsaWVudHMgb2YgZHJvcCBldmVudHMgc28gYSBm cmFnbWVudCBjYW4gYmUgbW92ZWQgZnJvbSBvbmUgYnJvd3NlciB0bworICAgICAgICBhbm90aGVy LCBvciBpbnNpZGUgdGhlIHNhbWUgYnJvd3Nlci4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L0Ns aXBib2FyZFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNsaXBib2FyZFF0OjpkZWNsYXJlQW5k V3JpdGVEcmFnSW1hZ2UpOgorCiAyMDExLTA0LTA2ICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmls b3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3ku CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9DbGlwYm9hcmRRdC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9DbGlwYm9hcmRRdC5jcHAKaW5kZXggYzE0ZDM2 Mi4uNzIzY2RkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ2xpcGJv YXJkUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L0NsaXBib2FyZFF0LmNw cApAQCAtMjk5LDYgKzI5OSw3IEBAIHZvaWQgQ2xpcGJvYXJkUXQ6OmRlY2xhcmVBbmRXcml0ZURy YWdJbWFnZShFbGVtZW50KiBlbGVtZW50LCBjb25zdCBLVVJMJiB1cmwsIGNvCiAKICAgICBtX3dy aXRhYmxlRGF0YS0+c2V0VGV4dCh0aXRsZSk7CiAgICAgbV93cml0YWJsZURhdGEtPnNldFVybHMo dXJscyk7CisgICAgbV93cml0YWJsZURhdGEtPnNldEh0bWwoY3JlYXRlTWFya3VwKGVsZW1lbnQs IEluY2x1ZGVOb2RlLCAwLCBBYnNvbHV0ZVVSTHMpKTsKICNpZm5kZWYgUVRfTk9fQ0xJUEJPQVJE CiAgICAgaWYgKGlzRm9yQ29weUFuZFBhc3RlKCkpCiAgICAgICAgIFFBcHBsaWNhdGlvbjo6Y2xp cGJvYXJkKCktPnNldE1pbWVEYXRhKG1fd3JpdGFibGVEYXRhKTsK