193795 2019-01-24 16:06:46 -0800 We should do constant folding on ValueOp even when it is UntypedUse 2019-01-24 16:27:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 186173 1 ticaiolima webkit-unassigned saam oldest_to_newest 1498015 0 ticaiolima 2019-01-24 16:06:46 -0800 Right now, we don't do constant fold on ValueOp nodes, but there is no reason why we shouldn't do this, since profiling and prediction propagation can miss some opportunities. 1498023 1 saam 2019-01-24 16:27:26 -0800 Yeah, the only thing we need to make sure of is that we don't fold away things that would've failed type checks. For UntypedUse that's obviously nothing. But for BigInt, we must make sure the inputs are BigInt.