193770 2019-01-24 09:04:24 -0800 [ Mojave Release ] ProcessSwap.PageShowHide is a flakey API crash 2019-01-24 13:38:03 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 193716 P2 Normal --- 1 tsavell cdumez achristensen ap beidson cdumez ggaren jlewis3 koivisto lforschler ryanhaddad oldest_to_newest 1497827 0 tsavell 2019-01-24 09:04:24 -0800 ProcessSwap.PageShowHide is a flakey API crash on Mojave for Release builds. failure only happens every 25 runs or so, very infrequently. No repro case yet. Crashed TestWebKitAPI.ProcessSwap.PageShowHide _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. Received data during response processing, queuing it. _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. Received data during response processing, queuing it. 2019-01-18 06:52:59.632 com.apple.WebKit.WebContent.Development[41741:67269154] Application does not have the 'com.apple.security.network.client' entitlement. API Log: https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/1886/steps/run-api-tests/logs/stdio run with failure: https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/2019 1497833 1 cdumez 2019-01-24 09:13:50 -0800 No way to get the crash trace? 1497837 2 cdumez 2019-01-24 09:17:34 -0800 Never mind, I was able to reproduce: Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Segmentation fault: 11 Termination Reason: Namespace SIGNAL, Code 0xb Terminating Process: exc handler [25431] VM Regions Near 0: --> __TEXT 0000000107242000-00000001076c7000 [ 4628K] r-x/rwx SM=COW /Volumes/VOLUME/* Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 libsystem_platform.dylib 0x00007fff77c4c712 _platform_strlen + 18 1 TestWebKitAPI 0x00000001074d1b88 TestWebKitAPI::Printer::OnTestPartResult(testing::TestPartResult const&) + 302 (TestsController.cpp:43) 2 TestWebKitAPI 0x00000001075b1c34 testing::internal::TestEventRepeater::OnTestPartResult(testing::TestPartResult const&) + 48 3 TestWebKitAPI 0x00000001075a5155 testing::UnitTest::AddTestPartResult(testing::TestPartResult::Type, char const*, int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 717 4 TestWebKitAPI 0x00000001075ae14d testing::internal::ReportFailureInUnknownLocation(testing::TestPartResult::Type, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 64 5 TestWebKitAPI 0x00000001075aea41 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 236 6 TestWebKitAPI 0x00000001075ae906 testing::Test::Run() + 184 7 TestWebKitAPI 0x00000001075af850 testing::TestInfo::Run() + 220 8 TestWebKitAPI 0x00000001075affd9 testing::TestCase::Run() + 273 9 TestWebKitAPI 0x00000001075b96e3 testing::internal::UnitTestImpl::RunAllTests() + 697 10 TestWebKitAPI 0x00000001075b9313 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 72 11 TestWebKitAPI 0x00000001075b929e testing::UnitTest::Run() + 108 12 TestWebKitAPI 0x00000001074d19ec TestWebKitAPI::TestsController::run(int, char**) + 120 (TestsController.cpp:86) 13 TestWebKitAPI 0x0000000107588729 main + 344 (mainMac.mm:52) 14 libdyld.dylib 0x00007fff77a64ed9 start + 1 1497838 3 360016 cdumez 2019-01-24 09:20:40 -0800 Created attachment 360016 Patch 1497857 4 cdumez 2019-01-24 09:56:38 -0800 Antti's patch fixes this too. *** This bug has been marked as a duplicate of bug 193716 *** 1497862 5 koivisto 2019-01-24 10:16:09 -0800 I'm not entirely convinced that that patch fixes any existing flakiness. 1497863 6 cdumez 2019-01-24 10:16:55 -0800 (In reply to Antti Koivisto from comment #5) > I'm not entirely convinced that that patch fixes any existing flakiness. I have verified locally that waiting for all 7 messages fixes the flaky crashes. 1497865 7 cdumez 2019-01-24 10:17:38 -0800 (In reply to Chris Dumez from comment #6) > (In reply to Antti Koivisto from comment #5) > > I'm not entirely convinced that that patch fixes any existing flakiness. > > I have verified locally that waiting for all 7 messages fixes the flaky > crashes. This was a pre-existing issue, your patch just made it even flakier by delaying the Closing. 1497866 8 koivisto 2019-01-24 10:22:09 -0800 I think I saw this test flake once even with delaying applied (hanging in the wait loop). 1497867 9 koivisto 2019-01-24 10:23:17 -0800 But bots will tell. 360016 2019-01-24 09:20:40 -0800 2019-01-24 09:56:28 -0800 Patch bug-193770-20190124092040.patch text/plain 1969 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNDM1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2M3YTg2NTk3M2JhNmRkY2Q1MzVmODYyN2UxZjg4YzBm Y2E4OTM5My4uMTUyNzQyYmNlNmJlNjIyNDZhOGQ0YWZkZDJkN2JhMDNlMTk5N2Q1MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE5LTAxLTI0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgWyBNb2phdmUgUmVsZWFzZSBdIFByb2Nlc3NTd2FwLlBhZ2VTaG93SGlkZSBpcyBhIGZsYWtl eSBBUEkgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5Mzc3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1ha2Ugc3VyZSB3ZSByZWNlaXZlZCBhbGwgdGhlIG1lc3NhZ2VzIGJlZm9yZSB3ZSB2YWxp ZGF0ZSB0aGVtLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Q cm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbToKKwogMjAxOS0wMS0yNCAgUGhpbGlwcGUgTm9ybWFu ZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0gUmVtb3ZlIGhhcmQgZGVw ZW5kZW5jeSBvbiBzdWJwcm9jZXNzMzIgZm9yIHRoZSBBUEkgdGVzdHMKZGlmZiAtLWdpdCBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5hdmlnYXRp b24ubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Byb2Nlc3NTd2Fw T25OYXZpZ2F0aW9uLm1tCmluZGV4IGZkYTQ2YTU5N2M4ZDNjMDNlM2QwNDgzNGRjMzFlYTYyNTBh MmUyMzAuLmE4MTE5NTM0Nzg4NzQwMzQ0MzMyZTc2MDcxOGNjODQ5OGZiMTkyN2UgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1N3YXBPbk5h dmlnYXRpb24ubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Q cm9jZXNzU3dhcE9uTmF2aWdhdGlvbi5tbQpAQCAtMjM0MCw2ICsyMzQwLDkgQEAgVEVTVChQcm9j ZXNzU3dhcCwgUGFnZVNob3dIaWRlKQogICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigmZG9u ZSk7CiAgICAgZG9uZSA9IGZhbHNlOwogCisgICAgd2hpbGUgKFtyZWNlaXZlZE1lc3NhZ2VzIGNv dW50XSA8IDcpCisgICAgICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnNsZWVwKDAuMSk7CisKICAg ICBFWFBFQ1RfRVEoN3UsIFtyZWNlaXZlZE1lc3NhZ2VzIGNvdW50XSk7CiAgICAgRVhQRUNUX1dL X1NUUkVRKEAicHNvbjovL3d3dy53ZWJraXQub3JnL21haW4uaHRtbCAtIHBhZ2VzaG93IE5PVCBw ZXJzaXN0ZWQiLCByZWNlaXZlZE1lc3NhZ2VzLmdldCgpWzBdKTsKICAgICBpZiAoW3JlY2VpdmVk TWVzc2FnZXMuZ2V0KClbMV0gaGFzUHJlZml4OkAicHNvbjovL3d3dy53ZWJraXQub3JnL21haW4u aHRtbCJdKSB7CkBAIC0yNDMwLDYgKzI0MzMsOSBAQCBURVNUKFByb2Nlc3NTd2FwLCBMb2FkVW5s b2FkKQogICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigmZG9uZSk7CiAgICAgZG9uZSA9IGZh bHNlOwogCisgICAgd2hpbGUgKFtyZWNlaXZlZE1lc3NhZ2VzIGNvdW50XSA8IDcpCisgICAgICAg IFRlc3RXZWJLaXRBUEk6OlV0aWw6OnNsZWVwKDAuMSk7CisKICAgICBFWFBFQ1RfRVEoN3UsIFty ZWNlaXZlZE1lc3NhZ2VzIGNvdW50XSk7CiAgICAgRVhQRUNUX1dLX1NUUkVRKEAicHNvbjovL3d3 dy53ZWJraXQub3JnL21haW4uaHRtbCAtIGxvYWQiLCByZWNlaXZlZE1lc3NhZ2VzLmdldCgpWzBd KTsKICAgICBpZiAoW3JlY2VpdmVkTWVzc2FnZXMuZ2V0KClbMV0gaGFzUHJlZml4OkAicHNvbjov L3d3dy53ZWJraXQub3JnL21haW4uaHRtbCJdKSB7Cg==