19374 2008-06-03 07:39:34 -0700 Expose boundingBox value in QWebHitTestResult 2008-10-22 12:58:28 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P3 Minor --- 1 siraj siraj hausmann pierre-luc.beaudoin oldest_to_newest 82201 0 siraj 2008-06-03 07:39:34 -0700 QWebHitTestResult does not have an API function to get the boundingBox value from WebCore, I will attach a patch will that will expose the API function. 82202 1 21477 siraj 2008-06-03 08:19:30 -0700 Created attachment 21477 Expose boundingBox value in QWebHitTestResult Add API function QRect QWebHitResult::boundingBox() const 82610 2 21477 siraj 2008-06-08 05:55:54 -0700 Comment on attachment 21477 Expose boundingBox value in QWebHitTestResult Making obsolete till API documentation is added to the patch 96114 3 21477 hausmann 2008-10-21 15:30:36 -0700 Comment on attachment 21477 Expose boundingBox value in QWebHitTestResult The patch looks good actually, it looks like we completly overlooked it :). Ariya added some API docs and I'm going to land it soon 96115 4 hausmann 2008-10-21 15:33:31 -0700 Landed in r37764 96121 5 pierre-luc.beaudoin 2008-10-21 15:54:53 -0700 I think you didn't overlook it, it wasn't "r?" :) 96123 6 siraj 2008-10-21 16:05:18 -0700 (In reply to comment #3) > (From update of attachment 21477 [edit]) > The patch looks good actually, it looks like we completly overlooked it :). > Ariya added some API docs and I'm going to land it soon > Thank you for the review + !and sorry for not adding the API docs. And Thank you Ariya for cleaning up the mess :) . 96210 7 hausmann 2008-10-22 12:58:28 -0700 After a brief discussion we committed also r37787 that renames boundingBox() to boundingRect(), for consistency with the rest of the Qt API 21477 2008-06-03 08:19:30 -0700 2008-10-21 15:30:36 -0700 Expose boundingBox value in QWebHitTestResult boundingbox.diff text/plain 2325 siraj SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gMzQzNDApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDgtMDYtMDMgIFNpcmFqIFJhemljayAgPHNpcmFqLnJh emlja0Bjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 Mzc0CisKKyAgICAgICAgRXhwb3NlIGJvdW5kaW5nQm94IHZhbHVlIGluIFFXZWJIaXRUZXN0UmVz dWx0CisKKyAgICAgICAgQWRkIEFQSSBmdW5jdGlvbiBRUmVjdCBRV2ViSGl0UmVzdWx0Ojpib3Vu ZGluZ0JveCgpIGNvbnN0CisKKyAgICAgICAgKiBBcGkvcXdlYmZyYW1lLmNwcDoKKyAgICAgICAg KFFXZWJIaXRUZXN0UmVzdWx0UHJpdmF0ZTo6UVdlYkhpdFRlc3RSZXN1bHRQcml2YXRlKToKKyAg ICAgICAgKFFXZWJIaXRUZXN0UmVzdWx0Ojpib3VuZGluZ0JveCk6CisgICAgICAgICogQXBpL3F3 ZWJmcmFtZS5oOgorICAgICAgICAqIEFwaS9xd2ViZnJhbWVfcC5oOgorCiAyMDA4LTA1LTI5ICBL YXZpbmRyYSBEZXZpIFBhbGFyYWphICA8a2RwYWxhcmFAdHJvbGx0ZWNoLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTaW1vbi4KSW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAJKHJldmlzaW9uIDM0Mjg4 KQorKysgV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MDQs NiArOTA0LDcgQEAgUVdlYkhpdFRlc3RSZXN1bHRQcml2YXRlOjpRV2ViSGl0VGVzdFJlcwogICAg IGlmICghaGl0VGVzdC5pbm5lck5vZGUoKSkKICAgICAgICAgcmV0dXJuOwogICAgIHBvcyA9IGhp dFRlc3QucG9pbnQoKTsKKyAgICBib3VuZGluZ0JveCA9IGhpdFRlc3QuYm91bmRpbmdCb3goKTsK ICAgICB0aXRsZSA9IGhpdFRlc3QudGl0bGUoKTsKICAgICBsaW5rVGV4dCA9IGhpdFRlc3QudGV4 dENvbnRlbnQoKTsKICAgICBsaW5rVXJsID0gaGl0VGVzdC5hYnNvbHV0ZUxpbmtVUkwoKTsKQEAg LTk5Miw2ICs5OTMsMTUgQEAgUVBvaW50IFFXZWJIaXRUZXN0UmVzdWx0Ojpwb3MoKSBjb25zdAog fQogCiAvKiEKKyAqLworUVJlY3QgUVdlYkhpdFRlc3RSZXN1bHQ6OmJvdW5kaW5nQm94KCkgY29u c3QKK3sKKyAgICBpZiAoIWQpCisgICAgICAgIHJldHVybiBRUmVjdCgpOworICAgIHJldHVybiBk LT5ib3VuZGluZ0JveDsKK30KKworLyohCiAgICAgUmV0dXJucyB0aGUgdGl0bGUgb2YgdGhlIG5l YXJlc3QgZW5jbG9zaW5nIEhUTUwgZWxlbWVudC4KICovCiBRU3RyaW5nIFFXZWJIaXRUZXN0UmVz dWx0Ojp0aXRsZSgpIGNvbnN0CkluZGV4OiBXZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmgJKHJldmlzaW9uIDM0Mjg4KQorKysg V2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuaAkod29ya2luZyBjb3B5KQpAQCAtNjcsNiArNjcsNyBA QCBwdWJsaWM6CiAgICAgYm9vbCBpc051bGwoKSBjb25zdDsKIAogICAgIFFQb2ludCBwb3MoKSBj b25zdDsKKyAgICBRUmVjdCBib3VuZGluZ0JveCgpIGNvbnN0OwogICAgIFFTdHJpbmcgdGl0bGUo KSBjb25zdDsKIAogICAgIFFTdHJpbmcgbGlua1RleHQoKSBjb25zdDsKSW5kZXg6IFdlYktpdC9x dC9BcGkvcXdlYmZyYW1lX3AuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJmcmFt ZV9wLmgJKHJldmlzaW9uIDM0Mjg4KQorKysgV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWVfcC5oCSh3 b3JraW5nIGNvcHkpCkBAIC0xMDAsNiArMTAwLDcgQEAgcHVibGljOgogICAgIFFXZWJIaXRUZXN0 UmVzdWx0UHJpdmF0ZShjb25zdCBXZWJDb3JlOjpIaXRUZXN0UmVzdWx0ICZoaXRUZXN0KTsKIAog ICAgIFFQb2ludCBwb3M7CisgICAgUVJlY3QgYm91bmRpbmdCb3g7CiAgICAgUVN0cmluZyB0aXRs ZTsKICAgICBRU3RyaW5nIGxpbmtUZXh0OwogICAgIFFVcmwgbGlua1VybDsK