193738 2019-01-23 14:17:09 -0800 Try to fix imported/w3c/web-platform-tests/css/css-display/run-in/quotes-applies-to-011.xht 2019-05-06 19:04:20 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux NEW https://bugs.webkit.org/show_bug.cgi?id=193628 P2 Normal --- 1 mcatanzaro mcatanzaro cgarcia lforschler mcatanzaro Ms2ger oldest_to_newest 1497562 0 mcatanzaro 2019-01-23 14:17:09 -0800 Try to fix imported/w3c/web-platform-tests/css/css-display/run-in/quotes-applies-to-011.xht. This reftest is failing for GTK since we switched to complex text because the "PASS" printed by the -expected.html now uses kerning. 1497565 1 mcatanzaro 2019-01-23 14:18:30 -0800 (Let's see what Mac EWS thinks.) 1497566 2 359940 mcatanzaro 2019-01-23 14:18:40 -0800 Created attachment 359940 Patch 1497693 3 359984 mcatanzaro 2019-01-23 18:47:46 -0800 Created attachment 359984 Patch 1497776 4 359984 Ms2ger 2019-01-24 03:19:06 -0800 Comment on attachment 359984 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359984&action=review > LayoutTests/imported/w3c/web-platform-tests/css/css-display/run-in/quotes-applies-to-011-expected.html:9 > + <div style="font-kerning: none;">PASS</div> This is imported from `wpt/css/reference/pass_if_pass_below.html` upstream, so making this change there would affect a couple dozen other tests as well, unfortunately. OTOH, it seems like this is the only test with this reference that's imported in WebKit, so it's worth checking if they all fail without this change. 1497824 5 mcatanzaro 2019-01-24 09:00:36 -0800 Hm, what's the easiest way to test it? Create an upstream pull request and see what happens on the upstream CI? 1533735 6 359984 mcatanzaro 2019-05-06 19:04:20 -0700 Comment on attachment 359984 Patch Removing this from my request queue, since I don't plan to work on this further. 359940 2019-01-23 14:18:40 -0800 2019-01-23 18:47:44 -0800 Patch bug-193738-20190123161839.patch text/plain 1663 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMzUwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpp bmRleCBlNzcxNjY4ZDUzMTJkNmM2YjlkYjhiYTFmNTRiNjQzMDBiZjljNTQzLi45YTJkZGFjNGE3 MTRhNzhhODZjYjIyNjRhYWE3NDg3YjNiMGYzMjUyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wMS0yMyAgTWljaGFlbCBDYXRhbnphcm8gIDxt Y2F0YW56YXJvQGlnYWxpYS5jb20+CisKKyAgICAgICAgVHJ5IHRvIGZpeCBpbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZGlzcGxheS9ydW4taW4vcXVvdGVzLWFwcGxpZXMt dG8tMDExLnhodAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkzNzM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyByZWZ0ZXN0IGlzIGZhaWxpbmcgZm9yIEdUSyBzaW5jZSB3ZSBzd2l0Y2hlZCB0byBj b21wbGV4IHRleHQgYmVjYXVzZSB0aGUgIlBBU1MiIHByaW50ZWQKKyAgICAgICAgYnkgdGhlIC1l eHBlY3RlZC5odG1sIG5vdyB1c2VzIGtlcm5pbmcsIHNvIHRyeSBkaXNhYmxlIHRoZSBrZXJuaW5n LgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZGlzcGxheS9ydW4taW4v cXVvdGVzLWFwcGxpZXMtdG8tMDExLWV4cGVjdGVkLmh0bWw6CisKIDIwMTktMDEtMjMgIE9yaW9s IEJydWZhdSAgPG9icnVmYXVAaWdhbGlhLmNvbT4KIAogICAgICAgICBbY3NzLWxvZ2ljYWxdIElt cGxlbWVudCBmbG93LXJlbGF0aXZlIGluc2V0IHByb3BlcnRpZXMKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1kaXNwbGF5L3J1 bi1pbi9xdW90ZXMtYXBwbGllcy10by0wMTEtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1kaXNwbGF5L3J1bi1pbi9xdW90 ZXMtYXBwbGllcy10by0wMTEtZXhwZWN0ZWQuaHRtbAppbmRleCA3ZGU0NDgyNWMwNjI5NGE2ZjMy YjhhMDdjMWVlMjExZTI4ZDM3ZmUwLi4wMGM1YWExZmI5MGRhYmI4N2U4MjAxZjNmZmRhNTdmZWVj NTIxZTkwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2Nzcy9jc3MtZGlzcGxheS9ydW4taW4vcXVvdGVzLWFwcGxpZXMtdG8tMDExLWV4cGVj dGVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0 cy9jc3MvY3NzLWRpc3BsYXkvcnVuLWluL3F1b3Rlcy1hcHBsaWVzLXRvLTAxMS1leHBlY3RlZC5o dG1sCkBAIC02LDYgKzYsNiBAQAogPC9oZWFkPgogPGJvZHk+CiAgICA8cD5UZXN0IHBhc3NlcyBp ZiB0aGVyZSBpcyB0aGUgd29yZCAiUEFTUyIgYmVsb3cuPC9wPgotICAgPGRpdj5QQVNTPC9kaXY+ CisgICA8ZGl2IHN0eWxlPSJmb250LWtlcm5pbmc6IG5vbmU7Ij5QQVNTPC9kaXY+CiA8L2JvZHk+ CiA8L2h0bWw+Cg== 359984 2019-01-23 18:47:46 -0800 2019-05-06 19:04:20 -0700 Patch bug-193738-20190123204745.patch text/plain 3395 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwNDAxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMmU2NGIzMDQ0NTYyN2M4MjU1OWEy NWY0ZmM0NjU5MTI0NThjY2ZiNS4uY2ZiZGY1Y2Q3Y2NlOGU0ODU5YzljZDI4ZjNkNjgyYzhiY2Ey YTUyYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAxLTIzICBNaWNoYWVsIENhdGFuemFy byAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBUcnkgdG8gZml4IGltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1kaXNwbGF5L3J1bi1pbi9xdW90ZXMtYXBw bGllcy10by0wMTEueGh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTM3MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZW1vdmUgZmFpbHVyZSBleHBlY3RhdGlvbi4KKworICAgICAgICAqIFRlc3RFeHBl Y3RhdGlvbnM6CisKIDIwMTktMDEtMjMgIE9yaW9sIEJydWZhdSAgPG9icnVmYXVAaWdhbGlhLmNv bT4KIAogICAgICAgICBBbGxvdyBmYWlsdXJlcyBpbiBmbGFreSB0ZXN0cyBmcm9tIGJ1ZyAxOTM2 NTcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IGU3NzE2NjhkNTMxMmQ2YzZiOWRi OGJhMWY1NGI2NDMwMGJmOWM1NDMuLjlhMmRkYWM0YTcxNGE3OGE4NmNiMjI2NGFhYTc0ODdiM2Iw ZjMyNTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisy MDE5LTAxLTIzICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKwor ICAgICAgICBUcnkgdG8gZml4IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nz cy1kaXNwbGF5L3J1bi1pbi9xdW90ZXMtYXBwbGllcy10by0wMTEueGh0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM3MzgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHJlZnRlc3QgaXMgZmFpbGlu ZyBmb3IgR1RLIHNpbmNlIHdlIHN3aXRjaGVkIHRvIGNvbXBsZXggdGV4dCBiZWNhdXNlIHRoZSAi UEFTUyIgcHJpbnRlZAorICAgICAgICBieSB0aGUgLWV4cGVjdGVkLmh0bWwgbm93IHVzZXMga2Vy bmluZywgc28gdHJ5IGRpc2FibGUgdGhlIGtlcm5pbmcuCisKKyAgICAgICAgKiB3ZWItcGxhdGZv cm0tdGVzdHMvY3NzL2Nzcy1kaXNwbGF5L3J1bi1pbi9xdW90ZXMtYXBwbGllcy10by0wMTEtZXhw ZWN0ZWQuaHRtbDoKKwogMjAxOS0wMS0yMyAgT3Jpb2wgQnJ1ZmF1ICA8b2JydWZhdUBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtjc3MtbG9naWNhbF0gSW1wbGVtZW50IGZsb3ctcmVsYXRpdmUgaW5z ZXQgcHJvcGVydGllcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBi L0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNGRmNTQ3YjAzYWMyYWM5NDE0MzY0 ZDcyMmIyNGI0NzY0YjQyOWMwOC4uMGVlODNiNTgxMjIyY2I5ZjU5YWRiZGI0YjNiYTZmMGRjZWRk ZDA1MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlv dXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0yODAyLDcgKzI4MDIsNiBAQCBpbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZGlzcGxheS9ydW4taW4vcnVuLWluLWlubGlu ZS1ibG9jay1iZXR3ZQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWRp c3BsYXkvcnVuLWluL3J1bi1pbi1maXhlZHBvcy1iZXR3ZWVuLTAwMS54aHQgWyBJbWFnZU9ubHlG YWlsdXJlIF0KIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1wc2V1ZG8v cGxhY2Vob2xkZXItaW5wdXQtbnVtYmVyLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIGltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy10ZXh0LWRlY29yL3RleHQtZW1waGFz aXMtcG9zaXRpb24tYmVsb3ctcmlnaHQtMDAyLnhodCBbIEltYWdlT25seUZhaWx1cmUgXQotaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWRpc3BsYXkvcnVuLWluL3F1b3Rl cy1hcHBsaWVzLXRvLTAxMS54aHQgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIGltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy10ZXh0L292ZXJmbG93LXdyYXAvb3ZlcmZsb3ctd3Jh cC1taW4tY29udGVudC1zaXplLTAwMS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZGlzcGxheS9ydW4taW4vcnVuLWluLWJh c2ljLTAxMi54aHQgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIGltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvY3NzL2Nzc29tLXZpZXcvc2Nyb2xsLWJlaGF2aW9yLXNtb290aC5odG1sIFsgU2tp cCBdCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2Nzcy9jc3MtZGlzcGxheS9ydW4taW4vcXVvdGVzLWFwcGxpZXMtdG8tMDExLWV4cGVjdGVk Lmh0bWwgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9j c3MtZGlzcGxheS9ydW4taW4vcXVvdGVzLWFwcGxpZXMtdG8tMDExLWV4cGVjdGVkLmh0bWwKaW5k ZXggN2RlNDQ4MjVjMDYyOTRhNmYzMmI4YTA3YzFlZTIxMWUyOGQzN2ZlMC4uMDBjNWFhMWZiOTBk YWJiODdlODIwMWYzZmZkYTU3ZmVlYzUyMWU5MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWRpc3BsYXkvcnVuLWluL3F1b3Rl cy1hcHBsaWVzLXRvLTAxMS1leHBlY3RlZC5odG1sCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1kaXNwbGF5L3J1bi1pbi9xdW90ZXMtYXBw bGllcy10by0wMTEtZXhwZWN0ZWQuaHRtbApAQCAtNiw2ICs2LDYgQEAKIDwvaGVhZD4KIDxib2R5 PgogICAgPHA+VGVzdCBwYXNzZXMgaWYgdGhlcmUgaXMgdGhlIHdvcmQgIlBBU1MiIGJlbG93Ljwv cD4KLSAgIDxkaXY+UEFTUzwvZGl2PgorICAgPGRpdiBzdHlsZT0iZm9udC1rZXJuaW5nOiBub25l OyI+UEFTUzwvZGl2PgogPC9ib2R5PgogPC9odG1sPgo=