193729 2019-01-23 10:38:01 -0800 [ews-app] Rename ews model buildermappings to buildermapping 2019-01-23 14:00:32 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193697 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1497417 0 aakash_jain 2019-01-23 10:38:01 -0800 The recommended naming convention for models in Django is to use singular noun. Therefore, we should rename 'buildermappings' to 'buildermapping' in ews-app model. 1497440 1 359907 aakash_jain 2019-01-23 11:16:54 -0800 Created attachment 359907 Proposed patch 1497444 2 359907 kocsen_chung 2019-01-23 11:19:27 -0800 Comment on attachment 359907 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359907&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:28 > +class BuilderMappings(models.Model): Should this be singular BuilderMapping ? 1497447 3 kocsen_chung 2019-01-23 11:20:42 -0800 R+; looks good to me. 1497530 4 359907 lforschler 2019-01-23 13:17:50 -0800 Comment on attachment 359907 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=359907&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:1 > +# Copyright (C) 2018 Apple Inc. All rights reserved. maybe update this to 2019? 1497552 5 aakash_jain 2019-01-23 13:59:16 -0800 Committed r240361: <https://trac.webkit.org/changeset/240361> 1497553 6 webkit-bug-importer 2019-01-23 14:00:32 -0800 <rdar://problem/47492954> 359907 2019-01-23 11:16:54 -0800 2019-01-23 13:18:20 -0800 Proposed patch ews-app-rename-buildermappings.patch text/plain 5773 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0MDM0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE5LTAxLTIzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gUmVuYW1lIGV3cyBtb2RlbCBidWlsZGVybWFwcGluZ3Mg dG8gYnVpbGRlcm1hcHBpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5MzcyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkZXJt YXBwaW5nLnB5OiBSZW5hbWVkIGZyb20gQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9k ZWxzL2J1aWxkZXJtYXBwaW5ncy5weS4KKyAgICAgICAgKEJ1aWxkZXJNYXBwaW5nKTogUmVuYW1l ZCBCdWlsZGVyTWFwcGluZ3MgdG8gQnVpbGRlck1hcHBpbmcuCisgICAgICAgICogQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL19faW5pdF9fLnB5OiBEaXR0by4KKwogMjAxOS0w MS0yMyAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgd2Vi a2l0cHk6IFVzZSBjb3JyZWN0IGNvbmZpZyBmb3IgLS1pcGhvbmUtc2ltdWxhdG9yIGFuZCAtLWlw YWQtc2ltdWxhdG9yCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9t b2RlbHMvX19pbml0X18ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWFwcC9ld3MvbW9kZWxzL19faW5pdF9fLnB5CShyZXZpc2lvbiAyNDAzNDcpCisrKyBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvX19pbml0X18ucHkJKHdvcmtp bmcgY29weSkKQEAgLTEsNCArMSw0IEBACi1mcm9tIGJ1aWxkZXJtYXBwaW5ncyBpbXBvcnQgKgor ZnJvbSBidWlsZGVybWFwcGluZyBpbXBvcnQgKgogZnJvbSBidWlsZHMgaW1wb3J0ICoKIGZyb20g cGF0Y2ggaW1wb3J0ICoKIGZyb20gc3RlcHMgaW1wb3J0ICoKSW5kZXg6IFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9idWlsZGVybWFwcGluZy5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvYnVpbGRlcm1h cHBpbmcucHkJKHJldmlzaW9uIDI0MDM0NykJKGZyb20gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkZXJtYXBwaW5ncy5weToyNDAzNDcpCisrKyBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvYnVpbGRlcm1hcHBpbmcucHkJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSwzMyBAQAorIyBDb3B5cmlnaHQgKEMpIDIwMTggQXBwbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIworIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGlu IHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyMgbW9kaWZpY2F0aW9u LCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisj IGFyZSBtZXQ6CisjIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRh aW4gdGhlIGFib3ZlIGNvcHlyaWdodAorIyAgICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0 aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorIyAyLiAgUmVkaXN0cmlidXRpb25z IGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMgICAg IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xh aW1lciBpbiB0aGUKKyMgICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBw cm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisjCisjIFRISVMgU09GVFdBUkUgSVMgUFJP VklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycgQU5ECisj IEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJ TUlURUQgVE8sIFRIRSBJTVBMSUVECisjIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFO RCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUKKyMgRElTQ0xBSU1FRC4gSU4g Tk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBG T1IKKyMgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFS WSwgT1IgQ09OU0VRVUVOVElBTAorIyBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRF RCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUgorIyBTRVJWSUNFUzsgTE9T UyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9X RVZFUgorIyBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElO IENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLAorIyBPUiBUT1JUIChJTkNMVURJTkcgTkVHTElH RU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorIyBP RiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNV Q0ggREFNQUdFLgorCitmcm9tIF9fZnV0dXJlX18gaW1wb3J0IHVuaWNvZGVfbGl0ZXJhbHMKKwor ZnJvbSBkamFuZ28uZGIgaW1wb3J0IG1vZGVscworCisKK2NsYXNzIEJ1aWxkZXJNYXBwaW5ncyht b2RlbHMuTW9kZWwpOgorICAgIGJ1aWxkZXJpZCA9IG1vZGVscy5JbnRlZ2VyRmllbGQocHJpbWFy eV9rZXk9VHJ1ZSkKKyAgICBuYW1lID0gbW9kZWxzLlRleHRGaWVsZCgpCisKKyAgICBkZWYgX19z dHJfXyhzZWxmKToKKyAgICAgICAgcmV0dXJuICJ7fToge30iLmZvcm1hdChzZWxmLmJ1aWxkZXJp ZCwgc2VsZi5uYW1lKQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mv bW9kZWxzL2J1aWxkZXJtYXBwaW5nLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9idWlsZGVybWFwcGluZy5weQkocmV2aXNpb24gMjQw MzQ3KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxk ZXJtYXBwaW5nLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNSw3ICsyNSw3IEBAIGZyb20gX19mdXR1 cmVfXyBpbXBvcnQgdW5pY29kZV9saXRlcmFscwogZnJvbSBkamFuZ28uZGIgaW1wb3J0IG1vZGVs cwogCiAKLWNsYXNzIEJ1aWxkZXJNYXBwaW5ncyhtb2RlbHMuTW9kZWwpOgorY2xhc3MgQnVpbGRl ck1hcHBpbmcobW9kZWxzLk1vZGVsKToKICAgICBidWlsZGVyaWQgPSBtb2RlbHMuSW50ZWdlckZp ZWxkKHByaW1hcnlfa2V5PVRydWUpCiAgICAgbmFtZSA9IG1vZGVscy5UZXh0RmllbGQoKQogCklu ZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvYnVpbGRlcm1h cHBpbmdzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAv ZXdzL21vZGVscy9idWlsZGVybWFwcGluZ3MucHkJKHJldmlzaW9uIDI0MDM0NykKKysrIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9idWlsZGVybWFwcGluZ3MucHkJ KG5vbmV4aXN0ZW50KQpAQCAtMSwzMyArMCwwIEBACi0jIENvcHlyaWdodCAoQykgMjAxOCBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0jCi0jIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAotIyBtb2RpZmljYXRp b24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMK LSMgYXJlIG1ldDoKLSMgMS4gIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJl dGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Ci0jICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25k aXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCi0jIDIuICBSZWRpc3RyaWJ1dGlv bnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAotIyAg ICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNj bGFpbWVyIGluIHRoZQotIyAgICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxz IHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KLSMKLSMgVEhJUyBTT0ZUV0FSRSBJUyBQ Uk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJyBBTkQK LSMgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1Qg TElNSVRFRCBUTywgVEhFIElNUExJRUQKLSMgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkg QU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRQotIyBESVNDTEFJTUVELiBJ TiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMgQkUgTElBQkxF IEZPUgotIyBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBM QVJZLCBPUiBDT05TRVFVRU5USUFMCi0jIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1J VEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SCi0jIFNFUlZJQ0VTOyBM T1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBI T1dFVkVSCi0jIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIg SU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksCi0jIE9SIFRPUlQgKElOQ0xVRElORyBORUdM SUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCi0j IE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0Yg U1VDSCBEQU1BR0UuCi0KLWZyb20gX19mdXR1cmVfXyBpbXBvcnQgdW5pY29kZV9saXRlcmFscwot Ci1mcm9tIGRqYW5nby5kYiBpbXBvcnQgbW9kZWxzCi0KLQotY2xhc3MgQnVpbGRlck1hcHBpbmdz KG1vZGVscy5Nb2RlbCk6Ci0gICAgYnVpbGRlcmlkID0gbW9kZWxzLkludGVnZXJGaWVsZChwcmlt YXJ5X2tleT1UcnVlKQotICAgIG5hbWUgPSBtb2RlbHMuVGV4dEZpZWxkKCkKLQotICAgIGRlZiBf X3N0cl9fKHNlbGYpOgotICAgICAgICByZXR1cm4gInt9OiB7fSIuZm9ybWF0KHNlbGYuYnVpbGRl cmlkLCBzZWxmLm5hbWUpCg==