193695 2019-01-22 16:04:46 -0800 [ews-app] Rename ews model Builds to Build 2019-01-23 13:38:48 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193697 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue kocsen_chung lforschler webkit-bug-importer oldest_to_newest 1497055 0 aakash_jain 2019-01-22 16:04:46 -0800 The recommended naming convention for models in Django is to use singular noun. Therefore, we should rename 'Builds' to 'Build' in ews-app model. 1497105 1 359812 aakash_jain 2019-01-22 17:04:01 -0800 Created attachment 359812 Proposed patch 1497441 2 359908 aakash_jain 2019-01-23 11:18:01 -0800 Created attachment 359908 Proposed patch 1497446 3 kocsen_chung 2019-01-23 11:20:30 -0800 r+; looks good to me. 1497540 4 359908 commit-queue 2019-01-23 13:37:35 -0800 Comment on attachment 359908 Proposed patch Clearing flags on attachment: 359908 Committed r240357: <https://trac.webkit.org/changeset/240357> 1497541 5 commit-queue 2019-01-23 13:37:37 -0800 All reviewed patches have been landed. Closing bug. 1497542 6 webkit-bug-importer 2019-01-23 13:38:48 -0800 <rdar://problem/47492092> 359812 2019-01-22 17:04:01 -0800 2019-01-23 11:18:01 -0800 Proposed patch 0001-ews-app-Rename-ews-model-Builds-to-Build.patch text/plain 2927 aakash_jain RnJvbSBhMDA3NWEwZjJlYmQ2MzQ5NzBmNDA3NjYwYTNjYzIwODY4ZjdhYjhhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYWthc2ggSmFpbiA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgpE YXRlOiBUdWUsIDIyIEphbiAyMDE5IDE5OjA2OjIwIC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gW2V3 cy1hcHBdIFJlbmFtZSBld3MgbW9kZWwgQnVpbGRzIHRvIEJ1aWxkCiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzNjk1CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KCiogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkLnB5OiBSZW5h bWVkIGZyb20gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxk cy5weS4KKEJ1aWxkKTogUmVuYW1lZCBCdWlsZHMgdG8gQnVpbGQuCi0tLQogLi4uL2V3cy1hcHAv ZXdzL21vZGVscy97YnVpbGRzLnB5ID0+IGJ1aWxkLnB5fSAgICAgICAgIHwgIDIgKy0KIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwcy5weSAgICB8ICA0ICsr LS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB8IDEwICsrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKIHJlbmFtZSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9t b2RlbHMve2J1aWxkcy5weSA9PiBidWlsZC5weX0gKDk4JSkKCmRpZmYgLS1naXQgYS9Ub29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvYnVpbGRzLnB5IGIvVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkLnB5CnNpbWlsYXJpdHkgaW5k ZXggOTglCnJlbmFtZSBmcm9tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21v ZGVscy9idWlsZHMucHkKcmVuYW1lIHRvIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAv ZXdzL21vZGVscy9idWlsZC5weQppbmRleCBkZTE4ZjJjNjg3Ny4uNDZiNGIyNzhjMzAgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9idWlsZHMu cHkKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxk LnB5CkBAIC0yNiw3ICsyNiw3IEBAIGZyb20gZGphbmdvLmRiIGltcG9ydCBtb2RlbHMKIGZyb20g ZXdzLm1vZGVscy5wYXRjaCBpbXBvcnQgUGF0Y2gKIAogCi1jbGFzcyBCdWlsZHMobW9kZWxzLk1v ZGVsKToKK2NsYXNzIEJ1aWxkKG1vZGVscy5Nb2RlbCk6CiAgICAgcGF0Y2ggPSBtb2RlbHMuRm9y ZWlnbktleShQYXRjaCwgb25fZGVsZXRlPW1vZGVscy5DQVNDQURFKQogICAgIGJ1aWxkaWQgPSBt b2RlbHMuSW50ZWdlckZpZWxkKHByaW1hcnlfa2V5PVRydWUpCiAgICAgYnVpbGRlcmlkID0gbW9k ZWxzLkludGVnZXJGaWVsZCgpCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYXBwL2V3cy9tb2RlbHMvc3RlcHMucHkgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3Mt YXBwL2V3cy9tb2RlbHMvc3RlcHMucHkKaW5kZXggZGFlOGY1MzYyNDcuLmRkMzNkNGEwNGJlIDEw MDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvc3Rl cHMucHkKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0 ZXBzLnB5CkBAIC0yMywxMiArMjMsMTIgQEAKIGZyb20gX19mdXR1cmVfXyBpbXBvcnQgdW5pY29k ZV9saXRlcmFscwogCiBmcm9tIGRqYW5nby5kYiBpbXBvcnQgbW9kZWxzCi1mcm9tIGV3cy5tb2Rl bHMuYnVpbGRzIGltcG9ydCBCdWlsZHMKK2Zyb20gZXdzLm1vZGVscy5idWlsZHMgaW1wb3J0IEJ1 aWxkCiAKIAogY2xhc3MgU3RlcHMobW9kZWxzLk1vZGVsKToKICAgICBzdGVwaWQgPSBtb2RlbHMu SW50ZWdlckZpZWxkKHByaW1hcnlfa2V5PVRydWUpCi0gICAgYnVpbGQgPSBtb2RlbHMuRm9yZWln bktleShCdWlsZHMsIG9uX2RlbGV0ZT1tb2RlbHMuQ0FTQ0FERSkKKyAgICBidWlsZCA9IG1vZGVs cy5Gb3JlaWduS2V5KEJ1aWxkLCBvbl9kZWxldGU9bW9kZWxzLkNBU0NBREUpCiAgICAgcmVzdWx0 ID0gbW9kZWxzLkludGVnZXJGaWVsZCgpCiAgICAgc3RhdGVfc3RyaW5nID0gbW9kZWxzLlRleHRG aWVsZCgpCiAgICAgc3RhcnRlZF9hdCA9IG1vZGVscy5JbnRlZ2VyRmllbGQoKQpkaWZmIC0tZ2l0 IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDBkY2ZlZGU2MDNmLi40 MjU2NzJhNzRmNiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTAxLTIyICBBYWthc2ggSmFpbiAgPGFha2FzaF9q YWluQGFwcGxlLmNvbT4KKworICAgICAgICBbZXdzLWFwcF0gUmVuYW1lIGV3cyBtb2RlbCBCdWls ZHMgdG8gQnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MzY5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkLnB5OiBSZW5h bWVkIGZyb20gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxk cy5weS4KKyAgICAgICAgKEJ1aWxkKTogUmVuYW1lZCBCdWlsZHMgdG8gQnVpbGQuCisKIDIwMTkt MDEtMjIgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFti dWlsZC53ZWJraXQub3JnXSBVbml0LXRlc3QgZmFpbHVyZSBhZnRlciByMjM3MTEzCi0tIAoyLjE3 LjIgKEFwcGxlIEdpdC0xMTMpCgo= 359908 2019-01-23 11:18:01 -0800 2019-01-23 13:37:35 -0800 Proposed patch 0001-ews-app-Rename-ews-model-Builds-to-Build.patch text/plain 3411 aakash_jain RnJvbSAxMDk0ODU4ZTYxNjNmZjZlODRkNTQ2ODg1ZWMzNDcyMjJjOGE5ZDYzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBYWthc2ggSmFpbiA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgpE YXRlOiBXZWQsIDIzIEphbiAyMDE5IDEzOjMxOjMzIC0wNTAwClN1YmplY3Q6IFtQQVRDSCAxLzNd IFtld3MtYXBwXSBSZW5hbWUgZXdzIG1vZGVsIEJ1aWxkcyB0byBCdWlsZAogaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzY5NQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgoqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9idWlsZC5weTog UmVuYW1lZCBmcm9tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9i dWlsZHMucHkuCihCdWlsZCk6IFJlbmFtZWQgQnVpbGRzIHRvIEJ1aWxkLgotLS0KIFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9fX2luaXRfXy5weSB8ICAyICstCiAu Li4vZXdzLWFwcC9ld3MvbW9kZWxzL3tidWlsZHMucHkgPT4gYnVpbGQucHl9ICAgICAgICAgfCAg MiArLQogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL3N0ZXBzLnB5 ICAgIHwgIDQgKystLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgMTAgKysrKysrKysrKwogNCBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRp b25zKCspLCA0IGRlbGV0aW9ucygtKQogcmVuYW1lIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3 cy1hcHAvZXdzL21vZGVscy97YnVpbGRzLnB5ID0+IGJ1aWxkLnB5fSAoOTglKQoKZGlmZiAtLWdp dCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9fX2luaXRfXy5w eSBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9fX2luaXRfXy5w eQppbmRleCAyN2I0MWRkOTQyYS4uNDg2NDg0ZDc1NWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9fX2luaXRfXy5weQorKysgYi9Ub29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvX19pbml0X18ucHkKQEAgLTEsNCAr MSw0IEBACiBmcm9tIGJ1aWxkZXJtYXBwaW5ncyBpbXBvcnQgKgotZnJvbSBidWlsZHMgaW1wb3J0 ICoKK2Zyb20gYnVpbGQgaW1wb3J0ICoKIGZyb20gcGF0Y2ggaW1wb3J0ICoKIGZyb20gc3RlcHMg aW1wb3J0ICoKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdz L21vZGVscy9idWlsZHMucHkgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9t b2RlbHMvYnVpbGQucHkKc2ltaWxhcml0eSBpbmRleCA5OCUKcmVuYW1lIGZyb20gVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkcy5weQpyZW5hbWUgdG8gVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkLnB5CmluZGV4IGRl MThmMmM2ODc3Li40NmI0YjI3OGMzMCAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWFwcC9ld3MvbW9kZWxzL2J1aWxkcy5weQorKysgYi9Ub29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvYnVpbGQucHkKQEAgLTI2LDcgKzI2LDcgQEAgZnJvbSBk amFuZ28uZGIgaW1wb3J0IG1vZGVscwogZnJvbSBld3MubW9kZWxzLnBhdGNoIGltcG9ydCBQYXRj aAogCiAKLWNsYXNzIEJ1aWxkcyhtb2RlbHMuTW9kZWwpOgorY2xhc3MgQnVpbGQobW9kZWxzLk1v ZGVsKToKICAgICBwYXRjaCA9IG1vZGVscy5Gb3JlaWduS2V5KFBhdGNoLCBvbl9kZWxldGU9bW9k ZWxzLkNBU0NBREUpCiAgICAgYnVpbGRpZCA9IG1vZGVscy5JbnRlZ2VyRmllbGQocHJpbWFyeV9r ZXk9VHJ1ZSkKICAgICBidWlsZGVyaWQgPSBtb2RlbHMuSW50ZWdlckZpZWxkKCkKZGlmZiAtLWdp dCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwcy5weSBi L1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwcy5weQppbmRl eCBkYWU4ZjUzNjI0Ny4uODIxYjI5NTgyYmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1hcHAvZXdzL21vZGVscy9zdGVwcy5weQorKysgYi9Ub29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYXBwL2V3cy9tb2RlbHMvc3RlcHMucHkKQEAgLTIzLDEyICsyMywxMiBAQAog ZnJvbSBfX2Z1dHVyZV9fIGltcG9ydCB1bmljb2RlX2xpdGVyYWxzCiAKIGZyb20gZGphbmdvLmRi IGltcG9ydCBtb2RlbHMKLWZyb20gZXdzLm1vZGVscy5idWlsZHMgaW1wb3J0IEJ1aWxkcworZnJv bSBld3MubW9kZWxzLmJ1aWxkIGltcG9ydCBCdWlsZAogCiAKIGNsYXNzIFN0ZXBzKG1vZGVscy5N b2RlbCk6CiAgICAgc3RlcGlkID0gbW9kZWxzLkludGVnZXJGaWVsZChwcmltYXJ5X2tleT1UcnVl KQotICAgIGJ1aWxkID0gbW9kZWxzLkZvcmVpZ25LZXkoQnVpbGRzLCBvbl9kZWxldGU9bW9kZWxz LkNBU0NBREUpCisgICAgYnVpbGQgPSBtb2RlbHMuRm9yZWlnbktleShCdWlsZCwgb25fZGVsZXRl PW1vZGVscy5DQVNDQURFKQogICAgIHJlc3VsdCA9IG1vZGVscy5JbnRlZ2VyRmllbGQoKQogICAg IHN0YXRlX3N0cmluZyA9IG1vZGVscy5UZXh0RmllbGQoKQogICAgIHN0YXJ0ZWRfYXQgPSBtb2Rl bHMuSW50ZWdlckZpZWxkKCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0No YW5nZUxvZwppbmRleCAwZGNmZWRlNjAzZi4uNDI1NjcyYTc0ZjYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOS0w MS0yMiAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CisKKyAgICAgICAgW2V3 cy1hcHBdIFJlbmFtZSBld3MgbW9kZWwgQnVpbGRzIHRvIEJ1aWxkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTM2OTUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1h cHAvZXdzL21vZGVscy9idWlsZC5weTogUmVuYW1lZCBmcm9tIFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2V3cy1hcHAvZXdzL21vZGVscy9idWlsZHMucHkuCisgICAgICAgIChCdWlsZCk6IFJlbmFt ZWQgQnVpbGRzIHRvIEJ1aWxkLgorCiAyMDE5LTAxLTIyICBBYWthc2ggSmFpbiAgPGFha2FzaF9q YWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gVW5pdC10ZXN0IGZh aWx1cmUgYWZ0ZXIgcjIzNzExMwotLSAKMi4xNy4yIChBcHBsZSBHaXQtMTEzKQoK