193636 2019-01-20 18:42:08 -0800 REGRESSION(r240117): [SOUP] Layout test imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html is timing out 2019-10-09 05:30:14 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro webkit-unassigned aboya achristensen bugs-noreply cgarcia oldest_to_newest 1496466 0 mcatanzaro 2019-01-20 18:42:08 -0800 Something in the range of r240117-240121 has caused layout test imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https.html to time out for WPE/GTK. And the only likely suspect there is r240117 "Stop using NetworkStorageSession::storageSession in WebCore". Alex, any suspicions here? --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https-actual.txt @@ -1,3 +1,5 @@ -FAIL Verify WebSockets can be created in a Service Worker assert_equals: expected "PASS" but got "FAIL: Got an error event" +Harness Error (TIMEOUT), message = null +TIMEOUT Verify WebSockets can be created in a Service Worker Test timed out + 1556610 1 achristensen 2019-07-29 10:42:46 -0700 If I were looking into this I would first try the revision before and after that to verify that was the change that broke it. Then I'd look at the soup-specific code in SocketStreamHandleImpl::create and see if nullptr is being passed. My guess is before there was some kind of fallback to "the default" storage and now it needs to be explicit. I'd add a new fallback in the soup code if that's what you want, or even better: find a way to pass the proper session to the socket stream. 1556908 2 cgarcia 2019-07-30 01:04:39 -0700 SocketStreamHandleImplSoup is going to die soon (hopefully, see bug #200162). I'll check this again after the switch to the libsoup API. 1556996 3 achristensen 2019-07-30 10:23:59 -0700 Your bug may have been fixed by https://bugs.webkit.org/show_bug.cgi?id=199906 1578196 4 aboya 2019-10-09 05:30:14 -0700 Passing in last runs.