19363 2008-06-02 15:34:31 -0700 Compiler error in Entity.h 2008-06-03 00:57:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Major --- 0 avasilev webkit-unassigned oldest_to_newest 82167 0 avasilev 2008-06-02 15:34:31 -0700 Compiling WebKit with MINGW, cygwin environment. Compiler says that class Entity has a default constructor but its base class ContainerNode doesn't have a default constructor. From what I found the Entity class is there only for compatibility, so I made a temporary fix with teh attached patch, but I hope someone competent can solve the problem the right way. 82168 1 21470 avasilev 2008-06-02 15:36:24 -0700 Created attachment 21470 proposed temporary fix 82180 2 21470 ap 2008-06-03 00:56:51 -0700 Comment on attachment 21470 proposed temporary fix I think that this is basically the right fix. I'll land it with some modifications. + Entity(): ContainerNode(0){}; We'd write this as + Entity() : ContainerNode(0) {} Also, the constructor should be private for clarity. 82181 3 ap 2008-06-03 00:57:59 -0700 Fixed in <http://trac.webkit.org/changeset/34336>. 21470 2008-06-02 15:36:24 -0700 2008-06-03 00:56:51 -0700 proposed temporary fix wxwebkit_Entity_patch.patch text/plain 552 avasilev SW5kZXg6IFdlYkNvcmUvZG9tL0VudGl0eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL0Vu dGl0eS5oCShyZXZpc2lvbiAzNDI2NykKKysrIFdlYkNvcmUvZG9tL0VudGl0eS5oCSh3b3JraW5n IGNvcHkpCkBAIC0zMCw2ICszMCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIC8vIGNhbiBjb250 aW51ZSB0byBiZSBjb21waWxlZC4KIGNsYXNzIEVudGl0eSA6IHB1YmxpYyBDb250YWluZXJOb2Rl IHsKIHB1YmxpYzoKKyAgICBFbnRpdHkoKTogQ29udGFpbmVyTm9kZSgwKXt9OwogICAgIFN0cmlu ZyBwdWJsaWNJZCgpIGNvbnN0IHsgQVNTRVJUX05PVF9SRUFDSEVEKCk7IHJldHVybiBTdHJpbmco KTsgfQogICAgIFN0cmluZyBzeXN0ZW1JZCgpIGNvbnN0IHsgQVNTRVJUX05PVF9SRUFDSEVEKCk7 IHJldHVybiBTdHJpbmcoKTsgfQogICAgIFN0cmluZyBub3RhdGlvbk5hbWUoKSBjb25zdCB7IEFT U0VSVF9OT1RfUkVBQ0hFRCgpOyByZXR1cm4gU3RyaW5nKCk7IH0K