19360 2008-06-02 11:17:07 -0700 Frags on current page don't generate "navigation-requested" events 2009-08-18 14:49:03 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 Don webkit-unassigned a9016009 alp dmacks fpeters gustavo oldest_to_newest 82135 0 Don 2008-06-02 11:17:07 -0700 While trying to make yelp (the GNOME help browser) work with Webkit, I've hit the following issue (copy-paste of an email I originally sent to Alp directly): I've uploaded an example program to: http://www.gnome.org/~dscorgie/webkit_frags.c The basic problem is that anchor points to current documents sometimes doesn't emit a "navigation-request" signal. The example program (compiled with: gcc -o main webkit_frags.c `pkg-config --cflags --libs webkit-1.0` ) produces a page with 2 anchors and 2 links in it. The first link looks like: <a href="#link1"> while the second looks like: <a href="out.xhtml#link2"> When run without parameters, the example will set the base URI to: "file://out.xhtml". In this case, clicking the first link will move to the corresponding anchor, but not generate the "navigation-requested" event (as denoted by a message to stdout). The program can take a second parameter, which specifies the base URI. If this is set to: "out.xhtml", the navigation-requested signal is generated, but the page doesn't jump. "/out.xhtml" the navigation-signal is NOT generated and the page jumps. "file:out" &#65279;the navigation-signal is NOT generated and the page jumps. "out" the navigation-signal is &#65279;generated, but the page doesn't jump. Anyway, the basic pattern seems to be a signal is only generated when the base URI doesn't contain a ":" or "/" character. This is a bit of a problem for us as gnome-doc-utils (which generates our xhtml) tends to create links using "#frag" for pages in the same document, but not on the same page. The way we get around this is to intercept links clicked and handle them ourselves. Long ramblings later, I'm done. Any help with this would be appreciated. 132933 1 gustavo 2009-07-18 11:13:38 -0700 Hey. I'm looking at Yelp, and noticed this bug in a comment. I may have misunderstood something about the problem, but I think this problem is gone for a while now. The signal is emitted in both links of the example for me, without passing arguments for the program. Can you confirm my investigation is correct? 133774 2 fpeters 2009-07-22 08:39:14 -0700 I traced it back to FrameLoader::checkNavigationPolicy, which exits early at // We are always willing to show alternate content for unreachable URLs; // treat it like a reload so it maintains the right state for b/f list. if (loader->substituteData().isValid() && !loader->substituteData().failingURL().isEmpty()) { if (isBackForwardLoadType(m_policyLoadType)) m_policyLoadType = FrameLoadTypeReload; function(argument, request, 0, true); return; } and therefore skips the m_client->dispatchDecidePolicyForNavigationAction() which would emit the signal. From there, however, I do not know where to go :/ 141190 3 35066 gustavo 2009-08-18 13:27:15 -0700 Created attachment 35066 fix SubstituteData creation WebKit/gtk/ChangeLog | 13 +++++++++++++ WebKit/gtk/webkit/webkitwebframe.cpp | 4 ++-- 2 files changed, 15 insertions(+), 2 deletions(-) 141191 4 35066 xan.lopez 2009-08-18 13:31:35 -0700 Comment on attachment 35066 fix SubstituteData creation r=me 141208 5 35071 gustavo 2009-08-18 14:00:06 -0700 Created attachment 35071 fix SubstituteData creation WebKit/gtk/ChangeLog | 14 ++++++++++++++ WebKit/gtk/webkit/webkitwebframe.cpp | 2 +- 2 files changed, 15 insertions(+), 1 deletions(-) 141209 6 35072 gustavo 2009-08-18 14:01:05 -0700 Created attachment 35072 fix SubstituteData creation WebKit/gtk/ChangeLog | 14 ++++++++++++++ WebKit/gtk/webkit/webkitwebframe.cpp | 2 +- 2 files changed, 15 insertions(+), 1 deletions(-) 141210 7 35072 gustavo 2009-08-18 14:02:55 -0700 Comment on attachment 35072 fix SubstituteData creation Sorry for the spam. So, it looks like we are also using the baseKURL incorrectly. This patch makes both the normal reload, and the 'try again' work on error pages, in addition to fixing this bug. 141256 8 35072 jmalonzo 2009-08-18 14:45:14 -0700 Comment on attachment 35072 fix SubstituteData creation r=me 141259 9 gustavo 2009-08-18 14:49:03 -0700 Landed as r47457. 35066 2009-08-18 13:27:15 -0700 2009-08-18 14:00:22 -0700 fix SubstituteData creation fix-SubstituteData-creation.patch text/plain 1652 gustavo OTdiNGNhYzc0MTViMzg3NDQ2ZTVkMGY2NGMyZWE1NGZiY2JmZjViZApkaWZmIC0tZ2l0IGEvV2Vi S2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA2ZjY2NTJlLi45 MDdlYTNkIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3Rr L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTA4LTE4ICBHdXN0YXZvIE5vcm9uaGEg U2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTM2MAorICAgICAgICBGcmFncyBvbiBjdXJyZW50IHBhZ2UgZG9u J3QgZ2VuZXJhdGUgIm5hdmlnYXRpb24tcmVxdWVzdGVkIiBldmVudHMKKworICAgICAgICBGaXgg b3JkZXIgb2YgcGFyYW1ldGVycyBmb3IgdGhlIGNyZWF0aW9uIG9mIFN1YnN0aXR1dGVEYXRhIG9i amVjdCwKKyAgICAgICAgc28gdGhhdCBub3JtYWwgZGF0YSBsb2FkcyBkbyBub3QgaGF2ZSBhbiB1 bnJlYWNoYWJsZSBVUkwuCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwOgor ICAgICAgICAod2Via2l0X3dlYl9mcmFtZV9sb2FkX2RhdGEpOgorCiAyMDA5LTA4LTE1ICBaYW4g RG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg WGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViZnJhbWUu Y3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwCmluZGV4IDdlMmNlNDUu LjA1NGQyYzkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNw cAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAKQEAgLTQ0Myw4ICs0 NDMsOCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX2ZyYW1lX2xvYWRfZGF0YShXZWJLaXRXZWJG cmFtZSogZnJhbWUsIGNvbnN0IGdjaGFyKiBjb250ZQogICAgIFN1YnN0aXR1dGVEYXRhIHN1YnN0 aXR1dGVEYXRhKHNoYXJlZEJ1ZmZlci5yZWxlYXNlKCksCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgbWltZVR5cGUgPyBTdHJpbmc6OmZyb21VVEY4KG1pbWVUeXBlKSA6IFN0cmlu Zzo6ZnJvbVVURjgoInRleHQvaHRtbCIpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGVuY29kaW5nID8gU3RyaW5nOjpmcm9tVVRGOChlbmNvZGluZykgOiBTdHJpbmc6OmZyb21V VEY4KCJVVEYtOCIpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJhc2VLVVJM LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEtVUkwoS1VSTCgpLCBTdHJpbmc6 OmZyb21VVEY4KHVucmVhY2hhYmxlVVJMKSkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIEtVUkwoS1VSTCgpLCBTdHJpbmc6OmZyb21VVEY4KHVucmVhY2hhYmxlVVJMKSksCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYmFzZUtVUkwpOwogCiAgICAgY29yZUZy YW1lLT5sb2FkZXIoKS0+bG9hZChyZXF1ZXN0LCBzdWJzdGl0dXRlRGF0YSwgZmFsc2UpOwogfQo= 35071 2009-08-18 14:00:06 -0700 2009-08-18 14:00:06 -0700 fix SubstituteData creation -fix-SubstituteData-creation.patch text/plain 1677 gustavo Y2NlNzllOGNiNzMxMjA2ZDQzOGYxYzU1YzVhZGFlMDBiZmZhZDZlMQpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA2ZjY2NTJlLi5k YzMzMmEyIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3Rr L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDA5LTA4LTE4ICBHdXN0YXZvIE5vcm9uaGEg U2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTM2MAorICAgICAgICBGcmFncyBvbiBjdXJyZW50IHBhZ2UgZG9u J3QgZ2VuZXJhdGUgIm5hdmlnYXRpb24tcmVxdWVzdGVkIiBldmVudHMKKworICAgICAgICBGaXgg b3JkZXIgb2YgcGFyYW1ldGVycyBmb3IgdGhlIGNyZWF0aW9uIG9mIFN1YnN0aXR1dGVEYXRhIG9i amVjdCwKKyAgICAgICAgc28gdGhhdCBub3JtYWwgZGF0YSBsb2FkcyBkbyBub3QgaGF2ZSBhbiB1 bnJlYWNoYWJsZSBVUkwuIEFsc28KKyAgICAgICAgcmVtb3ZlIGEgY29uZnVzaW9uIGFib3V0IHRo ZSBwdXJwb3NlIG9mIHRoZSBsYXN0IHBhcmFtZXRlci4KKworICAgICAgICAqIHdlYmtpdC93ZWJr aXR3ZWJmcmFtZS5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX2ZyYW1lX2xvYWRfZGF0YSk6CisK IDIwMDktMDgtMTUgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJmcmFtZS5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5j cHAKaW5kZXggN2UyY2U0NS4uMDQ2MjdhZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2ViZnJhbWUuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1l LmNwcApAQCAtNDQzLDcgKzQ0Myw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfZnJhbWVfbG9h ZF9kYXRhKFdlYktpdFdlYkZyYW1lKiBmcmFtZSwgY29uc3QgZ2NoYXIqIGNvbnRlCiAgICAgU3Vi c3RpdHV0ZURhdGEgc3Vic3RpdHV0ZURhdGEoc2hhcmVkQnVmZmVyLnJlbGVhc2UoKSwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtaW1lVHlwZSA/IFN0cmluZzo6ZnJvbVVURjgo bWltZVR5cGUpIDogU3RyaW5nOjpmcm9tVVRGOCgidGV4dC9odG1sIiksCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZW5jb2RpbmcgPyBTdHJpbmc6OmZyb21VVEY4KGVuY29kaW5n KSA6IFN0cmluZzo6ZnJvbVVURjgoIlVURi04IiksCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgYmFzZUtVUkwsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgS1VS TChLVVJMKCksIFN0cmluZzo6ZnJvbVVURjgodW5yZWFjaGFibGVVUkwpKSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBLVVJMKEtVUkwoKSwgU3RyaW5nOjpmcm9tVVRGOCh1bnJl YWNoYWJsZVVSTCkpKTsKIAogICAgIGNvcmVGcmFtZS0+bG9hZGVyKCktPmxvYWQocmVxdWVzdCwg c3Vic3RpdHV0ZURhdGEsIGZhbHNlKTsK 35072 2009-08-18 14:01:05 -0700 2009-08-18 14:45:14 -0700 fix SubstituteData creation -fix-SubstituteData-creation.patch text/plain 1677 gustavo Y2NlNzllOGNiNzMxMjA2ZDQzOGYxYzU1YzVhZGFlMDBiZmZhZDZlMQpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2d0ay9DaGFuZ2VMb2cgYi9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCA2ZjY2NTJlLi5k YzMzMmEyIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZworKysgYi9XZWJLaXQvZ3Rr L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDA5LTA4LTE4ICBHdXN0YXZvIE5vcm9uaGEg U2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTM2MAorICAgICAgICBGcmFncyBvbiBjdXJyZW50IHBhZ2UgZG9u J3QgZ2VuZXJhdGUgIm5hdmlnYXRpb24tcmVxdWVzdGVkIiBldmVudHMKKworICAgICAgICBGaXgg b3JkZXIgb2YgcGFyYW1ldGVycyBmb3IgdGhlIGNyZWF0aW9uIG9mIFN1YnN0aXR1dGVEYXRhIG9i amVjdCwKKyAgICAgICAgc28gdGhhdCBub3JtYWwgZGF0YSBsb2FkcyBkbyBub3QgaGF2ZSBhbiB1 bnJlYWNoYWJsZSBVUkwuIEFsc28KKyAgICAgICAgcmVtb3ZlIGEgY29uZnVzaW9uIGFib3V0IHRo ZSBwdXJwb3NlIG9mIHRoZSBsYXN0IHBhcmFtZXRlci4KKworICAgICAgICAqIHdlYmtpdC93ZWJr aXR3ZWJmcmFtZS5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX2ZyYW1lX2xvYWRfZGF0YSk6CisK IDIwMDktMDgtMTUgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJmcmFtZS5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5j cHAKaW5kZXggN2UyY2U0NS4uMDQ2MjdhZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2ViZnJhbWUuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1l LmNwcApAQCAtNDQzLDcgKzQ0Myw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfZnJhbWVfbG9h ZF9kYXRhKFdlYktpdFdlYkZyYW1lKiBmcmFtZSwgY29uc3QgZ2NoYXIqIGNvbnRlCiAgICAgU3Vi c3RpdHV0ZURhdGEgc3Vic3RpdHV0ZURhdGEoc2hhcmVkQnVmZmVyLnJlbGVhc2UoKSwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtaW1lVHlwZSA/IFN0cmluZzo6ZnJvbVVURjgo bWltZVR5cGUpIDogU3RyaW5nOjpmcm9tVVRGOCgidGV4dC9odG1sIiksCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZW5jb2RpbmcgPyBTdHJpbmc6OmZyb21VVEY4KGVuY29kaW5n KSA6IFN0cmluZzo6ZnJvbVVURjgoIlVURi04IiksCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgYmFzZUtVUkwsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgS1VS TChLVVJMKCksIFN0cmluZzo6ZnJvbVVURjgodW5yZWFjaGFibGVVUkwpKSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBLVVJMKEtVUkwoKSwgU3RyaW5nOjpmcm9tVVRGOCh1bnJl YWNoYWJsZVVSTCkpKTsKIAogICAgIGNvcmVGcmFtZS0+bG9hZGVyKCktPmxvYWQocmVxdWVzdCwg c3Vic3RpdHV0ZURhdGEsIGZhbHNlKTsK