193579 2019-01-18 09:49:09 -0800 Duplicate tests between canvas/philip/tests and imported/w3c/canvas 2019-01-21 01:07:02 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=193042 https://bugs.webkit.org/show_bug.cgi?id=179769 P2 Normal --- 1 ddkilzer webkit-unassigned cdumez dino jlewis3 lforschler Ms2ger rniwa ryanhaddad simon.fraser oldest_to_newest 1495889 0 ddkilzer 2019-01-18 09:49:09 -0800 There appear to be a large number of duplicate tests between canvas/philip/tests and imported/w3c/canvas in the LayoutTests directory. Removing the duplicate tests could marginally speed up layout test runs. 1495890 1 ddkilzer 2019-01-18 09:49:46 -0800 The canvas/philip/tests were imported in <https://trac.webkit.org/r59954> on May 14, 2010 long before the W3C test suite existed. It seems like these tests have been upstreamed to the W3C test suite, but the older copies have not all been removed. In fact, there appear to be 741 tests that are duplicates by name: $ ls `find LayoutTests/canvas/philip/tests -name \*.html | sed -e 's#canvas/philip/tests#imported/w3c/canvas#'` 2> /dev/null | wc -l 741 And there are 34 tests that only exist in canvas/philip/tests: $ ls `find LayoutTests/canvas/philip/tests -name \*.html | sed -e 's#canvas/philip/tests#imported/w3c/canvas#'` > /dev/null ls: LayoutTests/imported/w3c/canvas/2d.clearRect+fillRect.alpha0.5.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.clearRect+fillRect.alpha0.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.clearRect+fillRect.basic.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.composite.globalComposite.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.composite.operation.foobar.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.composite.operation.nullsuffix.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.drawImage.incomplete.emptysrc.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.drawImage.incomplete.nosrc.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.drawImage.incomplete.removedsrc.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.drawImage.negativeSourceHeight.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.drawImage.negativeSourceHeight2.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.drawImage.negativeSourceHeightAndWidth.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.drawImage.outsidesource.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.line.cap.invalid.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.line.join.invalid.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.missingargs.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.pattern.image.broken.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.pattern.image.incomplete.emptysrc.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.pattern.image.incomplete.removedsrc.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.pattern.repeat.nullsuffix.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.strokeRect.zero.4.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text-custom-font-load-crash.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text.align.invalid.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text.baseline.invalid.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text.draw.baseline.bottom.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text.draw.baseline.hanging.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text.draw.baseline.ideographic.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text.draw.baseline.middle.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text.draw.baseline.top.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text.draw.space.collapse.end.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text.draw.space.collapse.other.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text.draw.space.collapse.space.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text.draw.space.collapse.start.html: No such file or directory ls: LayoutTests/imported/w3c/canvas/2d.text.measure.width.space.html: No such file or directory 1495891 2 ddkilzer 2019-01-18 09:50:57 -0800 I noticed this while working on finding leaks in WebKit2 tests, but I don't have time to investigate this right now (other than blindly removing the duplicate canvas/philip/tests--which I did not want to do), so filed this bug to track the issue. 1495942 3 simon.fraser 2019-01-18 11:22:32 -0800 See bug 193042