193505 2019-01-16 12:38:14 -0800 REGRESSION(r238168) Web Inspector: <iframe src=...> request does not show up in Network Tab 2019-04-16 14:28:31 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1495168 0 joepeck 2019-01-16 12:38:14 -0800 <iframe src=...> request does not show up in Network Tab Steps to reproduce: 1. Login to iCloud.com 2. Show the "iCloud Drive" app 3. Drill down and select a file 4. Tap the Download icon in the toolbar => <iframe src="..."> is added to page but network request doesn't show in Network Tab 1495169 1 webkit-bug-importer 2019-01-16 12:38:32 -0800 <rdar://problem/47325957> 1527821 2 joepeck 2019-04-16 12:34:51 -0700 Seems to have regressed with: https://trac.webkit.org/changeset/238168/webkit/trunk 1527859 3 367565 joepeck 2019-04-16 13:52:58 -0700 Created attachment 367565 [PATCH] Proposed Fix 1527867 4 367565 hi 2019-04-16 14:02:12 -0700 Comment on attachment 367565 [PATCH] Proposed Fix rs=me 1527873 5 367565 commit-queue 2019-04-16 14:28:30 -0700 Comment on attachment 367565 [PATCH] Proposed Fix Clearing flags on attachment: 367565 Committed r244358: <https://trac.webkit.org/changeset/244358> 1527874 6 commit-queue 2019-04-16 14:28:31 -0700 All reviewed patches have been landed. Closing bug. 367565 2019-04-16 13:52:58 -0700 2019-04-16 14:28:30 -0700 [PATCH] Proposed Fix frames-1.patch text/plain 3316 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNjNTNhYjFiOTYwLi43ZThkMWRiMWE5ZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDQtMTYgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIy MzgxNjgpIFdlYiBJbnNwZWN0b3I6IDxpZnJhbWUgc3JjPS4uLj4gcmVxdWVzdCBkb2VzIG5vdCBz aG93IHVwIGluIE5ldHdvcmsgVGFiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTM1MDUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ3MzI1OTU3Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLk5l dHdvcmtUYWJsZUNvbnRlbnRWaWV3KToKKyAgICAgICAgKFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRW aWV3LnByb3RvdHlwZS5faGFuZGxlRnJhbWVXYXNBZGRlZCk6CisgICAgICAgIEhhbmRsZSBuZXcg ZnJhbWVzIGJ5IGFkZGluZyB0aGUgZnJhbWUncyBtYWluIHJlc291cmNlLgorCiAyMDE5LTA0LTE1 ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogRE9NIE5vZGVzIHNob3VsZCBub3Qgc2hvdyAkMCB3aGVuIHNlbGVjdGVkIGluIENv bnNvbGUgYXJlYQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcwppbmRleCA4 NTIzZjBlMjFhNy4uYWEwODRhMWJiMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRl bnRWaWV3LmpzCkBAIC0xNjIsNiArMTYyLDcgQEAgV0kuTmV0d29ya1RhYmxlQ29udGVudFZpZXcg PSBjbGFzcyBOZXR3b3JrVGFibGVDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWUKICAg ICAgICAgV0kuVGFyZ2V0LmFkZEV2ZW50TGlzdGVuZXIoV0kuVGFyZ2V0LkV2ZW50LlJlc291cmNl QWRkZWQsIHRoaXMuX2hhbmRsZVJlc291cmNlQWRkZWQsIHRoaXMpOwogICAgICAgICBXSS5GcmFt ZS5hZGRFdmVudExpc3RlbmVyKFdJLkZyYW1lLkV2ZW50Lk1haW5SZXNvdXJjZURpZENoYW5nZSwg dGhpcy5fbWFpblJlc291cmNlRGlkQ2hhbmdlLCB0aGlzKTsKICAgICAgICAgV0kuRnJhbWUuYWRk RXZlbnRMaXN0ZW5lcihXSS5GcmFtZS5FdmVudC5SZXNvdXJjZVdhc0FkZGVkLCB0aGlzLl9oYW5k bGVSZXNvdXJjZUFkZGVkLCB0aGlzKTsKKyAgICAgICAgV0kuRnJhbWUuYWRkRXZlbnRMaXN0ZW5l cihXSS5GcmFtZS5FdmVudC5DaGlsZEZyYW1lV2FzQWRkZWQsIHRoaXMuX2hhbmRsZUZyYW1lV2Fz QWRkZWQsIHRoaXMpOwogICAgICAgICBXSS5SZXNvdXJjZS5hZGRFdmVudExpc3RlbmVyKFdJLlJl c291cmNlLkV2ZW50LkxvYWRpbmdEaWRGaW5pc2gsIHRoaXMuX3Jlc291cmNlTG9hZGluZ0RpZEZp bmlzaCwgdGhpcyk7CiAgICAgICAgIFdJLlJlc291cmNlLmFkZEV2ZW50TGlzdGVuZXIoV0kuUmVz b3VyY2UuRXZlbnQuTG9hZGluZ0RpZEZhaWwsIHRoaXMuX3Jlc291cmNlTG9hZGluZ0RpZEZhaWws IHRoaXMpOwogICAgICAgICBXSS5SZXNvdXJjZS5hZGRFdmVudExpc3RlbmVyKFdJLlJlc291cmNl LkV2ZW50LlRyYW5zZmVyU2l6ZURpZENoYW5nZSwgdGhpcy5fcmVzb3VyY2VUcmFuc2ZlclNpemVE aWRDaGFuZ2UsIHRoaXMpOwpAQCAtMTY2Nyw2ICsxNjY4LDIyIEBAIFdJLk5ldHdvcmtUYWJsZUNv bnRlbnRWaWV3ID0gY2xhc3MgTmV0d29ya1RhYmxlQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250 ZW50VmllCiAgICAgICAgIH0pOwogICAgIH0KIAorICAgIF9oYW5kbGVGcmFtZVdhc0FkZGVkKGV2 ZW50KQorICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX25lZWRzSW5pdGlhbFBvcHVsYXRlKQorICAg ICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHRoaXMuX3J1bkZvck1haW5Db2xsZWN0aW9uKChj b2xsZWN0aW9uKSA9PiB7CisgICAgICAgICAgICBsZXQgZnJhbWUgPSBldmVudC5kYXRhLmNoaWxk RnJhbWU7CisgICAgICAgICAgICBsZXQgbWFpblJlc291cmNlID0gZnJhbWUucHJvdmlzaW9uYWxN YWluUmVzb3VyY2UgfHwgZnJhbWUubWFpblJlc291cmNlOworICAgICAgICAgICAgY29uc29sZS5h c3NlcnQobWFpblJlc291cmNlLCAiRnJhbWUgc2hvdWxkIGhhdmUgYSBtYWluIHJlc291cmNlLiIp OworICAgICAgICAgICAgdGhpcy5faW5zZXJ0UmVzb3VyY2VBbmRSZWxvYWRUYWJsZShtYWluUmVz b3VyY2UpOworCisgICAgICAgICAgICBjb25zb2xlLmFzc2VydCghZnJhbWUucmVzb3VyY2VDb2xs ZWN0aW9uLnNpemUsICJOZXcgZnJhbWUgc2hvdWxkIGJlIGVtcHR5LiIpOworICAgICAgICAgICAg Y29uc29sZS5hc3NlcnQoIWZyYW1lLmNoaWxkRnJhbWVDb2xsZWN0aW9uLnNpemUsICJOZXcgZnJh bWUgc2hvdWxkIGJlIGVtcHR5LiIpOworICAgICAgICB9KTsKKyAgICB9CisKICAgICBfcnVuRm9y TWFpbkNvbGxlY3Rpb24oY2FsbGJhY2spCiAgICAgewogICAgICAgICBsZXQgY3VycmVudENvbGxl Y3Rpb24gPSB0aGlzLl9hY3RpdmVDb2xsZWN0aW9uOwpAQCAtMjA1Nyw3ICsyMDc0LDcgQEAgV0ku TmV0d29ya1RhYmxlQ29udGVudFZpZXcgPSBjbGFzcyBOZXR3b3JrVGFibGVDb250ZW50VmlldyBl eHRlbmRzIFdJLkNvbnRlbnRWaWUKIAogICAgICAgICBpZiAodGhpcy5faGFzVVJMRmlsdGVyKCkp IHsKICAgICAgICAgICAgIGZvciAobGV0IGVudHJ5IG9mIHRoaXMuX2FjdGl2ZUNvbGxlY3Rpb24u ZW50cmllcykKLSAgICAgICAgICAgICAgICB0aGlzLl9jaGVja1VSTEZpbHRlckFnYWluc3RSZXNv dXJjZShlbnRyeS5yZXNvdXJjZSk7ICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgdGhpcy5f Y2hlY2tVUkxGaWx0ZXJBZ2FpbnN0UmVzb3VyY2UoZW50cnkucmVzb3VyY2UpOwogICAgICAgICB9 CiAgICAgfQogCg==