193478 2019-01-15 18:22:56 -0800 [Mac] Add a new quirk to HTMLFormControlElement::isMouseFocusable 2026-04-02 18:34:06 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=311383 InRadar P2 Normal --- 267569 276709 296989 311383 1 jiewen_tan jiewen_tan bfulgham cdumez commit-queue karlcow rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1494952 0 jiewen_tan 2019-01-15 18:22:56 -0800 Add a new quirk to HTMLFormControlElement::isMouseFocusable such that submit buttons are mouse focusable. This quirk is for ceac.state.gov specifically. 1494953 1 jiewen_tan 2019-01-15 18:24:44 -0800 <rdar://problem/34368591> 1494954 2 359238 jiewen_tan 2019-01-15 18:31:21 -0800 Created attachment 359238 Patch 1494955 3 359238 jiewen_tan 2019-01-15 18:32:45 -0800 Comment on attachment 359238 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:661 > + The new line should be deleted. 1494977 4 359238 cdumez 2019-01-15 19:19:33 -0800 Comment on attachment 359238 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:662 > +bool HTMLFormControlElement::needsSiteSpecificQuirks() const The name should say what the quirk is about. What if we had more than one quirk? 1494978 5 359238 cdumez 2019-01-15 19:19:36 -0800 Comment on attachment 359238 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:662 > +bool HTMLFormControlElement::needsSiteSpecificQuirks() const The name should say what the quirk is about. What if we had more than one quirk? 1494987 6 359238 cdumez 2019-01-15 19:34:19 -0800 Comment on attachment 359238 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review > Source/WebCore/ChangeLog:9 > + Add a new quirk to HTMLFormControlElement::isMouseFocusable such that submit buttons are mouse focusable. Could you explain in the changelog why we do this behavior only for this site and not all sites? How do other browsers behave? >>> Source/WebCore/html/HTMLFormControlElement.cpp:662 >>> +bool HTMLFormControlElement::needsSiteSpecificQuirks() const >> >> The name should say what the quirk is about. What if we had more than one quirk? > > The name should say what the quirk is about. What if we had more than one quirk? E.g. needsMouseFocusableQuirk() 1495145 7 359238 jiewen_tan 2019-01-16 11:55:12 -0800 Comment on attachment 359238 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359238&action=review Thanks Chris for reviewing the patch. >> Source/WebCore/ChangeLog:9 >> + Add a new quirk to HTMLFormControlElement::isMouseFocusable such that submit buttons are mouse focusable. > > Could you explain in the changelog why we do this behavior only for this site and not all sites? How do other browsers behave? Sure, improved. >>>> Source/WebCore/html/HTMLFormControlElement.cpp:662 >>>> +bool HTMLFormControlElement::needsSiteSpecificQuirks() const >>> >>> The name should say what the quirk is about. What if we had more than one quirk? >> >> The name should say what the quirk is about. What if we had more than one quirk? > > E.g. needsMouseFocusableQuirk() Hopefully not. Fixed. 1495150 8 359287 jiewen_tan 2019-01-16 11:58:50 -0800 Created attachment 359287 Patch 1495330 9 359287 jiewen_tan 2019-01-16 16:47:56 -0800 Comment on attachment 359287 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359287&action=review > Source/WebCore/html/HTMLFormControlElement.cpp:660 > Added: // FIXME: We should remove the quirk once <rdar://problem/47334655> is fixed. 1495379 10 359287 bfulgham 2019-01-16 19:48:26 -0800 Comment on attachment 359287 Patch Thanks! 1495546 11 359392 jiewen_tan 2019-01-17 11:08:30 -0800 Created attachment 359392 Patch for landing 1495547 12 jiewen_tan 2019-01-17 11:08:54 -0800 (In reply to Brent Fulgham from comment #10) > Comment on attachment 359287 [details] > Patch > > Thanks! Thanks for r+ it. 1495568 13 359392 commit-queue 2019-01-17 11:34:34 -0800 Comment on attachment 359392 Patch for landing Clearing flags on attachment: 359392 Committed r240122: <https://trac.webkit.org/changeset/240122> 2005515 14 karlcow 2024-01-16 23:59:30 -0800 *** Bug 267449 has been marked as a duplicate of this bug. *** 359238 2019-01-15 18:31:21 -0800 2019-01-16 11:58:49 -0800 Patch bug-193478-20190115183120.patch text/plain 3101 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5OTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMwMzZkOWMxNWYwZjA0 MWEwOTI4ZjJhZDZhZjNjODcyNmQzZTcwMS4uNzQwNTdlZjczOGZhOTgxZDgyMzJkMWFiNzRhYzY1 YTdmZDFhNThlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAxLTE1ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gQWRkIGEgbmV3 IHF1aXJrIHRvIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmlzTW91c2VGb2N1c2FibGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzQ3OAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzQzNjg1OTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbmV3IHF1aXJrIHRvIEhUTUxGb3JtQ29udHJvbEVs ZW1lbnQ6OmlzTW91c2VGb2N1c2FibGUgc3VjaCB0aGF0IHN1Ym1pdCBidXR0b25zIGFyZSBtb3Vz ZSBmb2N1c2FibGUuCisgICAgICAgIFRoaXMgcXVpcmsgaXMgZm9yIGNlYWMuc3RhdGUuZ292IHNw ZWNpZmljYWxseSwgYW5kIHRoZXJlZm9yZSBubyB0ZXN0cy4KKworICAgICAgICAqIGh0bWwvSFRN TEZvcm1Db250cm9sRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRy b2xFbGVtZW50Ojppc01vdXNlRm9jdXNhYmxlIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkhU TUxGb3JtQ29udHJvbEVsZW1lbnQ6Om5lZWRzU2l0ZVNwZWNpZmljUXVpcmtzIGNvbnN0KToKKyAg ICAgICAgKiBodG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaDoKKwogMjAxOS0wMS0xNCAgUnlv c3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgcmVkdW5kYW50 IGNoZWNrIGZvciBhbGlnbkF0dHIgYW5kIGhpZGRlbkF0dHIgaW4gdmFyaW91cyBpc1ByZXNlbnRh dGlvbkF0dHJpYnV0ZSBvdmVycmlkZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3Jt Q29udHJvbEVsZW1lbnQuY3BwCmluZGV4IDFkNjQ3ZWZkNmVjNGFiOGRkZTJhZWNjOGZkNzhjZGQ4 NjJjZmZkNWMuLjk4ZmRmZDM4ZGFiOGUwNjFjODkxNmI4YzhiODE0NDY3NjE3ZjZiNzEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcApAQCAtNDAs NiArNDAsNyBAQAogI2luY2x1ZGUgIkhUTUxUZXh0QXJlYUVsZW1lbnQuaCIKICNpbmNsdWRlICJS ZW5kZXJCb3guaCIKICNpbmNsdWRlICJSZW5kZXJUaGVtZS5oIgorI2luY2x1ZGUgIlNldHRpbmdz LmgiCiAjaW5jbHVkZSAiU3R5bGVUcmVlUmVzb2x2ZXIuaCIKICNpbmNsdWRlICJWYWxpZGF0aW9u TWVzc2FnZS5oIgogI2luY2x1ZGUgPHd0Zi9Jc29NYWxsb2NJbmxpbmVzLmg+CkBAIC0zNzIsNiAr MzczLDggQEAgYm9vbCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50Ojppc01vdXNlRm9jdXNhYmxlKCkg Y29uc3QKICNpZiBQTEFURk9STShHVEspCiAgICAgcmV0dXJuIEhUTUxFbGVtZW50Ojppc01vdXNl Rm9jdXNhYmxlKCk7CiAjZWxzZQorICAgIGlmIChuZWVkc1NpdGVTcGVjaWZpY1F1aXJrcygpKQor ICAgICAgICByZXR1cm4gSFRNTEVsZW1lbnQ6OmlzTW91c2VGb2N1c2FibGUoKTsKICAgICByZXR1 cm4gZmFsc2U7CiAjZW5kaWYKIH0KQEAgLTY1NSw0ICs2NTgsMTggQEAgQXV0b2ZpbGxEYXRhIEhU TUxGb3JtQ29udHJvbEVsZW1lbnQ6OmF1dG9maWxsRGF0YSgpIGNvbnN0CiAgICAgcmV0dXJuIEF1 dG9maWxsRGF0YTo6Y3JlYXRlRnJvbUhUTUxGb3JtQ29udHJvbEVsZW1lbnQoKnRoaXMpOwogfQog CisKK2Jvb2wgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6bmVlZHNTaXRlU3BlY2lmaWNRdWlya3Mo KSBjb25zdAoreworI2lmIFBMQVRGT1JNKE1BQykKKyAgICBpZiAoIWRvY3VtZW50KCkuc2V0dGlu Z3MoKS5uZWVkc1NpdGVTcGVjaWZpY1F1aXJrcygpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisK KyAgICBhdXRvIGhvc3QgPSBkb2N1bWVudCgpLnVybCgpLmhvc3QoKTsKKyAgICByZXR1cm4gZXF1 YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9zdCwgImNlYWMuc3RhdGUuZ292IikgfHwgaG9z dC5lbmRzV2l0aElnbm9yaW5nQVNDSUlDYXNlKCIuY2VhYy5zdGF0ZS5nb3YiKTsKKyNlbHNlCisg ICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYmNvcmUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5oIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmgKaW5kZXggZDg3NjU3 M2EyOThiMmQ2Y2ViN2RlOTE1MWE4MWNhMmQ0NWM0NWU2Yy4uNDdhMWYxN2Y3MzU3NWJkZDM5OWY3 YjhkMzBlMDJjZWYzMjFhMmU4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M Rm9ybUNvbnRyb2xFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNv bnRyb2xFbGVtZW50LmgKQEAgLTE3Nyw2ICsxNzcsOCBAQCBwcml2YXRlOgogICAgIGNvbnN0IEhU TUxGb3JtQ29udHJvbEVsZW1lbnQmIGFzSFRNTEVsZW1lbnQoKSBjb25zdCBmaW5hbCB7IHJldHVy biAqdGhpczsgfQogICAgIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQqIGFzRm9ybU5hbWVkSXRlbSgp IGZpbmFsIHsgcmV0dXJuIHRoaXM7IH0KIAorICAgIGJvb2wgbmVlZHNTaXRlU3BlY2lmaWNRdWly a3MoKSBjb25zdDsKKwogICAgIHN0ZDo6dW5pcXVlX3B0cjxWYWxpZGF0aW9uTWVzc2FnZT4gbV92 YWxpZGF0aW9uTWVzc2FnZTsKICAgICB1bnNpZ25lZCBtX2Rpc2FibGVkIDogMTsKICAgICB1bnNp Z25lZCBtX2lzUmVhZE9ubHkgOiAxOwo= 359287 2019-01-16 11:58:50 -0800 2019-01-16 19:48:26 -0800 Patch bug-193478-20190116115849.patch text/plain 3635 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5OTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMwMzZkOWMxNWYwZjA0 MWEwOTI4ZjJhZDZhZjNjODcyNmQzZTcwMS4uMzkyZGRkNjJmOGZjMzM5ZDEwZjc3NGE2MjMzOWFk NDA0ZWJhNjNmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTAxLTE1ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gQWRkIGEgbmV3 IHF1aXJrIHRvIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmlzTW91c2VGb2N1c2FibGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzQ3OAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzQzNjg1OTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQnkgZGVmYXVsdCBpbiBtYWNPUywgc3VibWl0IGJ1dHRvbnMg KGNvbnRyb2xzKSBhcmUgbm90IGZvY3VzYWJsZS4gV2ViS2l0IGZvbGxvd3MgdGhpcyBzeXN0ZW0g Y29udmVudGlvbgorICAgICAgICBhcyBzdWdnZXN0ZWQgYnkgdGhlIHNwZWM6IGh0dHBzOi8vaHRt bC5zcGVjLndoYXR3Zy5vcmcvbXVsdGlwYWdlL2ludGVyYWN0aW9uLmh0bWwjZm9jdXNhYmxlLWFy ZWEuIFRoaXMKKyAgICAgICAgaXMgYWxzbyB0aGUgY29udmVudGlvbiBGaXJlZm94IHJlc3BlY3Rz LiBIb3dldmVyLCBDaHJvbWUgZG9lc24ndC4gY2VhYy5zdGF0ZS5nb3YgaXMgYnkgZmFyIHRoZSBv bmx5CisgICAgICAgIHdlYnNpdGUgdGhhdCBhc3N1bWVzIHN1Ym1pdCBidXR0b25zIGFyZSBmb2N1 c2FibGUsIGFuZCB3aWxsIHByb2hpYml0IHVzZXJzIGZyb20gY29tcGxldGluZyBpbW1pZ3JhdGlv bgorICAgICAgICBmb3Jtcywgc3VjaCBhcyBEUzE2MCBpZiBidXR0b25zIGFyZSBub3QuIFRvIGhl bHAgaW1taWdyYXRpb25zLCB3ZSBkZWNpZGUgdG8gYWRkIGEgbmV3IHF1aXJrIHRvCisgICAgICAg IEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmlzTW91c2VGb2N1c2FibGUgc3VjaCB0aGF0IHN1Ym1p dCBidXR0b25zIGFyZSBtb3VzZSBmb2N1c2FibGUuCisKKyAgICAgICAgVGhpcyBxdWlyayBpcyBm b3IgY2VhYy5zdGF0ZS5nb3Ygc3BlY2lmaWNhbGx5LCBhbmQgdGhlcmVmb3JlIG5vIHRlc3RzLgor CisgICAgICAgICogaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmlzTW91c2VGb2N1c2FibGUgY29uc3QpOgor ICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1Db250cm9sRWxlbWVudDo6bmVlZHNTaXRlU3BlY2lm aWNRdWlya3MgY29uc3QpOgorICAgICAgICAqIGh0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5o OgorCiAyMDE5LTAxLTE0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJlbW92ZSByZWR1bmRhbnQgY2hlY2sgZm9yIGFsaWduQXR0ciBhbmQgaGlkZGVuQXR0ciBp biB2YXJpb3VzIGlzUHJlc2VudGF0aW9uQXR0cmlidXRlIG92ZXJyaWRlcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAKaW5kZXggMWQ2NDdlZmQ2ZWM0 YWI4ZGRlMmFlY2M4ZmQ3OGNkZDg2MmNmZmQ1Yy4uYWFjN2VlYWM4NDFkNWQ3OGMwY2M4ODcyMTQy MjAwZTcxOTcxNTg0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNv bnRyb2xFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJv bEVsZW1lbnQuY3BwCkBAIC00MCw2ICs0MCw3IEBACiAjaW5jbHVkZSAiSFRNTFRleHRBcmVhRWxl bWVudC5oIgogI2luY2x1ZGUgIlJlbmRlckJveC5oIgogI2luY2x1ZGUgIlJlbmRlclRoZW1lLmgi CisjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRlICJTdHlsZVRyZWVSZXNvbHZlci5oIgog I2luY2x1ZGUgIlZhbGlkYXRpb25NZXNzYWdlLmgiCiAjaW5jbHVkZSA8d3RmL0lzb01hbGxvY0lu bGluZXMuaD4KQEAgLTM3Miw2ICszNzMsOCBAQCBib29sIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6 OmlzTW91c2VGb2N1c2FibGUoKSBjb25zdAogI2lmIFBMQVRGT1JNKEdUSykKICAgICByZXR1cm4g SFRNTEVsZW1lbnQ6OmlzTW91c2VGb2N1c2FibGUoKTsKICNlbHNlCisgICAgaWYgKG5lZWRzTW91 c2VGb2N1c2FibGVRdWlyaygpKQorICAgICAgICByZXR1cm4gSFRNTEVsZW1lbnQ6OmlzTW91c2VG b2N1c2FibGUoKTsKICAgICByZXR1cm4gZmFsc2U7CiAjZW5kaWYKIH0KQEAgLTY1NSw0ICs2NTgs MTcgQEAgQXV0b2ZpbGxEYXRhIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmF1dG9maWxsRGF0YSgp IGNvbnN0CiAgICAgcmV0dXJuIEF1dG9maWxsRGF0YTo6Y3JlYXRlRnJvbUhUTUxGb3JtQ29udHJv bEVsZW1lbnQoKnRoaXMpOwogfQogCitib29sIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6Om5lZWRz TW91c2VGb2N1c2FibGVRdWlyaygpIGNvbnN0Cit7CisjaWYgUExBVEZPUk0oTUFDKQorICAgIGlm ICghZG9jdW1lbnQoKS5zZXR0aW5ncygpLm5lZWRzU2l0ZVNwZWNpZmljUXVpcmtzKCkpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKworICAgIGF1dG8gaG9zdCA9IGRvY3VtZW50KCkudXJsKCkuaG9z dCgpOworICAgIHJldHVybiBlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShob3N0LCAiY2Vh Yy5zdGF0ZS5nb3YiKSB8fCBob3N0LmVuZHNXaXRoSWdub3JpbmdBU0NJSUNhc2UoIi5jZWFjLnN0 YXRlLmdvdiIpOworI2Vsc2UKKyAgICByZXR1cm4gZmFsc2U7CisjZW5kaWYKK30KKwogfSAvLyBu YW1lc3BhY2UgV2ViY29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9y bUNvbnRyb2xFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVs ZW1lbnQuaAppbmRleCBkODc2NTczYTI5OGIyZDZjZWI3ZGU5MTUxYTgxY2EyZDQ1YzQ1ZTZjLi45 YTQyZTRlZWNmNmRjMjlmNGNiZWYyYTQwMjFiZWU4MWY2ZDliMzc2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaApAQCAtMTc3LDYgKzE3Nyw4IEBAIHBy aXZhdGU6CiAgICAgY29uc3QgSFRNTEZvcm1Db250cm9sRWxlbWVudCYgYXNIVE1MRWxlbWVudCgp IGNvbnN0IGZpbmFsIHsgcmV0dXJuICp0aGlzOyB9CiAgICAgSFRNTEZvcm1Db250cm9sRWxlbWVu dCogYXNGb3JtTmFtZWRJdGVtKCkgZmluYWwgeyByZXR1cm4gdGhpczsgfQogCisgICAgYm9vbCBu ZWVkc01vdXNlRm9jdXNhYmxlUXVpcmsoKSBjb25zdDsKKwogICAgIHN0ZDo6dW5pcXVlX3B0cjxW YWxpZGF0aW9uTWVzc2FnZT4gbV92YWxpZGF0aW9uTWVzc2FnZTsKICAgICB1bnNpZ25lZCBtX2Rp c2FibGVkIDogMTsKICAgICB1bnNpZ25lZCBtX2lzUmVhZE9ubHkgOiAxOwo= 359392 2019-01-17 11:08:30 -0800 2019-01-17 11:34:34 -0800 Patch for landing bug-193478-20190117110829.patch text/plain 3713 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5OTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWMwMzZkOWMxNWYwZjA0 MWEwOTI4ZjJhZDZhZjNjODcyNmQzZTcwMS4uMTNjODBiZTAyNWZkODIyNzUwZGNmMzdiMWFlOGNm YjI0NGMzZDNhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTAxLTE1ICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gQWRkIGEgbmV3 IHF1aXJrIHRvIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmlzTW91c2VGb2N1c2FibGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzQ3OAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzQzNjg1OTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQnJlbnQg RnVsZ2hhbS4KKworICAgICAgICBCeSBkZWZhdWx0IGluIG1hY09TLCBzdWJtaXQgYnV0dG9ucyAo Y29udHJvbHMpIGFyZSBub3QgZm9jdXNhYmxlLiBXZWJLaXQgZm9sbG93cyB0aGlzIHN5c3RlbSBj b252ZW50aW9uCisgICAgICAgIGFzIHN1Z2dlc3RlZCBieSB0aGUgc3BlYzogaHR0cHM6Ly9odG1s LnNwZWMud2hhdHdnLm9yZy9tdWx0aXBhZ2UvaW50ZXJhY3Rpb24uaHRtbCNmb2N1c2FibGUtYXJl YS4gVGhpcworICAgICAgICBpcyBhbHNvIHRoZSBjb252ZW50aW9uIEZpcmVmb3ggcmVzcGVjdHMu IEhvd2V2ZXIsIENocm9tZSBkb2Vzbid0LiBjZWFjLnN0YXRlLmdvdiBpcyBieSBmYXIgdGhlIG9u bHkKKyAgICAgICAgd2Vic2l0ZSB0aGF0IGFzc3VtZXMgc3VibWl0IGJ1dHRvbnMgYXJlIGZvY3Vz YWJsZSwgYW5kIHdpbGwgcHJvaGliaXQgdXNlcnMgZnJvbSBjb21wbGV0aW5nIGltbWlncmF0aW9u CisgICAgICAgIGZvcm1zLCBzdWNoIGFzIERTMTYwIGlmIGJ1dHRvbnMgYXJlIG5vdC4gVG8gaGVs cCBpbW1pZ3JhdGlvbnMsIHdlIGRlY2lkZSB0byBhZGQgYSBuZXcgcXVpcmsgdG8KKyAgICAgICAg SFRNTEZvcm1Db250cm9sRWxlbWVudDo6aXNNb3VzZUZvY3VzYWJsZSBzdWNoIHRoYXQgc3VibWl0 IGJ1dHRvbnMgYXJlIG1vdXNlIGZvY3VzYWJsZS4KKworICAgICAgICBUaGlzIHF1aXJrIGlzIGZv ciBjZWFjLnN0YXRlLmdvdiBzcGVjaWZpY2FsbHksIGFuZCB0aGVyZWZvcmUgbm8gdGVzdHMuCisK KyAgICAgICAgKiBodG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SFRNTEZvcm1Db250cm9sRWxlbWVudDo6aXNNb3VzZUZvY3VzYWJsZSBjb25zdCk6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpuZWVkc1NpdGVTcGVjaWZp Y1F1aXJrcyBjb25zdCk6CisgICAgICAgICogaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50Lmg6 CisKIDIwMTktMDEtMTQgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmVtb3ZlIHJlZHVuZGFudCBjaGVjayBmb3IgYWxpZ25BdHRyIGFuZCBoaWRkZW5BdHRyIGlu IHZhcmlvdXMgaXNQcmVzZW50YXRpb25BdHRyaWJ1dGUgb3ZlcnJpZGVzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcAppbmRleCAxZDY0N2VmZDZlYzRh YjhkZGUyYWVjYzhmZDc4Y2RkODYyY2ZmZDVjLi4wZDJiOGVmOTA1NGEyZjFhNTA3OTdmMGNjYTMz YmIwYThhNjJiZjVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29u dHJvbEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9s RWxlbWVudC5jcHAKQEAgLTQwLDYgKzQwLDcgQEAKICNpbmNsdWRlICJIVE1MVGV4dEFyZWFFbGVt ZW50LmgiCiAjaW5jbHVkZSAiUmVuZGVyQm94LmgiCiAjaW5jbHVkZSAiUmVuZGVyVGhlbWUuaCIK KyNpbmNsdWRlICJTZXR0aW5ncy5oIgogI2luY2x1ZGUgIlN0eWxlVHJlZVJlc29sdmVyLmgiCiAj aW5jbHVkZSAiVmFsaWRhdGlvbk1lc3NhZ2UuaCIKICNpbmNsdWRlIDx3dGYvSXNvTWFsbG9jSW5s aW5lcy5oPgpAQCAtMzcyLDYgKzM3Myw4IEBAIGJvb2wgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6 aXNNb3VzZUZvY3VzYWJsZSgpIGNvbnN0CiAjaWYgUExBVEZPUk0oR1RLKQogICAgIHJldHVybiBI VE1MRWxlbWVudDo6aXNNb3VzZUZvY3VzYWJsZSgpOwogI2Vsc2UKKyAgICBpZiAobmVlZHNNb3Vz ZUZvY3VzYWJsZVF1aXJrKCkpCisgICAgICAgIHJldHVybiBIVE1MRWxlbWVudDo6aXNNb3VzZUZv Y3VzYWJsZSgpOwogICAgIHJldHVybiBmYWxzZTsKICNlbmRpZgogfQpAQCAtNjU1LDQgKzY1OCwx OCBAQCBBdXRvZmlsbERhdGEgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6YXV0b2ZpbGxEYXRhKCkg Y29uc3QKICAgICByZXR1cm4gQXV0b2ZpbGxEYXRhOjpjcmVhdGVGcm9tSFRNTEZvcm1Db250cm9s RWxlbWVudCgqdGhpcyk7CiB9CiAKKy8vIEZJWE1FOiBXZSBzaG91bGQgcmVtb3ZlIHRoZSBxdWly ayBvbmNlIDxyZGFyOi8vcHJvYmxlbS80NzMzNDY1NT4gaXMgZml4ZWQuCitib29sIEhUTUxGb3Jt Q29udHJvbEVsZW1lbnQ6Om5lZWRzTW91c2VGb2N1c2FibGVRdWlyaygpIGNvbnN0Cit7CisjaWYg UExBVEZPUk0oTUFDKQorICAgIGlmICghZG9jdW1lbnQoKS5zZXR0aW5ncygpLm5lZWRzU2l0ZVNw ZWNpZmljUXVpcmtzKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGF1dG8gaG9zdCA9 IGRvY3VtZW50KCkudXJsKCkuaG9zdCgpOworICAgIHJldHVybiBlcXVhbExldHRlcnNJZ25vcmlu Z0FTQ0lJQ2FzZShob3N0LCAiY2VhYy5zdGF0ZS5nb3YiKSB8fCBob3N0LmVuZHNXaXRoSWdub3Jp bmdBU0NJSUNhc2UoIi5jZWFjLnN0YXRlLmdvdiIpOworI2Vsc2UKKyAgICByZXR1cm4gZmFsc2U7 CisjZW5kaWYKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViY29yZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaAppbmRleCBkODc2NTczYTI5OGIyZDZjZWI3ZGU5 MTUxYTgxY2EyZDQ1YzQ1ZTZjLi45YTQyZTRlZWNmNmRjMjlmNGNiZWYyYTQwMjFiZWU4MWY2ZDli Mzc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1l bnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaApA QCAtMTc3LDYgKzE3Nyw4IEBAIHByaXZhdGU6CiAgICAgY29uc3QgSFRNTEZvcm1Db250cm9sRWxl bWVudCYgYXNIVE1MRWxlbWVudCgpIGNvbnN0IGZpbmFsIHsgcmV0dXJuICp0aGlzOyB9CiAgICAg SFRNTEZvcm1Db250cm9sRWxlbWVudCogYXNGb3JtTmFtZWRJdGVtKCkgZmluYWwgeyByZXR1cm4g dGhpczsgfQogCisgICAgYm9vbCBuZWVkc01vdXNlRm9jdXNhYmxlUXVpcmsoKSBjb25zdDsKKwog ICAgIHN0ZDo6dW5pcXVlX3B0cjxWYWxpZGF0aW9uTWVzc2FnZT4gbV92YWxpZGF0aW9uTWVzc2Fn ZTsKICAgICB1bnNpZ25lZCBtX2Rpc2FibGVkIDogMTsKICAgICB1bnNpZ25lZCBtX2lzUmVhZE9u bHkgOiAxOwo=