193351 2019-01-11 07:10:37 -0800 Release assert when removing element with a map element in the shadow tree 2019-01-11 23:40:05 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193378 InRadar P2 Normal --- 1 koivisto webkit-unassigned cdumez commit-queue esprehn+autocc ews-watchlist ggaren gyuyoung.kim rniwa oldest_to_newest 1493666 0 koivisto 2019-01-11 07:10:37 -0800 (lldb) bt * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BREAKPOINT (code=EXC_I386_BPT, subcode=0x0) * frame #0: 0x000000010b242cb3 WebCore`WTFCrashWithInfo((null)=81, (null)="./dom/TreeScopeOrderedMap.cpp", (null)="void WebCore::TreeScopeOrderedMap::remove(const WTF::AtomicStringImpl &, WebCore::Element &)", (null)=139) at Assertions.h:559 [opt] frame #1: 0x000000010bf8465e WebCore`WebCore::TreeScopeOrderedMap::remove(this=0x00000001de412fe0, key=<unavailable>, element=0x00000001de9abf90) at TreeScopeOrderedMap.cpp:81 [opt] frame #2: 0x000000010c0c3dc3 WebCore`WebCore::HTMLMapElement::removedFromAncestor(this=0x00000001de9abf90, removalType=(disconnectedFromDocument = true, treeScopeChanged = false), oldParentOfRemovedTree=0x00000001de3befa0) at HTMLMapElement.cpp:129 [opt] frame #3: 0x000000010bebbf85 WebCore`WebCore::notifyNodeRemovedFromDocument(oldParentOfRemovedTree=0x00000001de3befa0, treeScopeChange=DidNotChange, node=0x00000001de9abf90) at ContainerNodeAlgorithms.cpp:114 [opt] frame #4: 0x000000010bebbfc6 WebCore`WebCore::notifyNodeRemovedFromDocument(oldParentOfRemovedTree=0x00000001de3befa0, treeScopeChange=DidNotChange, node=0x00000001de95bf40) at ContainerNodeAlgorithms.cpp:121 [opt] frame #5: 0x000000010bebc032 WebCore`WebCore::notifyNodeRemovedFromDocument(oldParentOfRemovedTree=0x00000001de3befa0, treeScopeChange=Changed, node=0x00000001de438fa0) at ContainerNodeAlgorithms.cpp:129 [opt] frame #6: 0x000000010beb8788 WebCore`WebCore::ContainerNode::removeChild(WebCore::Node&) [inlined] WebCore::notifyChildNodeRemoved(oldParentOfRemovedTree=<unavailable>, child=<unavailable>) at ContainerNodeAlgorithms.cpp:161 [opt] frame #7: 0x000000010beb875e WebCore`WebCore::ContainerNode::removeChild(WebCore::Node&) at ContainerNode.cpp:168 [opt] frame #8: 0x000000010beb8704 WebCore`WebCore::ContainerNode::removeChild(this=0x00000001de3befa0, oldChild=0x00000001de438fa0) at ContainerNode.cpp:571 [opt] frame #9: 0x000000010bf418c0 WebCore`WebCore::Node::remove(this=<unavailable>) at Node.cpp:625 [opt] 1493667 1 koivisto 2019-01-11 07:11:01 -0800 <rdar://problem/47208807> 1493668 2 358894 koivisto 2019-01-11 07:22:01 -0800 Created attachment 358894 patch 1493828 3 358894 commit-queue 2019-01-11 14:38:31 -0800 Comment on attachment 358894 patch Clearing flags on attachment: 358894 Committed r239877: <https://trac.webkit.org/changeset/239877> 1493829 4 commit-queue 2019-01-11 14:38:32 -0800 All reviewed patches have been landed. Closing bug. 358894 2019-01-11 07:22:01 -0800 2019-01-11 14:38:31 -0800 patch imagemap-scope.patch text/plain 3872 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzOTg2MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE5LTAxLTExICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZWxlYXNlIGFzc2VydCB3aGVu IHJlbW92aW5nIGVsZW1lbnQgd2l0aCBhIG1hcCBlbGVtZW50IGluIHRoZSBzaGFkb3cgdHJlZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMzUxCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NzIwODgwNz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGEgc2hhZG93IGhvc3QgdGhhdCBoYXMgYSBt YXAgZWxlbWVudCBpbiB0aGUgc2hhZG93IHRyZWUgaXMgcmVtb3ZlZCBmcm9tIHRoZSBkb2N1bWVu dCwgd2UgdHJ5CisgICAgICAgIHRvIHJlbW92ZSB0aGUgbWFwIGZyb20gdGhlIHNjb3BlIG9mIHRo ZSBob3N0LgorCisgICAgICAgIFRlc3Q6IGZhc3Qvc2hhZG93LWRvbS9pbWFnZS1tYXAtdHJlZS1z Y29wZS5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxNYXBFbGVtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxNYXBFbGVtZW50OjppbnNlcnRlZEludG9BbmNlc3Rvcik6CisgICAgICAg IChXZWJDb3JlOjpIVE1MTWFwRWxlbWVudDo6cmVtb3ZlZEZyb21BbmNlc3Rvcik6CisKKyAgICAg ICAgQWRkIGFuZCByZW1vdmUgaW1hZ2UgbWFwcyB3aGVuIHRoZSBzY29wZSBjaGFuZ2VzLCBub3Qg d2hlbiB0aGUgZG9jdW1lbnQgY2hhbmdlcy4KKyAgICAgICAgVGhpcyBtYXRjaGVzIGhvdyBpZC9u YW1lL2V0YyB1cGRhdGVzIHdvcmsgaW4gdGhlIEhUTUxFbGVtZW50LgorCiAyMDE5LTAxLTEwICBN eWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgW1dITFNM XSBJbmNsdWRlIHRoZSBzdGFuZGFyZCBsaWJyYXJ5CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNYXBFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxNYXBFbGVtZW50LmNwcAkocmV2aXNpb24gMjM5ODI2KQorKysgU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MTWFwRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExOCwxNCArMTE4LDE0IEBA IFJlZjxIVE1MQ29sbGVjdGlvbj4gSFRNTE1hcEVsZW1lbnQ6OmFyZWEKIE5vZGU6Okluc2VydGVk SW50b0FuY2VzdG9yUmVzdWx0IEhUTUxNYXBFbGVtZW50OjppbnNlcnRlZEludG9BbmNlc3RvcihJ bnNlcnRpb25UeXBlIGluc2VydGlvblR5cGUsIENvbnRhaW5lck5vZGUmIHBhcmVudE9mSW5zZXJ0 ZWRUcmVlKQogewogICAgIE5vZGU6Okluc2VydGVkSW50b0FuY2VzdG9yUmVzdWx0IHJlcXVlc3Qg PSBIVE1MRWxlbWVudDo6aW5zZXJ0ZWRJbnRvQW5jZXN0b3IoaW5zZXJ0aW9uVHlwZSwgcGFyZW50 T2ZJbnNlcnRlZFRyZWUpOwotICAgIGlmIChpbnNlcnRpb25UeXBlLmNvbm5lY3RlZFRvRG9jdW1l bnQpCisgICAgaWYgKGluc2VydGlvblR5cGUudHJlZVNjb3BlQ2hhbmdlZCkKICAgICAgICAgdHJl ZVNjb3BlKCkuYWRkSW1hZ2VNYXAoKnRoaXMpOwogICAgIHJldHVybiByZXF1ZXN0OwogfQogCiB2 b2lkIEhUTUxNYXBFbGVtZW50OjpyZW1vdmVkRnJvbUFuY2VzdG9yKFJlbW92YWxUeXBlIHJlbW92 YWxUeXBlLCBDb250YWluZXJOb2RlJiBvbGRQYXJlbnRPZlJlbW92ZWRUcmVlKQogewotICAgIGlm IChyZW1vdmFsVHlwZS5kaXNjb25uZWN0ZWRGcm9tRG9jdW1lbnQpCisgICAgaWYgKHJlbW92YWxU eXBlLnRyZWVTY29wZUNoYW5nZWQpCiAgICAgICAgIG9sZFBhcmVudE9mUmVtb3ZlZFRyZWUudHJl ZVNjb3BlKCkucmVtb3ZlSW1hZ2VNYXAoKnRoaXMpOwogICAgIEhUTUxFbGVtZW50OjpyZW1vdmVk RnJvbUFuY2VzdG9yKHJlbW92YWxUeXBlLCBvbGRQYXJlbnRPZlJlbW92ZWRUcmVlKTsKIH0KSW5k ZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHJldmlzaW9uIDIzOTgyNikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE5LTAxLTExICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZWxlYXNlIGFzc2VydCB3aGVuIHJlbW92aW5nIGVs ZW1lbnQgd2l0aCBhIG1hcCBlbGVtZW50IGluIHRoZSBzaGFkb3cgdHJlZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkzMzUxCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS80NzIwODgwNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGZhc3Qvc2hhZG93LWRvbS9pbWFnZS1tYXAtdHJlZS1zY29wZS1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc2hhZG93LWRvbS9pbWFnZS1tYXAtdHJl ZS1zY29wZS5odG1sOiBBZGRlZC4KKwogMjAxOS0wMS0xMCAgRG9taW5payBJbmZ1ZWhyICA8ZGlu ZnVlaHJAaWdhbGlhLmNvbT4KIAogICAgICAgICBFbmFibGUgREZHIG9uIEFSTS9MaW51eCBhZ2Fp bgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL2ltYWdlLW1hcC10cmVlLXNjb3Bl LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1kb20v aW1hZ2UtbWFwLXRyZWUtc2NvcGUtZXhwZWN0ZWQudHh0CShub25leGlzdGVudCkKKysrIExheW91 dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9pbWFnZS1tYXAtdHJlZS1zY29wZS1leHBlY3RlZC50eHQJ KHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSBAQAorVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vz bid0IGNyYXNoLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9tL2ltYWdlLW1hcC10 cmVlLXNjb3BlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9zaGFkb3ctZG9t L2ltYWdlLW1hcC10cmVlLXNjb3BlLmh0bWwJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMv ZmFzdC9zaGFkb3ctZG9tL2ltYWdlLW1hcC10cmVlLXNjb3BlLmh0bWwJKHdvcmtpbmcgY29weSkK QEAgLTAsMCArMSwxOSBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRl c3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKK2Z1bmN0aW9uIHRlc3Qo KSB7CisgICAgdmFyIHNoYWRvdyA9IGhvc3QuYXR0YWNoU2hhZG93KHttb2RlOiAib3BlbiJ9KTsK KyAgICBzaGFkb3cuaW5uZXJIVE1MID0gJzxtYXAgbmFtZT0iYmFyIj4nOworICAgIGhvc3QucmVt b3ZlKCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVzdCgpIj4KK1Ro aXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4KKzxtYXAgaWQ9Im1hcCIgbmFtZT0i Zm9vIj48L21hcD4KKzxkaXYgaWQ9Imhvc3QiPjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgo=