193279 2019-01-09 05:26:15 -0800 ComplexText: Test fast/text/word-space-nbsp.html fails when using complex text path 2019-02-01 16:34:36 -0800 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=101443 https://bugs.webkit.org/show_bug.cgi?id=193628 InRadar P2 Normal --- 1 cgarcia webkit-unassigned mcatanzaro mmaxfield webkit-bug-importer oldest_to_newest 1492926 0 cgarcia 2019-01-09 05:26:15 -0800 The fix applied in r135884 to WidthIterator should also be applied to ComplexTextController. 1492927 1 358697 cgarcia 2019-01-09 05:28:21 -0800 Created attachment 358697 Patch 1493855 2 358697 mmaxfield 2019-01-11 15:17:37 -0800 Comment on attachment 358697 Patch Where's the test? 1493909 3 358697 mcatanzaro 2019-01-11 17:23:50 -0800 Comment on attachment 358697 Patch fast/text/word-space-nbsp.html? :) 1493917 4 mmaxfield 2019-01-11 17:42:54 -0800 (In reply to Michael Catanzaro from comment #3) > Comment on attachment 358697 [details] > Patch > > fast/text/word-space-nbsp.html? :) Oh, it's not marked as failing yet? 1494028 5 cgarcia 2019-01-13 01:34:28 -0800 (In reply to Myles C. Maxfield from comment #4) > (In reply to Michael Catanzaro from comment #3) > > Comment on attachment 358697 [details] > > Patch > > > > fast/text/word-space-nbsp.html? :) > > Oh, it's not marked as failing yet? It started to fail when we switched to use complex text code path for layout tests, but we never marked it as failure: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r239904%20(9360)/fast/text/word-space-nbsp-diffs.html 1496639 6 mcatanzaro 2019-01-21 12:35:55 -0800 Um... it's marked as failing now! (After bug #193628.) Myles? 1496640 7 mcatanzaro 2019-01-21 12:36:27 -0800 (Patch should remove the failure expectation when landing, but no reason to block review on that.) 1499974 8 cgarcia 2019-01-30 06:09:31 -0800 Ping Myles. 1499994 9 mcatanzaro 2019-01-30 07:14:37 -0800 (In reply to Michael Catanzaro from comment #7) > (Patch should remove the failure expectation when landing, but no reason to > block review on that.) 1501093 10 cgarcia 2019-02-01 06:33:22 -0800 Committed r240846: <https://trac.webkit.org/changeset/240846> 1501094 11 webkit-bug-importer 2019-02-01 06:34:27 -0800 <rdar://problem/47734600> 1501353 12 mmaxfield 2019-02-01 16:34:36 -0800 Sorry for not getting to this in time. 358697 2019-01-09 05:28:21 -0800 2019-01-30 07:14:32 -0800 Patch wc-complex-nbsp.diff text/plain 1749 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMWQwNmM1NTZlZS4uZmExNzU0NDQzMzAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOS0wMS0wOSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgQ29tcGxleFRleHQ6IFRlc3QgZmFzdC90ZXh0L3dvcmQtc3Bh Y2UtbmJzcC5odG1sIGZhaWxzIHdoZW4gdXNpbmcgY29tcGxleCB0ZXh0IHBhdGgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzI3OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBmaXggYXBwbGllZCBp biByMTM1ODg0IHRvIFdpZHRoSXRlcmF0b3Igc2hvdWxkIGFsc28gYmUgYXBwbGllZCB0byBDb21w bGV4VGV4dENvbnRyb2xsZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Db21wbGV4 VGV4dENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29tcGxleFRleHRDb250cm9s bGVyOjphZGp1c3RHbHlwaHNBbmRBZHZhbmNlcyk6CisKIDIwMTktMDEtMDkgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIz OTE1Nik6IFtGcmVlVHlwZV0gZml4ZWQgd2lkdGgsIGFuZCBzeW50aGV0aWMgYm9sZC9pdGFsaWMg bm90IGNvcnJlY3RseSBhcHBsaWVkIHNpbmNlIHIyMzkxNTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbXBsZXhUZXh0Q29udHJvbGxlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db21wbGV4VGV4dENvbnRyb2xsZXIuY3BwCmlu ZGV4IDlhOWM5NzY4NjEyLi5jNGQwNzJiNTE5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvQ29tcGxleFRleHRDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db21wbGV4VGV4dENvbnRyb2xsZXIuY3BwCkBAIC04 MDQsNyArODA0LDcgQEAgdm9pZCBDb21wbGV4VGV4dENvbnRyb2xsZXI6OmFkanVzdEdseXBoc0Fu ZEFkdmFuY2VzKCkKICAgICAgICAgICAgICAgICAgICAgICAgIGFmdGVyRXhwYW5zaW9uID0gZmFs c2U7CiAKICAgICAgICAgICAgICAgICAgICAgLy8gQWNjb3VudCBmb3Igd29yZC1zcGFjaW5nLgot ICAgICAgICAgICAgICAgICAgICBpZiAodHJlYXRBc1NwYWNlICYmIChjaCAhPSAnXHQnIHx8ICFt X3J1bi5hbGxvd1RhYnMoKSkgJiYgKGNoYXJhY3RlckluZGV4ID4gMCB8fCBydW5JbmRleCA+IDAp ICYmIG1fZm9udC53b3JkU3BhY2luZygpKQorICAgICAgICAgICAgICAgICAgICBpZiAodHJlYXRB c1NwYWNlICYmIChjaCAhPSAnXHQnIHx8ICFtX3J1bi5hbGxvd1RhYnMoKSkgJiYgKGNoYXJhY3Rl ckluZGV4ID4gMCB8fCBydW5JbmRleCA+IDAgfHwgY2ggPT0gbm9CcmVha1NwYWNlKSAmJiBtX2Zv bnQud29yZFNwYWNpbmcoKSkKICAgICAgICAgICAgICAgICAgICAgICAgIGFkdmFuY2UuZXhwYW5k KG1fZm9udC53b3JkU3BhY2luZygpLCAwKTsKICAgICAgICAgICAgICAgICB9IGVsc2UKICAgICAg ICAgICAgICAgICAgICAgYWZ0ZXJFeHBhbnNpb24gPSBmYWxzZTsK