<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>193255</bug_id>
          
          <creation_ts>2019-01-08 14:30:23 -0800</creation_ts>
          <short_desc>[iOS] Command + . key events to non-editable elements have incorrect key details</short_desc>
          <delta_ts>2019-01-09 15:02:08 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Local Build</version>
          <rep_platform>iPhone / iPad</rep_platform>
          <op_sys>iOS 12</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>192824</dup_id>
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=193258</see_also>
          <bug_file_loc>https://unixpapa.com/js/testkey.html</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, PlatformOnly</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>190571</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1492763</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2019-01-08 14:30:23 -0800</bug_when>
    <thetext>Seen on iOS using a hardware keyboard.

Steps to reproduce:

1. Visit &lt;https://unixpapa.com/js/testkey.html&gt;.
2. Ensure Modifiers and DOM 3 attribute values are enabled.
3. Press Command + . on the keyboard.

Then the properties keyCode, which, charCode and key have values 85, 85, 85, and UIKeyInputEscape, respectively. But the values of these properties should be 27, 27, 0, and Escape, respectively to match Mac.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1492817</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2019-01-08 16:49:28 -0800</bug_when>
    <thetext>&lt;rdar://problem/47133149&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1493122</commentid>
    <comment_count>2</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2019-01-09 14:58:23 -0800</bug_when>
    <thetext>(In reply to Daniel Bates from comment #0)
&gt; Seen on iOS using a hardware keyboard.
&gt; 
&gt; Steps to reproduce:
&gt; 
&gt; 1. Visit &lt;https://unixpapa.com/js/testkey.html&gt;.
&gt; 2. Ensure Modifiers and DOM 3 attribute values are enabled.
&gt; 3. Press Command + . on the keyboard.
&gt; 
&gt; Then the properties keyCode, which, charCode and key have values 85, 85, 85,
&gt; and UIKeyInputEscape, respectively. But the values of these properties
&gt; should be 27, 27, 0, and Escape, respectively to match Mac.

Actually, on Mac we do not convert Command + . to Escape.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1493124</commentid>
    <comment_count>3</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2019-01-09 14:59:39 -0800</bug_when>
    <thetext>(In reply to Daniel Bates from comment #0)
&gt; Seen on iOS using a hardware keyboard.
&gt; 
&gt; Steps to reproduce:
&gt; 
&gt; 1. Visit &lt;https://unixpapa.com/js/testkey.html&gt;.
&gt; 2. Ensure Modifiers and DOM 3 attribute values are enabled.
&gt; 3. Press Command + . on the keyboard.
&gt; 
&gt; Then the properties keyCode, which, charCode and key have values 85, 85, 85,
&gt; and UIKeyInputEscape, respectively. But the values of these properties
&gt; should be 27, 27, 0, and Escape, respectively to match Mac.

The expected output should be:

keydown  keyCode=91  ([)   which=91  ([)   charCode=0        
         shiftKey=false ctrlKey=false altKey=false metaKey=true 
         key=Meta char=undefined location=1 repeat=false
keydown  keyCode=190       which=190       charCode=0        
         shiftKey=false ctrlKey=false altKey=false metaKey=true 
         key=. char=undefined location=0 repeat=false
keyup    keyCode=91  ([)   which=91  ([)   charCode=0        
         shiftKey=false ctrlKey=false altKey=false metaKey=false
         key=Meta char=undefined location=1 repeat=false</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1493127</commentid>
    <comment_count>4</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2019-01-09 15:02:08 -0800</bug_when>
    <thetext>This will be fixed in as a side effect of fixing bug #192824 and using the same code path for both hardware key presses in non-editable elements as we do for hardware key presses in editable elements.

*** This bug has been marked as a duplicate of bug 192824 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>