19323 2008-05-30 08:47:51 -0700 support 'Edit Mode' in QtWebKit 2008-06-10 09:49:33 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 1 jonathon jonathon hausmann oldest_to_newest 81938 0 jonathon 2008-05-30 08:47:51 -0700 QtWebKit should provide an API to allow switching to 'edit mode' so that the user can edit the displayed web page. This would be useful for html email composing, for instance. 81946 1 21435 jonathon 2008-05-30 09:23:22 -0700 Created attachment 21435 Patch to add the QWebPage::setEditable() API 82832 2 21435 hausmann 2008-06-10 09:49:17 -0700 Comment on attachment 21435 Patch to add the QWebPage::setEditable() API Landed in r34481 with small doc fixes and the removal of the default argument of the setEditable(bool editable) argument. Thanks Jonathon! 21435 2008-05-30 09:23:22 -0700 2008-06-10 09:49:17 -0700 Patch to add the QWebPage::setEditable() API 0001-Add-QWebPage-setEditable-QWebPage-isEditable.patch text/plain 5186 jonathon RnJvbSA1NzZiMGFjMmI1ZTRmMWJiMDgxOWFiNDIxMDFhNDAwZWI3NDc4YzgwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb25hdGhvbiBKb25nc21hIDxqam9uZ3NtYUBnbm9tZS5vcmc+ CkRhdGU6IE1vbiwgMjYgTWF5IDIwMDggMTY6MjI6MzIgLTA1MDAKU3ViamVjdDogW1BBVENIXSBB ZGQgUVdlYlBhZ2U6OnNldEVkaXRhYmxlKCkvUVdlYlBhZ2U6OmlzRWRpdGFibGUoKQoKICAgICAg ICAqIEFwaS9xd2VicGFnZS5jcHA6CiAgICAgICAgKFFXZWJQYWdlUHJpdmF0ZTo6UVdlYlBhZ2VQ cml2YXRlKToKICAgICAgICAoUVdlYlBhZ2U6OnNldEVkaXRhYmxlKToKICAgICAgICAoUVdlYlBh Z2U6OmlzRWRpdGFibGUpOgogICAgICAgICogQXBpL3F3ZWJwYWdlLmg6CiAgICAgICAgKiBBcGkv cXdlYnBhZ2VfcC5oOiBpbXBsZW1lbnQgdGhlIGVkaXRhYmxlIHByb3BlcnR5IGFuZCBhZGQgQVBJ IHNvIHRoYXQKICAgICAgICBhcHBsaWNhdGlvbnMgY2FuIHN3aXRjaCBlZGl0IG1vZGUgb24gYW5k IG9mZiBmb3IgYSBwYXJ0aWN1bGFyIFFXZWJQYWdlCiAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9F ZGl0b3JDbGllbnRRdC5jcHA6IHJldHJpZXZlIGVkaXRhYmxlIHByb3BlcnR5IGZyb20gdGhlCiAg ICAgICAgUVdlYlBhZ2UgaW5zdGVhZCBvZiBhbHdheXMgcmV0dXJuaW5nIGZhbHNlCi0tLQogV2Vi S2l0L3F0L0FwaS9xd2VicGFnZS5jcHAgICAgICAgICAgICAgICAgICB8ICAgMjggKysrKysrKysr KysrKysrKysrKysrKysrKysrCiBXZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmggICAgICAgICAgICAg ICAgICAgIHwgICAgNCArKysKIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2VfcC5oICAgICAgICAgICAg ICAgICAgfCAgICAxICsKIFdlYktpdC9xdC9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgfCAgIDE0ICsrKysrKysrKysrKysKIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JD bGllbnRRdC5jcHAgfCAgICAzICstCiA1IGZpbGVzIGNoYW5nZWQsIDQ4IGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAg Yi9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAppbmRleCBmYzJmMjZiLi5hOWViZGU0IDEwMDY0 NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcAorKysgYi9XZWJLaXQvcXQvQXBpL3F3 ZWJwYWdlLmNwcApAQCAtMTU4LDYgKzE1OCw3IEBAIFFXZWJQYWdlUHJpdmF0ZTo6UVdlYlBhZ2VQ cml2YXRlKFFXZWJQYWdlICpxcSkKICAgICBwbHVnaW5GYWN0b3J5ID0gMDsKICAgICBpbnNpZGVP cGVuQ2FsbCA9IGZhbHNlOwogICAgIGZvcndhcmRVbnN1cHBvcnRlZENvbnRlbnQgPSBmYWxzZTsK KyAgICBlZGl0YWJsZSA9IGZhbHNlOwogICAgIGxpbmtQb2xpY3kgPSBRV2ViUGFnZTo6RG9udERl bGVnYXRlTGlua3M7CiAgICAgY3VycmVudENvbnRleHRNZW51ID0gMDsKIApAQCAtMTczMyw2ICsx NzM0LDMzIEBAIGJvb2wgUVdlYlBhZ2U6OmZvY3VzTmV4dFByZXZDaGlsZChib29sIG5leHQpCiB9 CiAKIC8qIQorICAgIFxwcm9wZXJ0eSBRV2ViUGFnZTo6ZWRpdGFibGUKKyAgICBcYnJpZWYgd2hl dGhlciB0aGUgY29udGVudCBpbiB0aGlzIFFXZWJQYWdlIGlzIGVkaXRhYmxlIG9yIG5vdAorKi8K K3ZvaWQgUVdlYlBhZ2U6OnNldEVkaXRhYmxlKGJvb2wgZWRpdGFibGUpCit7CisgICAgaWYgKGQt PmVkaXRhYmxlICE9IGVkaXRhYmxlKSB7CisgICAgICAgIGQtPmVkaXRhYmxlID0gZWRpdGFibGU7 CisgICAgICAgIGQtPnBhZ2UtPnNldFRhYktleUN5Y2xlc1Rocm91Z2hFbGVtZW50cyghZWRpdGFi bGUpOworICAgICAgICBpZiAoZC0+bWFpbkZyYW1lKSB7CisgICAgICAgICAgICBXZWJDb3JlOjpG cmFtZSogZnJhbWUgPSBkLT5tYWluRnJhbWUtPmQtPmZyYW1lOworICAgICAgICAgICAgaWYgKGVk aXRhYmxlKSB7CisgICAgICAgICAgICAgICAgZnJhbWUtPmFwcGx5RWRpdGluZ1N0eWxlVG9Cb2R5 RWxlbWVudCgpOworICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBtYWMgcG9ydCBjYWxscyB0aGlz IGlmIHRoZXJlIGlzIG5vIHNlbGVjdGVkRE9NUmFuZ2UKKyAgICAgICAgICAgICAgICAvL2ZyYW1l LT5zZXRTZWxlY3Rpb25Gcm9tTm9uZSgpOworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAg ICAgICAgICBmcmFtZS0+cmVtb3ZlRWRpdGluZ1N0eWxlRnJvbUJvZHlFbGVtZW50KCk7CisgICAg ICAgICAgICB9CisgICAgICAgIH0KKyAgICB9Cit9CisKK2Jvb2wgUVdlYlBhZ2U6OmlzRWRpdGFi bGUoKSBjb25zdAoreworICAgIHJldHVybiBkLT5lZGl0YWJsZTsKK30KKworLyohCiAgICAgXHBy b3BlcnR5IFFXZWJQYWdlOjpmb3J3YXJkVW5zdXBwb3J0ZWRDb250ZW50CiAgICAgXGJyaWVmIHdo ZXRoZXIgUVdlYlBhZ2Ugc2hvdWxkIGZvcndhcmQgdW5zdXBwb3J0ZWQgY29udGVudCB0aHJvdWdo IHRoZQogICAgIHVuc3VwcG9ydGVkQ29udGVudCBzaWduYWwKZGlmZiAtLWdpdCBhL1dlYktpdC9x dC9BcGkvcXdlYnBhZ2UuaCBiL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuaAppbmRleCA3MDE4Yzhm Li5kMzg4Y2RmIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmgKKysrIGIvV2Vi S2l0L3F0L0FwaS9xd2VicGFnZS5oCkBAIC02Niw2ICs2Niw3IEBAIGNsYXNzIFFXRUJLSVRfRVhQ T1JUIFFXZWJQYWdlIDogcHVibGljIFFPYmplY3QKICAgICBRX1BST1BFUlRZKGJvb2wgZm9yd2Fy ZFVuc3VwcG9ydGVkQ29udGVudCBSRUFEIGZvcndhcmRVbnN1cHBvcnRlZENvbnRlbnQgV1JJVEUg c2V0Rm9yd2FyZFVuc3VwcG9ydGVkQ29udGVudCkKICAgICBRX1BST1BFUlRZKExpbmtEZWxlZ2F0 aW9uUG9saWN5IGxpbmtEZWxlZ2F0aW9uUG9saWN5IFJFQUQgbGlua0RlbGVnYXRpb25Qb2xpY3kg V1JJVEUgc2V0TGlua0RlbGVnYXRpb25Qb2xpY3kpCiAgICAgUV9QUk9QRVJUWShRUGFsZXR0ZSBw YWxldHRlIFJFQUQgcGFsZXR0ZSBXUklURSBzZXRQYWxldHRlKQorICAgIFFfUFJPUEVSVFkoYm9v bCBlZGl0YWJsZSBSRUFEIGlzRWRpdGFibGUgV1JJVEUgc2V0RWRpdGFibGUpCiAgICAgUV9FTlVN UyhMaW5rRGVsZWdhdGlvblBvbGljeSBOYXZpZ2F0aW9uVHlwZSBXZWJBY3Rpb24pCiBwdWJsaWM6 CiAgICAgZW51bSBOYXZpZ2F0aW9uVHlwZSB7CkBAIC0yMjEsNiArMjIyLDkgQEAgcHVibGljOgog ICAgIHZvaWQgc2V0UGFsZXR0ZShjb25zdCBRUGFsZXR0ZSAmcGFsZXR0ZSk7CiAgICAgUVBhbGV0 dGUgcGFsZXR0ZSgpIGNvbnN0OwogCisgICAgdm9pZCBzZXRFZGl0YWJsZShib29sIGVkaXRhYmxl ID0gdHJ1ZSk7CisgICAgYm9vbCBpc0VkaXRhYmxlKCkgY29uc3Q7CisKICAgICBib29sIHN3YWxs b3dDb250ZXh0TWVudUV2ZW50KFFDb250ZXh0TWVudUV2ZW50ICpldmVudCk7CiAgICAgdm9pZCB1 cGRhdGVQb3NpdGlvbkRlcGVuZGVudEFjdGlvbnMoY29uc3QgUVBvaW50ICZwb3MpOwogCmRpZmYg LS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlX3AuaCBiL1dlYktpdC9xdC9BcGkvcXdlYnBh Z2VfcC5oCmluZGV4IDJmZDRkOTIuLjFhZDk0ZmEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkv cXdlYnBhZ2VfcC5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2VfcC5oCkBAIC0xNDgsNiAr MTQ4LDcgQEAgcHVibGljOgogICAgIFFNZW51ICpjdXJyZW50Q29udGV4dE1lbnU7CiAgICAgUVdl YlNldHRpbmdzICpzZXR0aW5nczsKICAgICBRUGFsZXR0ZSBwYWxldHRlOworICAgIGJvb2wgZWRp dGFibGU7CiAKICAgICBRQWN0aW9uICphY3Rpb25zW1FXZWJQYWdlOjpXZWJBY3Rpb25Db3VudF07 CiAKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9n CmluZGV4IDgwYTJjNzEuLjZmZTc4MTkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDA4LTA1LTI2ICBK b25hdGhvbiBKb25nc21hICA8am9uYXRob24uam9uZ3NtYUBjb2xsYWJvcmEuY28udWs+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBBcGkvcXdlYnBh Z2UuY3BwOgorICAgICAgICAoUVdlYlBhZ2VQcml2YXRlOjpRV2ViUGFnZVByaXZhdGUpOgorICAg ICAgICAoUVdlYlBhZ2U6OnNldEVkaXRhYmxlKToKKyAgICAgICAgKFFXZWJQYWdlOjppc0VkaXRh YmxlKToKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuaDoKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2Vf cC5oOiBpbXBsZW1lbnQgdGhlIGVkaXRhYmxlIHByb3BlcnR5IGFuZCBhZGQgQVBJIHNvIHRoYXQK KyAgICAgICAgYXBwbGljYXRpb25zIGNhbiBzd2l0Y2ggZWRpdCBtb2RlIG9uIGFuZCBvZmYgZm9y IGEgcGFydGljdWxhciBRV2ViUGFnZQorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0VkaXRvckNs aWVudFF0LmNwcDogcmV0cmlldmUgZWRpdGFibGUgcHJvcGVydHkgZnJvbSB0aGUKKyAgICAgICAg UVdlYlBhZ2UgaW5zdGVhZCBvZiBhbHdheXMgcmV0dXJuaW5nIGZhbHNlCisKIDIwMDgtMDUtMTMg IEFuZHkgU2hhdyAgPGFuZHlAdHJvbGx0ZWNoLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT aW1vbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRR dC5jcHAgYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRWRpdG9yQ2xpZW50UXQuY3BwCmluZGV4 IDFiNzNiMzEuLjUyZmU2YTggMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9F ZGl0b3JDbGllbnRRdC5jcHAKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNs aWVudFF0LmNwcApAQCAtMjQ0LDggKzI0NCw3IEBAIGJvb2wgRWRpdG9yQ2xpZW50UXQ6OnNlbGVj dFdvcmRCZWZvcmVNZW51RXZlbnQoKQogCiBib29sIEVkaXRvckNsaWVudFF0Ojppc0VkaXRhYmxl KCkKIHsgCi0gICAgLy8gRklYTUU6IHNob3VsZCBiZSBjb250cm9sbGFibGUgYnkgYSBzZXR0aW5n IGluIFFXZWJQYWdlCi0gICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiBtX3BhZ2UtPmlzRWRp dGFibGUoKTsKIH0KIAogdm9pZCBFZGl0b3JDbGllbnRRdDo6cmVnaXN0ZXJDb21tYW5kRm9yVW5k byhXVEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6RWRpdENvbW1hbmQ+IGNtZCkKLS0gCjEuNS41Cgo=