193217 2019-01-07 15:10:24 -0800 Crash in SWServer::Connection::resolveRegistrationReadyRequests 2019-01-07 16:39:37 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=187115 InRadar P2 Normal --- 1 youennf youennf cdumez commit-queue webkit-bug-importer oldest_to_newest 1492430 0 youennf 2019-01-07 15:10:24 -0800 Thread 0 Crashed: 0 WebCore 0x00000001c5309048 WebCore::SWServer::Connection::resolveRegistrationReadyRequests(WebCore::SWServerRegistration&) + 40 (Vector.h:337) 1 WebCore 0x00000001c530b104 WebCore::SWServerRegistration::activate() + 208 (SWServer.cpp:823) 2 WebCore 0x00000001c530b104 WebCore::SWServerRegistration::activate() + 208 (SWServer.cpp:823) 3 WebCore 0x00000001c5308b80 WebCore::SWServer::unregisterServiceWorkerClient(WebCore::ClientOrigin const&, WebCore::ServiceWorkerClientIdentifier) + 1576 (SWServer.cpp:810) 4 WebKit 0x00000001cb13927c WebKit::WebSWServerConnection::~WebSWServerConnection() + 308 (WebSWServerConnection.cpp:76) 5 WebKit 0x00000001cb1393d8 WebKit::WebSWServerConnection::~WebSWServerConnection() + 12 (WebSWServerConnection.cpp:73) 6 WebCore 0x00000001c5300084 WebCore::SWServer::~SWServer() + 92 (memory:2285) 7 WebKit 0x00000001cadcfd50 WTF::KeyValuePairHashTraits<WTF::HashTraits<PAL::SessionID>, WTF::HashTraits<std::__1::unique_ptr<WebCore::SWServer, std::__1::default_delete<WebCore::SWServer> > > >::customDeleteBucket(WTF::KeyValuePair<PAL::SessionID, std::__1::unique_ptr<WebCore::SWServer, std::__1::default_delete<WebCore::SWServer> > >&) + 32 (memory:2285) 8 WebKit 0x00000001cadcfcdc WTF::HashTable<PAL::SessionID, WTF::KeyValuePair<PAL::SessionID, std::__1::unique_ptr<WebCore::SWServer, std::__1::default_delete<WebCore::SWServer> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<PAL::SessionID, std::__1::unique_ptr<WebCore::SWServer, std::__1::default_delete<WebCore::SWServer> > > >, WTF::SessionIDHash, WTF::HashMap<PAL::SessionID, std::__1::unique_ptr<WebCore::SWServer, std::__1::default_delete<WebCore::SWServer> >, WTF::SessionIDHash, WTF::HashTraits<PAL::SessionID>, WTF::HashTraits<std::__1::unique_ptr<WebCore::SWServer, std::__1::default_delete<WebCore::SWServer> > > >::KeyValuePairTraits, WTF::HashTraits<PAL::SessionID> >::remove(WTF::KeyValuePair<PAL::SessionID, std::__1::unique_ptr<WebCore::SWServer, std::__1::default_delete<WebCore::SWServer> > >*) + 24 (HashTraits.h:253) 9 WebKit 0x00000001cadba594 WTF::HashMap<PAL::SessionID, std::__1::unique_ptr<WebCore::SWServer, std::__1::default_delete<WebCore::SWServer> >, WTF::SessionIDHash, WTF::HashTraits<PAL::SessionID>, WTF::HashTraits<std::__1::unique_ptr<WebCore::SWServer, std::__1::default_delete<WebCore::SWServer> > > >::remove(PAL::SessionID const&) + 56 (HashTable.h:1045) 10 WebKit 0x00000001cadba4f0 WebKit::NetworkProcess::destroySession(PAL::SessionID) + 64 (NetworkProcess.cpp:463) 11 WebKit 0x00000001cad8be40 WebKit::NetworkProcess::didReceiveNetworkProcessMessage(IPC::Connection&, IPC::Decoder&) + 2808 (HandleMessage.h:41) 12 WebKit 0x00000001cad72e50 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 148 (Connection.cpp:978) 1492434 1 358539 youennf 2019-01-07 15:14:57 -0800 Created attachment 358539 Patch 1492445 2 youennf 2019-01-07 15:27:15 -0800 <rdar://problem/45489324> 1492452 3 358539 cdumez 2019-01-07 15:37:42 -0800 Comment on attachment 358539 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358539&action=review > Source/WebCore/ChangeLog:10 > + This method is iterating on the connectionds HashMap which is being cleared. typo: connectionds 1492465 4 358549 youennf 2019-01-07 16:01:31 -0800 Created attachment 358549 Patch for landing 1492489 5 358549 commit-queue 2019-01-07 16:39:36 -0800 Comment on attachment 358549 Patch for landing Clearing flags on attachment: 358549 Committed r239715: <https://trac.webkit.org/changeset/239715> 1492490 6 commit-queue 2019-01-07 16:39:37 -0800 All reviewed patches have been landed. Closing bug. 358539 2019-01-07 15:14:57 -0800 2019-01-07 16:01:29 -0800 Patch bug-193217-20190107151456.patch text/plain 1790 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODFhMGExZDU3OGM3YzMx MjIyOWY1OWExNmQ3MDk4NmQwNjA2N2VmYS4uMjgyYTU2Y2E1NTM5ZjAyNzU0ZDU4NzE2ZDIwNTky Y2QzZTNjMTUwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAxLTA3ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBTV1NlcnZl cjo6Q29ubmVjdGlvbjo6cmVzb2x2ZVJlZ2lzdHJhdGlvblJlYWR5UmVxdWVzdHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzIxNworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIGNhbiBiZSBzZWVuIGZy b20gdGhlIHRyYWNlcywgU1dTZXJ2ZXIgbWlnaHQgY2xlYXIgaXRzIGNvbm5lY3Rpb25zIEhhc2hN YXAgaW4gaXRzIGRlc3RydWN0b3IuCisgICAgICAgIFRoaXMgbWlnaHQgdGhlbiB0cmlnZ2VyIGNh bGxpbmcgU1dTZXJ2ZXI6OnJlc29sdmVSZWdpc3RyYXRpb25SZWFkeVJlcXVlc3RzLgorICAgICAg ICBUaGlzIG1ldGhvZCBpcyBpdGVyYXRpbmcgb24gdGhlIGNvbm5lY3Rpb25kcyBIYXNoTWFwIHdo aWNoIGlzIGJlaW5nIGNsZWFyZWQuCisgICAgICAgIFRvIHJlbW92ZSB0aGUgcHJvYmxlbSwgbW92 ZSB0aGUgSGFzaE1hcCBpbiBhIHRlbXBvcmFyeSB2YXJpYWJsZSBhbmQgY2xlYXIgdGhlIHRlbXBv cmFyeSB2YXJpYWJsZS4KKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2 ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1dTZXJ2ZXI6On5TV1NlcnZlcik6CisKIDIwMTkt MDEtMDUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIHNlcnZp Y2Ugd29ya2VyIGZldGNoIGhhbmRsZXIgcmVzdWx0cyBpbiBiYWQgcmVmZXJyZXIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL3NlcnZlci9TV1NlcnZlci5jcHAKaW5kZXgg Zjg3NmI4MmJlNmFiZjExMjM1ZjZhMjY5N2NlMjVhZGFkOTFmZTc3Ny4uMDQ0YmM4NDEzODgyNzlk ZDUyYTY2MzRlNmIyYjEzMzU2NzRjNjZiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29y a2Vycy9zZXJ2aWNlL3NlcnZlci9TV1NlcnZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvd29y a2Vycy9zZXJ2aWNlL3NlcnZlci9TV1NlcnZlci5jcHAKQEAgLTY2LDcgKzY2LDggQEAgU1dTZXJ2 ZXI6On5TV1NlcnZlcigpCiB7CiAgICAgLy8gRGVzdHJveSB0aGUgcmVtYWluaW5nIGNvbm5lY3Rp b25zIGJlZm9yZSB0aGUgU1dTZXJ2ZXIgZ2V0cyBkZXN0cm95ZWQgc2luY2UgdGhleSBoYXZlIGEg cmF3IHBvaW50ZXIKICAgICAvLyB0byB0aGUgc2VydmVyIGFuZCBzaW5jZSB0aGV5IHRyeSB0byB1 bnJlZ2lzdGVyIGNsaWVudHMgZnJvbSB0aGUgc2VydmVyIGluIHRoZWlyIGRlc3RydWN0b3IuCi0g ICAgbV9jb25uZWN0aW9ucy5jbGVhcigpOworICAgIGF1dG8gY29ubmVjdGlvbnMgPSBXVEZNb3Zl KG1fY29ubmVjdGlvbnMpOworICAgIGNvbm5lY3Rpb25zLmNsZWFyKCk7CiAKICAgICBhbGxTZXJ2 ZXJzKCkucmVtb3ZlKHRoaXMpOwogfQo= 358549 2019-01-07 16:01:31 -0800 2019-01-07 16:39:36 -0800 Patch for landing bug-193217-20190107160130.patch text/plain 1800 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGFiY2RiOGVhMzRmN2I5 MzYxOTUxMjE3Y2RkOGU1OTEyYjdjZDhlNy4uOThlNzU5YTA2Zjk5MzU3M2M5MzJiNTBkMjhkMWQ2 ZDNmNGI4MGY3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE5LTAxLTA3ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBTV1NlcnZl cjo6Q29ubmVjdGlvbjo6cmVzb2x2ZVJlZ2lzdHJhdGlvblJlYWR5UmVxdWVzdHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MzIxNworCisgICAgICAg IFJldmlld2VkIGJ5IENocmlzIER1bWV6LgorCisgICAgICAgIEFzIGNhbiBiZSBzZWVuIGZyb20g dGhlIHRyYWNlcywgU1dTZXJ2ZXIgbWlnaHQgY2xlYXIgaXRzIGNvbm5lY3Rpb25zIEhhc2hNYXAg aW4gaXRzIGRlc3RydWN0b3IuCisgICAgICAgIFRoaXMgbWlnaHQgdGhlbiB0cmlnZ2VyIGNhbGxp bmcgU1dTZXJ2ZXI6OnJlc29sdmVSZWdpc3RyYXRpb25SZWFkeVJlcXVlc3RzLgorICAgICAgICBU aGlzIG1ldGhvZCBpcyBpdGVyYXRpbmcgb24gdGhlIGNvbm5lY3Rpb25zIEhhc2hNYXAgd2hpY2gg aXMgYmVpbmcgY2xlYXJlZC4KKyAgICAgICAgVG8gcmVtb3ZlIHRoaXMgcHJvYmxlbSwgbW92ZSB0 aGUgSGFzaE1hcCBpbiBhIHRlbXBvcmFyeSB2YXJpYWJsZSBhbmQgY2xlYXIgdGhlIHRlbXBvcmFy eSB2YXJpYWJsZS4KKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U1dTZXJ2ZXI6On5TV1NlcnZlcik6CisKIDIwMTktMDEt MDcgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIElEQiBzdG9y YWdlIG9mIENyeXB0byBrZXlzIGRvZXMgbm90IHdvcmsgaW4gcHJpdmF0ZSBicm93c2luZyBtb2Rl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uvc2VydmVyL1NXU2Vy dmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIu Y3BwCmluZGV4IGY4NzZiODJiZTZhYmYxMTIzNWY2YTI2OTdjZTI1YWRhZDkxZmU3NzcuLjA0NGJj ODQxMzg4Mjc5ZGQ1MmE2NjM0ZTZiMmIxMzM1Njc0YzY2YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3dvcmtlcnMvc2VydmljZS9zZXJ2ZXIvU1dTZXJ2ZXIuY3BwCkBAIC02Niw3ICs2Niw4 IEBAIFNXU2VydmVyOjp+U1dTZXJ2ZXIoKQogewogICAgIC8vIERlc3Ryb3kgdGhlIHJlbWFpbmlu ZyBjb25uZWN0aW9ucyBiZWZvcmUgdGhlIFNXU2VydmVyIGdldHMgZGVzdHJveWVkIHNpbmNlIHRo ZXkgaGF2ZSBhIHJhdyBwb2ludGVyCiAgICAgLy8gdG8gdGhlIHNlcnZlciBhbmQgc2luY2UgdGhl eSB0cnkgdG8gdW5yZWdpc3RlciBjbGllbnRzIGZyb20gdGhlIHNlcnZlciBpbiB0aGVpciBkZXN0 cnVjdG9yLgotICAgIG1fY29ubmVjdGlvbnMuY2xlYXIoKTsKKyAgICBhdXRvIGNvbm5lY3Rpb25z ID0gV1RGTW92ZShtX2Nvbm5lY3Rpb25zKTsKKyAgICBjb25uZWN0aW9ucy5jbGVhcigpOwogCiAg ICAgYWxsU2VydmVycygpLnJlbW92ZSh0aGlzKTsKIH0K