193119 2019-01-03 12:02:27 -0800 [MSVC] Add .natvis support of WebKit types 2020-03-04 23:51:14 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead basuke basuke bfulgham commit-queue don.olmstead lforschler webkit-bug-importer oldest_to_newest 1491484 0 don.olmstead 2019-01-03 12:02:27 -0800 Would be nice to do something similar with Visual Studio that's being done for gdb to get better views of WTF data types. https://docs.microsoft.com/en-us/visualstudio/debugger/create-custom-views-of-native-objects?view=vs-2017 1625778 1 392485 basuke 2020-03-04 14:32:11 -0800 Created attachment 392485 PATCH 1625854 2 392485 don.olmstead 2020-03-04 16:55:54 -0800 Comment on attachment 392485 PATCH Seems fine just want to see if Apple folks have any issues with it all. 1625964 3 392485 commit-queue 2020-03-04 23:50:52 -0800 Comment on attachment 392485 PATCH Clearing flags on attachment: 392485 Committed r257906: <https://trac.webkit.org/changeset/257906> 1625965 4 commit-queue 2020-03-04 23:50:54 -0800 All reviewed patches have been landed. Closing bug. 1625966 5 webkit-bug-importer 2020-03-04 23:51:14 -0800 <rdar://problem/60074016> 392485 2020-03-04 14:32:11 -0800 2020-03-04 23:50:52 -0800 PATCH bug-193119.diff text/plain 3793 basuke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiNDEw NTExMzE0NDkuLjMyMTAwZGVkYThiZCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTA0ICBCYXN1a2UgU3V6 dWtpICA8YmFzdWtlLnN1enVraUBzb255LmNvbT4KKworICAgICAgICBbTVNWQ10gQWRkIC5uYXR2 aXMgc3VwcG9ydCBvZiBXZWJLaXQgdHlwZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5MzExOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRvIGhlbHAgdGhlIFdlYktpdCBkZXZlbG9wZXIgd2hpbGUgZGVi dWdnaW5nLCB0aGlzIGZpbGUgZGVmaW5lcyBob3cKKyAgICAgICAgV2ViS2l0IHR5cGVzIGFyZSBk aXNwbGF5ZWQgaW4gZGVidWdnZXIgb2YgVmlzdWFsIFN0dWRpby4KKyAgICAgICAgVmVyeSBsaW1p dGVkIHNldCBvZiBXZWJLaXQgdHlwZXMsIGJ1dCBpdCBjaGFuZ2VzIHRoZSB3b3JsZC4KKworICAg ICAgICAqIFZpc3VhbFN0dWRpby9XZWJLaXQubmF0dmlzOiBBZGRlZC4KKwogMjAyMC0wMy0wMiAg Sm9obiBXaWxhbmRlciAgPHdpbGFuZGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXNvdXJjZUxv YWRTdGF0aXN0aWNzOiBFbmFibGUgY29va2llIGJsb2NraW5nIGFuZCB0aGUgU3RvcmFnZSBBY2Nl c3MgQVBJIGluIGVwaGVtZXJhbCBzZXNzaW9ucwpkaWZmIC0tZ2l0IGEvVG9vbHMvVmlzdWFsU3R1 ZGlvL1dlYktpdC5uYXR2aXMgYi9Ub29scy9WaXN1YWxTdHVkaW8vV2ViS2l0Lm5hdHZpcwpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAuLmMwNDNjNzU3N2UwMAotLS0gL2Rl di9udWxsCisrKyBiL1Rvb2xzL1Zpc3VhbFN0dWRpby9XZWJLaXQubmF0dmlzCkBAIC0wLDAgKzEs ODQgQEAKKzw/eG1sIHZlcnNpb249IjEuMCIgZW5jb2Rpbmc9InV0Zi04Ij8+IA0KKzxBdXRvVmlz dWFsaXplciB4bWxucz0iaHR0cDovL3NjaGVtYXMubWljcm9zb2Z0LmNvbS92c3R1ZGlvL2RlYnVn Z2VyL25hdHZpcy8yMDEwIj4NCisgIDwhLS0NCisgICAgUGxhY2UgdGhpcyBmaWxlIHRvICVVU0VS UFJPRklMRSVcRG9jdW1lbnRzXFZpc3VhbCBTdHVkaW8gMjAxOVxWaXN1YWxpemVycw0KKyAgICBG b3IgbW9yZSBpbmZvOg0KKyAgICAgIGh0dHBzOi8vZG9jcy5taWNyb3NvZnQuY29tL2VuLXVzL3Zp c3VhbHN0dWRpby9kZWJ1Z2dlci9jcmVhdGUtY3VzdG9tLXZpZXdzLW9mLW5hdGl2ZS1vYmplY3Rz P3ZpZXc9dnMtMjAxOQ0KKyAgLS0+DQorICA8VHlwZSBOYW1lPSJXVEY6OlJlZlB0ciZsdDsqJmd0 OyI+DQorICAgIDxEaXNwbGF5U3RyaW5nIENvbmRpdGlvbj0ibV9wdHIgPT0gMCI+ZW1wdHk8L0Rp c3BsYXlTdHJpbmc+DQorICAgIDxEaXNwbGF5U3RyaW5nPnsqbV9wdHJ9PC9EaXNwbGF5U3RyaW5n Pg0KKyAgPC9UeXBlPg0KKyAgPFR5cGUgTmFtZT0iV1RGOjpVbmlxdWVSZWYmbHQ7KiZndDsiPg0K KyAgICA8RGlzcGxheVN0cmluZz57bV9yZWZ9PC9EaXNwbGF5U3RyaW5nPg0KKyAgPC9UeXBlPg0K KyAgDQorICA8VHlwZSBOYW1lPSJXVEY6OlN0cmluZ0ltcGxTaGFwZSI+DQorICAgIDwhLS0gQXRv bVN0cmluZyAtLT4NCisgICAgPERpc3BsYXlTdHJpbmcgQ29uZGl0aW9uPSIobV9oYXNoQW5kRmxh Z3MgJmFtcDsgMHgxMCkgJmFtcDsmYW1wOyAobV9oYXNoQW5kRmxhZ3MgJmFtcDsgNCkiPg0KKyAg ICAgIEF0b206e21fZGF0YTgsW21fbGVuZ3RoXXN9DQorICAgIDwvRGlzcGxheVN0cmluZz4NCisg ICAgPERpc3BsYXlTdHJpbmcgQ29uZGl0aW9uPSIobV9oYXNoQW5kRmxhZ3MgJmFtcDsgMHgxMCki Pg0KKyAgICAgIEF0b206e21fZGF0YTE2LFttX2xlbmd0aF1zdX0NCisgICAgPC9EaXNwbGF5U3Ry aW5nPg0KKw0KKyAgICA8IS0tIFN5bWJvbCAtLT4NCisgICAgPERpc3BsYXlTdHJpbmcgQ29uZGl0 aW9uPSIobV9oYXNoQW5kRmxhZ3MgJmFtcDsgMHgyMCkgJmFtcDsmYW1wOyAobV9oYXNoQW5kRmxh Z3MgJmFtcDsgNCkiPg0KKyAgICAgICZsdDt7bV9kYXRhOCxbbV9sZW5ndGhdc30mZ3Q7DQorICAg IDwvRGlzcGxheVN0cmluZz4NCisgICAgPERpc3BsYXlTdHJpbmcgQ29uZGl0aW9uPSIobV9oYXNo QW5kRmxhZ3MgJmFtcDsgMHgyMCkiPg0KKyAgICAgICZsdDt7bV9kYXRhMTYsW21fbGVuZ3RoXXN1 fSZndDsNCisgICAgPC9EaXNwbGF5U3RyaW5nPg0KKw0KKyAgICA8RGlzcGxheVN0cmluZyBDb25k aXRpb249IihtX2hhc2hBbmRGbGFncyAmYW1wOyA0KSI+DQorICAgICAge21fZGF0YTgsW21fbGVu Z3RoXXN9DQorICAgIDwvRGlzcGxheVN0cmluZz4NCisgICAgPERpc3BsYXlTdHJpbmcgQ29uZGl0 aW9uPSIhKG1faGFzaEFuZEZsYWdzICZhbXA7IDQpIj4NCisgICAgICB7bV9kYXRhMTYsW21fbGVu Z3RoXXN1fQ0KKyAgICA8L0Rpc3BsYXlTdHJpbmc+DQorDQorICAgIDxEaXNwbGF5U3RyaW5nPm5v dCBzdXBwb3J0ZWQgKHttX2hhc2hBbmRGbGFnc30pPC9EaXNwbGF5U3RyaW5nPg0KKyAgPC9UeXBl Pg0KKyAgDQorICA8VHlwZSBOYW1lPSJXVEY6OlN0cmluZyI+DQorICAgIDxEaXNwbGF5U3RyaW5n PnttX2ltcGx9PC9EaXNwbGF5U3RyaW5nPg0KKyAgPC9UeXBlPg0KKw0KKyAgPFR5cGUgTmFtZT0i SVBDOjpTdHJpbmdSZWZlcmVuY2UiPg0KKyAgICA8RGlzcGxheVN0cmluZyBDb25kaXRpb249IiFt X3NpemUiPmVtcHR5PC9EaXNwbGF5U3RyaW5nPg0KKyAgICA8RGlzcGxheVN0cmluZz57bV9kYXRh LFttX3NpemVdczh9PC9EaXNwbGF5U3RyaW5nPg0KKyAgPC9UeXBlPg0KKyAgDQorICA8VHlwZSBO YW1lPSJJUEM6OkRlY29kZXIiPg0KKyAgICA8RGlzcGxheVN0cmluZz57bV9tZXNzYWdlUmVjZWl2 ZXJOYW1lfTo6e21fbWVzc2FnZU5hbWV9KElEPXttX2Rlc3RpbmF0aW9ufSk8L0Rpc3BsYXlTdHJp bmc+DQorICA8L1R5cGU+DQorICANCisgIDxUeXBlIE5hbWU9IldURjo6VVJMIj4NCisgICAgPERp c3BsYXlTdHJpbmc+e21fc3RyaW5nfTwvRGlzcGxheVN0cmluZz4NCisgIDwvVHlwZT4NCisgIDxU eXBlIE5hbWU9IldURjo6QXRvbVN0cmluZyI+DQorICAgIDxEaXNwbGF5U3RyaW5nPnttX3N0cmlu Z30gKEF0b20pPC9EaXNwbGF5U3RyaW5nPg0KKyAgPC9UeXBlPg0KKyANCisgIDxUeXBlIE5hbWU9 IlBBTDo6U2Vzc2lvbklEIj4NCisgICAgPERpc3BsYXlTdHJpbmc+e21faWRlbnRpZmllcn08L0Rp c3BsYXlTdHJpbmc+DQorICA8L1R5cGU+DQorICANCisgIDxUeXBlIE5hbWU9IldURjo6T2JqZWN0 SWRlbnRpZmllciZsdDsqJmd0OyI+DQorICAgIDxEaXNwbGF5U3RyaW5nPnttX2lkZW50aWZpZXJ9 PC9EaXNwbGF5U3RyaW5nPg0KKyAgPC9UeXBlPg0KKw0KKyAgPFR5cGUgTmFtZT0iV1RGOjpPcHRp b25TZXQmbHQ7KiZndDsiPg0KKyAgICA8RGlzcGxheVN0cmluZz57bV9zdG9yYWdlLHh9PC9EaXNw bGF5U3RyaW5nPg0KKyAgPC9UeXBlPg0KKw0KKyAgPFR5cGUgTmFtZT0iV2ViQ29yZTo6SW50U2l6 ZSI+DQorICAgIDxEaXNwbGF5U3RyaW5nPih7bV93aWR0aH0geCB7bV9oZWlnaHR9KTwvRGlzcGxh eVN0cmluZz4NCisgIDwvVHlwZT4NCisNCisgIDwhLS0gTmV0d29ya2luZyAtLT4NCisNCisgIDxU eXBlIE5hbWU9IldlYkNvcmU6OlJlc291cmNlUmVxdWVzdCI+DQorICAgIDxEaXNwbGF5U3RyaW5n PnttX2h0dHBNZXRob2R9IHttX3VybH0ge21faHR0cEJvZHl9PC9EaXNwbGF5U3RyaW5nPg0KKyAg PC9UeXBlPiAgDQorPC9BdXRvVmlzdWFsaXplcj4NCg==