19311 2008-05-29 10:46:31 -0700 On Mac, no way to differentiate Apple port from others in build scripts 2008-05-29 11:04:11 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED Gtk, Qt, Wx P2 Normal --- 1 kevino webkit-unassigned oldest_to_newest 81864 0 kevino 2008-05-29 10:46:31 -0700 In r33446, a change was made to webkitdirs.pm that removed the isDarwin() check and changed isOSX() to behave like isDarwin(). However, isOSX() has always been used for code intended only for the Apple port, not other ports running on OS X, so now ports using build-webkit get the properties/settings intended for the Apple port. 81865 1 21415 kevino 2008-05-29 10:47:16 -0700 Created attachment 21415 Restore original behavior of isOSX() 81867 2 21415 darin 2008-05-29 10:57:47 -0700 Comment on attachment 21415 Restore original behavior of isOSX() Seems fine. Although I would probably use a different phrase from "Apple port". Please don't check in the double-ChangeLog entry. 81869 3 kevino 2008-05-29 11:04:11 -0700 landed in r34206, thanks! :) 21415 2008-05-29 10:47:16 -0700 2008-05-29 10:57:47 -0700 Restore original behavior of isOSX() platform-defines.patch text/plain 1564 kevino SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM0MjA1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMDUtMjkgIEtldmluIE9sbGl2aWVyICA8 a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisgICAgICAgIAorICAgICAgICBSZXN0b3JlIG9yaWdpbmFsIGJlaGF2aW9yIG9mIGlz T1NYKCkgcmVmZXJyaW5nIHRvIHRoZSBBcHBsZSBwb3J0LCBub3QgdGhlIE9TIGl0c2VsZi4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKwogMjAwOC0wNS0yOSAgQWxleGV5IFBy b3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBS b2Jlbi4KQEAgLTEyLDYgKzIwLDE0IEBACiAKIDIwMDgtMDUtMjcgIEtldmluIE9sbGl2aWVyICA8 a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisgICAgICAgIAorICAgICAgICBidWlsZCBzY3JpcHRzIG5lZWQgYSB3YXkgdG8gZGlm ZmVyZW50aWF0ZSBiZXR3ZWVuIEFwcGxlIHBvcnQgYW5kIG90aGVycyBvbiBPUyBYLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorCisyMDA4LTA1LTI3ICBLZXZpbiBPbGxpdmll ciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgorCiAgICAgICAgIHd4IGJ1aWxkIGZpeC4gVXBk YXRlIHRoZSBzYW1wbGUgYXBwIGFmdGVyIHd4V2ViRnJhbWUtPnd4V2ViQnJvd3NlclNoZWxsIHJl bmFtZS4KIAogICAgICAgICAqIHd4L2Jyb3dzZXIvYnJvd3Nlci5jcHA6CkluZGV4OiBXZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCShyZXZpc2lvbiAzNDIwMykKKysrIFdlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbQkod29ya2luZyBjb3B5KQpAQCAtNTEyLDExICs1MTIsMTkgQEAKICAg ICByZXR1cm4gKCReTyBlcSAiY3lnd2luIikgfHwgMDsKIH0KIAotc3ViIGlzT1NYKCkKK3N1YiBp c0RhcndpbigpCiB7CiAgICAgcmV0dXJuICgkXk8gZXEgImRhcndpbiIpIHx8IDA7CiB9CiAKKyMg aXNPU1goKSBvbmx5IHJldHVybnMgdHJ1ZSBmb3IgQXBwbGUncyBwb3J0LCBub3QgZm9yIG90aGVy IHBvcnRzIHRoYXQgY2FuIGJlCisjIGJ1aWx0L3J1biBvbiBPUyBYLgorc3ViIGlzT1NYKCkKK3sK KyAgICByZXR1cm4gaXNEYXJ3aW4oKSB1bmxlc3MgKGlzUXQoKSBvciBpc0d0aygpIG9yIGlzV3go KSk7CisgICAgcmV0dXJuIDA7Cit9CisKIHN1YiBkZXRlcm1pbmVPU1hWZXJzaW9uKCkKIHsKICAg ICByZXR1cm4gaWYgJG9zWFZlcnNpb247Cg==