193104 2019-01-03 07:25:44 -0800 [GLIB] WebDriver: browser close not correctly detected on session close in some cases 2019-01-04 03:41:48 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg bugs-noreply ews-watchlist mcatanzaro webkit-bug-importer oldest_to_newest 1491414 0 cgarcia 2019-01-03 07:25:44 -0800 This happens when the dbus connection is closed right before the response to SendMessageToBackend message is going to be sent. In that case, g_dbus_connection_call async ready handler generates an error before the close signal is emitted. Then the close commands try to handle the error checking if SessionHost::isConnected(), but it still returns true, because the browser is still still alive, but the dbus connection has been closed. 1491415 1 358252 cgarcia 2019-01-03 07:28:16 -0800 Created attachment 358252 Patch 1491416 2 ews-watchlist 2019-01-03 07:30:05 -0800 Attachment 358252 did not pass style-queue: ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:112: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1491417 3 358253 cgarcia 2019-01-03 07:33:09 -0800 Created attachment 358253 Patch 1491611 4 cgarcia 2019-01-04 03:34:08 -0800 Committed r239606: <https://trac.webkit.org/changeset/239606> 1491612 5 webkit-bug-importer 2019-01-04 03:41:48 -0800 <rdar://problem/47045793> 358252 2019-01-03 07:28:16 -0800 2019-01-03 07:33:09 -0800 Patch wd-closed.diff text/plain 1890 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggMTFjODI3MDIyYzcuLjA3NjcwN2Y5OTZiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAxLTAzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl0gV2ViRHJpdmVyOiBicm93c2VyIGNs b3NlIG5vdCBjb3JyZWN0bHkgZGV0ZWN0ZWQgb24gc2Vzc2lvbiBjbG9zZSBpbiBzb21lIGNhc2Vz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTMxMDQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGhh cHBlbnMgd2hlbiB0aGUgZGJ1cyBjb25uZWN0aW9uIGlzIGNsb3NlZCByaWdodCBiZWZvcmUgdGhl IHJlc3BvbnNlIHRvIFNlbmRNZXNzYWdlVG9CYWNrZW5kIG1lc3NhZ2UgaXMKKyAgICAgICAgZ29p bmcgdG8gYmUgc2VudC4gSW4gdGhhdCBjYXNlLCBnX2RidXNfY29ubmVjdGlvbl9jYWxsIGFzeW5j IHJlYWR5IGhhbmRsZXIgZ2VuZXJhdGVzIGFuIGVycm9yIGJlZm9yZSB0aGUgY2xvc2UKKyAgICAg ICAgc2lnbmFsIGlzIGVtaXR0ZWQuIFRoZW4sIHRoZSBjbG9zZSBjb21tYW5kcyB0cnkgdG8gaGFu ZGxlIHRoZSBlcnJvciBjaGVja2luZyBpZiBTZXNzaW9uSG9zdDo6aXNDb25uZWN0ZWQoKSwgYnV0 CisgICAgICAgIGl0IHN0aWxsIHJldHVybnMgdHJ1ZSwgYmVjYXVzZSB0aGUgYnJvd3NlciBpcyBz dGlsbCBhbGl2ZSwgYnV0IHRoZSBkYnVzIGNvbm5lY3Rpb24gaGFzIGJlZW4gY2xvc2VkLgorCisg ICAgICAgICogZ2xpYi9TZXNzaW9uSG9zdEdsaWIuY3BwOgorICAgICAgICAoV2ViRHJpdmVyOjpT ZXNzaW9uSG9zdDo6aXNDb25uZWN0ZWQgY29uc3QpOiBTZXNzaW9uIGlzIGNvbm5lY3RlZCB3aGVu IGxhdW5jaGluZyBvciB3aGVuIGRidXMgY29ubmVjdGlvbiBoYXNuJ3QKKyAgICAgICAgYmVlbiBj bG9zZWQuCisKIDIwMTgtMTItMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHTElCXSBXZWJEcml2ZXI6IGRidXNDb25uZWN0aW9uQ2xvc2Vk Q2FsbGJhY2sgY2FuIGJlIGNhbGxlZCBhZnRlciBTZXNzaW9uSG9zdCBoYXMgYmVlbiBkZWxldGVk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVyL2dsaWIvU2Vzc2lvbkhvc3RHbGliLmNwcCBi L1NvdXJjZS9XZWJEcml2ZXIvZ2xpYi9TZXNzaW9uSG9zdEdsaWIuY3BwCmluZGV4IDM2NGNhODBm ODkzLi4zZTFkNTMxNGI5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9nbGliL1Nlc3Np b25Ib3N0R2xpYi5jcHAKKysrIGIvU291cmNlL1dlYkRyaXZlci9nbGliL1Nlc3Npb25Ib3N0R2xp Yi5jcHAKQEAgLTEwOCw3ICsxMDgsOCBAQCB2b2lkIFNlc3Npb25Ib3N0Ojpjb25uZWN0VG9Ccm93 c2VyKEZ1bmN0aW9uPHZvaWQgKE9wdGlvbmFsPFN0cmluZz4gZXJyb3IpPiYmIGNvbQogCiBib29s IFNlc3Npb25Ib3N0Ojppc0Nvbm5lY3RlZCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuICEhbV9icm93 c2VyOworICAgIC8vIFNlc3Npb24gaXMgY29ubmVjdGVkIHdoZW4gbGF1bmNoaW5nIG9yIHdoZW4g ZGJ1cyBjb25uZWN0aW9uIGhhc24ndCBiZWVuIGNsb3NlZC4KKyAgICByZXR1cm4gbV9icm93c2Vy ICYmICghbV9kYnVzQ29ubmVjdGlvbiB8fCAhZ19kYnVzX2Nvbm5lY3Rpb25faXNfY2xvc2VkKG1f ZGJ1c0Nvbm5lY3Rpb24uZ2V0KCkpKSA7CiB9CiAKIHN0cnVjdCBDb25uZWN0VG9Ccm93c2VyQXN5 bmNEYXRhIHsK 358253 2019-01-03 07:33:09 -0800 2019-01-03 08:30:01 -0800 Patch wd-closed.diff text/plain 1889 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggMTFjODI3MDIyYzcuLjA3NjcwN2Y5OTZiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTAxLTAzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl0gV2ViRHJpdmVyOiBicm93c2VyIGNs b3NlIG5vdCBjb3JyZWN0bHkgZGV0ZWN0ZWQgb24gc2Vzc2lvbiBjbG9zZSBpbiBzb21lIGNhc2Vz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTMxMDQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGhh cHBlbnMgd2hlbiB0aGUgZGJ1cyBjb25uZWN0aW9uIGlzIGNsb3NlZCByaWdodCBiZWZvcmUgdGhl IHJlc3BvbnNlIHRvIFNlbmRNZXNzYWdlVG9CYWNrZW5kIG1lc3NhZ2UgaXMKKyAgICAgICAgZ29p bmcgdG8gYmUgc2VudC4gSW4gdGhhdCBjYXNlLCBnX2RidXNfY29ubmVjdGlvbl9jYWxsIGFzeW5j IHJlYWR5IGhhbmRsZXIgZ2VuZXJhdGVzIGFuIGVycm9yIGJlZm9yZSB0aGUgY2xvc2UKKyAgICAg ICAgc2lnbmFsIGlzIGVtaXR0ZWQuIFRoZW4sIHRoZSBjbG9zZSBjb21tYW5kcyB0cnkgdG8gaGFu ZGxlIHRoZSBlcnJvciBjaGVja2luZyBpZiBTZXNzaW9uSG9zdDo6aXNDb25uZWN0ZWQoKSwgYnV0 CisgICAgICAgIGl0IHN0aWxsIHJldHVybnMgdHJ1ZSwgYmVjYXVzZSB0aGUgYnJvd3NlciBpcyBz dGlsbCBhbGl2ZSwgYnV0IHRoZSBkYnVzIGNvbm5lY3Rpb24gaGFzIGJlZW4gY2xvc2VkLgorCisg ICAgICAgICogZ2xpYi9TZXNzaW9uSG9zdEdsaWIuY3BwOgorICAgICAgICAoV2ViRHJpdmVyOjpT ZXNzaW9uSG9zdDo6aXNDb25uZWN0ZWQgY29uc3QpOiBTZXNzaW9uIGlzIGNvbm5lY3RlZCB3aGVu IGxhdW5jaGluZyBvciB3aGVuIGRidXMgY29ubmVjdGlvbiBoYXNuJ3QKKyAgICAgICAgYmVlbiBj bG9zZWQuCisKIDIwMTgtMTItMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHTElCXSBXZWJEcml2ZXI6IGRidXNDb25uZWN0aW9uQ2xvc2Vk Q2FsbGJhY2sgY2FuIGJlIGNhbGxlZCBhZnRlciBTZXNzaW9uSG9zdCBoYXMgYmVlbiBkZWxldGVk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVyL2dsaWIvU2Vzc2lvbkhvc3RHbGliLmNwcCBi L1NvdXJjZS9XZWJEcml2ZXIvZ2xpYi9TZXNzaW9uSG9zdEdsaWIuY3BwCmluZGV4IDM2NGNhODBm ODkzLi4zNGY5YmNhMmI4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkRyaXZlci9nbGliL1Nlc3Np b25Ib3N0R2xpYi5jcHAKKysrIGIvU291cmNlL1dlYkRyaXZlci9nbGliL1Nlc3Npb25Ib3N0R2xp Yi5jcHAKQEAgLTEwOCw3ICsxMDgsOCBAQCB2b2lkIFNlc3Npb25Ib3N0Ojpjb25uZWN0VG9Ccm93 c2VyKEZ1bmN0aW9uPHZvaWQgKE9wdGlvbmFsPFN0cmluZz4gZXJyb3IpPiYmIGNvbQogCiBib29s IFNlc3Npb25Ib3N0Ojppc0Nvbm5lY3RlZCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuICEhbV9icm93 c2VyOworICAgIC8vIFNlc3Npb24gaXMgY29ubmVjdGVkIHdoZW4gbGF1bmNoaW5nIG9yIHdoZW4g ZGJ1cyBjb25uZWN0aW9uIGhhc24ndCBiZWVuIGNsb3NlZC4KKyAgICByZXR1cm4gbV9icm93c2Vy ICYmICghbV9kYnVzQ29ubmVjdGlvbiB8fCAhZ19kYnVzX2Nvbm5lY3Rpb25faXNfY2xvc2VkKG1f ZGJ1c0Nvbm5lY3Rpb24uZ2V0KCkpKTsKIH0KIAogc3RydWN0IENvbm5lY3RUb0Jyb3dzZXJBc3lu Y0RhdGEgewo=