19310 2008-05-29 10:08:17 -0700 [wx] Stop crash/asserts due to incorrect hash algorithm 2008-06-09 08:40:27 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) All All RESOLVED FIXED Gtk, Wx P2 Normal --- 1 kevino webkit-unassigned alp mmacleod oldest_to_newest 81857 0 kevino 2008-05-29 10:08:17 -0700 Our computeHash function would generate different hashes for fonts which are equal, which is unexpected behavior for the hash() function. 81858 1 21413 kevino 2008-05-29 10:09:19 -0700 Created attachment 21413 Fix to stop asserts caused by incorrect hash algorithm In this patch, we now calculate the hash by creating a hash value from all the font's properties, which resolves the asserts and brings us in line with the other ports' behavior. 82063 2 alp 2008-06-01 08:53:00 -0700 This issue may exist in the GTK+ or other Cairo-based ports. Haven't checked yet though. Adding GTK keyword so it shows up on our radar. 82697 3 21413 darin 2008-06-08 18:13:50 -0700 Comment on attachment 21413 Fix to stop asserts caused by incorrect hash algorithm r=me 82747 4 ap 2008-06-09 07:52:09 -0700 *** Bug 19274 has been marked as a duplicate of this bug. *** 82757 5 kevino 2008-06-09 08:40:27 -0700 Landed in r34459, thanks! 21413 2008-05-29 10:09:19 -0700 2008-06-08 18:13:50 -0700 Fix to stop asserts caused by incorrect hash algorithm fontplatformdata.patch text/plain 1665 kevino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNDIwMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMDUtMjkgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9s bGl2aWVycy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRml4IGZvbnQgYXNzZXJ0cyBpbiB3eCBwb3J0LiBPdXIgY29tcHV0ZUhhc2ggZnVuY3Rp b24gc2hvdWxkIGdlbmVyYXRlIHRoZSBzYW1lIGhhc2gKKyAgICAgICAgZm9yIHR3byBpZGVudGlj YWwgZm9udHMgd2hpY2ggYXJlIGRpZmZlcmVudCBvYmplY3RzLCB3aGljaCBpdCB3YXNuJ3QgZG9p bmcgYmVmb3JlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3Jt RGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6Rm9udFBsYXRmb3JtRGF0YTo6Y29tcHV0ZUhhc2gp OgorCiAyMDA4LTA1LTI5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy93eC9Gb250UGxhdGZvcm1EYXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy93eC9Gb250UGxhdGZvcm1EYXRhLmgJKHJldmlzaW9uIDM0MjAzKQorKysg V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93eC9Gb250UGxhdGZvcm1EYXRhLmgJKHdvcmtpbmcg Y29weSkKQEAgLTkwLDcgKzkwLDE0IEBACiAgICAgCiAgICAgdW5zaWduZWQgY29tcHV0ZUhhc2go KSBjb25zdCB7CiAgICAgICAgIEFTU0VSVChtX2ZvbnQuT2soKSk7Ci0gICAgICAgIHJldHVybiBy ZWludGVycHJldF9jYXN0PHVuc2lnbmVkPigmbV9mb250KTsKKyAgICAgICAgCisgICAgICAgIC8v IG1ha2UgYSBoYXNoIHRoYXQgaXMgdW5pcXVlIGZvciB0aGlzIGZvbnQsIGJ1dCBub3QgZ2xvYmFs bHkgdW5pcXVlIC0gdGhhdCBpcywKKyAgICAgICAgLy8gYSBmb250IHdob3NlIHByb3BlcnRpZXMg YXJlIGVxdWFsIHNob3VsZCBnZW5lcmF0ZSB0aGUgc2FtZSBoYXNoCisgICAgICAgIHVpbnRwdHJf dCBoYXNoQ29kZXNbNl0gPSB7IG1fZm9udC5HZXRQb2ludFNpemUoKSwgbV9mb250LkdldEZhbWls eSgpLCBtX2ZvbnQuR2V0U3R5bGUoKSwgCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBtX2ZvbnQuR2V0V2VpZ2h0KCksIG1fZm9udC5HZXRVbmRlcmxpbmVkKCksIAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU3RyaW5nSW1wbDo6Y29tcHV0ZUhhc2gobV9m b250LkdldEZhY2VOYW1lKCkubWJfc3RyKHd4Q29udlVURjgpKSB9OworICAgICAgICAKKyAgICAg ICAgcmV0dXJuIFN0cmluZ0ltcGw6OmNvbXB1dGVIYXNoKHJlaW50ZXJwcmV0X2Nhc3Q8VUNoYXIq PihoYXNoQ29kZXMpLCBzaXplb2YoaGFzaENvZGVzKSAvIHNpemVvZihVQ2hhcikpOwogICAgIH0K IAogcHJpdmF0ZToK