193068 2019-01-01 17:29:02 -0800 [GTK] Add missing autocleanups 2019-02-05 08:03:53 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro aperez bugs-noreply cgarcia mcatanzaro webkit-bug-importer oldest_to_newest 1491119 0 mcatanzaro 2019-01-01 17:29:02 -0800 Add missing autocleanups I wish we could switch to G_DECLARE_[FINAL,DERIVABLE]_TYPE so that we don't keep forgetting these, but I don't think it's possible without breaking ABI, and it would be insane to do with #ifdefs so we can't really do it for GTK+ 4 unless we drop GTK+ 3 at the same time... so we might be stuck with this legacy autocleanups file forever. 1491120 1 358177 mcatanzaro 2019-01-01 17:38:50 -0800 Created attachment 358177 Patch 1491123 2 mcatanzaro 2019-01-01 17:50:49 -0800 (In reply to Michael Catanzaro from comment #0) > so we might be stuck with this legacy autocleanups file forever. FWIW I think it's reasonable to break ABI once every five years or so. This will cause zero problems for Linux distros as long as we don't make API changes. I want more padding in the WebKitWebView class struct anyway. 1491247 3 mcatanzaro 2019-01-02 13:42:51 -0800 Er, I noticed WebKitOptionMenu is a GTK-specific type, and was surprised this didn't break the WPE EWS. But that's because it's a GTK-specific header. It looks like WPE does not have any autocleanups at all! 1492887 4 358177 cgarcia 2019-01-09 00:59:45 -0800 Comment on attachment 358177 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358177&action=review > Source/WebKit/ChangeLog:3 > + [WPE][GTK] Add missing autocleanups This is not affecting WPE 1492937 5 mcatanzaro 2019-01-09 07:06:56 -0800 That's a problem in itself... how can we have failed to noticed that WPE does not offer autocleanups; that's awful. :( Adrian, why aren't you using these in cog? 1492939 6 mcatanzaro 2019-01-09 07:08:30 -0800 Committed r239770: <https://trac.webkit.org/changeset/239770> 358177 2019-01-01 17:38:50 -0800 2019-01-09 00:59:45 -0800 Patch bug-193068-20190101193849.patch text/plain 2516 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk0MDc0YzliYWNmMWVmNGUx Y2RmZjY2ODgyMDRjN2E5ZTk3ODgwNmEuLmExNjA3MDg4NTFlOTljNGVmNjIwNzU3ZGUwN2Y4NmYz YzY4ZDhiMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTktMDEtMDEgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10g QWRkIG1pc3NpbmcgYXV0b2NsZWFudXBzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTMwNjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEF1dG9jbGVhbnVwcy5o OgorCiAyMDE4LTEyLTIwICBZdXN1a2UgU3V6dWtpICA8eXVzdWtlc3V6dWtpQHNsb3dzdGFydC5v cmc+CiAKICAgICAgICAgVXNlIFJlZjw+IGFzIG11Y2ggYXMgcG9zc2libGUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0QXV0b2NsZWFudXBzLmggYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEF1dG9jbGVhbnVwcy5oCmluZGV4 IGMzMmMwOTljMDQ5YmQxYzFlOThmYmNjOWU2YmJlOTBhNWE2MDdhODEuLjhjYzlmMGY3NzYyMjEz MDM0MmY3MGVhYjVmNGJmMmNmMWFiNzcyMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0QXV0b2NsZWFudXBzLmgKKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRBdXRvY2xlYW51cHMuaApAQCAtMzQsNiArMzQsNyBAQAog I2lmbmRlZiBfX0dJX1NDQU5ORVJfXwogCiBHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAo V2ViS2l0QXV0aGVudGljYXRpb25SZXF1ZXN0LCBnX29iamVjdF91bnJlZikKK0dfREVGSU5FX0FV VE9QVFJfQ0xFQU5VUF9GVU5DIChXZWJLaXRBdXRvbWF0aW9uU2Vzc2lvbiwgZ19vYmplY3RfdW5y ZWYpCiBHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0QmFja0ZvcndhcmRMaXN0 LCBnX29iamVjdF91bnJlZikKIEdfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9GVU5DIChXZWJLaXRC YWNrRm9yd2FyZExpc3RJdGVtLCBnX29iamVjdF91bnJlZikKIEdfREVGSU5FX0FVVE9QVFJfQ0xF QU5VUF9GVU5DIChXZWJLaXRDb2xvckNob29zZXJSZXF1ZXN0LCBnX29iamVjdF91bnJlZikKQEAg LTUyLDYgKzUzLDcgQEAgR19ERUZJTkVfQVVUT1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdEluc3Rh bGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QKIEdfREVGSU5FX0FVVE9QVFJf Q0xFQU5VUF9GVU5DIChXZWJLaXROYXZpZ2F0aW9uUG9saWN5RGVjaXNpb24sIGdfb2JqZWN0X3Vu cmVmKQogR19ERUZJTkVfQVVUT1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdE5vdGlmaWNhdGlvbiwg Z19vYmplY3RfdW5yZWYpCiBHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0Tm90 aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3QsIGdfb2JqZWN0X3VucmVmKQorR19ERUZJTkVfQVVU T1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdE9wdGlvbk1lbnUsIGdfb2JqZWN0X3VucmVmKQogR19E RUZJTkVfQVVUT1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdFBlcm1pc3Npb25SZXF1ZXN0LCBnX29i amVjdF91bnJlZikKIEdfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9GVU5DIChXZWJLaXRQbHVnaW4s IGdfb2JqZWN0X3VucmVmKQogR19ERUZJTkVfQVVUT1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdFBv bGljeURlY2lzaW9uLCBnX29iamVjdF91bnJlZikKQEAgLTcyLDYgKzc0LDcgQEAgR19ERUZJTkVf QVVUT1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdFdlYlZpZXcsIGdfb2JqZWN0X3VucmVmKQogR19E RUZJTkVfQVVUT1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdFdlYnNpdGVEYXRhTWFuYWdlciwgZ19v YmplY3RfdW5yZWYpCiBHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0V2luZG93 UHJvcGVydGllcywgZ19vYmplY3RfdW5yZWYpCiAKK0dfREVGSU5FX0FVVE9QVFJfQ0xFQU5VUF9G VU5DIChXZWJLaXRBcHBsaWNhdGlvbkluZm8sIHdlYmtpdF9hcHBsaWNhdGlvbl9pbmZvX3VucmVm KQogR19ERUZJTkVfQVVUT1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdENyZWRlbnRpYWwsIHdlYmtp dF9jcmVkZW50aWFsX2ZyZWUpCiBHX0RFRklORV9BVVRPUFRSX0NMRUFOVVBfRlVOQyAoV2ViS2l0 SmF2YXNjcmlwdFJlc3VsdCwgd2Via2l0X2phdmFzY3JpcHRfcmVzdWx0X3VucmVmKQogR19ERUZJ TkVfQVVUT1BUUl9DTEVBTlVQX0ZVTkMgKFdlYktpdE1pbWVJbmZvLCB3ZWJraXRfbWltZV9pbmZv X3VucmVmKQo=