193023 2018-12-24 16:14:26 -0800 [lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage 2019-01-02 10:51:25 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193024 InRadar P2 Normal --- 1 dbates dbates ddkilzer lforschler simon.fraser webkit-bug-importer oldest_to_newest 1490730 0 dbates 2018-12-24 16:14:26 -0800 The WTF::OptionSet pretty printer contains code to print the value of WTF::OptionSet::m_storage. Due to an off-by-one error this code is broken and as a result we never print the value of WTF::OptionSet::m_storage when pretty printing the option set. Having said that, it does not seem very meaningful to print the value of m_storage as it is just the sum of the values of the enumerators in the set and I find it would just be noise if printed. We should just remove the code that tried to print WTF::OptionSet::m_storage. If there is someone that likes knowing m_storage then we should still remove the current code and re-implement this functionality as part of the summary string for WTF::OptionSet so that we do not print m_storage as if it was an item in the set. For completeness, if the code had worked then pretty printed output would look like: (WTF::OptionSet<ExampleFlags>) $0 = { size = 3 } { A = 1 C = 4 D = 8 m_storage = 13 } Currently it looks like: (WTF::OptionSet<ExampleFlags>) $0 = { size = 3 } { A = 1 C = 4 D = 8 } 1490732 1 358049 dbates 2018-12-24 16:16:48 -0800 Created attachment 358049 Patch 1491163 2 358049 simon.fraser 2019-01-02 10:34:17 -0800 Comment on attachment 358049 Patch No tests? 1491164 3 dbates 2019-01-02 10:36:16 -0800 (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 358049 [details] > Patch > > No tests? No tests, because I am removing functionality. 1491166 4 358049 dbates 2019-01-02 10:50:20 -0800 Comment on attachment 358049 Patch Clearing flags on attachment: 358049 Committed r239570: <https://trac.webkit.org/changeset/239570> 1491167 5 dbates 2019-01-02 10:50:21 -0800 All reviewed patches have been landed. Closing bug. 1491168 6 webkit-bug-importer 2019-01-02 10:51:25 -0800 <rdar://problem/47005480> 358049 2018-12-24 16:16:48 -0800 2019-01-02 10:50:20 -0800 Patch bug-193023-20181224161647.patch text/plain 2233 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGRjZWUxZTUyNzAwZmFlMGE3MzdjNTAwOGQ1YTg1ZjBm MWE4ZjA2MC4uZDkwMTcxM2ZhMzUyM2MzYjZmYmJjOTY1ZmViNGNhYjkxZDRiYTAwZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE4LTEyLTI0ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbbGxkYi13ZWJraXRdIFJlbW92ZSBicm9rZW4gY29kZSB0byBwcmludCBXVEY6Ok9wdGlv blNldDo6bV9zdG9yYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTMwMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgY29kZSB0byBwcmludCBXVEY6Ok9wdGlvblNldDo6bV9zdG9yYWdlIGFzIGFu IGl0ZW0gaW4gdGhlIHNldCBuZXZlciB3b3JrZWQgYW5kIGRvZXMKKyAgICAgICAgbm90IHNlZW0g bWVhbmluZ2Z1bCB0byBmaXggYmVjYXVzZSBXVEY6Ok9wdGlvblNldDo6bV9zdG9yYWdlIGlzIGp1 c3QgdGhlIHN1bSBvZiB0aGUgcHJpbnRlZAorICAgICAgICBlbnVtZXJhdG9yIHZhbHVlcy4gV2Ug c2hvdWxkIGp1c3QgcmVtb3ZlIHRoaXMgY29kZS4KKworICAgICAgICAqIGxsZGIvbGxkYl93ZWJr aXQucHk6CisgICAgICAgIChXVEZPcHRpb25TZXRQcm92aWRlci5oYXNfY2hpbGRyZW4pOgorICAg ICAgICAoV1RGT3B0aW9uU2V0UHJvdmlkZXIubnVtX2NoaWxkcmVuKToKKyAgICAgICAgKFdURk9w dGlvblNldFByb3ZpZGVyLmdldF9jaGlsZF9pbmRleCk6CisgICAgICAgIChXVEZPcHRpb25TZXRQ cm92aWRlci5nZXRfY2hpbGRfYXRfaW5kZXgpOgorCiAyMDE4LTEyLTIyICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBXZWJEcml2ZXI6IHdhcm4g YWJvdXQgbm9uIGV4aXN0aW5nIHRlc3RzIHdoZW4gcGFyc2luZyBleHBlY3RhdGlvbnMKZGlmZiAt LWdpdCBhL1Rvb2xzL2xsZGIvbGxkYl93ZWJraXQucHkgYi9Ub29scy9sbGRiL2xsZGJfd2Via2l0 LnB5CmluZGV4IGFmN2JhYjBhYzljNWE5ZmIwYmQ2N2U0YzI0ZWJjMDdlZTA1MjdjY2MuLjQ3ZTUx ZjZhOWE3ZDNkMjk5ZmZhOWFhZDZhY2I3NGQyNmQwYjlkMjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2xs ZGIvbGxkYl93ZWJraXQucHkKKysrIGIvVG9vbHMvbGxkYi9sbGRiX3dlYmtpdC5weQpAQCAtNzA1 LDEzICs3MDUsMTAgQEAgY2xhc3MgV1RGT3B0aW9uU2V0UHJvdmlkZXI6CiAgICAgZGVmIGhhc19j aGlsZHJlbihzZWxmKToKICAgICAgICAgcmV0dXJuIGJvb2woc2VsZi5fZWxlbWVudHMpCiAKLSAg ICAjICBNZXRhZGF0YSBpcyBzdG9yZWQgYXQgaW5kaWNlcyBncmVhdGVyIHRoYW4gb3IgZXF1YWwg dG8gdGhlIG51bWJlciBvZiBlbGVtZW50cyBpbiB0aGUgc2V0LgogICAgIGRlZiBudW1fY2hpbGRy ZW4oc2VsZik6Ci0gICAgICAgIHJldHVybiBsZW4oc2VsZi5fZWxlbWVudHMpICsgMQorICAgICAg ICByZXR1cm4gbGVuKHNlbGYuX2VsZW1lbnRzKQogCiAgICAgZGVmIGdldF9jaGlsZF9pbmRleChz ZWxmLCBuYW1lKToKLSAgICAgICAgaWYgbmFtZSA9PSAnbV9zdG9yYWdlJzoKLSAgICAgICAgICAg IHJldHVybiBzZWxmLm51bV9jaGlsZHJlbigpCiAgICAgICAgIHRyeToKICAgICAgICAgICAgIHJl dHVybiBpbnQobmFtZS5sc3RyaXAoJ1snKS5yc3RyaXAoJ10nKSkKICAgICAgICAgZXhjZXB0OgpA QCAtNzIwLDggKzcxNyw2IEBAIGNsYXNzIFdURk9wdGlvblNldFByb3ZpZGVyOgogICAgIGRlZiBn ZXRfY2hpbGRfYXRfaW5kZXgoc2VsZiwgaW5kZXgpOgogICAgICAgICBpZiBpbmRleCA8IDAgb3Ig bm90IHNlbGYudmFsb2JqLklzVmFsaWQoKToKICAgICAgICAgICAgIHJldHVybiBOb25lCi0gICAg ICAgIGlmIGluZGV4ID09IHNlbGYubnVtX2NoaWxkcmVuKCk6Ci0gICAgICAgICAgICByZXR1cm4g c2VsZi5zdG9yYWdlCiAgICAgICAgIGlmIGluZGV4IDwgbGVuKHNlbGYuX2VsZW1lbnRzKToKICAg ICAgICAgICAgIChuYW1lLCB2YWx1ZSkgPSBzZWxmLl9lbGVtZW50c1tpbmRleF0KICAgICAgICAg ICAgIHJldHVybiBzZWxmLnZhbG9iai5DcmVhdGVWYWx1ZUZyb21FeHByZXNzaW9uKG5hbWUsIHN0 cih2YWx1ZSkpCg==