192922 2018-12-20 00:49:14 -0800 CSS variables don't work for colors in "border" property 2018-12-21 13:33:13 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=192916 HasReduction, InRadar P2 Normal --- 1 nvasilyev justin_michaud commit-queue dino joepeck justin_michaud simon.fraser webkit-bug-importer zalan oldest_to_newest 1489791 0 357798 nvasilyev 2018-12-20 00:49:14 -0800 Created attachment 357798 [HTML] Reduction See the reduction. In Chrome both rectangles have a green border. In STP 72, only the first one. 1489969 1 webkit-bug-importer 2018-12-20 11:43:29 -0800 <rdar://problem/46878323> 1489980 2 joepeck 2018-12-20 11:58:17 -0800 Actually this appears to just be the order of properties in the `border` shorthand: Note that this works: border: hsl(100, 100%, var(--foreground-lightness)) 4px solid; But not this: border: 4px solid hsl(100, 100%, var(--foreground-lightness)); 1490398 3 justin_michaud 2018-12-21 10:46:31 -0800 This works: .fail { --foreground: 100; border: 4px rgb(100, 0, var(--foreground)) dashed; } This does not: .fail { --foreground: 100; border: 4px dashed rgb(100, 0, var(--foreground)); } The reason is that in the first case, in CSSPropertyParser::consumeBorder, we do not consume the entire value and so consuming the border fails. In the second case, consuming the border does not fail. In CSSPropertyParser::parseValueStart, we expect the parsing to fail in order to fall through to the variable reference parser. 1490422 4 357962 justin_michaud 2018-12-21 11:56:05 -0800 Created attachment 357962 Patch 1490458 5 357962 commit-queue 2018-12-21 13:33:12 -0800 Comment on attachment 357962 Patch Clearing flags on attachment: 357962 Committed r239516: <https://trac.webkit.org/changeset/239516> 1490459 6 commit-queue 2018-12-21 13:33:13 -0800 All reviewed patches have been landed. Closing bug. 357798 2018-12-20 00:49:14 -0800 2018-12-20 00:49:14 -0800 [HTML] Reduction border-color.html text/html 423 nvasilyev PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPG1ldGEgY2hhcnNldD0iVVRGLTgiPgo8c3R5 bGU+CmJvZHkgewogICAgLS1mb3JlZ3JvdW5kLWxpZ2h0bmVzczogNDAlOwp9CgoucGFzcyB7CiAg ICBib3JkZXI6IDRweCBzb2xpZCBoc2woMTAwLCAxMDAlLCB2YXIoLS1mb3JlZ3JvdW5kLWxpZ2h0 bmVzcykpOwogICAgYm9yZGVyLWNvbG9yOiBoc2woMTAwLCAxMDAlLCB2YXIoLS1mb3JlZ3JvdW5k LWxpZ2h0bmVzcykpOwp9CgouZmFpbCB7CiAgICBib3JkZXI6IDRweCBzb2xpZCBoc2woMTAwLCAx MDAlLCB2YXIoLS1mb3JlZ3JvdW5kLWxpZ2h0bmVzcykpOwp9Cjwvc3R5bGU+CjwvaGVhZD4KPGJv ZHk+CjxzcGFuIGNsYXNzPSJwYXNzIj5wYXNzPC9zcGFuPgo8c3BhbiBjbGFzcz0iZmFpbCI+ZmFp bDwvc3Bhbj4KPC9ib2R5Pgo8L2h0bWw+ 357962 2018-12-21 11:56:05 -0800 2018-12-21 13:33:12 -0800 Patch bug-192922-20181221115557.patch text/plain 3515 justin_michaud U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5NTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDc5OTA4MzM2MTI5NTAy ZDFmMzA5ZWQ0MDkyYjAyMjVjYzRmOTNkMy4uNGM2ZjA3NGZhNDgzMTJjYTU1ZWUyNDM3ZGI3MzIw ZDZkMTRmZTE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTEyLTIxICBKdXN0 aW4gTWljaGF1ZCAgPGp1c3Rpbl9taWNoYXVkQGFwcGxlLmNvbT4KKworICAgICAgICBDU1MgdmFy aWFibGVzIGRvbid0IHdvcmsgZm9yIGNvbG9ycyBpbiAiYm9yZGVyIiBwcm9wZXJ0eQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyOTIyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFyc2VDb2xvckZ1bmN0 aW9uIG5vIGxvbmdlciBjb25zdW1lcyBhbnl0aGluZyBpZiB0aGUgY29sb3Igd2FzIG5vdCB2YWxp ZC4KKworICAgICAgICBUZXN0OiBjc3MtY3VzdG9tLXByb3BlcnRpZXMtYXBpL2JvcmRlci12YXJp YWJsZS1wYXJzaW5nLmh0bWwKKworICAgICAgICAqIGNzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJz ZXJIZWxwZXJzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1Byb3BlcnR5UGFyc2VySGVscGVy czo6cGFyc2VDb2xvckZ1bmN0aW9uKToKKwogMjAxOC0xMi0yMSAgSnVzdGluIE1pY2hhdWQgIDxq dXN0aW5fbWljaGF1ZEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVwZWF0ZWQgYmFja2dyb3VuZCBp bWFnZXMgd2l0aCB6ZXJvIHNpemUgc2hvdWxkIGRpc3BsYXkgdGhlIGJhY2tncm91bmQgY29sb3IK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXJI ZWxwZXJzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXJI ZWxwZXJzLmNwcAppbmRleCBhZTk0ODY0Y2UxM2I5M2QyODY4MTQ3MzBiNGQ4MWIwZjIzMTkzZmU3 Li4wM2IxMWFlMzNhYzU1MTJlZmExMmVjZjZhMzFlZmVjNDlmN2NiM2QwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VySGVscGVycy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlckhlbHBlcnMuY3Bw CkBAIC02ODEsNyArNjgxLDggQEAgc3RhdGljIENvbG9yIHBhcnNlQ29sb3JGdW5jdGlvbihDU1NQ YXJzZXJUb2tlblJhbmdlJiByYW5nZSwgQ1NTUGFyc2VyTW9kZSBjc3NQYXIKICAgICBkZWZhdWx0 OgogICAgICAgICByZXR1cm4gQ29sb3IoKTsKICAgICB9Ci0gICAgcmFuZ2UgPSBjb2xvclJhbmdl OworICAgIGlmIChjb2xvci5pc1ZhbGlkKCkpCisgICAgICAgIHJhbmdlID0gY29sb3JSYW5nZTsK ICAgICByZXR1cm4gY29sb3I7CiB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmZjhhODZkNDVhZDc5NmUyNzUxNGE5NzAx ZDk3MWQ2NGJkMzBiYWRiLi44NzY4ZmIyYmYzZmZhN2U3Njg1ZTY0ZjU0ODk5ZmFkODhhZjQ3N2Fk IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTItMjEgIEp1c3RpbiBNaWNoYXVkICA8anVz dGluX21pY2hhdWRAYXBwbGUuY29tPgorCisgICAgICAgIENTUyB2YXJpYWJsZXMgZG9uJ3Qgd29y ayBmb3IgY29sb3JzIGluICJib3JkZXIiIHByb3BlcnR5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTI5MjIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzcy1jdXN0b20tcHJvcGVydGllcy1hcGkvYm9y ZGVyLXZhcmlhYmxlLXBhcnNpbmctZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogY3Nz LWN1c3RvbS1wcm9wZXJ0aWVzLWFwaS9ib3JkZXItdmFyaWFibGUtcGFyc2luZy5odG1sOiBBZGRl ZC4KKwogMjAxOC0xMi0yMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmVydCByMjM5NTAzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Y3NzLWN1c3RvbS1wcm9wZXJ0aWVzLWFwaS9ib3JkZXItdmFyaWFibGUtcGFyc2luZy1leHBlY3Rl ZC5odG1sIGIvTGF5b3V0VGVzdHMvY3NzLWN1c3RvbS1wcm9wZXJ0aWVzLWFwaS9ib3JkZXItdmFy aWFibGUtcGFyc2luZy1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjRkZDBiMmRiNDVhNjIzYjE2 NzEwZDhkYjFkYWJlMjhlMjg4ZTNmMTgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9j c3MtY3VzdG9tLXByb3BlcnRpZXMtYXBpL2JvcmRlci12YXJpYWJsZS1wYXJzaW5nLWV4cGVjdGVk Lmh0bWwKQEAgLTAsMCArMSwxNiBAQAorPHN0eWxlPgorI2VsMSB7CisgICAgLS1mb3JlZ3JvdW5k OiAxMDA7CisgICAgYm9yZGVyOiAzMHB4IGRhc2hlZCByZ2IoMTAwLCAwLCAxMDApOworfQorI2Vs MiB7CisgICAgLS1mb3JlZ3JvdW5kOiAxMDA7CisgICAgYm9yZGVyOiAzMHB4IHJnYigxMDAsIDAs IDEwMCkgZGFzaGVkOworfQorZGl2IHsKKyAgICB3aWR0aDogMTUwcHg7CisgICAgaGVpZ2h0OiAx NTBweDsKK30KKzwvc3R5bGU+Cis8ZGl2IGlkPSJlbDEiPjwvZGl2PgorPGRpdiBpZD0iZWwyIj48 L2Rpdj4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Nzcy1jdXN0b20tcHJvcGVydGllcy1hcGkv Ym9yZGVyLXZhcmlhYmxlLXBhcnNpbmcuaHRtbCBiL0xheW91dFRlc3RzL2Nzcy1jdXN0b20tcHJv cGVydGllcy1hcGkvYm9yZGVyLXZhcmlhYmxlLXBhcnNpbmcuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40MzUx YjZjOGM5MWMwMWI5NTQzNjEzYTlhNjM0Y2JkZDM0Yjk4ZDRmCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvY3NzLWN1c3RvbS1wcm9wZXJ0aWVzLWFwaS9ib3JkZXItdmFyaWFibGUtcGFy c2luZy5odG1sCkBAIC0wLDAgKzEsMTYgQEAKKzxzdHlsZT4KKyNlbDEgeworICAgIC0tZm9yZWdy b3VuZDogMTAwOworICAgIGJvcmRlcjogMzBweCBkYXNoZWQgcmdiKDEwMCwgMCwgdmFyKC0tZm9y ZWdyb3VuZCkpOworfQorI2VsMiB7CisgICAgLS1mb3JlZ3JvdW5kOiAxMDA7CisgICAgYm9yZGVy OiAzMHB4IHJnYigxMDAsIDAsIHZhcigtLWZvcmVncm91bmQpKSBkYXNoZWQ7Cit9CitkaXYgewor ICAgIHdpZHRoOiAxNTBweDsKKyAgICBoZWlnaHQ6IDE1MHB4OworfQorPC9zdHlsZT4KKzxkaXYg aWQ9ImVsMSI+PC9kaXY+Cis8ZGl2IGlkPSJlbDIiPjwvZGl2Pgo=