192870 2018-12-19 12:31:26 -0800 Web Inspector: Audit: provide localization support for % pass display 2018-12-19 16:31:35 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 190754 1 hi hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1489407 0 hi 2018-12-19 12:31:26 -0800 . 1489408 1 hi 2018-12-19 12:31:38 -0800 <rdar://problem/46779245> 1489411 2 357708 hi 2018-12-19 12:33:34 -0800 Created attachment 357708 Patch 1489544 3 357708 bburg 2018-12-19 15:50:45 -0800 Comment on attachment 357708 Patch r=me Localizers are going to have a hard time understanding what "%s%%" is supposed to mean. 1489572 4 357708 commit-queue 2018-12-19 16:31:34 -0800 Comment on attachment 357708 Patch Clearing flags on attachment: 357708 Committed r239404: <https://trac.webkit.org/changeset/239404> 1489573 5 commit-queue 2018-12-19 16:31:35 -0800 All reviewed patches have been landed. Closing bug. 357708 2018-12-19 12:33:34 -0800 2018-12-19 16:31:34 -0800 Patch bug-192870-20181219133333.patch text/plain 6356 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdkMGFmNWEwYzgyMjBmZDQyZGUyNDZiYzRlMjlk Zjg5YmNmZWRhNTIuLjU0NDYzN2MyZDM1YjMzZmE1YmE4MjEyMzgxMDUxOTZhZDMyMTdlMmMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE4LTEyLTE5ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB dWRpdDogcHJvdmlkZSBsb2NhbGl6YXRpb24gc3VwcG9ydCBmb3IgJSBwYXNzIGRpc3BsYXkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Mjg3MAorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNDY3NzkyNDU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdEdy b3VwQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5BdWRpdFRlc3RHcm91cENvbnRlbnRWaWV3 LnByb3RvdHlwZS5pbml0aWFsTGF5b3V0KToKKyAgICAgICAgKFdJLkF1ZGl0VGVzdEdyb3VwQ29u dGVudFZpZXcucHJvdG90eXBlLmxheW91dCk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9BdWRpdFRlc3RHcm91cENvbnRlbnRWaWV3LmNzczoKKyAgICAgICAgKC5jb250ZW50LXZpZXcu YXVkaXQtdGVzdC1ncm91cCA+IGhlYWRlciA+IC5wZXJjZW50YWdlLXBhc3MpOgorICAgICAgICAo LmNvbnRlbnQtdmlldy5hdWRpdC10ZXN0LWdyb3VwID4gaGVhZGVyID4gLnBlcmNlbnRhZ2UtcGFz cyA+IHNwYW4pOiBBZGRlZC4KKyAgICAgICAgKEBtZWRpYSAocHJlZmVycy1kYXJrLWludGVyZmFj ZSkgLmNvbnRlbnQtdmlldy5hdWRpdC10ZXN0LWdyb3VwID4gaGVhZGVyID4gLnBlcmNlbnRhZ2Ut cGFzcyk6IEFkZGVkLgorICAgICAgICAoQG1lZGlhIChwcmVmZXJzLWRhcmstaW50ZXJmYWNlKSAu Y29udGVudC12aWV3LmF1ZGl0LXRlc3QtZ3JvdXAgPiBoZWFkZXIgPiAucGVyY2VudGFnZS1wYXNz ID4gc3Bhbik6IEFkZGVkLgorICAgICAgICAoLmNvbnRlbnQtdmlldy5hdWRpdC10ZXN0LWdyb3Vw ID4gaGVhZGVyID4gLnBlcmNlbnRhZ2UtcGFzczpub3QoOmVtcHR5KTo6YWZ0ZXIpOiBEZWxldGVk LgorCisgICAgICAgICogTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpz OgorCiAyMDE4LTEyLTE4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogbTN1OCBjb250ZW50IG5vdCBzaG93biwgaXQgc2hvdWxk IGJlIHRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25z L2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9j YWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IDYwZmMxZDk3YTE4 ZGVhNDlkNWQ2YjFhMTM0OWU5ZTMzMTEwNjFlYmQuLjY3NWJhMzE5NTRiYzUwNjA0MmU2Y2RkMjcw NGFkY2U0NjUzY2FhYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6 YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpAQCAtNTQs NiArNTQsNyBAQCBsb2NhbGl6ZWRTdHJpbmdzWyIlcyBcdTIwMTQgJXMiXSA9ICIlcyBcdTIwMTQg JXMiOwogbG9jYWxpemVkU3RyaW5nc1siJXMgY2Fubm90IGJlIG1vZGlmaWVkIl0gPSAiJXMgY2Fu bm90IGJlIG1vZGlmaWVkIjsKIGxvY2FsaXplZFN0cmluZ3NbIiVzIGRlbGF5Il0gPSAiJXMgZGVs YXkiOwogbG9jYWxpemVkU3RyaW5nc1siJXMgaW50ZXJ2YWwiXSA9ICIlcyBpbnRlcnZhbCI7Cits b2NhbGl6ZWRTdHJpbmdzWyIlcyUlIl0gPSAiJXMlJSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyIoQWN0 aW9uICVzKSJdID0gIihBY3Rpb24gJXMpIjsKIGxvY2FsaXplZFN0cmluZ3NbIihEaXNrKSJdID0g IihEaXNrKSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyIoSW5kZXgpIl0gPSAiKEluZGV4KSI7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRpdFRl c3RHcm91cENvbnRlbnRWaWV3LmNzcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0F1ZGl0VGVzdEdyb3VwQ29udGVudFZpZXcuY3NzCmluZGV4IDE4ZGU4NjZkZjlj MzViMjIyNDYzNzUxMDg5OTEyMTE1MzIwMThiZDYuLjcyNjMxMjI3NTU5MGYwZjE0NjBjMjQ0NWM5 YjE3YzY3M2ZkOTAyZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdEdyb3VwQ29udGVudFZpZXcuY3NzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdEdyb3VwQ29udGVudFZp ZXcuY3NzCkBAIC0xMjIsMTYgKzEyMiwxNyBAQAogLmNvbnRlbnQtdmlldy5hdWRpdC10ZXN0LWdy b3VwID4gaGVhZGVyID4gLnBlcmNlbnRhZ2UtcGFzcyB7CiAgICAgd2lkdGg6IHZhcigtLW1ldGFk YXRhLXdpZHRoKTsKICAgICAtd2Via2l0LW1hcmdpbi1zdGFydDogdmFyKC0tYXVkaXQtdGVzdC1o b3Jpem9udGFsLXNwYWNlKTsKLSAgICBmb250LXNpemU6IDI0cHg7CisgICAgZm9udC1zaXplOiAx NnB4OwogICAgIHRleHQtYWxpZ246IGNlbnRlcjsKICAgICBmb250LXdlaWdodDogYm9sZDsKLSAg ICBvcGFjaXR5OiAwLjY1OworICAgIC8qIEZJWE1FOiBVc2UgQ1NTNCBjb2xvciBibGVuZCBmdW5j dGlvbnMgb25jZSB0aGV5J3JlIGF2YWlsYWJsZS4gKi8KKyAgICBjb2xvcjogaHNsYSgwLCAwJSwg MCUsIDAuNSk7CiB9CiAKLS5jb250ZW50LXZpZXcuYXVkaXQtdGVzdC1ncm91cCA+IGhlYWRlciA+ IC5wZXJjZW50YWdlLXBhc3M6bm90KDplbXB0eSk6OmFmdGVyIHsKLSAgICBjb250ZW50OiAiJSI7 Ci0gICAgZm9udC1zaXplOiAxNnB4OwotICAgIG9wYWNpdHk6IDAuNzU7CisuY29udGVudC12aWV3 LmF1ZGl0LXRlc3QtZ3JvdXAgPiBoZWFkZXIgPiAucGVyY2VudGFnZS1wYXNzID4gc3BhbiB7Cisg ICAgZm9udC1zaXplOiAyNHB4OworICAgIC8qIEZJWE1FOiBVc2UgQ1NTNCBjb2xvciBibGVuZCBm dW5jdGlvbnMgb25jZSB0aGV5J3JlIGF2YWlsYWJsZS4gKi8KKyAgICBjb2xvcjogaHNsYSgwLCAw JSwgMCUsIDAuNjUpOwogfQogCiAuY29udGVudC12aWV3LmF1ZGl0LXRlc3QtZ3JvdXAgPiBzZWN0 aW9uID4gLmF1ZGl0LXRlc3QtY2FzZTpmaXJzdC1jaGlsZCwKQEAgLTE0MywzICsxNDQsMTUgQEAK IC5jb250ZW50LXZpZXcuYXVkaXQtdGVzdC1ncm91cCA+IHNlY3Rpb24gPiAuYXVkaXQtdGVzdC1j YXNlOmxhc3QtY2hpbGQgewogICAgIG1hcmdpbi1ib3R0b206IHZhcigtLWF1ZGl0LXRlc3QtdmVy dGljYWwtc3BhY2UpOwogfQorCitAbWVkaWEgKHByZWZlcnMtZGFyay1pbnRlcmZhY2UpIHsKKyAg ICAuY29udGVudC12aWV3LmF1ZGl0LXRlc3QtZ3JvdXAgPiBoZWFkZXIgPiAucGVyY2VudGFnZS1w YXNzIHsKKyAgICAgICAgLyogRklYTUU6IFVzZSBDU1M0IGNvbG9yIGJsZW5kIGZ1bmN0aW9ucyBv bmNlIHRoZXkncmUgYXZhaWxhYmxlLiAqLworICAgICAgICBjb2xvcjogaHNsYSgwLCAwJSwgODgl LCAwLjUpOworICAgIH0KKworICAgIC5jb250ZW50LXZpZXcuYXVkaXQtdGVzdC1ncm91cCA+IGhl YWRlciA+IC5wZXJjZW50YWdlLXBhc3MgPiBzcGFuIHsKKyAgICAgICAgLyogRklYTUU6IFVzZSBD U1M0IGNvbG9yIGJsZW5kIGZ1bmN0aW9ucyBvbmNlIHRoZXkncmUgYXZhaWxhYmxlLiAqLworICAg ICAgICBjb2xvcjogaHNsYSgwLCAwJSwgODglLCAwLjY1KTsKKyAgICB9Cit9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRpdFRlc3RHcm91 cENvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQXVkaXRUZXN0R3JvdXBDb250ZW50Vmlldy5qcwppbmRleCA1NGJhY2Y0ZGIxOTIyMTFmYTkz MmNkYjRkODM2NTE0OTdiZDllMGU5Li40NDEwMWRhZDVhY2EzZmY0NTQwNDY3YTQzNDY4NmI1ZWJi ZGFlODFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9BdWRpdFRlc3RHcm91cENvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdEdyb3VwQ29udGVudFZpZXcuanMKQEAg LTU5LDkgKzU5LDE2IEBAIFdJLkF1ZGl0VGVzdEdyb3VwQ29udGVudFZpZXcgPSBjbGFzcyBBdWRp dFRlc3RHcm91cENvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQXVkaXRUCiAgICAgICAgIHRoaXMuX2xl dmVsTmF2aWdhdGlvbkJhci5lbGVtZW50LmRhdGFzZXQucHJlZml4ID0gV0kuVUlTdHJpbmcoIlNo b3dpbmc6Iik7CiAgICAgICAgIHRoaXMuaGVhZGVyVmlldy5hZGRTdWJ2aWV3KHRoaXMuX2xldmVs TmF2aWdhdGlvbkJhcik7CiAKLSAgICAgICAgdGhpcy5fcGVyY2VudGFnZVRleHRFbGVtZW50ID0g dGhpcy5oZWFkZXJWaWV3LmVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgiZGl2IikpOwotICAgICAgICB0aGlzLl9wZXJjZW50YWdlVGV4dEVsZW1lbnQuY2xhc3NMaXN0 LmFkZCgicGVyY2VudGFnZS1wYXNzIik7Ci0gICAgICAgIHRoaXMuaGVhZGVyVmlldy5lbGVtZW50 LmFwcGVuZENoaWxkKHRoaXMuX3BlcmNlbnRhZ2VUZXh0RWxlbWVudCk7CisgICAgICAgIHRoaXMu X3BlcmNlbnRhZ2VDb250YWluZXIgPSB0aGlzLmhlYWRlclZpZXcuZWxlbWVudC5hcHBlbmRDaGls ZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKSk7CisgICAgICAgIHRoaXMuX3BlcmNlbnRh Z2VDb250YWluZXIuY2xhc3NMaXN0LmFkZCgicGVyY2VudGFnZS1wYXNzIik7CisgICAgICAgIHRo aXMuX3BlcmNlbnRhZ2VDb250YWluZXIuaGlkZGVuID0gdHJ1ZTsKKworICAgICAgICB0aGlzLl9w ZXJjZW50YWdlVGV4dEVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzcGFuIik7CisK KyAgICAgICAgU3RyaW5nLmZvcm1hdChXSS5VSVN0cmluZygiJXMlJSIpLCBbdGhpcy5fcGVyY2Vu dGFnZVRleHRFbGVtZW50XSwgU3RyaW5nLnN0YW5kYXJkRm9ybWF0dGVycywgdGhpcy5fcGVyY2Vu dGFnZUNvbnRhaW5lciwgKGEsIGIpID0+IHsKKyAgICAgICAgICAgIGEuYXBwZW5kKGIpOworICAg ICAgICAgICAgcmV0dXJuIGE7CisgICAgICAgIH0pOwogICAgIH0KIAogICAgIGxheW91dCgpCkBA IC03OCw2ICs4NSw3IEBAIFdJLkF1ZGl0VGVzdEdyb3VwQ29udGVudFZpZXcgPSBjbGFzcyBBdWRp dFRlc3RHcm91cENvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQXVkaXRUCiAgICAgICAgICAgICAgICAg dGhpcy5fbGV2ZWxTY29wZUJhciA9IG51bGw7CiAgICAgICAgICAgICB9CiAKKyAgICAgICAgICAg IHRoaXMuX3BlcmNlbnRhZ2VDb250YWluZXIuaGlkZGVuID0gdHJ1ZTsKICAgICAgICAgICAgIHRo aXMuX3BlcmNlbnRhZ2VUZXh0RWxlbWVudC50ZXh0Q29udGVudCA9ICIiOwogCiAgICAgICAgICAg ICBpZiAodGhpcy5yZXByZXNlbnRlZE9iamVjdC5ydW5uaW5nU3RhdGUgPT09IFdJLkF1ZGl0TWFu YWdlci5SdW5uaW5nU3RhdGUuSW5hY3RpdmUpCkBAIC05Myw2ICsxMDEsNyBAQCBXSS5BdWRpdFRl c3RHcm91cENvbnRlbnRWaWV3ID0gY2xhc3MgQXVkaXRUZXN0R3JvdXBDb250ZW50VmlldyBleHRl bmRzIFdJLkF1ZGl0VAogICAgICAgICBsZXQgbGV2ZWxDb3VudHMgPSByZXN1bHQubGV2ZWxDb3Vu dHM7CiAgICAgICAgIGxldCB0b3RhbENvdW50ID0gT2JqZWN0LnZhbHVlcyhsZXZlbENvdW50cyku cmVkdWNlKChhY2N1bXVsYXRvciwgY3VycmVudCkgPT4gYWNjdW11bGF0b3IgKyBjdXJyZW50KTsK ICAgICAgICAgdGhpcy5fcGVyY2VudGFnZVRleHRFbGVtZW50LnRleHRDb250ZW50ID0gTWF0aC5m bG9vcigxMDAgKiBsZXZlbENvdW50c1tXSS5BdWRpdFRlc3RDYXNlUmVzdWx0LkxldmVsLlBhc3Nd IC8gdG90YWxDb3VudCk7CisgICAgICAgIHRoaXMuX3BlcmNlbnRhZ2VDb250YWluZXIuaGlkZGVu ID0gZmFsc2U7CiAKICAgICAgICAgaWYgKCF0aGlzLl9sZXZlbFNjb3BlQmFyKSB7CiAgICAgICAg ICAgICBsZXQgc2NvcGVCYXJJdGVtcyA9IFtdOwo=