19279 2008-05-27 15:10:58 -0700 REGRESSION (r32660): Text not redrawn correctly when selection changes 2008-06-07 15:38:33 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) PC Linux RESOLVED FIXED Regression P1 Normal --- 1 jonathon pierre-luc.beaudoin alp krit mitz pierre-luc.beaudoin oldest_to_newest 81657 0 jonathon 2008-05-27 15:10:58 -0700 I've noticed that often when you drag down to select a block of text and then move back up to de-select some of it, sometimes the newly-deselected text disappears. It only seems to happen on multi-line text and usually only if the start of the text selection is above (or on the boundary of) the affected element. 81658 1 21371 jonathon 2008-05-27 15:12:19 -0700 Created attachment 21371 81659 2 jonathon 2008-05-27 15:15:59 -0700 I should also note that I don't know for certain whether this is only a QtWebKit issue, but that's the only one that I had available to test. 81675 3 jonathon 2008-05-27 18:56:09 -0700 OK, so I compiled GtkWebKit and the issue also shows up there, so it doesn't appear to be specific to the Qt port. Changing component. If 'Text' is not correct, feel free to re-assign to the correct component. 81722 4 pierre-luc.beaudoin 2008-05-28 07:13:38 -0700 Confirmed with Alexey Proskuryakov, this does not affect the Mac port. 82021 5 krit 2008-05-30 23:07:38 -0700 Got the problems with GtkLauncher but NOT with midori on the same webkitgtk-code. 82041 6 alp 2008-05-31 17:18:00 -0700 (In reply to comment #5) > Got the problems with GtkLauncher but NOT with midori on the same > webkitgtk-code. > I get the problem with Midori too. Maybe your experience was a fluke? 82050 7 krit 2008-05-31 22:19:09 -0700 (In reply to comment #6) > I get the problem with Midori too. Maybe your experience was a fluke? No, I tested it several times on different pages. I don't run in to problems using midori the latest trunk and wbkit with soup,freetype. I made it like in the movie. I got the problems on GtkLauncher but not with midori. Could be because on midori the selection/marking of objects and texts don't work correctly at the moment. 82222 8 krit 2008-06-03 11:18:57 -0700 Midori solved the problems with selection, but the described bug does still not apear on Midori. I tried it with epiphany/webkit with out any problems. Seems only a problem with GtkLauncher on WebKitGtk. 82436 9 pierre-luc.beaudoin 2008-06-06 10:11:12 -0700 The bug does not appear on WebKit shipped with Qt 4.4 but does appear on QtWebKit from webkit.org. I ran a git bisect on code.staikos.net and it pointed to this changeset: http://trac.webkit.org/changeset/32660 Investigation continues. 82451 10 21528 jonathon 2008-06-06 13:49:05 -0700 Created attachment 21528 Patch that fixes the text disappearance on selection changes Here's a patch that fixes the disappearing text issue on both Qt and Gtk. I don't necessarily think that it's the *correct* solution since I think what it is doing is a) drawing all text in the run as unselected b) later any selected text is drawn overtop of it There's at least a couple problems with this simplistic fix: - we're doing unnecessary work by drawing text and then drawing over it - In many cases, text has a different style when selected and unselected. For example, links often have underlines when they're not selected, but are not supposed to be underlined when they're selected. So if you apply this patch you'll see that when you select a link, it will improperly have an underline in the unselected color. 82477 11 21533 pierre-luc.beaudoin 2008-06-06 15:14:58 -0700 Created attachment 21533 Test case Sample html file with 2 paragraph where the issue can be reproduced. 82486 12 mitz 2008-06-06 16:20:34 -0700 You can reproduce the bug on Mac, too, if you make it take the "paint selection separately" code path, for example by adding this to the test case: <style> ::selection { background-color: red; color: white; } </style> 82488 13 21538 pierre-luc.beaudoin 2008-06-06 16:51:42 -0700 Created attachment 21538 Fix Fix discussed with Mitz Pettel. 82489 14 21539 pierre-luc.beaudoin 2008-06-06 17:04:06 -0700 Created attachment 21539 Fix Fixed bad paste and improved ChangeLog 82490 15 21539 mitz 2008-06-06 17:07:59 -0700 Comment on attachment 21539 Fix r=me. It would be nice to have a pixel test for this, but that would have to be made on Mac OS X. 82517 16 21547 mitz 2008-06-07 00:16:55 -0700 Created attachment 21547 Pixel test for Mac OS X 82528 17 21539 mitz 2008-06-07 01:22:55 -0700 Comment on attachment 21539 Fix Landed in <http://trac.webkit.org/changeset/34414>, so clearing the review flag. Leaving the bug open pending review of the regression test. 82587 18 mitz 2008-06-07 15:38:33 -0700 Test landed in <http://trac.webkit.org/changeset/34430>. 21528 2008-06-06 13:49:05 -0700 2008-06-06 13:49:05 -0700 Patch that fixes the text disappearance on selection changes selection-fix.patch text/plain 1205 jonathon ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwIGIvV2ViQ29y ZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHAKaW5kZXggNTY4MWExZS4uYmU1NTBhNSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHAKKysrIGIvV2ViQ29y ZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHAKQEAgLTQxNywxMSArNDE3LDggQEAgdm9pZCBJ bmxpbmVUZXh0Qm94OjpwYWludChSZW5kZXJPYmplY3Q6OlBhaW50SW5mbyYgcGFpbnRJbmZvLCBp bnQgdHgsIGludCB0eSkKICAgICAgICAgICAgIGNvbnRleHQtPnNhdmUoKTsKIAogICAgICAgICB1 cGRhdGVHcmFwaGljc0NvbnRleHQoY29udGV4dCwgdGV4dEZpbGxDb2xvciwgdGV4dFN0cm9rZUNv bG9yLCB0ZXh0U3Ryb2tlV2lkdGgpOwotICAgICAgICBpZiAoIXBhaW50U2VsZWN0ZWRUZXh0U2Vw YXJhdGVseSkgewotICAgICAgICAgICAgLy8gRklYTUU6IFRydW5jYXRlIHJpZ2h0LXRvLWxlZnQg dGV4dCBjb3JyZWN0bHkuCi0gICAgICAgICAgICBwYWludFRleHRXaXRoU2hhZG93cyhjb250ZXh0 LCB0ZXh0UnVuLCAwLCBtX3RydW5jYXRpb24gPT0gY05vVHJ1bmNhdGlvbiA/IG1fbGVuIDogbV90 cnVuY2F0aW9uLCB0ZXh0T3JpZ2luLCBtX3ggKyB0eCwgbV95ICsgdHksIHdpZHRoKCksIGhlaWdo dCgpLCB0ZXh0U2hhZG93LCB0ZXh0U3Ryb2tlV2lkdGggPiAwKTsKLSAgICAgICAgfSBlbHNlCi0g ICAgICAgICAgICBwYWludFRleHRXaXRoU2hhZG93cyhjb250ZXh0LCB0ZXh0UnVuLCBlUG9zLCBz UG9zLCB0ZXh0T3JpZ2luLCBtX3ggKyB0eCwgbV95ICsgdHksIHdpZHRoKCksIGhlaWdodCgpLCB0 ZXh0U2hhZG93LCB0ZXh0U3Ryb2tlV2lkdGggPiAwKTsKKyAgICAgICAgLy8gRklYTUU6IFRydW5j YXRlIHJpZ2h0LXRvLWxlZnQgdGV4dCBjb3JyZWN0bHkuCisgICAgICAgIHBhaW50VGV4dFdpdGhT aGFkb3dzKGNvbnRleHQsIHRleHRSdW4sIDAsIG1fdHJ1bmNhdGlvbiA9PSBjTm9UcnVuY2F0aW9u ID8gbV9sZW4gOiBtX3RydW5jYXRpb24sIHRleHRPcmlnaW4sIG1feCArIHR4LCBtX3kgKyB0eSwg d2lkdGgoKSwgaGVpZ2h0KCksIHRleHRTaGFkb3csIHRleHRTdHJva2VXaWR0aCA+IDApOwogCiAg ICAgICAgIGlmICh0ZXh0U3Ryb2tlV2lkdGggPiAwKQogICAgICAgICAgICAgY29udGV4dC0+cmVz dG9yZSgpOwo= 21533 2008-06-06 15:14:58 -0700 2008-06-06 15:14:58 -0700 Test case test.html text/html 1177 pierre-luc.beaudoin PGh0bWw+Cjxib2R5Pgo8aDE+VWJ1bnR1IHNwcmVhZHMgaXRzIHdpbmdzPC9oMT4KPHA+VWJ1bnR1 IDguMDQsIGNvZGVuYW1lZCBIYXJkeSBIZXJvbiwgc3ByZWFkIGl0cyB3aW5ncyBhbmQgPHU+Zmxl dyBvdXQgb2YgdGhlIG5lc3QgbGFzdCBtb250aDwvdT4uIFRoaXMgaXMgdGhlIHNlY29uZCBVYnVu dHUgcmVsZWFzZSB0byBvZmZlciBsb25nLXRlcm0gc3VwcG9ydCwgd2hpY2ggbWVhbnMgdGhhdCBj cml0aWNhbCB1cGRhdGVzIHdpbGwgYmUgYXZhaWxhYmxlIG9uIHRoZSBkZXNrdG9wIGZvciB0aHJl ZSB5ZWFycyBhbmQgb24gdGhlIHNlcnZlciBmb3IgZml2ZSB5ZWFycy4gVGhlIGV4dGVuZGVkIGxp ZmVzcGFuIG1ha2VzIHRoaXMgcmVsZWFzZSBhbiBpbXBvcnRhbnQgb25lIGZvciBDYW5vbmljYWws IHRoZSBjb21wYW55IGJlaGluZCBVYnVudHUsIGJlY2F1c2UgaXQgaXMgYSBrZXkgcGFydCBvZiB0 aGUgY29tcGFueSdzIHN0cmF0ZWd5IHRvIGJyaW5nIGl0cyBMaW51eCBkaXN0cmlidXRpb24gaW50 byBlbnRlcnByaXNlIGVudmlyb25tZW50cy4gPC9wPgo8cD5UaGUgc2Vjb25kIGlzIGZvciB1c2Ug d2l0aCB0aGUgYXNzb2NpYXRlZCBkb2N1bWVudCBkZWxpdmVyeQogICBpbnN0cnVjdGlvbnMuICBE b2N1bWVudCBEZWxpdmVyeSBJbnN0cnVjdGlvbnMgKERESSkgaXMgYW4gZW1lcmdpbmcKICAgcHJv dG9jb2wgd2hpY2ggZW5hYmxlcyBhdXRvbWF0aWMgZWxlY3Ryb25pYyBkZWxpdmVyeSBvZiBpdGVt cy4gSXQKICAgYWxsb3dzIGEgcmVxdWVzdCBtYW5hZ2VtZW50IHN5c3RlbSAod2hpY2ggbWlnaHQg aGF2ZSByZWNlaXZlZCBhCiAgIHJlcXVlc3QgZm9yIGFuIGl0ZW0gdmlhIHRoZSBJU08gSW50ZXJs aWJyYXJ5IExvYW4gUHJvdG9jb2wgKElTTwogICAxMDE2MC8xMDE2MSkpICB0byBwYXNzIGRldGFp bHMgb2YgdGhlIHJlcXVlc3QsIGl0ZW0sIGFuZCBkZWxpdmVyeSwgdG8KICAgYSBkZWxpdmVyeSBt b2R1bGUsIGFuZCB0byByZWNlaXZlIGJhY2sgcmVwb3J0cyBvbiB0aGUgZGVsaXZlcnkKICAgcHJv Y2VzcyBvciBhcnJpdmFsIG9mIGFuIGl0ZW0uIEl0IGlzIGN1cnJlbnRseSBiZWluZyBzdWJtaXR0 ZWQgdG8gdGhlCiAgIElTTyBUQzQ2L1NDNC9XRzQgY29tbWl0dGVlIGZvciBhcHByb3ZhbCBhcyBh biBJU08gc3RhbmRhcmQuCjwvcD4KPC9ib2R5Pgo8L2h0bWw+Cg== 21538 2008-06-06 16:51:42 -0700 2008-06-06 17:04:06 -0700 Fix fix19279.patch text/plain 1426 pierre-luc.beaudoin SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCShyw6l2aXNpb24gMzQzMjQpCisr KyBXZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcAkoY29waWUgZGUgdHJhdmFpbCkK QEAgLTQxNyw3ICs0MTcsNyBAQAogICAgICAgICAgICAgY29udGV4dC0+c2F2ZSgpOwogCiAgICAg ICAgIHVwZGF0ZUdyYXBoaWNzQ29udGV4dChjb250ZXh0LCB0ZXh0RmlsbENvbG9yLCB0ZXh0U3Ry b2tlQ29sb3IsIHRleHRTdHJva2VXaWR0aCk7Ci0gICAgICAgIGlmICghcGFpbnRTZWxlY3RlZFRl eHRTZXBhcmF0ZWx5KSB7CisgICAgICAgIGlmICghcGFpbnRTZWxlY3RlZFRleHRTZXBhcmF0ZWx5 IHx8IGVQb3MgPD0gc1BvcykgeykgewogICAgICAgICAgICAgLy8gRklYTUU6IFRydW5jYXRlIHJp Z2h0LXRvLWxlZnQgdGV4dCBjb3JyZWN0bHkuCiAgICAgICAgICAgICBwYWludFRleHRXaXRoU2hh ZG93cyhjb250ZXh0LCB0ZXh0UnVuLCAwLCBtX3RydW5jYXRpb24gPT0gY05vVHJ1bmNhdGlvbiA/ IG1fbGVuIDogbV90cnVuY2F0aW9uLCB0ZXh0T3JpZ2luLCBtX3ggKyB0eCwgbV95ICsgdHksIHdp ZHRoKCksIGhlaWdodCgpLCB0ZXh0U2hhZG93LCB0ZXh0U3Ryb2tlV2lkdGggPiAwKTsKICAgICAg ICAgfSBlbHNlCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L0NoYW5nZUxvZwkocsOpdmlzaW9uIDM0NDA5KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKGNvcGll IGRlIHRyYXZhaWwpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMDYtMDYgIFBpZXJyZS1MdWMgQmVh dWRvaW4gIDxwaWVycmUtbHVjLmJlYXVkb2luQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaXRoIHRoZSBoZWxwIG9mIEpv bmF0aG9uIEpvbmdzbWEgYW5kIE1pdHogUGV0dGVsLgorCisgICAgICAgICogcmVuZGVyaW5nL0lu bGluZVRleHRCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5saW5lVGV4dEJveDo6cGFpbnQp OgorICAgICAgICAgICAgQWRkIGEgY29uZGl0aW9uIGZvciB3aGVuIGVQb3MgPD0gc1BvcyB3aGlj aCBjYXVzZWQgYnVnICMxOTI3OSAKKyAgICAgICAgICAgIChEaXNhcHBlYXJpbmcgdGV4dCB3aGVu IHNlbGVjdGlvbiBjaGFuZ2VzKSB0byBoYXBwZW4uCisKIDIwMDgtMDYtMDYgIFJvYmVydCBCbGF1 dCAgPHdlYmtpdEBibGF1dC5iaXo+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu Cg== 21539 2008-06-06 17:04:06 -0700 2008-06-07 01:22:55 -0700 Fix fix19279.patch text/plain 1397 pierre-luc.beaudoin SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCShyw6l2aXNpb24gMzQzMjQpCisr KyBXZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94LmNwcAkoY29waWUgZGUgdHJhdmFpbCkK QEAgLTQxNyw3ICs0MTcsNyBAQAogICAgICAgICAgICAgY29udGV4dC0+c2F2ZSgpOwogCiAgICAg ICAgIHVwZGF0ZUdyYXBoaWNzQ29udGV4dChjb250ZXh0LCB0ZXh0RmlsbENvbG9yLCB0ZXh0U3Ry b2tlQ29sb3IsIHRleHRTdHJva2VXaWR0aCk7Ci0gICAgICAgIGlmICghcGFpbnRTZWxlY3RlZFRl eHRTZXBhcmF0ZWx5KSB7CisgICAgICAgIGlmICghcGFpbnRTZWxlY3RlZFRleHRTZXBhcmF0ZWx5 IHx8IGVQb3MgPD0gc1BvcykgewogICAgICAgICAgICAgLy8gRklYTUU6IFRydW5jYXRlIHJpZ2h0 LXRvLWxlZnQgdGV4dCBjb3JyZWN0bHkuCiAgICAgICAgICAgICBwYWludFRleHRXaXRoU2hhZG93 cyhjb250ZXh0LCB0ZXh0UnVuLCAwLCBtX3RydW5jYXRpb24gPT0gY05vVHJ1bmNhdGlvbiA/IG1f bGVuIDogbV90cnVuY2F0aW9uLCB0ZXh0T3JpZ2luLCBtX3ggKyB0eCwgbV95ICsgdHksIHdpZHRo KCksIGhlaWdodCgpLCB0ZXh0U2hhZG93LCB0ZXh0U3Ryb2tlV2lkdGggPiAwKTsKICAgICAgICAg fSBlbHNlCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0No YW5nZUxvZwkocsOpdmlzaW9uIDM0NDA5KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKGNvcGllIGRl IHRyYXZhaWwpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDYtMDYgIFBpZXJyZS1MdWMgQmVhdWRv aW4gIDxwaWVycmUtbHVjLmJlYXVkb2luQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaXRoIHRoZSBoZWxwIG9mIEpvbmF0 aG9uIEpvbmdzbWEgYW5kIE1pdHogUGV0dGVsLgorCisgICAgICAgIEZpeCBmb3IgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Mjc5CisKKyAgICAgICAgKiByZW5kZXJp bmcvSW5saW5lVGV4dEJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVUZXh0Qm94Ojpw YWludCk6CisgICAgICAgICAgICBBZGQgYSBjb25kaXRpb24gZm9yIHdoZW4gZVBvcyA8PSBzUG9z IAorCiAyMDA4LTA2LTA2ICBSb2JlcnQgQmxhdXQgIDx3ZWJraXRAYmxhdXQuYml6PgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgo= 21547 2008-06-07 00:16:55 -0700 2008-06-07 15:34:01 -0700 Pixel test for Mac OS X 19279 test.html text/html 433 mitz PHN0eWxlPgogICAgZGl2ID4gZGl2IHsgd2lkdGg6IDEwMHB4OyBmb250LWZhbWlseTogQWhlbTsg Zm9udC1zaXplOiAyMHB4OyB9CiAgICBkaXYgPiBkaXY6OnNlbGVjdGlvbiB7IGNvbG9yOiB3aGl0 ZTsgfQo8L3N0eWxlPgo8ZGl2IHN0eWxlPSJvdmVyZmxvdzogaGlkZGVuOyBiYWNrZ3JvdW5kOiBy ZWQ7IHdpZHRoOiAxMDBweDsgY29sb3I6IGdyZWVuOyI+CjxkaXYgaWQ9InRhcmdldCI+eHh4eHgg eHh4eHg8L2Rpdj48ZGl2Pnh4eHh4IHh4eHh4PC9kaXY+CjwvZGl2Pgo8c2NyaXB0PgogICAgdmFy IHRhcmdldCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0YXJnZXQiKTsKICAgIGdldFNlbGVj dGlvbigpLnNldEJhc2VBbmRFeHRlbnQodGFyZ2V0LmZpcnN0Q2hpbGQsIDYsIHRhcmdldC5uZXh0 U2libGluZy5maXJzdENoaWxkLCA1KTsKPC9zY3JpcHQ+Cg==