192750 2018-12-17 01:23:56 -0800 SLL: innerText should preserve leading whitespace when the out-of-flow (or float) element starts with collapsed new line(s). 2025-03-11 22:04:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=193628 https://bugs.chromium.org/p/chromium/issues/detail?id=916540 BrowserCompat, Gtk, InRadar, LayoutTestFailure P2 Normal --- 289597 1 cgarcia zalan aboya ahmad.saleem792 bfulgham emilio koivisto mcatanzaro simon.fraser webkit-bug-importer zalan oldest_to_newest 1488404 0 357429 cgarcia 2018-12-17 01:23:56 -0800 Created attachment 357429 Test case Several tests started to fail for GTK+ port when we switched to always use complex text. See for example: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r239206%20(9103)/fast/css/getComputedStyle/computed-style-font-family-pretty-diff.html Note that the only difference is that the expected output doesn't have a space between "Firefox behavior." and "stopPropagation called." This is because the simple line layout code path is taken in TextIterator::handleTextNode(). When forcing complex text, that path is not taken and a space is added, which is the correct behavior I guess. I've created a simple test to check this, see the attached file. 1488436 1 357439 zalan 2018-12-17 07:48:41 -0800 Created attachment 357439 Test case2 Apparently we are supposed to preserve the collapsed new line for out of flow elements (and floats too). 1489296 2 cgarcia 2018-12-19 06:55:33 -0800 *** Bug 192851 has been marked as a duplicate of this bug. *** 1491063 3 cgarcia 2018-12-31 05:36:28 -0800 Committed r239564: <https://trac.webkit.org/changeset/239564> 1491064 4 webkit-bug-importer 2018-12-31 05:39:13 -0800 <rdar://problem/46987463> 1491144 5 emilio 2019-01-02 08:26:20 -0800 I bet this wasn't meant to be closed. 1491145 6 zalan 2019-01-02 08:30:06 -0800 (In reply to Emilio Cobos Álvarez (:emilio) from comment #5) > I bet this wasn't meant to be closed. Yeah, I was wondering about that too. 1491386 7 cgarcia 2019-01-02 23:46:30 -0800 I think it's a bug in webkit-patch. I landed a gardening patch mentioning this bug in the changelog description (not in the title), and decided to close this. I'll try to remember to use --no-close option next time. 1896078 8 ahmad.saleem792 2022-09-03 14:20:14 -0700 Test case 2 is broken on macOS 12.5.1 in Safari Technology Preview 152 as well, it does not move "here" to next line like other browsers (Chrome Canary 107 and Firefox Nightly 106). *** Safari 15.6.1 / STP 152 *** Pass if there's a whitespace here *** Chrome Canary 107 & Firefox Nightly 106 *** Pass if there's a whitespace here _________ Just wanted to share updated status. Thanks! 357429 2018-12-17 01:23:56 -0800 2018-12-17 01:23:56 -0800 Test case simple-line-layout-innerText-space.html text/html 495 cgarcia PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHk+CjxkaXYgaWQ9InRlc3Qi PgogIGZvby4KPGRpdiBzdHlsZT0icG9zaXRpb246IGFic29sdXRlOyB0b3A6IDUwOyBsZWZ0OiA1 MCI+CiAgYmFyCjwvZGl2Pgo8L2Rpdj4KPHNjcmlwdD4KZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMg dGhhdCBzcGFjZSBpcyBhZGRlZCBhZnRlciBhIGRvdCBmb3IgaW5uZXIgdGV4dCBpbiBzaW1wbGUg bGluZSBsYXlvdXQgbW9kZSIpOwpzaG91bGRCZSgiZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rl c3QnKS5pbm5lclRleHQiLCAiJ2Zvby4gYmFyJyIpOwpkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgn dGVzdCcpLmlubmVySFRNTD0gIiI7Cjwvc2NyaXB0Pgo8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3Vy Y2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CjwvYm9keT4K 357439 2018-12-17 07:48:41 -0800 2018-12-17 07:48:41 -0800 Test case2 sll-trailing-whitespace.html text/html 143 zalan PGRpdiBpZD0idGVzdCI+UGFzcyBpZiB0aGVyZSdzIGEgd2hpdGVzcGFjZTxkaXYgc3R5bGU9InBv c2l0aW9uOiBhYnNvbHV0ZTsiPgpoZXJlPC9kaXY+PC9kaXY+PHNjcmlwdD50ZXN0LmlubmVyVGV4 dCA9IHRlc3QuaW5uZXJUZXh0Ozwvc2NyaXB0Pgo=