19274 2008-05-27 12:26:45 -0700 wxWebKit compile error on linux x86_64 2008-06-09 07:52:09 -0700 1 1 1 Unclassified WebKit WebKit wx 420+ Other Linux RESOLVED DUPLICATE 19310 P2 Normal --- 1 mmacleod mmacleod oldest_to_newest 81635 0 mmacleod 2008-05-27 12:26:45 -0700 SVN Trunk version of wxWebKit fails to compile on x86_64 platforms due to relying on a cast from pointer to int in order to generate font keys. The attached file provides a fix that works around this. The patch is not 100% ideal as it could lead to conflicts in keys in very rare circumstances. 81640 1 21368 mmacleod 2008-05-27 12:33:34 -0700 Created attachment 21368 Compile fix for x86_64 platforms 81714 2 ap 2008-05-28 06:04:52 -0700 A better way to fix this would be by using PtrHash: return PtrHash<wxFont*>::hash(&m_font); This class appears broken in that it computes m_fontHash and never uses it later, and also includes hash table machinery that should be in hash traits instead, but fixing that is out of scope for a simple bug fix. Please do not use tab characters in your patch. 82746 3 ap 2008-06-09 07:52:09 -0700 Fixed by fixing the hash function itself. *** This bug has been marked as a duplicate of 19310 *** 21368 2008-05-27 12:33:34 -0700 2008-05-27 12:33:34 -0700 Compile fix for x86_64 platforms compile.diff text/plain 1077 mmacleod SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3JtRGF0YS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3JtRGF0 YS5oCShyZXZpc2lvbiAzNDE1MSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9u dFBsYXRmb3JtRGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC05MCw3ICs5MCwxNiBAQCBwdWJsaWM6 CiAgICAgCiAgICAgdW5zaWduZWQgY29tcHV0ZUhhc2goKSBjb25zdCB7CiAgICAgICAgIEFTU0VS VChtX2ZvbnQuT2soKSk7Ci0gICAgICAgIHJldHVybiByZWludGVycHJldF9jYXN0PHVuc2lnbmVk PigmbV9mb250KTsKKwkjaWZkZWYgX194ODZfNjRfXworCS8vVGhlIGJlbG93IGlzIGEgIGhhY2t5 IGZpeCB0byB0aGUgcHJvYmxlbSB0aGF0IHdlIG5lZWQgYSAzMiBiaXQgaW50ZWdlciBrZXkgdmFs dWUgYnV0IHRoYXQgcG9pbnRlcnMgb24geDg2XzY0IGFyZSA2NCBiaXQKKwkvL0l0IHdvcmtzIGJ5 IHRyZWF0aW5nIHRoZSBwb2ludGVyIGFzIGFuIGFycmF5IG9mIGludGVnZXJzKEl0IHdpbGwgYmUg dHdvIGludGVnZXJzIGxvbmcpCisJLy9UaGUgc2Vjb25kIG9mIHRoZXNlIGludGVnZXJzIGlzIHRo ZW4gdXNlZCBmb3Igb3VyIHZhbHVlCisJLy9XaGlsZSB0aGlzIGlzIGJldHRlciB0aGVuIG5vdCBj b21waWxpbmcgYXQgYWxsIGl0IGlzIG5vdCBpZGVhbCBhcyB0aGVyZSBpcyBhIHJlbW90ICBwb3Nz aWJpbGl0eQorICAgICAgICAvLyB0aGF0IHR3byBwb2ludGVycyBtaWdodCBzaGFyZSB0aGUgc2Ft ZSBzZWNvbmQgaW50IHZhbHVlIGFuZCB0aGVyZWZvcmUgcmVzdWx0IGluIG1hdGNoaW5nIHJldHVy bnMgZnJvbSB0aGlzIGZ1bmN0aW9uCisgICAgICAgIHJldHVybiByZWludGVycHJldF9jYXN0PGNv bnN0IGludCo+KCZtX2ZvbnQpWzFdOworCSNlbHNlCisJcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8 dW5zaWduZWQ+KCZtX2ZvbnQpWzFdOworCSNlbmRpZgogICAgIH0KIAogcHJpdmF0ZToK