192691 2018-12-13 20:03:41 -0800 Web Inspector: Prefer "about:blank" instead of an empty string for WebPageDebuggable url 2018-12-14 11:37:49 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue darin inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1487822 0 joepeck 2018-12-13 20:03:41 -0800 Prefer "about:blank" instead of an empty string for WebPageDebuggable url When a WebPageProxy is created and has yet to actually load content it is better to display "about:blank" than an empty string. 1487823 1 webkit-bug-importer 2018-12-13 20:04:28 -0800 <rdar://problem/46719798> 1487825 2 357292 joepeck 2018-12-13 20:05:42 -0800 Created attachment 357292 [PATCH] Proposed Fix 1487944 3 357292 darin 2018-12-14 10:00:59 -0800 Comment on attachment 357292 [PATCH] Proposed Fix I suggest considering WTF::blankURL().string() rather than "about:blank"_s. 1487960 4 bburg 2018-12-14 10:26:56 -0800 LGTM. I don't think this is any worse for lack of localization. 1487961 5 357292 commit-queue 2018-12-14 10:26:57 -0800 Comment on attachment 357292 [PATCH] Proposed Fix Clearing flags on attachment: 357292 Committed r239221: <https://trac.webkit.org/changeset/239221> 1487962 6 commit-queue 2018-12-14 10:26:58 -0800 All reviewed patches have been landed. Closing bug. 1487981 7 joepeck 2018-12-14 11:37:49 -0800 Follow-up with the WTF::blankURL in: <https://trac.webkit.org/r239224> 357292 2018-12-13 20:05:42 -0800 2018-12-14 10:26:57 -0800 [PATCH] Proposed Fix about-blank-1.patch text/plain 1523 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMDlmMzZlMWZhZjEuLjgwMWQ5MmFmODQxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDE4LTEyLTEzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUHJlZmVyICJhYm91dDpibGFuayIgaW5zdGVhZCBv ZiBhbiBlbXB0eSBzdHJpbmcgZm9yIFdlYlBhZ2VEZWJ1Z2dhYmxlIHVybAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNjkxCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS80NjcxOTc5OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlRGVidWdnYWJsZS5jcHA6CisgICAgICAg IChXZWJLaXQ6OldlYlBhZ2VEZWJ1Z2dhYmxlOjp1cmwgY29uc3QpOgorICAgICAgICBJbnN0ZWFk IG9mIGFuIGVtcHR5IHN0cmluZywgcmV0dXJuICJhYm91dDpibGFuayIgaW4gYmFpbCBjYXNlcy4K KyAgICAgICAgV2hlbiBpbnNwZWN0aW5nIHRoZSBwYWdlIHRoYXQgbWF0Y2hlcyB0aGUgY29udGVu dHMuCisKIDIwMTgtMTItMTMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K IAogICAgICAgICBbaU9TXSBXZWIgSW5zcGVjdG9yOiBPY2Nhc2lvbmFsIFVJUHJvY2VzcyBjcmFz aGVzIHVuZGVyIFdlYlBhZ2VQcm94eTo6c2hvd0luc3BlY3RvckluZGljYXRpb24KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VEZWJ1Z2dhYmxlLmNwcCBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VEZWJ1Z2dhYmxlLmNwcAppbmRleCAxNjY0MTdiN2Jh Ny4uMzUxZjkyMzUyNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBh Z2VEZWJ1Z2dhYmxlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlRGVi dWdnYWJsZS5jcHAKQEAgLTU1LDEwICs1NSwxMyBAQCBTdHJpbmcgV2ViUGFnZURlYnVnZ2FibGU6 Om5hbWUoKSBjb25zdAogU3RyaW5nIFdlYlBhZ2VEZWJ1Z2dhYmxlOjp1cmwoKSBjb25zdAogewog ICAgIGlmICghbV9wYWdlLm1haW5GcmFtZSgpKQotICAgICAgICByZXR1cm4gU3RyaW5nKCk7Cisg ICAgICAgIHJldHVybiAiYWJvdXQ6YmxhbmsiX3M7CiAKICAgICBTdHJpbmcgdXJsID0gbV9wYWdl Lm1haW5GcmFtZSgpLT51cmwoKS5zdHJpbmcoKTsKLSAgICByZXR1cm4gdXJsLmlzRW1wdHkoKSA/ ICJhYm91dDpibGFuayJfcyA6IHVybDsKKyAgICBpZiAodXJsLmlzRW1wdHkoKSkKKyAgICAgICAg cmV0dXJuICJhYm91dDpibGFuayJfczsKKworICAgIHJldHVybiB1cmw7CiB9CiAKIGJvb2wgV2Vi UGFnZURlYnVnZ2FibGU6Omhhc0xvY2FsRGVidWdnZXIoKSBjb25zdAo=