192617 2018-12-11 23:48:13 -0800 [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag 2018-12-12 23:01:35 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 171618 1 fujii fujii achristensen bfulgham pvollan ross.kirsling webkit-bug-importer oldest_to_newest 1487141 0 fujii 2018-12-11 23:48:13 -0800 [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag clang-cl reports the following compilation warnings: > [5841/6308] Building CXX object Source\WebKitLegacy\CMakeFiles\WebKitLegacy.dir\win\WebDatabaseManager.cpp.obj > In file included from ..\..\Source\WebKitLegacy\win\WebDatabaseManager.cpp:32: > ..\..\Source\WebKitLegacy\win/COMEnumVariant.h(72,25): warning: expected a qualified name after 'typename' > COMEnumVariant<typename ContainerType>* COMEnumVariant<ContainerType>::adopt(ContainerType& container) > ^ > ..\..\Source\WebKitLegacy\win/COMEnumVariant.h(82,25): warning: expected a qualified name after 'typename' > COMEnumVariant<typename ContainerType>* COMEnumVariant<ContainerType>::createInstance(const ContainerType& container) > ^ > In file included from ..\..\Source\WebKitLegacy\win\WebDatabaseManager.cpp:33: > ..\..\Source\WebKitLegacy\win/COMPropertyBag.h(80,71): warning: expected a qualified name after 'typename' > COMPropertyBag<ValueType, KeyType, HashType>* COMPropertyBag<typename ValueType, typename KeyType, HashType>::createInstance(const HashMapType& hashMap) > ^ > ..\..\Source\WebKitLegacy\win/COMPropertyBag.h(80,91): warning: expected a qualified name after 'typename' > COMPropertyBag<ValueType, KeyType, HashType>* COMPropertyBag<typename ValueType, typename KeyType, HashType>::createInstance(const HashMapType& hashMap) > ^ > ..\..\Source\WebKitLegacy\win/COMPropertyBag.h(88,71): warning: expected a qualified name after 'typename' > COMPropertyBag<ValueType, KeyType, HashType>* COMPropertyBag<typename ValueType, typename KeyType, HashType>::adopt(HashMapType& hashMap) > ^ > ..\..\Source\WebKitLegacy\win/COMPropertyBag.h(88,91): warning: expected a qualified name after 'typename' > COMPropertyBag<ValueType, KeyType, HashType>* COMPropertyBag<typename ValueType, typename KeyType, HashType>::adopt(HashMapType& hashMap) > ^ 1487146 1 357111 fujii 2018-12-11 23:57:05 -0800 Created attachment 357111 Patch 1487148 2 fujii 2018-12-12 00:17:40 -0800 This patch fixes the following warning, too. > In file included from ..\..\Source\WebKitLegacy\win\WebCoreSupport\WebFrameLoaderClient.cpp:32: > ..\..\Source\WebKitLegacy\win\COMPropertyBag.h(140,5): warning: missing 'typename' prior to dependent type name 'HashMapType::const_iterator' [-Wtypename-missing] > HashMapType::const_iterator it = m_hashMap.find(String(pszPropName)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > typename > ..\..\Source\WebKitLegacy\win\COMPropertyBag.h(82,36): note: in instantiation of member function 'COMPropertyBag<WTF::String, WTF::String, WTF::StringHash>::COMPropertyBag' requested here > COMPropertyBag* instance = new COMPropertyBag(hashMap); > ^ > ..\..\Source\WebKitLegacy\win\WebCoreSupport\WebFrameLoaderClient.cpp(624,82): note: in instantiation of member function 'COMPropertyBag<WTF::String, WTF::String, WTF::StringHash>::createInstance' requested here > COMPtr<IPropertyBag> formValuesPropertyBag(AdoptCOM, COMPropertyBag<String>::createInstance(formValuesMap)); > ^ 1487440 3 ross.kirsling 2018-12-12 17:44:30 -0800 LGTM. 1487508 4 357111 fujii 2018-12-12 22:59:58 -0800 Comment on attachment 357111 Patch Committed in r239152: https://trac.webkit.org/changeset/239152/ 1487509 5 webkit-bug-importer 2018-12-12 23:01:35 -0800 <rdar://problem/46688436> 357111 2018-12-11 23:57:05 -0800 2018-12-12 22:59:58 -0800 Patch bug-192617-20181212165704.patch text/plain 5215 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L3dpbi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VMb2cKaW5k ZXggZWU2NTIzYzNhZDQ5NjgwZjNiNDU3OTRkYjk0ZDg2YzAzMDUxZWYxNS4uZTA2YTlmMGQ1MGUz OGI1NzMyMWUyYzkzZjI3YTg2MTYxOTUzM2JlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS93aW4vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTEyLTExICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3Jp LkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dW0NsYW5nXVtXZWJLaXRMZWdhY3ldIHdh cm5pbmc6IGV4cGVjdGVkIGEgcXVhbGlmaWVkIG5hbWUgYWZ0ZXIgJ3R5cGVuYW1lJyBvZiBDT01F bnVtVmFyaWFudCBhbmQgQ09NUHJvcGVydHlCYWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjYxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQ09NRW51bVZhcmlhbnQuaDoKKyAgICAgICAgKENPTUVu dW1WYXJpYW50PENvbnRhaW5lclR5cGU+OjphZG9wdCk6IFJlbW92ZWQgJ3R5cGVuYW1lJyBmcm9t IG5vbiBkZXBlbmRlbnQgbmFtZXMuCisgICAgICAgIChDT01FbnVtVmFyaWFudDxDb250YWluZXJU eXBlPjo6Y3JlYXRlSW5zdGFuY2UpOiBEaXR0by4KKyAgICAgICAgKENPTUVudW1WYXJpYW50PENv bnRhaW5lclR5cGU+OjpOZXh0KTogUHJlcGVuZCAndHlwZW5hbWUnIGZvciBkZXBlbmRlbnQgbmFt ZXMuCisgICAgICAgICogQ09NUHJvcGVydHlCYWcuaDoKKyAgICAgICAgKEhhc2hUeXBlPjo6Y3Jl YXRlSW5zdGFuY2UpOiBSZW1vdmVkICd0eXBlbmFtZScgZnJvbSBub24gZGVwZW5kZW50IG5hbWVz LgorICAgICAgICAoSGFzaFR5cGU+OjphZG9wdCk6IERpdHRvLgorICAgICAgICAoSGFzaFR5cGU+ OjpSZWFkKTogUmVwbGFjZWQgZGVwZW5kZW50IG5hbWUgJ0hhc2hNYXBUeXBlOjpjb25zdF9pdGVy YXRvcicgd2l0aCAnYXV0bycuCisgICAgICAgIChIYXNoVHlwZT46OkdldFByb3BlcnR5SW5mbyk6 IERpdHRvLgorCiAyMDE4LTEyLTExICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNv bnkuY29tPgogCiAgICAgICAgIFtXaW5dW0NsYW5nXSBGaXggd2FybmluZyAtV21pc3NpbmctZmll bGQtaW5pdGlhbGl6ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DT01F bnVtVmFyaWFudC5oIGIvU291cmNlL1dlYktpdExlZ2FjeS93aW4vQ09NRW51bVZhcmlhbnQuaApp bmRleCAyZmUwZjEwN2Q0NWJjNTU3MWZiOTU3NmNjNWFjZWNkZGM0ZTdmODM2Li45Zjg2M2RkNDhi ZjQ0N2E5YTM2NzUyOTY1Nzg0NDUwMDMyODE0YjdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 TGVnYWN5L3dpbi9DT01FbnVtVmFyaWFudC5oCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2lu L0NPTUVudW1WYXJpYW50LmgKQEAgLTY5LDcgKzY5LDcgQEAgcHJpdmF0ZToKIAogLy8gQ09NRW51 bVZhcmlhbnQgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCiB0ZW1wbGF0ZTx0eXBlbmFtZSBDb250YWluZXJUeXBlPgotQ09N RW51bVZhcmlhbnQ8dHlwZW5hbWUgQ29udGFpbmVyVHlwZT4qIENPTUVudW1WYXJpYW50PENvbnRh aW5lclR5cGU+OjphZG9wdChDb250YWluZXJUeXBlJiBjb250YWluZXIpIAorQ09NRW51bVZhcmlh bnQ8Q29udGFpbmVyVHlwZT4qIENPTUVudW1WYXJpYW50PENvbnRhaW5lclR5cGU+OjphZG9wdChD b250YWluZXJUeXBlJiBjb250YWluZXIpIAogewogICAgIENPTUVudW1WYXJpYW50KiBpbnN0YW5j ZSA9IG5ldyBDT01FbnVtVmFyaWFudDsKICAgICBpbnN0YW5jZS0+bV9jb250YWluZXIuc3dhcChj b250YWluZXIpOwpAQCAtNzksNyArNzksNyBAQCBDT01FbnVtVmFyaWFudDx0eXBlbmFtZSBDb250 YWluZXJUeXBlPiogQ09NRW51bVZhcmlhbnQ8Q29udGFpbmVyVHlwZT46OmFkb3B0KENvbgogfQog CiB0ZW1wbGF0ZTx0eXBlbmFtZSBDb250YWluZXJUeXBlPgotQ09NRW51bVZhcmlhbnQ8dHlwZW5h bWUgQ29udGFpbmVyVHlwZT4qIENPTUVudW1WYXJpYW50PENvbnRhaW5lclR5cGU+OjpjcmVhdGVJ bnN0YW5jZShjb25zdCBDb250YWluZXJUeXBlJiBjb250YWluZXIpCitDT01FbnVtVmFyaWFudDxD b250YWluZXJUeXBlPiogQ09NRW51bVZhcmlhbnQ8Q29udGFpbmVyVHlwZT46OmNyZWF0ZUluc3Rh bmNlKGNvbnN0IENvbnRhaW5lclR5cGUmIGNvbnRhaW5lcikKIHsKICAgICBDT01FbnVtVmFyaWFu dCogaW5zdGFuY2UgPSBuZXcgQ09NRW51bVZhcmlhbnQoY29udGFpbmVyKTsKICAgICBpbnN0YW5j ZS0+QWRkUmVmKCk7CkBAIC0xMzUsNyArMTM1LDcgQEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQ RSBDT01FbnVtVmFyaWFudDxDb250YWluZXJUeXBlPjo6TmV4dChVTE9ORyBjZWx0LCBWQVJJQU4K ICAgICAgICAgaWYgKG1fY3VycmVudFBvcyA9PSBtX2NvbnRhaW5lci5lbmQoKSkKICAgICAgICAg ICAgIHJldHVybiBTX0ZBTFNFOwogCi0gICAgICAgIENPTVZhcmlhbnRTZXR0ZXI8Q29udGFpbmVy VHlwZTo6VmFsdWVUeXBlPjo6c2V0VmFyaWFudCgmcmdWYXJbaV0sICptX2N1cnJlbnRQb3MpOwor ICAgICAgICBDT01WYXJpYW50U2V0dGVyPHR5cGVuYW1lIENvbnRhaW5lclR5cGU6OlZhbHVlVHlw ZT46OnNldFZhcmlhbnQoJnJnVmFyW2ldLCAqbV9jdXJyZW50UG9zKTsKICAgICAgICAgKyttX2N1 cnJlbnRQb3M7CiAgICAgICAgIGlmIChwQ2VsdEZldGNoZWQpCiAgICAgICAgICAgICAoKnBDZWx0 RmV0Y2hlZCkrKzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NPTVByb3Bl cnR5QmFnLmggYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DT01Qcm9wZXJ0eUJhZy5oCmluZGV4 IDcxODFmMmI0NGFmOGJjNjcwNjJiNTBkZWU5YTIxODExZWZlOTAxOTguLmRkYzNiZDQ5YjIzYjhm MTdiNTk2YmQxNThmZDIyOTUxNWUyYzkxMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXRMZWdh Y3kvd2luL0NPTVByb3BlcnR5QmFnLmgKKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS93aW4vQ09N UHJvcGVydHlCYWcuaApAQCAtNzcsNyArNzcsNyBAQCBwcml2YXRlOgogCiAvLyBDT01Qcm9wZXJ0 eUJhZyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KIHRlbXBsYXRlPHR5cGVuYW1lIFZhbHVlVHlwZSwgdHlwZW5hbWUgS2V5 VHlwZSwgdHlwZW5hbWUgSGFzaFR5cGU+Ci1DT01Qcm9wZXJ0eUJhZzxWYWx1ZVR5cGUsIEtleVR5 cGUsIEhhc2hUeXBlPiogQ09NUHJvcGVydHlCYWc8dHlwZW5hbWUgVmFsdWVUeXBlLCB0eXBlbmFt ZSBLZXlUeXBlLCBIYXNoVHlwZT46OmNyZWF0ZUluc3RhbmNlKGNvbnN0IEhhc2hNYXBUeXBlJiBo YXNoTWFwKQorQ09NUHJvcGVydHlCYWc8VmFsdWVUeXBlLCBLZXlUeXBlLCBIYXNoVHlwZT4qIENP TVByb3BlcnR5QmFnPFZhbHVlVHlwZSwgS2V5VHlwZSwgSGFzaFR5cGU+OjpjcmVhdGVJbnN0YW5j ZShjb25zdCBIYXNoTWFwVHlwZSYgaGFzaE1hcCkKIHsKICAgICBDT01Qcm9wZXJ0eUJhZyogaW5z dGFuY2UgPSBuZXcgQ09NUHJvcGVydHlCYWcoaGFzaE1hcCk7CiAgICAgaW5zdGFuY2UtPkFkZFJl ZigpOwpAQCAtODUsNyArODUsNyBAQCBDT01Qcm9wZXJ0eUJhZzxWYWx1ZVR5cGUsIEtleVR5cGUs IEhhc2hUeXBlPiogQ09NUHJvcGVydHlCYWc8dHlwZW5hbWUgVmFsdWVUeXBlLAogfQogCiB0ZW1w bGF0ZTx0eXBlbmFtZSBWYWx1ZVR5cGUsIHR5cGVuYW1lIEtleVR5cGUsIHR5cGVuYW1lIEhhc2hU eXBlPgotQ09NUHJvcGVydHlCYWc8VmFsdWVUeXBlLCBLZXlUeXBlLCBIYXNoVHlwZT4qIENPTVBy b3BlcnR5QmFnPHR5cGVuYW1lIFZhbHVlVHlwZSwgdHlwZW5hbWUgS2V5VHlwZSwgSGFzaFR5cGU+ OjphZG9wdChIYXNoTWFwVHlwZSYgaGFzaE1hcCkKK0NPTVByb3BlcnR5QmFnPFZhbHVlVHlwZSwg S2V5VHlwZSwgSGFzaFR5cGU+KiBDT01Qcm9wZXJ0eUJhZzxWYWx1ZVR5cGUsIEtleVR5cGUsIEhh c2hUeXBlPjo6YWRvcHQoSGFzaE1hcFR5cGUmIGhhc2hNYXApCiB7CiAgICAgQ09NUHJvcGVydHlC YWcqIGluc3RhbmNlID0gbmV3IENPTVByb3BlcnR5QmFnOwogICAgIGluc3RhbmNlLT5tX2hhc2hN YXAuc3dhcChoYXNoTWFwKTsKQEAgLTEzNyw4ICsxMzcsOCBAQCBIUkVTVUxUIFNURE1FVEhPRENB TExUWVBFIENPTVByb3BlcnR5QmFnPFZhbHVlVHlwZSwgS2V5VHlwZSwgSGFzaFR5cGU+OjpSZWFk KExQQwogICAgIGlmICghcHN6UHJvcE5hbWUpCiAgICAgICAgIHJldHVybiBFX1BPSU5URVI7CiAK LSAgICBIYXNoTWFwVHlwZTo6Y29uc3RfaXRlcmF0b3IgaXQgPSBtX2hhc2hNYXAuZmluZChTdHJp bmcocHN6UHJvcE5hbWUpKTsKLSAgICBIYXNoTWFwVHlwZTo6Y29uc3RfaXRlcmF0b3IgZW5kID0g bV9oYXNoTWFwLmVuZCgpOworICAgIGF1dG8gaXQgPSBtX2hhc2hNYXAuZmluZChTdHJpbmcocHN6 UHJvcE5hbWUpKTsKKyAgICBhdXRvIGVuZCA9IG1faGFzaE1hcC5lbmQoKTsKICAgICBpZiAoaXQg PT0gZW5kKQogICAgICAgICByZXR1cm4gRV9JTlZBTElEQVJHOwogCkBAIC0yMDUsOSArMjA1LDgg QEAgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBDT01Qcm9wZXJ0eUJhZzxWYWx1ZVR5cGUsIEtl eVR5cGUsIEhhc2hUeXBlPjo6R2V0UHJvcGUKICAgICAgICAgcmV0dXJuIEVfSU5WQUxJREFSRzsK IAogICAgICpwY1Byb3BlcnRpZXMgPSAwOwotICAgIHR5cGVkZWYgSGFzaE1hcFR5cGU6OmNvbnN0 X2l0ZXJhdG9yIEl0ZXJhdG9yOwotICAgIEl0ZXJhdG9yIGN1cnJlbnQgPSBtX2hhc2hNYXAuYmVn aW4oKTsKLSAgICBJdGVyYXRvciBlbmQgPSBtX2hhc2hNYXAuZW5kKCk7CisgICAgYXV0byBjdXJy ZW50ID0gbV9oYXNoTWFwLmJlZ2luKCk7CisgICAgYXV0byBlbmQgPSBtX2hhc2hNYXAuZW5kKCk7 CiAgICAgZm9yIChVTE9ORyBpID0gMDsgaSA8IGlQcm9wZXJ0eTsgKytpLCArK2N1cnJlbnQpCiAg ICAgICAgIDsKICAgICBmb3IgKFVMT05HIGogPSAwOyBqIDwgY1Byb3BlcnRpZXMgJiYgY3VycmVu dCAhPSBlbmQ7ICsraiwgKytjdXJyZW50KSB7Cg==