192564 2018-12-10 11:58:46 -0800 Regression (iOS 12): Keyboard dismissal leaves WKWebView viewport-fit=cover content offscreen 2020-03-17 21:31:58 -0700 1 1 1 Unclassified WebKit WebKit API Safari 12 iPhone / iPad iOS 12 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=193475 InRadar, Regression P2 Major --- 1 dvpdiner2 webkit-unassigned 709922234 bfulgham commit-queue david.goelzhaeuser dbates lindsay-needs-sleep megan_gardner ng radars rniwa simon.fraser steffen.schmidt thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1486650 0 dvpdiner2 2018-12-10 11:58:46 -0800 Also filed as rdar://44655885 When an input that would require webview centering is clicked, the viewport is repositioned to center that input, as iOS has traditionally done. However, when dismissing the keyboard, the viewport is not re-positioned properly back to its original position. A test project is available on GitHub: https://github.com/dpogue/WKScrollTest/tree/ios12-keyboard Run the test project on a device or simulator. Tap the text input field to open the keyboard. Tap the Done button on the keyboard to dismiss it. Expected Results: The keyboard overlay closes and the web view is positioned as before: filling the screen. Actual Results: The keyboard overlay closes, but the web view does not return to its original position, leaving a space at the bottom of the screen. If rubberband bounce scrolling is disabled, it is not possible to return the web view to its intended position. I strongly suspect this was introduced as a side effect of https://bugs.webkit.org/show_bug.cgi?id=187743 / https://trac.webkit.org/changeset/233905/webkit This is impacting several popular frameworks that embed WKWebView: - https://github.com/apache/cordova-ios/issues/417 - https://github.com/react-native-community/react-native-webview/issues/193 - https://github.com/ionic-team/capacitor/issues/814 Some additional comments from others: - when the viewport is in it's "stuck" position it seems as if any web elements still respond to interaction in their proper place. They are visually off the screen, but logically in the correct spot. This is similar to https://bugs.webkit.org/show_bug.cgi?id=158325 - webView.setNeedsLayout() on keyboard dismissal works as a workaround. UI is updated correctly but instantly, not smoothly like in Safari. It sounds like the issue is essentially that the visible content area is not getting updated when the keyboard closes and the keyboard inset is removed. 1487874 1 dvpdiner2 2018-12-14 00:25:42 -0800 Did a bit of investigating here. On dismissing the keyboard, in WKWebView's _contentBoundsExtendedForRubberbandingWithScale we're getting a verticalRubberbandAmountInContentCoordinates of 260, which leads to the content being partly offscreen. This seems to be due to [_scrollView contentOffset] not being adjusted for the keyboard dismissal at the time that we're reading it, because it is indicating (0, 260) 1497297 2 david.goelzhaeuser 2019-01-23 06:21:10 -0800 Is there an update to this issue? 1497567 3 rniwa 2019-01-23 14:22:59 -0800 I was hoping that my fix for https://trac.webkit.org/r240027 would fix this one as well but it didn't so it's back to our queue of the root cause analysis. 1498951 4 david.goelzhaeuser 2019-01-28 00:27:22 -0800 This issue only occurs in combination with iOS >= 12 and XCode >=10. Apple requires developers to build Apps with iOS 12.1 and Xcode 10.1 on March 2019. Am I right, after this issue has been fixed Apple needs to pull the latest WebKit and implement it into iOS WKWebView, or is there some kind of automatic update process? 1498961 5 rniwa 2019-01-28 01:23:06 -0800 (In reply to David Gölzhäuser from comment #4) > This issue only occurs in combination with iOS >= 12 and XCode >=10. Apple > requires developers to build Apps with iOS 12.1 and Xcode 10.1 on March 2019. Hm... that's strange. Xcode version itself shouldn't affect things. Are you also changing the target SDK when you do that? If so, could you tell us in which target SDK you're seeing the issue in iOS 12? There are certain features and behaviors we enable only when an app is linked against newer SDKs. So if this problem only occurs with newer SDKs, then I suspect one of those features / behaviors are the cause of it. > Am I right, after this issue has been fixed Apple needs to pull the latest > WebKit and implement it into iOS WKWebView, or is there some kind of > automatic update process? It depends. At some point, Apple make a branch of WebKit for a given release. If the fix has been landed by the time we made a branch, then the fix is likely to stay in the branch unless it caused a regression, etc... If the fix wasn't made by the time a given branch was created, then we'd have to manually merge it into the branch to be included in the release which uses that branch. There is a number of internal processes Apple uses to determine which change is merged into any given branch/release. 1499062 6 dvpdiner2 2019-01-28 09:52:36 -0800 (In reply to Ryosuke Niwa from comment #5) > (In reply to David Gölzhäuser from comment #4) > > This issue only occurs in combination with iOS >= 12 and XCode >=10. Apple > > requires developers to build Apps with iOS 12.1 and Xcode 10.1 on March 2019. > > Hm... that's strange. Xcode version itself shouldn't affect things. Are you > also changing the target SDK when you do that? If so, could you tell us in > which target SDK you're seeing the issue in iOS 12? > > There are certain features and behaviors we enable only when an app is > linked against newer SDKs. So if this problem only occurs with newer SDKs, > then I suspect one of those features / behaviors are the cause of it. This bug only happens when building against the iOS 12 SDKs. This matches the comments in the https://trac.webkit.org/changeset/233905/webkit > UIScrollView's _systemContentInset no longer includes keyboard insets in apps linked on iOS 12+ when contentInsetAdjustmentBehavior is None. > FirstWhereUIScrollViewDoesNotApplyKeyboardInsetsUnconditionally = DYLD_IOS_VERSION_12_0, 1521723 7 david.goelzhaeuser 2019-03-27 10:15:30 -0700 Any updates on this? 1566890 8 dvpdiner2 2019-08-30 17:03:21 -0700 This is still an issue in iOS 13 beta 8 :( 1568237 9 378115 dvpdiner2 2019-09-05 13:55:33 -0700 Created attachment 378115 Patch 1568254 10 378115 rniwa 2019-09-05 14:15:25 -0700 Comment on attachment 378115 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378115&action=review Thanks for the patch but we need a API test or a layout test. > Source/WebKit/ChangeLog:7 > + We need a description as to how the bug was caused and how it's fixed. 1568307 11 378134 dvpdiner2 2019-09-05 16:21:02 -0700 Created attachment 378134 Patch 1568621 12 rniwa 2019-09-06 11:56:48 -0700 Great. Thanks for the patch! 1568622 13 378134 commit-queue 2019-09-06 12:03:40 -0700 Comment on attachment 378134 Patch Clearing flags on attachment: 378134 Committed r249585: <https://trac.webkit.org/changeset/249585> 1568623 14 commit-queue 2019-09-06 12:03:42 -0700 All reviewed patches have been landed. Closing bug. 378115 2019-09-05 13:55:33 -0700 2019-09-05 16:21:00 -0700 Patch bug-192564-20190905135533.patch text/plain 1694 dvpdiner2 U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFmZDhkODljYjM2ZGMyOTY4 NzY4NDUzMmQ0N2I2ZTFmYTM1YjZmOWIuLjkzMzUzZjBhNjYyNWIxZGQ5MTQxZWU1NmNkMjdhNzQx Y2Y1MmE4MTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDktMDUgIERhcnJ5bCBQ b2d1ZSAgPGRhcnJ5bEBkcG9ndWUuY2E+CisKKyAgICAgICAgUkVHUkVTU0lPTihpT1MgMTIpOiBL ZXlib2FyZCBkaXNtaXNzYWwgbGVhdmVzIFdLV2ViVmlldyB2aWV3cG9ydC1maXQ9Y292ZXIgY29u dGVudCBvZmZzY3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5MjU2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVUlQcm9jZXNzL2lvcy9XS1Njcm9sbFZpZXcubW06CisgICAgICAgICgtW1dLU2Ny b2xsVmlldyBfYWRqdXN0Rm9yQXV0b21hdGljS2V5Ym9hcmRJbmZvOmFuaW1hdGVkOmxhc3RBZGp1 c3RtZW50Ol0pOgorCiAyMDE5LTA5LTA1ICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29t PgogCiAgICAgICAgIFJlbW92ZSBTdG9yYWdlQXJlYSBwb2ludGVycyBpbiBTdG9yYWdlTWFuYWdl clNldCB3aGVuIHJlbW92aW5nIFN0b3JhZ2VNYW5hZ2VycyB0aGF0IG93biB0aGVtCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tTY3JvbGxWaWV3Lm1tIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLU2Nyb2xsVmlldy5tbQppbmRleCA2N2M2M2I1ZmRjZmVh MzBmNDkyMzExZGFhZmI3ZTEzMmRhZTgwM2ZkLi5kODRjZGZjOWNjMDc2MDZjNTAxZjY0MzA5ODcy NTIzMzk1NDljMTI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tT Y3JvbGxWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS1Njcm9sbFZp ZXcubW0KQEAgLTMzOSw5ICszMzksOSBAQCAtICh2b2lkKV9zZXRDb250ZW50U2l6ZVByZXNlcnZp bmdDb250ZW50T2Zmc2V0RHVyaW5nUnViYmVyYmFuZDooQ0dTaXplKWNvbnRlbnRTaQogCiAtICh2 b2lkKV9hZGp1c3RGb3JBdXRvbWF0aWNLZXlib2FyZEluZm86KE5TRGljdGlvbmFyeSAqKWluZm8g YW5pbWF0ZWQ6KEJPT0wpYW5pbWF0ZWQgbGFzdEFkanVzdG1lbnQ6KENHRmxvYXQqKWxhc3RBZGp1 c3RtZW50CiB7Ci0gICAgW3N1cGVyIF9hZGp1c3RGb3JBdXRvbWF0aWNLZXlib2FyZEluZm86aW5m byBhbmltYXRlZDphbmltYXRlZCBsYXN0QWRqdXN0bWVudDpsYXN0QWRqdXN0bWVudF07Ci0KICAg ICBfa2V5Ym9hcmRCb3R0b21JbnNldEFkanVzdG1lbnQgPSBbW1VJUGVyaXBoZXJhbEhvc3Qgc2hh cmVkSW5zdGFuY2VdIGdldFZlcnRpY2FsT3ZlcmxhcEZvclZpZXc6c2VsZiB1c2luZ0tleWJvYXJk SW5mbzppbmZvXTsKKworICAgIFtzdXBlciBfYWRqdXN0Rm9yQXV0b21hdGljS2V5Ym9hcmRJbmZv OmluZm8gYW5pbWF0ZWQ6YW5pbWF0ZWQgbGFzdEFkanVzdG1lbnQ6bGFzdEFkanVzdG1lbnRdOwog fQogCiAtIChVSUVkZ2VJbnNldHMpX3N5c3RlbUNvbnRlbnRJbnNldAo= 378134 2019-09-05 16:21:02 -0700 2019-09-06 12:03:40 -0700 Patch bug-192564-20190905162102.patch text/plain 7102 dvpdiner2 U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ5NTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFmZDhkODljYjM2ZGMyOTY4 NzY4NDUzMmQ0N2I2ZTFmYTM1YjZmOWIuLjUyODQxM2FiYzQ1NGUyZjY2YmNmNjI2MzUyZDk2M2Y1 ODZmODAzODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDktMDUgIERhcnJ5bCBQ b2d1ZSAgPGRhcnJ5bEBkcG9ndWUuY2E+CisKKyAgICAgICAgUkVHUkVTU0lPTihpT1MgMTIpOiBL ZXlib2FyZCBkaXNtaXNzYWwgbGVhdmVzIFdLV2ViVmlldyB2aWV3cG9ydC1maXQ9Y292ZXIgY29u dGVudCBvZmZzY3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5MjU2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZSBuZXcga2V5Ym9hcmQgaGVpZ2h0IHdhcyBiZWluZyByZWFkIGludG8gYSB2YXJp YWJsZSBhZnRlciB0aGUgc2Nyb2xsdmlldyBoYWQgYWxyZWFkeSBiZWVuCisgICAgICAgIGFkanVz dGVkLiBUaGlzIHdvcmtlZCB3aGVuIHRoZSBrZXlib2FyZCB3YXMgb3BlbmluZywgYmVjYXVzZSB0 aGUgc2Nyb2xsdmlldyBpcyBhZGp1c3RlZCB3aXRoCisgICAgICAgIHRoZSBjb3JyZWN0IHZhbHVl IGEgc2Vjb25kIHRpbWUgd2hlbiB0aGUga2V5Ym9hcmQgYW5pbWF0aW9uIGhhcyBmaW5pc2hlZC4g SG93ZXZlciwgd2hlbiB0aGUKKyAgICAgICAga2V5Ym9hcmQgaXMgY2xvc2VkLCB0aGUgYWRqdXN0 bWVudCB3YXMgYmVpbmcgbWFkZSBiZWZvcmUgdGhlIGNvcnJlY3QgaGVpZ2h0IHdhcyBzdG9yZWQs CisgICAgICAgIGxlYWRpbmcgdG8gdGhlIHNjcm9sbHZpZXcgYmVpbmcgcG9zaXRpb25lZCBhcyBp ZiB0aGUga2V5Ym9hcmQgd2VyZSBzdGlsbCBvcGVuLgorCisgICAgICAgICogVUlQcm9jZXNzL2lv cy9XS1Njcm9sbFZpZXcubW06CisgICAgICAgICgtW1dLU2Nyb2xsVmlldyBfYWRqdXN0Rm9yQXV0 b21hdGljS2V5Ym9hcmRJbmZvOmFuaW1hdGVkOmxhc3RBZGp1c3RtZW50Ol0pOgorCiAyMDE5LTA5 LTA1ICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBT dG9yYWdlQXJlYSBwb2ludGVycyBpbiBTdG9yYWdlTWFuYWdlclNldCB3aGVuIHJlbW92aW5nIFN0 b3JhZ2VNYW5hZ2VycyB0aGF0IG93biB0aGVtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9pb3MvV0tTY3JvbGxWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9z L1dLU2Nyb2xsVmlldy5tbQppbmRleCA2N2M2M2I1ZmRjZmVhMzBmNDkyMzExZGFhZmI3ZTEzMmRh ZTgwM2ZkLi5kODRjZGZjOWNjMDc2MDZjNTAxZjY0MzA5ODcyNTIzMzk1NDljMTI2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tTY3JvbGxWaWV3Lm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS1Njcm9sbFZpZXcubW0KQEAgLTMzOSw5ICszMzks OSBAQCAtICh2b2lkKV9zZXRDb250ZW50U2l6ZVByZXNlcnZpbmdDb250ZW50T2Zmc2V0RHVyaW5n UnViYmVyYmFuZDooQ0dTaXplKWNvbnRlbnRTaQogCiAtICh2b2lkKV9hZGp1c3RGb3JBdXRvbWF0 aWNLZXlib2FyZEluZm86KE5TRGljdGlvbmFyeSAqKWluZm8gYW5pbWF0ZWQ6KEJPT0wpYW5pbWF0 ZWQgbGFzdEFkanVzdG1lbnQ6KENHRmxvYXQqKWxhc3RBZGp1c3RtZW50CiB7Ci0gICAgW3N1cGVy IF9hZGp1c3RGb3JBdXRvbWF0aWNLZXlib2FyZEluZm86aW5mbyBhbmltYXRlZDphbmltYXRlZCBs YXN0QWRqdXN0bWVudDpsYXN0QWRqdXN0bWVudF07Ci0KICAgICBfa2V5Ym9hcmRCb3R0b21JbnNl dEFkanVzdG1lbnQgPSBbW1VJUGVyaXBoZXJhbEhvc3Qgc2hhcmVkSW5zdGFuY2VdIGdldFZlcnRp Y2FsT3ZlcmxhcEZvclZpZXc6c2VsZiB1c2luZ0tleWJvYXJkSW5mbzppbmZvXTsKKworICAgIFtz dXBlciBfYWRqdXN0Rm9yQXV0b21hdGljS2V5Ym9hcmRJbmZvOmluZm8gYW5pbWF0ZWQ6YW5pbWF0 ZWQgbGFzdEFkanVzdG1lbnQ6bGFzdEFkanVzdG1lbnRdOwogfQogCiAtIChVSUVkZ2VJbnNldHMp X3N5c3RlbUNvbnRlbnRJbnNldApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDQ0OTNmN2MyZGRhZTBmYzAwMzFlMzY3N2I1N2Y0 NGUyZGIzODAxY2YuLjhmN2JkNjFjYWM3OWE1OWQ2NWY3MmQyOTcwMDE3NDhhOTdlYWE5OWMgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxOS0wOS0wNSAgRGFycnlsIFBvZ3VlICA8ZGFycnlsQGRw b2d1ZS5jYT4KKworICAgICAgICBSRUdSRVNTSU9OKGlPUyAxMik6IEtleWJvYXJkIGRpc21pc3Nh bCBsZWF2ZXMgV0tXZWJWaWV3IHZpZXdwb3J0LWZpdD1jb3ZlciBjb250ZW50IG9mZnNjcmVlbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNTY0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGVz dHMgdG8gdmVyaWZ5IHNjcm9sbGluZyBwcm9wZXJseSBhZGFwdHMgdG8gdGhlIGtleWJvYXJkIGlu c2V0cyBvbiBpT1MuCisKKyAgICAgICAgKiBmYXN0L3Njcm9sbGluZy9pb3Mvc2Nyb2xsdmlldy1h ZGp1c3RzLXRvLWtleWJvYXJkLWluc2V0cy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGZhc3Qvc2Nyb2xsaW5nL2lvcy9zY3JvbGx2aWV3LWFkanVzdHMtdG8ta2V5Ym9hcmQtaW5zZXRz Lmh0bWw6IEFkZGVkLgorCiAyMDE5LTA5LTA1ICBSdXNzZWxsIEVwc3RlaW4gIDxyZXBzdGVpbkBh cHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0IFRlc3QgbWVkaWEvYXVkaW8tY29uY3VycmVudC1z dXBwb3J0ZWQuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L3Njcm9sbGluZy9pb3Mvc2Nyb2xsdmlldy1hZGp1c3RzLXRvLWtleWJvYXJkLWluc2V0 cy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3Njcm9sbGluZy9pb3Mvc2Nyb2xsdmll dy1hZGp1c3RzLXRvLWtleWJvYXJkLWluc2V0cy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYjlj ODc1ZTI1ZmRhMWIwZjA3NWJiMTA1NjNkNWZkODYxNWJlMzZlZQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3Qvc2Nyb2xsaW5nL2lvcy9zY3JvbGx2aWV3LWFkanVzdHMtdG8ta2V5 Ym9hcmQtaW5zZXRzLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDYgQEAKK1RoaXMgdGVzdHMgZm9j dXNpbmcgYW4gZWxlbWVudCByaWdodCBhYm92ZSB0aGUga2V5Ym9hcmQuIFdlYktpdCBzaG91bGQg c2Nyb2xsIHRoZSBkb2N1bWVudCB0byByZXZlYWwgdGhlIGVsZW1lbnQgYW5kIHRoZW4gc2Nyb2xs IGJhY2sgd2hlbiB0aGUga2V5Ym9hcmQgaXMgZGlzbWlzc2VkLgorVG8gbWFudWFsbHkgdGVzdCwg Zm9jdXMgdGhlIHRleHQgZmllbGQgYmVsb3cgb24gaVBhZCB0byBicmluZyB1cCB0aGUgZG9ja2Vk IHNvZnR3YXJlIGtleWJvYXJkLgorVGhlIGRvY3VtZW50IHNob3VsZCBzY3JvbGwuIERpbWlzcyB0 aGUga2V5Ym9hcmQgYW5kIHRoZSBkb2N1bWVudCBzaG91bGQgc2Nyb2xsIGJhY2sgdG8gaXRzIG9y aWdpbmFsIHBvc2l0aW9uLgorUEFTUyAtIHRoZSBkb2N1bWVudCBkaWQgc2Nyb2xsIG9uIGZvY3Vz CitQQVNTIC0gdGhlIGRvY3VtZW50IGRpZCBzY3JvbGwgb24gYmx1cgorCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L3Njcm9sbGluZy9pb3Mvc2Nyb2xsdmlldy1hZGp1c3RzLXRvLWtleWJv YXJkLWluc2V0cy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9zY3JvbGxpbmcvaW9zL3Njcm9sbHZp ZXctYWRqdXN0cy10by1rZXlib2FyZC1pbnNldHMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41YzNlZTk5ODMw YzAyMjViZmMxZjM2NmM4ODkxNWU4NjUwNzcwOWIwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9zY3JvbGxpbmcvaW9zL3Njcm9sbHZpZXctYWRqdXN0cy10by1rZXlib2FyZC1p bnNldHMuaHRtbApAQCAtMCwwICsxLDc0IEBACis8IURPQ1RZUEUgaHRtbD4gPCEtLSB3ZWJraXQt dGVzdC1ydW5uZXIgWyB1c2VGbGV4aWJsZVZpZXdwb3J0PXRydWUgaW50ZXJuYWw6QXN5bmNPdmVy Zmxvd1Njcm9sbGluZ0VuYWJsZWQ9dHJ1ZSBpbnRlcm5hbDpBc3luY0ZyYW1lU2Nyb2xsaW5nRW5h YmxlZD10cnVlIF0gLS0+Cis8aHRtbD4KKzxoZWFkPgorPG1ldGEgbmFtZT0idmlld3BvcnQiIGNv bnRlbnQ9IndpZHRoPWRldmljZS13aWR0aCwgaW5pdGlhbC1zY2FsZT0xLCB1c2VyLXNjYWxhYmxl PW5vLCB2aWV3cG9ydC1maXQ9Y292ZXIiPgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNl cy91aS1oZWxwZXIuanMiPjwvc2NyaXB0PgorPHN0eWxlPgoraHRtbCwgYm9keSB7IHdpZHRoOiAx MDB2dzsgaGVpZ2h0OiAxMDB2aDsgbWFyZ2luOiAwcHg7IHBhZGRpbmc6IDBweDsgfQorI2NvbnRl bnQgeyB3aWR0aDogMTAwdnc7IGhlaWdodDogMTAwdmg7IGJveC1zaXppbmc6IGJvcmRlci1ib3g7 IHBhZGRpbmc6IDIwcHg7IGJhY2tncm91bmQ6ICNjY2M7IH0KKyN0YXJnZXQgeyBwb3NpdGlvbjog YWJzb2x1dGU7IGJvdHRvbTogMWVtOyB9Cis8L3N0eWxlPgorPHNjcmlwdD4KK2lmICh3aW5kb3cu dGVzdFJ1bm5lcikgeworICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworICAgIHRlc3RS dW5uZXIuZHVtcEFzVGV4dCgpOworfQorCitmdW5jdGlvbiBsaXN0ZW5Gb3JFdmVudE9uY2UodGFy Z2V0LCBuYW1lLCB0aW1lb3V0KSB7CisgICAgcmV0dXJuIG5ldyBQcm9taXNlKChyZXNvbHZlLCBy ZWplY3QpID0+IHsKKyAgICAgICAgY29uc3QgdGltZXIgPSB0aW1lb3V0ID8gc2V0VGltZW91dChy ZWplY3QsIHRpbWVvdXQpIDogbnVsbDsKKyAgICAgICAgdGFyZ2V0LmFkZEV2ZW50TGlzdGVuZXIo bmFtZSwgKCkgPT4geworICAgICAgICAgICAgaWYgKHRpbWVyKQorICAgICAgICAgICAgICAgIGNs ZWFyVGltZW91dCh0aW1lcik7CisgICAgICAgICAgICByZXNvbHZlKCk7CisgICAgICAgIH0sIHtv bmNlOiB0cnVlfSk7CisgICAgfSk7Cit9CisKK2FzeW5jIGZ1bmN0aW9uIHJ1blRlc3QoKSB7Cisg ICAgY29uc3QgdGFyZ2V0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3RhcmdldCcpOworICAg IHZhciBvdXRwdXQgPSAnJzsKKworICAgIGNvbnN0IGZpcnN0U2Nyb2xsRXZlbnQgPSBsaXN0ZW5G b3JFdmVudE9uY2UodGFyZ2V0LCAnZm9jdXMnKS50aGVuKCgpID0+IGxpc3RlbkZvckV2ZW50T25j ZSh2aXN1YWxWaWV3cG9ydCwgJ3Njcm9sbCcsIHdpbmRvdy50ZXN0UnVubmVyID8gMzAwMCA6IDUw MCkpOworCisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAgIGF3YWl0IFVJSGVs cGVyLnNldEhhcmR3YXJlS2V5Ym9hcmRBdHRhY2hlZChmYWxzZSk7CisgICAgICAgIGF3YWl0IFVJ SGVscGVyLmFjdGl2YXRlRWxlbWVudEFuZFdhaXRGb3JJbnB1dFNlc3Npb24odGFyZ2V0KTsKKyAg ICB9CisKKyAgICB0cnkgeworICAgICAgICBhd2FpdCBmaXJzdFNjcm9sbEV2ZW50OworICAgIH0g Y2F0Y2ggKGVycm9yKSB7IH0KKworICAgIG91dHB1dCArPSBkb2N1bWVudC5kb2N1bWVudEVsZW1l bnQuc2Nyb2xsVG9wID49IDUwID8gJ1BBU1MgLSB0aGUgZG9jdW1lbnQgZGlkIHNjcm9sbCBvbiBm b2N1cycgOiAnRkFJTCAtIHRoZSBkb2N1bWVudCBkaWQgbm90IHNjcm9sbCBvbiBmb2N1cyc7Cisg ICAgb3V0cHV0ICs9ICc8YnI+JzsKKworICAgIGNvbnN0IHNlY29uZFNjcm9sbEV2ZW50ID0gbGlz dGVuRm9yRXZlbnRPbmNlKHZpc3VhbFZpZXdwb3J0LCAnc2Nyb2xsJywgd2luZG93LnRlc3RSdW5u ZXIgPyAzMDAwIDogNTAwKTsKKworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAg ICBkb2N1bWVudC5hY3RpdmVFbGVtZW50LmJsdXIoKTsKKyAgICAgICAgYXdhaXQgVUlIZWxwZXIu d2FpdEZvcktleWJvYXJkVG9IaWRlKCk7CisgICAgfQorCisgICAgdHJ5IHsKKyAgICAgICAgYXdh aXQgc2Vjb25kU2Nyb2xsRXZlbnQ7CisgICAgfSBjYXRjaCAoZXJyb3IpIHsgfQorCisgICAgb3V0 cHV0ICs9IGRvY3VtZW50LmRvY3VtZW50RWxlbWVudC5zY3JvbGxUb3AgPT0gMCA/ICdQQVNTIC0g dGhlIGRvY3VtZW50IGRpZCBzY3JvbGwgb24gYmx1cicgOiAnRkFJTCAtIHRoZSBkb2N1bWVudCBk aWQgbm90IHNjcm9sbCBvbiBibHVyJzsKKworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdy ZXN1bHQnKS5pbm5lckhUTUwgPSBvdXRwdXQ7CisKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIp CisgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworfQorCis8L3NjcmlwdD4KKzxib2R5 IG9ubG9hZD0icnVuVGVzdCgpIj4KKzxkaXYgaWQ9ImNvbnRlbnQiPgorVGhpcyB0ZXN0cyBmb2N1 c2luZyBhbiBlbGVtZW50IHJpZ2h0IGFib3ZlIHRoZSBrZXlib2FyZC4gV2ViS2l0IHNob3VsZCBz Y3JvbGwgdGhlIGRvY3VtZW50IHRvIHJldmVhbCB0aGUgZWxlbWVudCBhbmQgdGhlbiBzY3JvbGwg YmFjayB3aGVuIHRoZSBrZXlib2FyZCBpcyBkaXNtaXNzZWQuPGJyPgorVG8gbWFudWFsbHkgdGVz dCwgZm9jdXMgdGhlIHRleHQgZmllbGQgYmVsb3cgb24gaVBhZCB0byBicmluZyB1cCB0aGUgZG9j a2VkIHNvZnR3YXJlIGtleWJvYXJkLjxicj4KK1RoZSBkb2N1bWVudCBzaG91bGQgc2Nyb2xsLiBE aW1pc3MgdGhlIGtleWJvYXJkIGFuZCB0aGUgZG9jdW1lbnQgc2hvdWxkIHNjcm9sbCBiYWNrIHRv IGl0cyBvcmlnaW5hbCBwb3NpdGlvbi48YnI+Cis8ZGl2IGlkPSJyZXN1bHQiPjwvZGl2PgorPGlu cHV0IGlkPSJ0YXJnZXQiPgorPC9kaXY+Cis8L2h0bWw+Cg==