19251 2008-05-26 01:53:22 -0700 [Qt] setTextSizeMultiplier does not scale button fonts 2008-06-02 05:58:03 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 siraj siraj hausmann pierre-luc.beaudoin vestbo oldest_to_newest 81518 0 siraj 2008-05-26 01:53:22 -0700 setTextSizeMultiplier does not scale the font size of buttons text. This is inconsistent with the way it happens in gtk webkit. I'll be attaching a fix shortly. 81522 1 vestbo 2008-05-26 03:58:42 -0700 Please note that on Mac we do want a fixed size button font. See RenderThemeQt::adjustButtonStyle(). 81571 2 21359 siraj 2008-05-27 01:54:08 -0700 Created attachment 21359 setTextSizeMultiplier now scales button fonts With this patch, setTextSizeMultiplier will scale the button fonts. It reproduces GtkWebKit behavior implemented by Barisione (http://people.collabora.co.uk/~bari/zoom.png): except on Mac, where the Safari behavior is reproduced. 82097 3 vestbo 2008-06-02 02:52:17 -0700 Tested on Mac and X11, looks good. Thanks for the patch, Simon will commit it later today. http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commitdiff;h=a9e4748a35a9f4d4c5196ddb9adbf2666520b20d 82101 4 hausmann 2008-06-02 03:09:23 -0700 Landed in r34296 82111 5 siraj 2008-06-02 05:58:03 -0700 (In reply to comment #3) > Tested on Mac and X11, looks good. Thanks for the patch, Simon will commit it > later today. > > http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commitdiff;h=a9e4748a35a9f4d4c5196ddb9adbf2666520b20d > (In reply to comment #3) > Tested on Mac and X11, looks good. Thanks for the patch, Simon will commit it > later today. > > http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=commitdiff;h=a9e4748a35a9f4d4c5196ddb9adbf2666520b20d > Thank you! 21359 2008-05-27 01:54:08 -0700 2008-06-02 03:08:27 -0700 setTextSizeMultiplier now scales button fonts qtwebkit-19251fix.diff text/plain 1573 siraj SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNDEzMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDgtMDUtMjYgIFNpcmFqIFJhemljayAgPHNpcmFqLnJhemlja0Bj b2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjUxCisK KyAgICAgICAgW1F0XSBzZXRUZXh0U2l6ZU11bHRpcGxpZXIgZG9lcyBub3Qgc2NhbGUgYnV0dG9u IGZvbnRzCisKKyAgICAgICAgc2V0VGV4dFNpemVNdWx0aXBsaWVyIGRvZXMgbm90IHNjYWxlIHRo ZSBmb250IHNpemUgb2YgYnV0dG9ucyB0ZXh0LgorICAgICAgICBUaGlzIGlzIGluY29uc2lzdGVu dCB3aXRoIHRoZSB3YXkgaXQgaGFwcGVucyBpbiBndGsgd2Via2l0LgorCisgICAgICAgICogcGxh dGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVt ZVF0OjphZGp1c3RCdXR0b25TdHlsZSk6CisKIDIwMDgtMDUtMjUgIENocmlzIEZsZWl6YWNoICA8 Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBIYXJyaXNv bgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCShyZXZpc2lvbiAzNDEz MCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTM2Nyw4ICszNjcsMTMgQEAgdm9pZCBSZW5kZXJUaGVtZVF0OjphZGp1c3RCdXR0b25T dHlsZShDUwogICAgIC8vIFVzZSBmaXhlZCBmb250IHNpemUgYW5kIGZhbWlseQogICAgIEZvbnRE ZXNjcmlwdGlvbiBmb250RGVzY3JpcHRpb24gPSBzdHlsZS0+Zm9udERlc2NyaXB0aW9uKCk7CiAg ICAgZm9udERlc2NyaXB0aW9uLnNldElzQWJzb2x1dGVTaXplKHRydWUpOworI2lmZGVmIFFfV1Nf TUFDCiAgICAgZm9udERlc2NyaXB0aW9uLnNldFNwZWNpZmllZFNpemUobV9idXR0b25Gb250UGl4 ZWxTaXplKTsKICAgICBmb250RGVzY3JpcHRpb24uc2V0Q29tcHV0ZWRTaXplKG1fYnV0dG9uRm9u dFBpeGVsU2l6ZSk7CisjZWxzZQorICAgIGZvbnREZXNjcmlwdGlvbi5zZXRTcGVjaWZpZWRTaXpl KHN0eWxlLT5mb250U2l6ZSgpKTsKKyAgICBmb250RGVzY3JpcHRpb24uc2V0Q29tcHV0ZWRTaXpl KHN0eWxlLT5mb250U2l6ZSgpKTsKKyNlbmRpZgogICAgIEZvbnRGYW1pbHkgZm9udEZhbWlseTsK ICAgICBmb250RmFtaWx5LnNldEZhbWlseShtX2J1dHRvbkZvbnRGYW1pbHkpOwogICAgIGZvbnRE ZXNjcmlwdGlvbi5zZXRGYW1pbHkoZm9udEZhbWlseSk7Cg==