192501 2018-12-07 10:19:55 -0800 [macOS WK2 Debug ] Flaky Test: animations/play-state-in-shorthand.html 2019-10-07 11:57:36 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=192503 InRadar P2 Normal --- 1 jlewis3 graouts commit-queue dino graouts ryanhaddad simon.fraser sroberts tsavell webkit-bug-importer oldest_to_newest 1486025 0 jlewis3 2018-12-07 10:19:55 -0800 animations/play-state-in-shorthand.html is a flaky failure on macOS WK2 Debug https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=animations%2Fplay-state-in-shorthand.html https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r238951%20(808)/results.html --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/animations/play-state-in-shorthand-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/animations/play-state-in-shorthand-actual.txt @@ -1,4 +1,4 @@ PASS - "transform" property for "box" element at 0.5s saw something close to: 1,0,0,1,75,0 -PASS - "transform" property for "box" element at 1s saw something close to: 1,0,0,1,150,0 -PASS - "transform" property for "box" element at 2.5s saw something close to: 1,0,0,1,150,0 +FAIL - "transform" property for "box" element at 1s expected: 1,0,0,1,150,0 but saw: matrix(1, 0, 0, 1, 171.3000030517578, 0) +FAIL - "transform" property for "box" element at 2.5s expected: 1,0,0,1,150,0 but saw: matrix(1, 0, 0, 1, 175.0500030517578, 0) Based on the flakiness dashboard and the fact that the legacy version of this test is also marked as flaky this doesn't seem to have a recent regression. The test itself usually take around 2 seconds, even when failing. 1499556 1 sroberts 2019-01-29 09:08:07 -0800 Test still flaky on Mac WK2 Debug animations/play-state-in-shorthand.html Flakiness dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=animations%2Fplay-state-in-shorthand.html Reproduce with: run-webkit-tests --root d240655 animations/play-state-in-shorthand.html --iterations 500 -f --debug 1531561 2 webkit-bug-importer 2019-04-30 09:58:11 -0700 <rdar://problem/50338860> 1531563 3 sroberts 2019-04-30 10:09:48 -0700 Test was added in https://trac.webkit.org/changeset/200043/webkit Is flaky on most Mac builds, and recently started showing up on iOS Sim Release and Debug as well. Updated test expectations for Mac Debug and iOS Simulator in https://trac.webkit.org/changeset/244780/webkit . 1577342 4 graouts 2019-10-07 07:15:40 -0700 If I understand this test, it does the following (Simon, please correct me if I'm wrong): - set a timeout for 1s in the start callback to pause the animation using the CSS `animation` property shorthand halfway through - set various timeouts for the animated value to be tested at 500ms (before the start callback timeout has elapsed and the animation is paused), at 1000ms and 2500ms to check the animation has been paused. So the design of this test relies exclusively on setTimeout, which is bound to be flaky, especially as both the start callback and the second value check use the same timeout. Let's see if we can respect the design of this test while making is robust. 1577347 5 graouts 2019-10-07 07:45:39 -0700 I think it would be best to rewrite this test for the new animation engine to check the play state of the animation rather than be looking at CSS values. I'm going to do that, and leave the legacy variety of this test alone. 1577355 6 380328 graouts 2019-10-07 08:18:04 -0700 Created attachment 380328 Patch 1577416 7 380328 commit-queue 2019-10-07 11:57:35 -0700 Comment on attachment 380328 Patch Clearing flags on attachment: 380328 Committed r250781: <https://trac.webkit.org/changeset/250781> 1577417 8 commit-queue 2019-10-07 11:57:36 -0700 All reviewed patches have been landed. Closing bug. 380328 2019-10-07 08:18:04 -0700 2019-10-07 11:57:35 -0700 Patch bug-192501-20191007171803.patch text/plain 5951 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjUwNzcwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjViMTljNjVjMDI2MmFkMDcxMDZk YjczODU0NWJiMjcwYmNlZjVjYi4uOWY5MmJhODAzNTdkNGU4MzMxNDZhZTUxYzExM2RkZTljNWI2 ZmFlOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTEwLTA3ICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TIFdLMiBEZWJ1ZyBdIEZsYWt5IFRl c3Q6IGFuaW1hdGlvbnMvcGxheS1zdGF0ZS1pbi1zaG9ydGhhbmQuaHRtbAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyNTAxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB0ZXN0IHVzZWQgdG8gcmVs eSBvbiB0aW1lcnMgdG8gY2hlY2sgdGhlIGNvbXB1dGVkIHN0eWxlIGF0IHZhcmlvdXMgYW5pbWF0 aW9uIHRpbWVzIGFuZCBhbHNvIHRvIGNoZWNrIHRoZSAiYW5pbWF0aW9uLXBsYXktc3RhdGUiCisg ICAgICAgIHRvICJwYXVzZWQiIHZpYSB0aGUgImFuaW1hdGlvbiIgc2hvcnRoYW5kIENTUyBwcm9w ZXJ0eS4gVGhpcyB3YXMgZmxha3kgYnkgZGVzaWduIHNpbmNlIHRpbWVycyBjb3VsZCBub3QgZmly ZSB3aXRoIGhpZ2ggZW5vdWdoIGZpZGVsaXR5CisgICAgICAgIHRvIGVuc3VyZSB0aGUgYW5pbWF0 aW9uIHRpbWUgbWF0Y2hlZCB0aGUgZXhwZWN0YXRpb24uIFdpdGggdGhlIGF2YWlsYWJpbGl0eSBv ZiB0aGUgV2ViIEFuaW1hdGlvbnMgQVBJLCB3ZSBjYW4gc2ltcGx5IHVzZSB0aGUgInBsYXlTdGF0 ZSIKKyAgICAgICAgcHJvcGVydHkgb24gdGhlIEFuaW1hdGlvbiBvYmplY3QgcmVmbGVjdGluZyB0 aGUgQ1NTIGFuaW1hdGlvbiB0byBjaGVjayB0aGF0IHRoZSBjaGFuZ2UgaXMgYWNjb3VudGVkIGZv ci4KKworICAgICAgICAqIGFuaW1hdGlvbnMvcGxheS1zdGF0ZS1pbi1zaG9ydGhhbmQtZXhwZWN0 ZWQudHh0OgorICAgICAgICAqIGFuaW1hdGlvbnMvcGxheS1zdGF0ZS1pbi1zaG9ydGhhbmQuaHRt bDoKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yLXdrMi9UZXN0RXhwZWN0YXRpb25z OgorICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE5LTEwLTA2 ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIGF0dGFjaFNoYWRv dyBzaG91bGQgc3VwcG9ydCBhdHRhY2hpbmcgYSBzaGFkb3cgcm9vdCB0byBhIG1haW4gZWxlbWVu dApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9wbGF5LXN0YXRlLWluLXNob3J0 aGFuZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL3BsYXktc3RhdGUtaW4t c2hvcnRoYW5kLWV4cGVjdGVkLnR4dAppbmRleCAwZGYwNDRiMGQ3MDcxNGEyODgxYTA1ZjM2MGEx YWIzOWRlNTQxOGY1Li5lYmY4YjU0ZTkzNTAzMjZkODFmMjk2N2ZmZjkzMTc1NjEwY2Q1NjExIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9hbmltYXRpb25zL3BsYXktc3RhdGUtaW4tc2hvcnRoYW5k LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL3BsYXktc3RhdGUtaW4t c2hvcnRoYW5kLWV4cGVjdGVkLnR4dApAQCAtMSw0ICsxLDIgQEAKLVBBU1MgLSAidHJhbnNmb3Jt IiBwcm9wZXJ0eSBmb3IgImJveCIgZWxlbWVudCBhdCAwLjVzIHNhdyBzb21ldGhpbmcgY2xvc2Ug dG86IDEsMCwwLDEsNzUsMAotUEFTUyAtICJ0cmFuc2Zvcm0iIHByb3BlcnR5IGZvciAiYm94IiBl bGVtZW50IGF0IDFzIHNhdyBzb21ldGhpbmcgY2xvc2UgdG86IDEsMCwwLDEsMTUwLDAKLVBBU1Mg LSAidHJhbnNmb3JtIiBwcm9wZXJ0eSBmb3IgImJveCIgZWxlbWVudCBhdCAyLjVzIHNhdyBzb21l dGhpbmcgY2xvc2UgdG86IDEsMCwwLDEsMTUwLDAKLQorUEFTUyAtIGFuaW1hdGlvbiBpcyBydW5u aW5nIHVwb24gcmVjZWl2aW5nIGFuaW1hdGlvbnN0YXJ0IGV2ZW50CitQQVNTIC0gYW5pbWF0aW9u IGlzIHBhdXNlZCBhZnRlciBzZXR0aW5nIHRoZSBhbmltYXRpb24tcGxheS1zdGF0ZSBwcm9wZXJ0 eSB0byBwYXVzZWQgdGhyb3VnaCB0aGUgc2hvcnRoYW5kCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9hbmltYXRpb25zL3BsYXktc3RhdGUtaW4tc2hvcnRoYW5kLmh0bWwgYi9MYXlvdXRUZXN0cy9h bmltYXRpb25zL3BsYXktc3RhdGUtaW4tc2hvcnRoYW5kLmh0bWwKaW5kZXggZWFlMmZiM2NiMjdm MGZhMjhmNDg5ZGIwZDg0MWI4ZDc3NzIxMWE1Yi4uNzE5M2NhNzhjOTBkMDE1NmE3N2NmYmMzMDgz NDIyY2IwNThkNjBhMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9wbGF5LXN0 YXRlLWluLXNob3J0aGFuZC5odG1sCisrKyBiL0xheW91dFRlc3RzL2FuaW1hdGlvbnMvcGxheS1z dGF0ZS1pbi1zaG9ydGhhbmQuaHRtbApAQCAtMjUsMzEgKzI1LDI2IEBACiAgICAgICB0byAgIHsg dHJhbnNmb3JtOiB0cmFuc2xhdGVYKDMwMHB4KTsgfQogICAgIH0KICAgPC9zdHlsZT4KLSAgPHNj cmlwdCBzcmM9InJlc291cmNlcy9hbmltYXRpb24tdGVzdC1oZWxwZXJzLmpzIiB0eXBlPSJ0ZXh0 L2phdmFzY3JpcHQiPjwvc2NyaXB0PgotICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+ Ci0gICAgY29uc3QgZXhwZWN0ZWRWYWx1ZXMgPSBbCi0gICAgICAvLyBbYW5pbWF0aW9uLW5hbWUs IHRpbWUsIGVsZW1lbnQtaWQsIHByb3BlcnR5LCBleHBlY3RlZC12YWx1ZSwgdG9sZXJhbmNlXQot ICAgICAgWyJtb3ZlMSIsIDAuNSwgImJveCIsICJ0cmFuc2Zvcm0iLCBbMSwwLDAsMSw3NSwwXSwg MjBdLAotICAgICAgWyJtb3ZlMSIsIDEuMCwgImJveCIsICJ0cmFuc2Zvcm0iLCBbMSwwLDAsMSwx NTAsMF0sIDIwXSwKLSAgICAgIFsibW92ZTEiLCAyLjUsICJib3giLCAidHJhbnNmb3JtIiwgWzEs MCwwLDEsMTUwLDBdLCAyMF0sCi0gICAgXTsKLQotICAgIGZ1bmN0aW9uIHBhdXNlQW5pbWF0aW9u KCkKLSAgICB7Ci0gICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJib3giKS5jbGFzc0xp c3QuYWRkKCdwYXVzZWQnKTsKLSAgICB9Ci0KLSAgICBmdW5jdGlvbiBzZXRUaW1lcnMoKQotICAg IHsKLSAgICAgICAgc2V0VGltZW91dChwYXVzZUFuaW1hdGlvbiwgMTAwMCk7Ci0gICAgfQotCi0g ICAgcnVuQW5pbWF0aW9uVGVzdChleHBlY3RlZFZhbHVlcywgc2V0VGltZXJzLCBudWxsLCB0cnVl KTsKLSAgPC9zY3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keT4KIDxkaXYgaWQ9ImJveCI+PC9kaXY+CiA8 ZGl2IGlkPSJyZXN1bHQiPjwvZGl2PgotPC9kaXY+Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNj cmlwdCI+CisKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgdGVzdFJ1bm5l ci5kdW1wQXNUZXh0KCk7CisgICAgICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworICAg IH0KKworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJib3giKS5hZGRFdmVudExpc3RlbmVy KCJhbmltYXRpb25zdGFydCIsIGV2ZW50ID0+IHsKKyAgICAgICAgY29uc3QgYW5pbWF0aW9uID0g ZXZlbnQudGFyZ2V0LmdldEFuaW1hdGlvbnMoKVswXTsKKyAgICAgICAgcmVzdWx0LmlubmVySFRN TCArPSBgJHthbmltYXRpb24ucGxheVN0YXRlID09ICJydW5uaW5nIiA/ICJQQVNTIiA6ICJGQUlM In0gLSBhbmltYXRpb24gaXMgcnVubmluZyB1cG9uIHJlY2VpdmluZyBhbmltYXRpb25zdGFydCBl dmVudDxicj5gOworICAgICAgICBldmVudC50YXJnZXQuY2xhc3NMaXN0LmFkZCgicGF1c2VkIik7 CisgICAgICAgIHJlc3VsdC5pbm5lckhUTUwgKz0gYCR7YW5pbWF0aW9uLnBsYXlTdGF0ZSA9PSAi cGF1c2VkIiA/ICJQQVNTIiA6ICJGQUlMIn0gLSBhbmltYXRpb24gaXMgcGF1c2VkIGFmdGVyIHNl dHRpbmcgdGhlIGFuaW1hdGlvbi1wbGF5LXN0YXRlIHByb3BlcnR5IHRvIHBhdXNlZCB0aHJvdWdo IHRoZSBzaG9ydGhhbmRgOworCisgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAg ICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgIH0pOworPC9zY3JpcHQ+CiA8L2Jv ZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxh dG9yLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXNpbXVs YXRvci13azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAyMDRiZDZmZGY3NGFjMjlhZmUzZTkzMWZl ZDM0MGY2ZTY1MjM0YWQwLi40ZmNlZTUzYzgyNTBmMDM1MDczMWMyY2YxYmE0NmMzYzU0MjNmYjEz IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yLXdrMi9UZXN0 RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy1zaW11bGF0b3Itd2sy L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTgwLDggKzgwLDYgQEAgd2Via2l0Lm9yZy9iLzE5Njk0NCBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2hyLXRpbWUvdGVzdF9jcm9zc19mcmFtZV9z dGEKIAogd2Via2l0Lm9yZy9iLzE5NzIwNyBodHRwL3dwdC9yZXNvdXJjZS10aW1pbmcvcnQtcmVz b3VyY2VzLXBlci1mcmFtZS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzE5 MjUwMSBhbmltYXRpb25zL3BsYXktc3RhdGUtaW4tc2hvcnRoYW5kLmh0bWwgWyBQYXNzIEZhaWx1 cmUgXQotCiB3ZWJraXQub3JnL2IvMTgyODQ5IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMveGhyL2V2ZW50LXVwbG9hZC1wcm9ncmVzcy1jcm9zc29yaWdpbi5odG0gWyBQYXNzIEZhaWx1 cmUgXQogCiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL0luZGV4ZWREQi9rZXlwYXRo LXNwZWNpYWwtaWRlbnRpZmllcnMuaHRtIFsgU2xvdyBdCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDljZTM5MjIxNzM0NmZlM2EzMjcxZGZmZTZjYWZlNzQ2 ODBmMDc5NWUuLmZkNDkwMDYzMWMxOWNkYmI3ODc5ZWM3NTI0NmYzOWUyNmY0ZGY5OTcgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xODgzLDggKzE4ODMs NiBAQCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3BvaW50ZXJldmVudHMvcG9pbnRl cmxvY2svcG9pbnRlcmV2ZW50X3BvaW50ZXJsbwogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9wb2ludGVyZXZlbnRzL3BvaW50ZXJsb2NrL3BvaW50ZXJldmVudF9wb2ludGVybW92ZV9p bl9wb2ludGVybG9jay1tYW51YWwuaHRtbCBbIFNraXAgXQogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9wb2ludGVyZXZlbnRzL3BvaW50ZXJsb2NrL3BvaW50ZXJldmVudF9wb2ludGVy bW92ZV9vbl9jaG9yZGVkX21vdXNlX2J1dHRvbl93aGVuX2xvY2tlZC1tYW51YWwuaHRtbCBbIFNr aXAgXQogCi13ZWJraXQub3JnL2IvMTkyNTAxIFsgRGVidWcgXSBhbmltYXRpb25zL3BsYXktc3Rh dGUtaW4tc2hvcnRoYW5kLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMTk3 NDczIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvcmVzb3VyY2UtdGltaW5nL3Jlc291 cmNlLXRpbWluZy1sZXZlbDEuc3ViLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCiB3ZWJraXQub3Jn L2IvMTM2NjI3IFsgTW9qYXZlKyBdIG1lZGlhL3RyYWNrL3RyYWNrLWN1ZS1yZW5kZXJpbmctdmVy dGljYWwuaHRtbCBbIEZhaWx1cmUgXQo=