192490 2018-12-07 01:13:49 -0800 webkitpy: WinCairoPort.default_child_processes should return the appropriate default number of DumpRenderTree processes 2018-12-10 00:20:13 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 fujii webkit-unassigned lforschler oldest_to_newest 1485943 0 fujii 2018-12-07 01:13:49 -0800 webkitpy: WinCairoPort.default_child_processes should return the appropriate default number of DumpRenderTree processes As discussed in Bug 192486, it should be based on the number of CPU and RAM size. Mac port has such implementation. https://github.com/WebKit/webkit/blob/9e192ff36b8e90d6361dae8b1e3022aa5c0d83e9/Tools/Scripts/webkitpy/port/mac.py#L191 1486507 1 fujii 2018-12-09 23:59:32 -0800 Here is the return value of win32api.GlobalMemoryStatusEx() on WinCairo Docker container. > {'TotalPageFile': 39459540992L, 'AvailVirtual': 140737373986816L, 'MemoryLoad': 30, 'TotalPhys': 34359267328L, 'AvailExtendedVirtual': 0L, 'Length': 64, 'TotalVrtual': 140737488224256L, 'AvailPhys': 23751901184L, 'AvailPageFile': 29975863296L} Here is the one on my PC. > {'TotalPageFile': 39389532160L, 'AvailVirtual': 140733064794112L, 'MemoryLoad': 25, 'TotalPhys': 34289258496L, 'AvailExtendedVirtual': 0L, 'Length': 64, 'TotalVirtual': 140737488224256L, 'AvailPhys': 25691299840L, 'AvailPageFile': 26506842112L} The Docker container says it has enough RAM. Umm, I can't use this approach for Bug 188036. 1486508 2 356948 fujii 2018-12-10 00:19:28 -0800 Created attachment 356948 WIP patch 1486509 3 fujii 2018-12-10 00:20:13 -0800 How can Python script know if it is run on a Docker container? 356948 2018-12-10 00:19:28 -0800 2018-12-10 00:19:28 -0800 WIP patch a.diff text/plain 2258 fujii ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9y bWluZm8ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1p bmZvLnB5CmluZGV4IGQ4ZGUzMTdjMzdhLi5mOGFjZDBlNWQzYSAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5CkBAIC0xMTks NiArMTE5LDkgQEAgY2xhc3MgUGxhdGZvcm1JbmZvKG9iamVjdCk6CiAgICAgZGVmIHRvdGFsX2J5 dGVzX21lbW9yeShzZWxmKToKICAgICAgICAgaWYgc2VsZi5pc19tYWMoKToKICAgICAgICAgICAg IHJldHVybiBsb25nKHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbInN5c2N0bCIsICItbiIs ICJody5tZW1zaXplIl0pKQorICAgICAgICBlbGlmIHNlbGYuaXNfd2luKCk6CisgICAgICAgICAg ICBpbXBvcnQgd2luMzJhcGkKKyAgICAgICAgICAgIHJldHVybiB3aW4zMmFwaS5HbG9iYWxNZW1v cnlTdGF0dXNFeCgpWydUb3RhbFBoeXMnXQogICAgICAgICByZXR1cm4gTm9uZQogCiAgICAgZGVm IHRlcm1pbmFsX3dpZHRoKHNlbGYpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wb3J0L3dpbi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHkKaW5kZXgg NGMyODdmNDBlNGQuLjI1MWIzNDAyNTcyIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvd2luLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93aW4ucHkK QEAgLTQ5MCwzICs0OTAsMTkgQEAgY2xhc3MgV2luQ2Fpcm9Qb3J0KFdpblBvcnQpOgogICAgICAg ICBmYWxsYmFja19uYW1lcyA9IFsnd2luY2Fpcm8tJyArIHZlcnNpb25fbmFtZV9tYXAudG9fbmFt ZSh2ZXJzaW9uLCBwbGF0Zm9ybT1zZWxmLnBvcnRfbmFtZSkubG93ZXIoKS5yZXBsYWNlKCcgJywg JycpIGZvciB2ZXJzaW9uIGluIGZhbGxiYWNrX3ZlcnNpb25zXQogICAgICAgICBmYWxsYmFja19u YW1lcy5hcHBlbmQoJ3dpbmNhaXJvJykKICAgICAgICAgcmV0dXJuIG1hcChzZWxmLl93ZWJraXRf YmFzZWxpbmVfcGF0aCwgZmFsbGJhY2tfbmFtZXMpCisKKyAgICBkZWYgZGVmYXVsdF9jaGlsZF9w cm9jZXNzZXMoc2VsZiwgKiprd2FyZ3MpOgorICAgICAgICBkZWZhdWx0X2NvdW50ID0gc3VwZXIo V2luQ2Fpcm9Qb3J0LCBzZWxmKS5kZWZhdWx0X2NoaWxkX3Byb2Nlc3NlcygpCisKKyAgICAgICAg IyBNYWtlIHN1cmUgd2UgaGF2ZSBlbm91Z2ggcmFtIHRvIHN1cHBvcnQgdGhhdCBtYW55IGluc3Rh bmNlczoKKyAgICAgICAgdG90YWxfbWVtb3J5ID0gc2VsZi5ob3N0LnBsYXRmb3JtLnRvdGFsX2J5 dGVzX21lbW9yeSgpCisgICAgICAgIGlmIHRvdGFsX21lbW9yeToKKyAgICAgICAgICAgIGJ5dGVz X3Blcl9kcnQgPSAyNTYgKiAxMDI0ICogMTAyNCAgIyBBc3N1bWUgZWFjaCBEUlQgbmVlZHMgMjU2 TUIgdG8gcnVuLgorICAgICAgICAgICAgb3ZlcmhlYWQgPSAyMDQ4ICogMTAyNCAqIDEwMjQgICMg QXNzdW1lIHdlIG5lZWQgMkdCIGZyZWUgZm9yIHRoZSBPL1MKKyAgICAgICAgICAgIHN1cHBvcnRh YmxlX2luc3RhbmNlcyA9IG1heCgodG90YWxfbWVtb3J5IC0gb3ZlcmhlYWQpIC8gYnl0ZXNfcGVy X2RydCwgMSkgICMgQWx3YXlzIHVzZSBvbmUgcHJvY2VzcywgZXZlbiBpZiB3ZSBkb24ndCBoYXZl IHNwYWNlIGZvciBpdC4KKyAgICAgICAgICAgIGlmIHN1cHBvcnRhYmxlX2luc3RhbmNlcyA8IGRl ZmF1bHRfY291bnQ6CisgICAgICAgICAgICAgICAgX2xvZy53YXJuaW5nKCJUaGlzIG1hY2hpbmUg Y291bGQgc3VwcG9ydCAlcyBjaGlsZCBwcm9jZXNzZXMsIGJ1dCBvbmx5IGhhcyBlbm91Z2ggbWVt b3J5IGZvciAlcy4iICUgKGRlZmF1bHRfY291bnQsIHN1cHBvcnRhYmxlX2luc3RhbmNlcykpCisg ICAgICAgIGVsc2U6CisgICAgICAgICAgICBfbG9nLndhcm5pbmcoIkNhbm5vdCBkZXRlcm1pbmUg YXZhaWxhYmxlIG1lbW9yeSBmb3IgY2hpbGQgcHJvY2Vzc2VzLCB1c2luZyBkZWZhdWx0IGNoaWxk IHByb2Nlc3MgY291bnQgb2YgJXMuIiAlIGRlZmF1bHRfY291bnQpCisgICAgICAgICAgICBzdXBw b3J0YWJsZV9pbnN0YW5jZXMgPSBkZWZhdWx0X2NvdW50CisgICAgICAgIHJldHVybiBtaW4oc3Vw cG9ydGFibGVfaW5zdGFuY2VzLCBkZWZhdWx0X2NvdW50KQo=