192486 2018-12-06 18:28:27 -0800 Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903 2018-12-07 01:16:38 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=192161 https://bugs.webkit.org/show_bug.cgi?id=188036 InRadar P2 Normal --- 1 fujii jbedard commit-queue ews-watchlist glenn jbedard lforschler webkit-bug-importer oldest_to_newest 1485905 0 fujii 2018-12-06 18:28:27 -0800 Consecutive DumpRenderTree crashes are happening again on WinCairo BuildBots since r238903 WinCairo BuildBots is using WEBKIT_TEST_CHILD_PROCESSES to avoid Bug 192161. But, WEBKIT_TEST_CHILD_PROCESSES was removed in Bug 192161. 1485906 1 fujii 2018-12-06 18:30:17 -0800 (In reply to Fujii Hironori from comment #0) > WinCairo BuildBots is using WEBKIT_TEST_CHILD_PROCESSES to avoid Bug 192161. Oops. Wrong bug id. I meant this: Bug 188036 – Consecutive DumpRenderTree crash on WinCairo BuildBots 1485913 2 jbedard 2018-12-06 19:38:35 -0800 Didn't see WEBKIT_TEST_CHILD_PROCESSES being used anywhere, apparently didn't look hard enough. This is an easy enough fix. 1485916 3 356780 jbedard 2018-12-06 19:50:55 -0800 Created attachment 356780 Original Behavior 1485917 4 356781 jbedard 2018-12-06 19:54:19 -0800 Created attachment 356781 Possible Improvement 1485918 5 jbedard 2018-12-06 19:58:11 -0800 I don't have a great way to test this (nor am I familiar with the original bug) but I have 2 patches, either one will likely fix the issue. The first patch will return the original behavior and respect WEBKIT_TEST_CHILD_PROCESSES. The second what I think we actually want here, it modifies the maximum number of child processes for the WinCairo port, that way no one has to worry about setting up WEBKIT_TEST_CHILD_PROCESSES on machines running these tests. 1485919 6 fujii 2018-12-06 20:57:52 -0800 Thank you very much for working on this. I tested both patches, and confirmed both work fine. IMO, Original Behavior patch is somewhat more preferable because Bug 188036 is happening only on WinCairo test bot. WinCairo test bot is now running on 8-thread machine, but has limited RAM. run-webkit-tests trys to run 8 DumpRenderTree processes on it, but fails to spawning a new process due to memory shortage. It doesn't happen on my PC. And, we have a plan to add new bot machines. I don't know the spec yet. But, I hope it would be able to run more workers to shorten testing time. 1485922 7 jbedard 2018-12-06 21:20:51 -0800 (In reply to Fujii Hironori from comment #6) > Thank you very much for working on this. I tested both patches, > and confirmed both work fine. > > IMO, Original Behavior patch is somewhat more preferable because > Bug 188036 is happening only on WinCairo test bot. WinCairo test > bot is now running on 8-thread machine, but has limited RAM. > run-webkit-tests trys to run 8 DumpRenderTree processes on it, > but fails to spawning a new process due to memory shortage. It > doesn't happen on my PC. And, we have a plan to add new bot > machines. I don't know the spec yet. But, I hope it would be able > to run more workers to shorten testing time. For now, I'll land the first then. We've actually had this problem with simulators too, the 'right' solution is to have the port define default processes based on CPU and RAM. 1485923 8 fujii 2018-12-06 21:27:23 -0800 (In reply to Jonathan Bedard from comment #7) > For now, I'll land the first then. > > We've actually had this problem with simulators too, the 'right' solution is > to have the port define default processes based on CPU and RAM. It makes sense. I get the idea. 1485924 9 356782 jbedard 2018-12-06 21:28:03 -0800 Created attachment 356782 Patch for landing 1485932 10 commit-queue 2018-12-06 22:17:53 -0800 The commit-queue encountered the following flaky tests while processing attachment 356782: imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSASSA-PKCS1-v1_5.https.any.html bug 192488 The commit-queue is continuing to process your patch. 1485933 11 356782 commit-queue 2018-12-06 22:18:41 -0800 Comment on attachment 356782 Patch for landing Clearing flags on attachment: 356782 Committed r238950: <https://trac.webkit.org/changeset/238950> 1485934 12 commit-queue 2018-12-06 22:18:43 -0800 All reviewed patches have been landed. Closing bug. 1485935 13 webkit-bug-importer 2018-12-06 22:19:30 -0800 <rdar://problem/46546609> 1485945 14 fujii 2018-12-07 01:16:38 -0800 WinCairo test bots get back to normal. Thank you very much. I am going to do comment#7 task in Bug 192490. 356780 2018-12-06 19:50:55 -0800 2018-12-06 21:28:01 -0800 Original Behavior bug-192486-20181206195054.patch text/plain 1341 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODk0NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE4LTEyLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBDb25zZWN1dGl2ZSBEdW1wUmVuZGVyVHJlZSBjcmFzaGVzIGFyZSBoYXBw ZW5pbmcgYWdhaW4gb24gV2luQ2Fpcm8gQnVpbGRCb3RzIHNpbmNlIHIyMzg5MDMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjQ4NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKyAgICAgICAgKF9zZXRfdXBfZGVy aXZlZF9vcHRpb25zKToKKwogMjAxOC0xMi0wNiAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBh cHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogcnVuLXdlYmtpdC10ZXN0cyBtYXkgZmFp bCB3aGVuIHVzaW5nIGJvb3RlZCBzaW11bGF0b3JzCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkJKHJldmlz aW9uIDIzODk0NykKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93 ZWJraXRfdGVzdHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTM3MCw2ICszNzAsOSBAQCBkZWYgX3By aW50X2V4cGVjdGF0aW9ucyhwb3J0LCBvcHRpb25zLCBhCiAKIGRlZiBfc2V0X3VwX2Rlcml2ZWRf b3B0aW9ucyhwb3J0LCBvcHRpb25zKToKICAgICAiIiJTZXRzIHRoZSBvcHRpb25zIHZhbHVlcyB0 aGF0IGRlcGVuZCBvbiBvdGhlciBvcHRpb25zIHZhbHVlcy4iIiIKKyAgICBpZiBub3Qgb3B0aW9u cy5jaGlsZF9wcm9jZXNzZXM6CisgICAgICAgIG9wdGlvbnMuY2hpbGRfcHJvY2Vzc2VzID0gb3Mu ZW52aXJvbi5nZXQoJ1dFQktJVF9URVNUX0NISUxEX1BST0NFU1NFUycpCisKICAgICBpZiBub3Qg b3B0aW9ucy5jb25maWd1cmF0aW9uOgogICAgICAgICBvcHRpb25zLmNvbmZpZ3VyYXRpb24gPSBw b3J0LmRlZmF1bHRfY29uZmlndXJhdGlvbigpCiAK 356781 2018-12-06 19:54:19 -0800 2018-12-06 21:21:03 -0800 Possible Improvement bug-192486-20181206195418.patch text/plain 1281 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODk0NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTEyLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBDb25zZWN1dGl2ZSBEdW1wUmVuZGVyVHJlZSBjcmFzaGVzIGFyZSBoYXBw ZW5pbmcgYWdhaW4gb24gV2luQ2Fpcm8gQnVpbGRCb3RzIHNpbmNlIHIyMzg5MDMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjQ4NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9wb3J0L3dpbi5weToKKyAgICAgICAgKFdpbkNhaXJvUG9ydCk6CisgICAgICAgIChXaW5DYWly b1BvcnQubWF4X2NoaWxkX3Byb2Nlc3Nlcyk6CisKIDIwMTgtMTItMDYgIEpvbmF0aGFuIEJlZGFy ZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046IHJ1bi13ZWJraXQt dGVzdHMgbWF5IGZhaWwgd2hlbiB1c2luZyBib290ZWQgc2ltdWxhdG9ycwpJbmRleDogVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvd2luLnB5CShyZXZpc2lvbiAyMzg5NDcpCisrKyBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvd2luLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00OTAsMyArNDkwLDYgQEAg Y2xhc3MgV2luQ2Fpcm9Qb3J0KFdpblBvcnQpOgogICAgICAgICBmYWxsYmFja19uYW1lcyA9IFsn d2luY2Fpcm8tJyArIHZlcnNpb25fbmFtZV9tYXAudG9fbmFtZSh2ZXJzaW9uLCBwbGF0Zm9ybT1z ZWxmLnBvcnRfbmFtZSkubG93ZXIoKS5yZXBsYWNlKCcgJywgJycpIGZvciB2ZXJzaW9uIGluIGZh bGxiYWNrX3ZlcnNpb25zXQogICAgICAgICBmYWxsYmFja19uYW1lcy5hcHBlbmQoJ3dpbmNhaXJv JykKICAgICAgICAgcmV0dXJuIG1hcChzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCwgZmFsbGJh Y2tfbmFtZXMpCisKKyAgICBkZWYgbWF4X2NoaWxkX3Byb2Nlc3NlcyhzZWxmLCBkZXZpY2VfdHlw ZT1Ob25lKToKKyAgICAgICAgcmV0dXJuIDIK 356782 2018-12-06 21:28:03 -0800 2018-12-06 22:18:41 -0800 Patch for landing bug-192486-20181206212803.patch text/plain 1451 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODk0NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTEyLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBDb25zZWN1dGl2ZSBEdW1wUmVuZGVyVHJlZSBjcmFzaGVzIGFyZSBoYXBw ZW5pbmcgYWdhaW4gb24gV2luQ2Fpcm8gQnVpbGRCb3RzIHNpbmNlIHIyMzg5MDMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MjQ4NgorCisgICAgICAg IFVucmV2aWV3ZWQgaW5mcmFzdHJ1Y3R1cmUgZml4LgorCisgICAgICAgIFdpbkNhaXJvIGJvdHMg ZGVmaW5lIFdFQktJVF9URVNUX0NISUxEX1BST0NFU1NFUyB0byBydW4gbGVzcyBwcm9jZXNzZXMg ZHVlIHRvIFJBTSByZXN0cmljdGlvbnMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5OgorICAgICAgICAoX3NldF91cF9kZXJpdmVk X29wdGlvbnMpOgorCiAyMDE4LTEyLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxl LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OOiBydW4td2Via2l0LXRlc3RzIG1heSBmYWlsIHdo ZW4gdXNpbmcgYm9vdGVkIHNpbXVsYXRvcnMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQkocmV2aXNpb24g MjM4OTQ3KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtp dF90ZXN0cy5weQkod29ya2luZyBjb3B5KQpAQCAtMzcwLDYgKzM3MCw5IEBAIGRlZiBfcHJpbnRf ZXhwZWN0YXRpb25zKHBvcnQsIG9wdGlvbnMsIGEKIAogZGVmIF9zZXRfdXBfZGVyaXZlZF9vcHRp b25zKHBvcnQsIG9wdGlvbnMpOgogICAgICIiIlNldHMgdGhlIG9wdGlvbnMgdmFsdWVzIHRoYXQg ZGVwZW5kIG9uIG90aGVyIG9wdGlvbnMgdmFsdWVzLiIiIgorICAgIGlmIG5vdCBvcHRpb25zLmNo aWxkX3Byb2Nlc3NlczoKKyAgICAgICAgb3B0aW9ucy5jaGlsZF9wcm9jZXNzZXMgPSBvcy5lbnZp cm9uLmdldCgnV0VCS0lUX1RFU1RfQ0hJTERfUFJPQ0VTU0VTJykKKwogICAgIGlmIG5vdCBvcHRp b25zLmNvbmZpZ3VyYXRpb246CiAgICAgICAgIG9wdGlvbnMuY29uZmlndXJhdGlvbiA9IHBvcnQu ZGVmYXVsdF9jb25maWd1cmF0aW9uKCkKIAo=