192472 2018-12-06 12:59:09 -0800 webkitpy: Create device given lower-case DeviceType 2018-12-06 14:09:28 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=192409 InRadar P2 Normal --- 1 jbedard jbedard commit-queue ews-watchlist glenn lforschler slewis webkit-bug-importer oldest_to_newest 1485780 0 jbedard 2018-12-06 12:59:09 -0800 After <https://bugs.webkit.org/show_bug.cgi?id=192409>, we can compare device types regardless of case, but constructing devices still requires an exact match. We should address this. 1485781 1 webkit-bug-importer 2018-12-06 12:59:33 -0800 <rdar://problem/46532650> 1485783 2 356743 jbedard 2018-12-06 13:03:16 -0800 Created attachment 356743 Patch 1485815 3 356743 commit-queue 2018-12-06 14:09:27 -0800 Comment on attachment 356743 Patch Clearing flags on attachment: 356743 Committed r238940: <https://trac.webkit.org/changeset/238940> 1485816 4 commit-queue 2018-12-06 14:09:28 -0800 All reviewed patches have been landed. Closing bug. 356743 2018-12-06 13:03:16 -0800 2018-12-06 14:09:27 -0800 Patch bug-192472-20181206130315.patch text/plain 3070 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzODkzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE4LTEyLTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogQ3JlYXRlIGRldmljZSBnaXZlbiBsb3dlci1jYXNlIERl dmljZVR5cGUKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTI0NzI+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NjUzMjY1MD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv eGNvZGUvc2ltdWxhdGVkX2RldmljZS5weToKKyAgICAgICAgKFNpbXVsYXRlZERldmljZU1hbmFn ZXIuX2dldF9kZXZpY2VfaWRlbnRpZmllcl9mb3JfdHlwZSk6IENvbXBhcmluZyBzaW1jdGwgZGV2 aWNlIGlkZW50aWZpZXJzIHdpdGggRGV2aWNlVHlwZXMKKyAgICAgICAgc2hvdWxkIGJlIGxldHRl ci1jYXNlIGFnbm9zdGljLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxh dGVkX2RldmljZV91bml0dGVzdC5weToKKyAgICAgICAgKHRlc3RfbG93ZXJfY2FzZV9kZXZpY2Vf dHlwZSk6CisKIDIwMTgtMTItMDUgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5j b20+CiAKICAgICAgICAgW0NvY29hXSBTaGFyZSBDbGFzc01ldGhvZFN3aXp6bGVyIGFuZCBJbnN0 YW5jZU1ldGhvZFN3aXp6bGVyIGJldHdlZW4gVGVzdFdlYktpdEFQSSBhbmQgV2ViS2l0VGVzdFJ1 bm5lcgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNl LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVk X2RldmljZS5weQkocmV2aXNpb24gMjM4OTM4KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS94 Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMjksNyArMjI5LDcg QEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlTWFuYWdlcihvYmplY3QpOgogICAgIEBzdGF0aWNtZXRo b2QKICAgICBkZWYgX2dldF9kZXZpY2VfaWRlbnRpZmllcl9mb3JfdHlwZShkZXZpY2VfdHlwZSk6 CiAgICAgICAgIGZvciB0eXBlX2lkLCB0eXBlX25hbWUgaW4gU2ltdWxhdGVkRGV2aWNlTWFuYWdl ci5fZGV2aWNlX2lkZW50aWZpZXJfdG9fbmFtZS5pdGVyaXRlbXMoKToKLSAgICAgICAgICAgIGlm IHR5cGVfbmFtZSA9PSAne30ge30nLmZvcm1hdChkZXZpY2VfdHlwZS5oYXJkd2FyZV9mYW1pbHks IGRldmljZV90eXBlLmhhcmR3YXJlX3R5cGUpOgorICAgICAgICAgICAgaWYgdHlwZV9uYW1lLmxv d2VyKCkgPT0gJ3t9IHt9Jy5mb3JtYXQoZGV2aWNlX3R5cGUuaGFyZHdhcmVfZmFtaWx5Lmxvd2Vy KCksIGRldmljZV90eXBlLmhhcmR3YXJlX3R5cGUubG93ZXIoKSk6CiAgICAgICAgICAgICAgICAg cmV0dXJuIHR5cGVfaWQKICAgICAgICAgcmV0dXJuIE5vbmUKIApJbmRleDogVG9vbHMvU2NyaXB0 cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZV91bml0dGVz dC5weQkocmV2aXNpb24gMjM4OTM4KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9z aW11bGF0ZWRfZGV2aWNlX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC02MTAsNiArNjEw LDIwIEBAIGNsYXNzIFNpbXVsYXRlZERldmljZVRlc3QodW5pdHRlc3QuVGVzdEMKICAgICAgICAg U2ltdWxhdGVkRGV2aWNlTWFuYWdlci50ZWFyX2Rvd24oaG9zdCkKICAgICAgICAgc2VsZi5hc3Nl cnRJc05vbmUoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5JTklUSUFMSVpFRF9ERVZJQ0VTKQogCisg ICAgZGVmIHRlc3RfbG93ZXJfY2FzZV9kZXZpY2VfdHlwZShzZWxmKToKKyAgICAgICAgU2ltdWxh dGVkRGV2aWNlVGVzdC5yZXNldF9zaW11bGF0ZWRfZGV2aWNlX21hbmFnZXIoKQorICAgICAgICBo b3N0ID0gU2ltdWxhdGVkRGV2aWNlVGVzdC5tb2NrX2hvc3RfZm9yX3NpbWN0bCgpCisgICAgICAg IFNpbXVsYXRlZERldmljZU1hbmFnZXIuYXZhaWxhYmxlX2RldmljZXMoaG9zdCkKKworICAgICAg ICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLmluaXRpYWxpemVfZGV2aWNlcyhEZXZpY2VSZXF1ZXN0 KERldmljZVR5cGUuZnJvbV9zdHJpbmcoJ2lwaG9uZSA1cycsIFZlcnNpb24oMTEpKSksIGhvc3Q9 aG9zdCkKKworICAgICAgICBzZWxmLmFzc2VydEVxdWFscygxLCBsZW4oU2ltdWxhdGVkRGV2aWNl TWFuYWdlci5JTklUSUFMSVpFRF9ERVZJQ0VTKSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMo JzM0RkI0NzZDLTZGQTAtNDNDOC04OTQ1LTFCRDdBNEVCRjBERScsIFNpbXVsYXRlZERldmljZU1h bmFnZXIuSU5JVElBTElaRURfREVWSUNFU1swXS51ZGlkKQorICAgICAgICBzZWxmLmFzc2VydEVx dWFscyhTaW11bGF0ZWREZXZpY2UuRGV2aWNlU3RhdGUuQk9PVEVELCBTaW11bGF0ZWREZXZpY2VN YW5hZ2VyLklOSVRJQUxJWkVEX0RFVklDRVNbMF0ucGxhdGZvcm1fZGV2aWNlLnN0YXRlKCkpCisK KyAgICAgICAgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci50ZWFyX2Rvd24oaG9zdCkKKyAgICAgICAg c2VsZi5hc3NlcnRJc05vbmUoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5JTklUSUFMSVpFRF9ERVZJ Q0VTKQorCiAgICAgQHN0YXRpY21ldGhvZAogICAgIGRlZiBjaGFuZ2Vfc3RhdGVfdG8oZGV2aWNl LCBzdGF0ZSk6CiAgICAgICAgIGFzc2VydCBpc2luc3RhbmNlKHN0YXRlLCBpbnQpCg==